corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
821,267 Commits 1 Branch 0 Tags
1c20c25eda9d3d558afc8b7eefb83c27bc14a0ab
Commit Graph

4212 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
1c20c25eda Bug 232598 - Return null for unset attributes in XUL. r=smaug,devtools-reviewers,omc-reviewers,zombie,nchevobbe,settings-reviewers,application-update-reviewers,credential-management-reviewers,mossop,aminomancer,bytesized,issammani,sessionstore-reviewers,dao 
I just got bit by this in bug 1873833, let's just fix it. There isn't
all that much stuff depending on it anymore.

Differential Revision: https://phabricator.services.mozilla.com/D204496
 2024-03-18 09:15:07 +00:00
Tim Giles
4b1c3b2da6 Bug 1864606 - Fix missing label association for crash reports checkbox r=fluent-reviewers,Gijs,bolsson 
Thanks to mhowell for the STRIP_ANCHOR function in the Fluent migration.

We were using the "for" attribute on a XUL label which does not behave
like an HTML label. This prevented the programmatic association
between the checkbox and the label. By utilizing moz-label, we maintain
the accesskey behavior of the previous XUL label.

Additionally we use moz-support-link to remove the
"collection-backlogged-crash-reports-link" Fluent string.

Differential Revision: https://phabricator.services.mozilla.com/D204557
 2024-03-15 00:10:38 +00:00
Mark Banner
99b2331403 Bug 1867288 - Load application provided search engine icons from remote settings. r=search-reviewers,mcheang,mconley 
Depends on D204529

Differential Revision: https://phabricator.services.mozilla.com/D204263
 2024-03-13 22:14:28 +00:00
Butkovits Atila
f35ecbe910 Backed out 3 changesets (bug 1885193, bug 1885177, bug 1867288) for causing documentation failure. CLOSED TREE 
Backed out changeset 80f62f285117 (bug 1885193)
Backed out changeset 91c5d5cb698c (bug 1867288)
Backed out changeset e0611f8935ff (bug 1885177)
 2024-03-13 23:25:16 +02:00
Mark Banner
8432a66c33 Bug 1867288 - Load application provided search engine icons from remote settings. r=search-reviewers,mcheang,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D204263
 2024-03-13 20:25:06 +00:00
Mark Banner
f65518c3c0 Bug 1882577 - Make nsISearchEngine.getIconURL an async function. r=search-reviewers,extension-reviewers,settings-reviewers,robwu,mcheang,mak 
Differential Revision: https://phabricator.services.mozilla.com/D203026
 2024-03-13 14:51:06 +00:00
Mark Banner
12acbf468b Bug 1884181 - Introduce a DefaultEngineDropDown class for search preferences and have EngineStore notify it and EngineView appropriately. r=settings-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D204024
 2024-03-12 13:38:15 +00:00
Mark Banner
2fe70e7c07 Bug 1884181 - Make EngineStore._engines a public property, remove the setter/getter. r=settings-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D204023
 2024-03-12 13:38:14 +00:00
Mark Banner
29f80a5587 Bug 1884181 - Move EngineStore/EngineView functions out of gSearchPane and into the relevant class. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D204022
 2024-03-12 13:38:14 +00:00
Mark Banner
7bc3786c4f Bug 1884181 - Rename EngineStore._defaultEngines for better clarity. r=settings-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D204021
 2024-03-12 13:38:14 +00:00
Mark Banner
4960f5682d Bug 1884181 - Avoid calling buildDefaultEngineDropDowns twice when opening preferences. r=settings-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D204020
 2024-03-12 13:38:13 +00:00
Mark Banner
3707c6f50d Bug 1884181 - Change search preferences EngineStore and EngineView to be classes. r=settings-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D204019
 2024-03-12 13:38:13 +00:00
Javier Rueda
5e40504c38 Bug 1884135 - Button to add exception in Manage DNS-over-HTTPS subdialog is enabled when input box is empty. r=mossop,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D204033
 2024-03-11 13:21:37 +00:00
dylan
f70687a436 Bug 621429 - added check to only show the Use system Web Proxy Auto-Discovery setting checkbox on windows. r=kershaw,settings-reviewers,mossop 
Depends on D183429

Differential Revision: https://phabricator.services.mozilla.com/D203387
 2024-03-08 04:38:56 +00:00
dylan
49d5f21cb7 Bug 621429 - Added button to allow WPAD while using system proxy settings. r=necko-reviewers,fluent-reviewers,settings-reviewers,kershaw,bolsson,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D183429
 2024-03-08 04:38:55 +00:00
Dale Harvey
8b8718db79 Bug 1883776 - Remove hardcoded detection of trending engines. r=Standard8,settings-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D203896
 2024-03-07 21:58:01 +00:00
Morgan Rae Reschenberg
e077d14d14 Bug 1875957: Update web appearance warning to use moz-message-bar r=fluent-reviewers,flod,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D199402
 2024-03-07 20:12:44 +00:00
Javier Rueda
07a8724602 Bug 1826095 - Add tests for DoH exception list UI. r=mossop,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D203921
 2024-03-07 15:40:26 +00:00
Niklas Baumgardner
06ab571bc9 Bug 1789727 - Initialize ExtensionSettingsStore before use to prevent test failures. r=mconley,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D203471
 2024-03-04 21:13:17 +00:00
Dave Townsend
b7532be063 Bug 1864896: Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D202952
 2024-03-01 18:28:32 +00:00
Natalia Csoregi
66cb0e397f Backed out 2 changesets (bug 1864896) for causing node failures. CLOSED TREE 
Backed out changeset adba0b352699 (bug 1864896)
Backed out changeset 153146ce081c (bug 1864896)
 2024-03-01 18:25:05 +02:00
Dave Townsend
b6eba7ca5c Bug 1864896: Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D202952
 2024-03-01 15:20:18 +00:00
Iulian Moraru
d067b329de Backed out 5 changesets (bug 1864896) for causing newtab failures related to bundles. CLOSED TREE 
Backed out changeset 2cd1cc279f99 (bug 1864896)
Backed out changeset e48d6928bdcb (bug 1864896)
Backed out changeset 1abbcaf91693 (bug 1864896)
Backed out changeset 06a05e5257d5 (bug 1864896)
Backed out changeset b1955ae3e9e2 (bug 1864896)
 2024-03-01 12:58:03 +02:00
Dave Townsend
2a38962b3a Bug 1864896: Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D202952
 2024-03-01 10:10:09 +00:00
Bojidar Marinov
4f5ad30178 Bug 1839845 - Add a few tests for about:settings behavior. r=Gijs,robwu,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D203052
 2024-02-29 10:09:59 +00:00
Bojidar Marinov
a02f6a1df5 Bug 1839845 - Add about:settings as alias of about:preferences. r=Gijs,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D202594
 2024-02-29 10:09:58 +00:00
Gregory Pappas
9bd4fc9c87 Bug 1878401 - part 7 - Pass BrowsingContext to nsIFilePicker::Init in tests r=extension-reviewers,settings-reviewers,credential-management-reviewers,anti-tracking-reviewers,devtools-reviewers,sgalich,pbz,nchevobbe,zombie,migration-reviewers,mconley 
Depends on D200551

Differential Revision: https://phabricator.services.mozilla.com/D200552
 2024-02-28 21:29:39 +00:00
Gregory Pappas
c1ec40f95a Bug 1878401 - part 2 - Update nsIFilePicker users in browser/ to pass BrowsingContext to init r=extension-reviewers,settings-reviewers,credential-management-reviewers,Gijs,sgalich,migration-reviewers,mconley,robwu 
Depends on D200546

Differential Revision: https://phabricator.services.mozilla.com/D200547
 2024-02-28 21:29:37 +00:00
Sandor Molnar
c853f2f3e9 Backed out 8 changesets (bug 1878401, bug 1879041) for causing build bustages on widget/nsBaseFilePicker.cpp CLOSED TREE 
Backed out changeset 2e2b8df3bdd6 (bug 1879041)
Backed out changeset 6d6952f9df2c (bug 1878401)
Backed out changeset 30b5bb590d3e (bug 1878401)
Backed out changeset 9a4b830334b9 (bug 1878401)
Backed out changeset 3c3d67f1fcb7 (bug 1878401)
Backed out changeset c83ba4026822 (bug 1878401)
Backed out changeset 6bcb670ce475 (bug 1878401)
Backed out changeset f263b196df96 (bug 1878401)
 2024-02-28 17:56:48 +02:00
Gregory Pappas
55e30a8b92 Bug 1878401 - part 7 - Pass BrowsingContext to nsIFilePicker::Init in tests r=extension-reviewers,settings-reviewers,credential-management-reviewers,anti-tracking-reviewers,devtools-reviewers,sgalich,pbz,nchevobbe,zombie,migration-reviewers,mconley 
Depends on D200551

Differential Revision: https://phabricator.services.mozilla.com/D200552
 2024-02-28 15:07:46 +00:00
Gregory Pappas
0428704119 Bug 1878401 - part 2 - Update nsIFilePicker users in browser/ to pass BrowsingContext to init r=extension-reviewers,settings-reviewers,credential-management-reviewers,Gijs,sgalich,migration-reviewers,mconley,robwu 
Depends on D200546

Differential Revision: https://phabricator.services.mozilla.com/D200547
 2024-02-28 15:07:44 +00:00
Harshit Sohaney
048922e69b Bug 1878111 - (part 2) Tests for remembering user prefs in the clear history dialog. r=pbz,settings-reviewers,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D201275
 2024-02-23 14:13:30 +00:00
Jules Simplicio
7adf282ac7 Bug 1880223 - Set auto min-height in textareas and fix heading sizing in connection settings r=desktop-theme-reviewers,settings-reviewers,emilio 
This fixes an existing scrollbar issue pointed out on this patch's bug that became more predominant with some of the heading standardization work in bug 1877793.

I'm making sure the heading looks like how it used to. I also noticed textareas had a very small min-height that seemed to be causing this issue.

Differential Revision: https://phabricator.services.mozilla.com/D202018
 2024-02-20 20:39:19 +00:00
Hanna Jones
8d97bdbd6a Bug 1849135 - make about:preferences search work with moz-toggle + custom elements r=settings-reviewers,Gijs 
I started hitting search issues with my change in D196494 and with other experiments to use more reusable components in about:preferences. We'll likely have to keep adding new elements to `searchWithinNode`, but changing `textNodeDescendants` to look for text nodes in the shadow DOM seems like a generally helpful change + gets the highlighting working properly.

Differential Revision: https://phabricator.services.mozilla.com/D197120
 2024-02-20 16:38:03 +00:00
Meera Murthy
5bbca8744d Bug 1872860 - [translations] Add basic elements to Translations settings page. r=nordzilla,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,translations-reviewers,Gijs,dao 
Differential Revision: https://phabricator.services.mozilla.com/D197750
 2024-02-09 17:04:12 +00:00
Morgan Rae Reschenberg
272affe059 Bug 1864445: Add text zoom only warning r=dholbert,fluent-reviewers,desktop-theme-reviewers,dao,mconley,flod 
Differential Revision: https://phabricator.services.mozilla.com/D196116
 2024-02-08 01:44:42 +00:00
Dale Harvey
27c8990068 Bug 1878279 - Have preferences recognise Bing as engine that supports trending. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D200509
 2024-02-06 20:57:33 +00:00
Gregory Pappas
ec549b100a Bug 1877883 - More consistently refer to 'your organization' in enterprise policy notices instead of 'your administrator' or 'system administrator' r=mkaply,fluent-reviewers,settings-reviewers,fxview-reviewers,bolsson,sclements,extension-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200328
 2024-02-06 08:27:10 +00:00
Sandor Molnar
1e9196f7fa Backed out changeset 1ce5079e7de7 (bug 1877883) for causing bc failures at toolkit/mozapps/extensions/test/browser/browser_webapi_install.js CLOSED TREE 2024-02-05 21:39:56 +02:00
Gregory Pappas
5d5148317a Bug 1877883 - More consistently refer to 'your organization' in enterprise policy notices instead of 'your administrator' or 'system administrator' r=mkaply,fluent-reviewers,settings-reviewers,fxview-reviewers,bolsson,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D200328
 2024-02-05 18:41:41 +00:00
Gijs Kruitbosch
b8e31c3dbe Bug 1869734 - update explainer text around deleting data and private browsing, r=pbz,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D200171
 2024-01-31 20:50:46 +00:00
Jules Simplicio
23705875ae Bug 1872788 - Improve spacing in preferences upon standardizing line height values r=desktop-theme-reviewers,settings-reviewers,dao,Gijs,reusable-components-reviewers,hjones 
Differential Revision: https://phabricator.services.mozilla.com/D197614
 2024-01-30 15:39:26 +00:00
Harshit Sohaney
6c978c9036 Bug 1854680 - Enable the new clear history dialog in nightly only. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D198600
 2024-01-30 14:45:24 +00:00
Harshit Sohaney
9d22126f61 Bug 1876378 - Ensure the data size displayed in about:preferences#privacy is updated after data sanitization. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D199580
 2024-01-30 14:45:24 +00:00
Norisz Fay
77b1e70097 Backed out 2 changesets (bug 1872788) for causing mochitest failure on test_moz_button_group.html CLOSED TREE 
Backed out changeset a9528d76a91b (bug 1872788)
Backed out changeset 4fde278ae659 (bug 1872788)
 2024-01-30 15:59:23 +02:00
Jules Simplicio
eaaed0558d Bug 1872788 - Improve spacing in preferences upon standardizing line height values r=desktop-theme-reviewers,settings-reviewers,dao,Gijs,reusable-components-reviewers,hjones 
Differential Revision: https://phabricator.services.mozilla.com/D197614
 2024-01-30 05:28:27 +00:00
Tom Marble
a42a175006 Bug 1868866 - adds ManifestParser TOML linter r=jmaher,linter-reviewers,ahal,webdriver-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,cookie-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,valentin,whimboo,Standard8,sclements,jesup 
Differential Revision: https://phabricator.services.mozilla.com/D199054
 2024-01-29 17:30:48 +00:00
Sandor Molnar
778333649c Backed out changeset 2be67d91cf16 (bug 1868866) for causing Mn failures at toolkit/xre/test/marionette/test_exitcode.py CLOSED TREE 2024-01-27 00:15:22 +02:00
Tom Marble
920ed4a927 Bug 1868866 - adds ManifestParser TOML linter r=jmaher,linter-reviewers,ahal,webdriver-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,cookie-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,valentin,whimboo,Standard8,sclements,jesup 
Differential Revision: https://phabricator.services.mozilla.com/D199054
 2024-01-26 20:06:56 +00:00
Jules Simplicio
48386fea6c Bug 1872909 - Commit to deemphasized descriptive text pattern in preferences that has already been introduced under Search settings in order to improve information architecture r=settings-reviewers,desktop-theme-reviewers,dao,Gijs 
This patch makes us commit to the deemphasized color descriptive pattern throughout settings.

I also made some changes where some settings were using description and should most likely be using a label instead and vice versa.

Quick note that if the descriptive text is tied to an input such as a checkbox or toggle, as opposed to a section heading, we opt for the `.text-deemphasized` class/treatment where not only do we use the `--text-color-deemphasized` color but also shrink the font size. You'll see I opted for such treatment in the Experiments page checkbox list.

Differential Revision: https://phabricator.services.mozilla.com/D197615
 2024-01-26 04:09:59 +00:00