Commit Graph

52 Commits

Author SHA1 Message Date
Kan-Ru Chen
1b9dd22e2d Bug 1314254 - Add mozilla::ipc::IPCResult type and convert IPDL handlers to use new return type. r=billm
We will use the new type for the generated IPDL message handler
prototype to make sure correct error handling method is called.

MozReview-Commit-ID: AzVbApxFGZ0
2016-11-15 04:26:00 +01:00
Nicholas Nethercote
b5810a1eb4 Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm.
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.

In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.

> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));

In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.

> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");

This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
  be true" sense used in assertions.

A common variation on the side-effect-free case is the following.

> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");
2016-09-02 17:12:24 +10:00
Kan-Ru Chen
a9b19d0584 Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj
The patch is generated from following command:

  rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,

MozReview-Commit-ID: AtLcWApZfES
2016-08-24 14:47:04 +08:00
Andrea Marchesini
3e782b8fc6 Bug 1288736 - Add some missing rv.SuppressException(), r=smaug 2016-07-22 16:50:10 +02:00
Kyle Huey
1f6993705a Bug 1263311: Part 3 - s/nsCancelableRunnable/CancelableRunnable/g. r=froydnj 2016-04-11 11:40:06 -07:00
Andrea Marchesini
65cc374a11 Bug 1257180 - patch 1 - Directory clonable to workers, r=smaug 2016-04-12 08:50:38 -04:00
Sebastian Hengst
d3fc87adc9 Backed out changeset b416fc68c0a2 (bug 1257180) for crash in test_performance_user_timing.html on Android debug. r=backout on a CLOSED TREE 2016-04-12 17:56:15 +02:00
Andrea Marchesini
4109793f74 Bug 1257180 - patch 1 - Directory clonable to workers, r=smaug 2016-04-12 08:50:38 -04:00
Andrea Marchesini
32c6dd01b5 Bug 1258221 - patch 3 - Rename FileSystemTaskBase to FileSystemTaskChildBase, r=smaug 2016-04-09 19:17:28 +01:00
Andrea Marchesini
f5655f4f9e Bug 1258221 - patch 2 - Port FileSystem API and DeviceStorage API to PBackground, r=smaug 2016-04-09 19:17:02 +01:00
Andrea Marchesini
8b45de854a Bug 1258221 - patch 1 - File::CreateFromFile only for main-thread, r=smaug 2016-04-09 19:15:50 +01:00
Andrea Marchesini
6852883163 Bug 1173320 - patch 5/8 - Cleanup manual string path management, r=smaug 2016-03-20 11:56:10 +01:00
Andrea Marchesini
c5b6c2add9 Bug 1173320 - patch 2/8 - Proper naming for the FileSystem path serialization, r=smaug 2016-03-20 11:56:10 +01:00
Andrea Marchesini
d10e0b4b34 Bug 1173320 - patch 1/8 - Implement Directory object as string and not as BlobImpl, r=smaug 2016-03-20 11:56:10 +01:00
Phil Ringnalda
9e96cfb31d Backed out 8 changesets (bug 1173320) for adding dom/filesystem/tests/test_basic.html without making it work on Android
Backed out changeset 7e3a105b9160 (bug 1173320)
Backed out changeset 094819fbb07f (bug 1173320)
Backed out changeset 23b0e55ff1db (bug 1173320)
Backed out changeset 8bf8e2fcedad (bug 1173320)
Backed out changeset 3de390c6f47f (bug 1173320)
Backed out changeset fb298010e12e (bug 1173320)
Backed out changeset f1a965c2f796 (bug 1173320)
Backed out changeset 176128ba757f (bug 1173320)
2016-03-19 19:44:22 -07:00
Andrea Marchesini
870442b443 Bug 1173320 - patch 5/8 - Cleanup manual string path management, r=smaug 2016-03-19 22:29:47 +01:00
Andrea Marchesini
c3f9559efd Bug 1173320 - patch 2/8 - Proper naming for the FileSystem path serialization, r=smaug 2016-03-19 22:29:46 +01:00
Andrea Marchesini
97ca49dfa3 Bug 1173320 - patch 1/8 - Implement Directory object as string and not as BlobImpl, r=smaug 2016-03-19 22:29:46 +01:00
Andrea Marchesini
058eacf49e Bug 1234192 - part 1 - FileSystemBase should not be thread-safe, r=smaug 2015-12-30 08:53:20 +00:00
Phil Ringnalda
410f611998 Back out 2 changesets (bug 1234192) for "Assertion failure: !mFileSystem" in test_fs_createFile.html
Backed out changeset 3f37b08ceb85 (bug 1234192)
Backed out changeset bab507aa7874 (bug 1234192)
2015-12-29 19:16:40 -08:00
Andrea Marchesini
423ab43000 Bug 1234192 - part 1 - FileSystemBase should not be thread-safe, r=smaug 2015-12-29 20:41:37 +00:00
Birunthan Mohanathas
ac37dec517 Bug 1219392 - Capitalize mozilla::unused to avoid conflicts. r=froydnj 2015-11-02 07:53:26 +02:00
Dragana Damjanovic
f5e3e71a6d Bug 905127 - Part 2 - remove unnecessary nsNetUtil.h includes r=jduell 2015-07-06 07:55:00 +02:00
Emanuel Hoogeveen
b30abdc582 Bug 905127 - Part 1 - Make some functions from nsNetUtil not inline. r=jduell 2015-07-07 04:17:00 +02:00
Juan Gomez
89035d527e Bug 1171931 - Refactor duplicated code using XRE_IsParent/ContentProcess. r=froydnj 2015-07-03 18:29:00 -07:00
Ryan VanderMeulen
7aba9d7002 Backed out changeset 8b4e4083639e (bug 1171931) for B2G debug emulator bustage. 2015-06-25 19:48:42 -04:00
Juan Gomez
7323e89a40 Bug 1171931 - Refactor duplicated code using XRE_IsParent/ContentProcess. r=froydnj 2015-06-24 14:11:00 -04:00
Andrea Marchesini
41c29ad762 Bug 1163387 - Rename FileImpl to BlobImpl, r=ehsan 2015-05-12 13:11:03 +01:00
Andrea Marchesini
a8f15ce969 Bug 1159401 - Split Blob and File classes, r=bz 2015-05-12 13:09:51 +01:00
Wes Kocher
040b8fe0e4 Backed out 2 changesets (bug 1159401) for b2g build bustage
Backed out changeset adfee1efb1e1 (bug 1159401)
Backed out changeset 70c63c8546e3 (bug 1159401)
2015-05-11 14:54:02 -07:00
Wes Kocher
81e9cbedba Backed out changeset 56e4c68dc3da (bug 1163387) for build bustage CLOSED TREE 2015-05-11 13:17:58 -07:00
Andrea Marchesini
bd76fd013b Bug 1163387 - Rename FileImpl to BlobImpl, r=ehsan 2015-05-11 18:50:54 +01:00
Andrea Marchesini
5d622f89aa Bug 1159401 - patch 1 - Split Blob and File in 2 classes, r=bz 2015-05-11 18:50:50 +01:00
Ryan VanderMeulen
95df0286b8 Backout revisions 4287533203fb and 96a3ebfe09d8 (bug 1159401) for bustage.
CLOSED TREE
2015-05-11 11:43:59 -04:00
Andrea Marchesini
2ffeefc77a Bug 1159401 - patch 1 - Split Blob and File in 2 classes, r=bz 2015-05-11 15:20:06 +01:00
Andrew McCreight
92010d3e4c Bug 1152551, part 2 - Fix mode lines in dom/. r=jst 2015-05-03 15:32:37 -04:00
Andrea Marchesini
1ca3c6632b Bug 1158437 - dom::File should accept negative date values, r=smaug 2015-04-27 12:17:19 +01:00
Andrea Marchesini
6887a8111f Bug 1047483 - patch 3 - Renaming DOMFile to File, r=ehsan 2014-10-08 17:15:23 +01:00
Andrea Marchesini
539efa95b3 Bug 1047483 - patch 1 - Porting DOMFile/DOMBlob to WebIDL, r=bz, r=bkelly, r=bholley 2014-10-08 17:15:22 +01:00
Ryan VanderMeulen
ac4e3f2f99 Backed out 7 changesets (bug 1047483, bug 1079301, bug 1079335) for webplatform test failures.
Backed out changeset 7d06b68c44d0 (bug 1079335)
Backed out changeset 92030169528e (bug 1079301)
Backed out changeset c09d7f95554a (bug 1047483)
Backed out changeset c199f1057d7e (bug 1047483)
Backed out changeset 18830d07884c (bug 1047483)
Backed out changeset e087289ccfbb (bug 1047483)
Backed out changeset 6238ff5d3ed0 (bug 1047483)

CLOSED TREE
2014-10-07 13:16:11 -04:00
Andrea Marchesini
63c7f37dd9 Bug 1047483 - patch 3 - Renaming DOMFile to File, r=ehsan 2014-10-07 15:20:55 +01:00
Andrea Marchesini
725b2db832 Bug 1047483 - patch 1 - Porting DOMFile/DOMBlob to WebIDL, r=bz, r=bkelly, r=bholley 2014-10-07 15:20:52 +01:00
Ben Turner
e30152a851 Bug 994190 - 'Modify main-thread IndexedDB to use PBackground', r=khuey. 2014-09-26 16:21:57 -07:00
Ben Turner
4937da099f Backout bug 994190 and merge over some stuff that landed afterwards on a CLOSED TREE. 2014-09-17 19:36:01 -04:00
Ben Turner
aede706b17 Bug 994190 - 'Modify main-thread IndexedDB to use PBackground', r=khuey. 2014-09-13 12:12:19 -04:00
Yuan Xulei
15cf2afe7c Bug 910412 - Filesystem API permission request and checks. r=dhylands 2014-03-05 11:24:19 +08:00
Yuan Xulei
22b80430dc Bug 910412 - Implement |getRoot|, |createDirectory| and |get| for Directory. r=dhylands, r=smaug 2014-03-05 11:25:40 +08:00
Ryan VanderMeulen
f3e7f70e31 Backed out 5 changesets (bug 910412) for intermittent crash whack-a-mole.
Backed out changeset e3eb9463b3e1 (bug 910412)
Backed out changeset d5863d302bde (bug 910412)
Backed out changeset 422b66d4b1ca (bug 910412)
Backed out changeset 3431d59d752e (bug 910412)
Backed out changeset b1c0310cdac1 (bug 910412)
2014-03-11 12:17:03 -04:00
Ryan VanderMeulen
553d6de5a8 Backed out changeset 3c126eebea64 (bug 981145) 2014-03-11 12:17:01 -04:00
Yuan Xulei
92212ec65d Bug 981145 - Remove main thread assertion from FileSystemTaskBase dtor. r=dhylands 2014-03-11 08:10:57 -04:00