Commit Graph

164 Commits

Author SHA1 Message Date
Adam Gashlin
349bf16d98 Bug 1639067 part 3 - Extend "Open In System Viewer" from PDF to all viewable internally. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D86652
2020-08-17 21:24:45 +00:00
Dorel Luca
431b3e2a3a Backed out 4 changesets (bug 1639067) for XPCshell failures in tests/unit/test_getMIMEInfo_pdf.js. CLOSED TREE
Backed out changeset 1e400fafd80b (bug 1639067)
Backed out changeset 7bb3c2ec5c7a (bug 1639067)
Backed out changeset 755fd5771648 (bug 1639067)
Backed out changeset 951e10b7354f (bug 1639067)
2020-08-18 00:18:32 +03:00
Adam Gashlin
fcc30dab7f Bug 1639067 part 3 - Extend "Open In System Viewer" from PDF to all viewable internally. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D86652
2020-08-17 19:14:00 +00:00
Sam Foster
7a6bf11a8c Bug 1649421 - Handle null mimeInfo from a download when populating the context menu. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D81767
2020-07-01 22:27:51 +00:00
Sam Foster
19f6f1121e Bug 1639069 - Add download context menu items to 'Use' and 'Always use' the system viewer to open the download. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D79396
2020-06-25 22:19:37 +00:00
Emma Malysz
fb826b9e34 Bug 1627676: add telemetry probes for downloads panel r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D78709
2020-06-12 17:18:07 +00:00
Sam Foster
dbcd872d8e Bug 1638156 - Allow key modifiers to determine how/'where' PDFs are opened when possible. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D75870
2020-05-29 07:16:54 +00:00
Razvan Maries
030be31f02 Backed out 2 changesets (bug 1638156) for perma failures on browser_pdfjs_preview.js. CLOSED TREE
Backed out changeset c5c3da72080f (bug 1638156)
Backed out changeset da0e27f7f17a (bug 1638156)
2020-05-28 05:01:13 +03:00
Sam Foster
0becf30a8f Bug 1638156 - Allow key modifiers to determine how/'where' PDFs are opened when possible. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D75870
2020-05-28 01:13:19 +00:00
Sam Foster
83842cd59d Bug 1191591 - Delegate to the parent class' code when opening downloads from the download panel. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D73773
2020-05-18 17:30:08 +00:00
Sam Foster
0af6b6c35b Bug 1191591 - Consolidate download opening to use download.launch() via a DownloadsCommon.openDownload helper. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D75435
2020-05-18 17:30:00 +00:00
Noemi Erli
80613259fb Backed out 3 changesets (bug 1191591) for causing newtab failures
Backed out changeset bd59c10af492 (bug 1191591)
Backed out changeset 3ff8cc8dd4b7 (bug 1191591)
Backed out changeset c6b3783367f6 (bug 1191591)
2020-05-16 01:57:34 +03:00
Sam Foster
8108b677c1 Bug 1191591 - Delegate to the parent class' code when opening downloads from the download panel. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D73773
2020-05-15 20:43:46 +00:00
Sam Foster
48546bf4cf Bug 1191591 - Consolidate download opening to use download.launch() via a DownloadsCommon.openDownload helper. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D75435
2020-05-15 20:42:03 +00:00
Christoph Kerschbaumer
414c32b5ed Bug 1584539: Stop propagation of event. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D48027
2019-10-03 14:42:29 +00:00
Thomas Nguyen
1b050362ee Bug 1567940 Apply ReferrerInfo to Download and fix Go to Download Page button r=Gijs,dimi
In the old way, if referrer is ommited we will not be able to go to
download page. In that case, we should use originalReferrer in
ReferrerInfo object

Differential Revision: https://phabricator.services.mozilla.com/D39875
2019-08-20 16:22:44 +00:00
Victor Porof
8eb72fd3fc Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042
2019-07-05 09:53:32 +02:00
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Paolo Amadini
3d858408e1 Bug 1513149 - Hovering the action buttons doesn't display the command associated with the button. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D14172
2018-12-11 18:27:01 +00:00
Tom Schuster
9c64b67174 Bug 1503588 - Remove aDataLen parameter from nsITransferable.getAnyTransferData. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D10441
2018-11-02 11:02:25 +00:00
Paolo Amadini
1b1a2ac959 Bug 1452626 - Remove the "download" binding. r=mak,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D7176
2018-10-04 11:12:03 +01:00
Paolo Amadini
1549bd8b40 Bug 1493969 - Refactor the user interface update code of download elements. r=mak,ursula
Differential Revision: https://phabricator.services.mozilla.com/D4539
2018-09-28 14:59:30 +01:00
Paolo Amadini
a9a795fc41 Bug 1452629 - Part 1 - Avoid redundant button elements in the "download" widget. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D4441
2018-09-13 16:16:46 +01:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
2018-08-31 05:59:17 +00:00
Brendan Dahl
532fe1f6b0 Bug 1485426 - Use createXULElement instead of createElement in XUL docs. r=bgrins
Preparing for transitioning to XHTML.

MozReview-Commit-ID: JLlmUxsvhIB

Differential Revision: https://phabricator.services.mozilla.com/D4265
2018-08-25 00:16:27 +00:00
Brian Grinstead
1c86f46ecd Bug 1479125 - Migrate calls that expect an element to be returned to use element variation firstChild etc to firstElementChild etc;r=Paolo
This allows the JS to work in HTML documents, where whitespace is preserved. In XUL
documents, whitespace is ignored when parsing so text nodes are generally not returned.

The following changes were made, with manual cleanups as necessary (i.e. when firstChild actually
refers to a text node, or when firstChild is used in a loop to empty out an element):

  firstChild->firstElementChild
  lastChild->lastElementChild
  nextSibling->nextElementSibling
  previousSibling->previousElementSibling
  childNodes->children

MozReview-Commit-ID: 95NQ8syBhYw
2018-08-08 15:22:53 -07:00
Ciure Andrei
642bbf1d1c Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE 2018-02-23 02:06:26 +02:00
Paolo Amadini
f7c87a1ab1 Bug 1439358 - Part 2 - Don't use the "current" property when restoring focus from the blocked downloads subview. r=Gijs
MozReview-Commit-ID: ASmmdQMctr5
2018-02-22 12:20:53 +00:00
Brendan Dahl
08481d480b Bug 1434077 - Inline indicators overlay. r=Paolo
This is part of the work to remove XUL overlays. The overlay was originally
created to help startup performance, but inlining the overlay seems to
no longer have detrimental effects to performance and is more straightforward.

MozReview-Commit-ID: 7sfVel6qvgv
2018-02-14 12:20:58 -08:00
Brendan Dahl
e5f0a48b9a Bug 1434077 - Inline downloads overlay. r=Paolo
This is part of the work to remove XUL overlays. The overlay was originally
created to help startup performance, but using a hidden panel instead seems to
have no detrimental effects to performance and is more straightforward.

MozReview-Commit-ID: JlWcZEhPXyH
2018-02-06 15:55:50 -08:00
Boris Zbarsky
4fd6e65c55 Bug 1436508 part 10. Remove use of nsIDOMKeyEvent in JS. r=masayuki
MozReview-Commit-ID: GGciORX62Yh
2018-02-09 11:17:09 -05:00
Paolo Amadini
ff1ddd6adf Bug 1434883 - Part 2 - Use an asynchronous API to open PanelMultiView panels. r=Gijs
MozReview-Commit-ID: 3VzoxJ3Ociy
2018-02-06 09:02:27 +00:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Florian Quèze
c5f15a4700 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Erica Wright
942200ccac Bug 1033395 - Panels Should Be Anchored from the Same Height on the Toolbar. r=johannh
MozReview-Commit-ID: 6bhlfeD1esE
2017-09-13 15:49:32 -04:00
Phil Ringnalda
6f4d37fc42 Backed out changeset 5b9d2ebcf44e (bug 1033395) for failures in browser_overflow_anchor.js
MozReview-Commit-ID: LfhmJLydnaF
2017-10-16 22:01:54 -07:00
Erica Wright
fa263f98ba Bug 1033395 - Panels Should Be Anchored from the Same Height on the Toolbar. r=johannh
MozReview-Commit-ID: 6bhlfeD1esE
2017-09-13 15:49:32 -04:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Boris Zbarsky
c4de48a0e8 Bug 1400898 part 1. Remove the one script use of nsIDOMChromeWindow. r=farre
MozReview-Commit-ID: I31eceiJP55
2017-09-19 10:13:22 -04:00
Gijs Kruitbosch
d48e2eaf65 Bug 1397447 - make downloads button autohide by default, r=mak
MozReview-Commit-ID: E9izQpa4fFZ
2017-09-08 14:16:36 +01:00
Mike de Boer
bc72a05e37 Bug 1354532 - Part 1 - Implement a new Downloads view as part of the Library widget. r=Paolo
MozReview-Commit-ID: AqH8Zj8XCQl
2017-09-06 16:23:00 +02:00
Sebastian Hengst
2b4cc8b55c Backed out changeset f1d18c741b2c (bug 1354532) for eslint failure at browser/components/downloads/DownloadsCommon.jsm:671: Expected property shorthand. r=backout 2017-09-06 16:48:00 +02:00
Mike de Boer
6cb3ed2016 Bug 1354532 - Part 1 - Implement a new Downloads view as part of the Library widget. r=Paolo
MozReview-Commit-ID: AqH8Zj8XCQl
2017-09-06 16:23:00 +02:00
Wes Kocher
08356deb1c Merge m-c to autoland, a=merge
MozReview-Commit-ID: LEKykpTAKjv
2017-08-25 17:32:33 -07:00
Gijs Kruitbosch
663af591de Back out changeset 97f7f5175b2f (bug 1371765) because we're changing the plan for the downloads button, rs=backout,firebot,paolo
MozReview-Commit-ID: FTvFDV5nuG6
2017-08-25 13:32:47 +01:00