Brad Werth
1aba681806
Bug 1457288 - Part 1: Clamp EllipseShapeInfo distance field operands to the maximum shape-margin we are willing to compute. r=mats
...
MozReview-Commit-ID: IXAV0uaxB0R
2018-04-27 13:10:08 -07:00
Brad Werth
2807283c13
Bug 1265342 Part 7: Implement shape-margin for shape-outside: shape-box. r=dholbert
...
MozReview-Commit-ID: 67vq9Gcr8qJ
2018-02-26 14:47:31 -08:00
Brad Werth
91c12e7873
Bug 1265342 Part 6b: Implement shape-margin for shape-outside: inset, for general case of shape-margin > 0. r=dholbert
...
MozReview-Commit-ID: 4pjALPSIBhI
2018-04-17 11:39:50 -07:00
Brad Werth
cf7f6fcd0f
Bug 1265342 Part 6a: Implement shape-margin for shape-outside: inset, for some special cases with shape-margin > 0. r=dholbert
...
MozReview-Commit-ID: AEOksiuM0GJ
2018-04-13 11:29:14 -07:00
Brad Werth
92f94f4546
Bug 1265342 Part 5d: Move EllipseShapeInfo class definition ahead of RoundedBoxShapeInfo so it can be referenced by rounded boxes. r=dholbert
...
MozReview-Commit-ID: G8qdPlnh8kY
2018-04-17 11:59:11 -07:00
Brad Werth
99177b8616
Bug 1265342 Part 5c: Add some asserts to ensure ellipse distance field index values are in-bounds. r=dholbert
...
MozReview-Commit-ID: CpuWWaLh1CX
2018-04-20 13:43:36 -07:00
Brad Werth
54e7c6fe32
Bug 1265342 Part 5b: Complete the implementation of shape-margin for ellipse (handling shape-margin: > 0). r=dholbert
...
MozReview-Commit-ID: CovCfk5ryEn
2018-04-11 15:18:32 -07:00
Brad Werth
3723030669
Bug 1265342 Part 5a: Implement shape-margin for shape-outside: circle and ellipse (ellipse only for shape-margin: 0). r=dholbert
...
MozReview-Commit-ID: HeipoUTkqUE
2018-02-26 13:13:03 -08:00
Brad Werth
359ed0b705
Bug 1265342 Part 4b: Add some logic and asserts to ensure distance field index values and image index values are in-bounds. r=dholbert
...
MozReview-Commit-ID: 1C9vB14Qhyj
2018-04-20 14:04:15 -07:00
Brad Werth
a9d6529a1b
Bug 1265342 Part 4a: Complete the implementation of shape-margin for shape-outside: image (handling shape-margin: > 0). r=dholbert
...
MozReview-Commit-ID: 4xqfqWB78Oh
2018-02-22 11:11:03 -08:00
Brad Werth
b126f691ee
Bug 1265342 Part 3: Stub in shape-margin for shape-outside: image, by implementing only for shape-margin: 0. r=dholbert
...
MozReview-Commit-ID: 2gVRyQtd7Io
2018-03-12 17:04:34 -07:00
Brad Werth
74132a44cd
Bug 1265342 Part 2b: Refactor interval creation for shape-outside:image. r=dholbert
...
MozReview-Commit-ID: LnzQPsSBVqY
2018-02-28 10:43:43 -08:00
Brad Werth
8711333a2d
Bug 1265342 Part 2a: Move interval binary search method into ShapeInfo. r=dholbert
...
MozReview-Commit-ID: BxJxIU0RVAo
2018-04-11 14:05:06 -07:00
Narcis Beleuzu
87b92a12ca
Backed out 20 changesets (bug 1265342) for mochitest-plain-headless failures on layout/style/test/test_first_letter_restrictions.html. CLOSED TREE
...
Backed out changeset 6c80ec2d0398 (bug 1265342)
Backed out changeset 62d571916086 (bug 1265342)
Backed out changeset fd247f38f8a7 (bug 1265342)
Backed out changeset 83aee3dafe4b (bug 1265342)
Backed out changeset 9b200122014e (bug 1265342)
Backed out changeset a90aa063b2fd (bug 1265342)
Backed out changeset 0791ff3d9194 (bug 1265342)
Backed out changeset 7109288f10b3 (bug 1265342)
Backed out changeset 048cce2fb99f (bug 1265342)
Backed out changeset c8e3dbc6c729 (bug 1265342)
Backed out changeset 09da0968333a (bug 1265342)
Backed out changeset d16f7ff85677 (bug 1265342)
Backed out changeset 53eb7f14463d (bug 1265342)
Backed out changeset 64fc631ef122 (bug 1265342)
Backed out changeset 332382c708e1 (bug 1265342)
Backed out changeset a8695981eec0 (bug 1265342)
Backed out changeset ce473fa5f1f4 (bug 1265342)
Backed out changeset 5ee470e75a53 (bug 1265342)
Backed out changeset 802aa95a52d9 (bug 1265342)
Backed out changeset 5da0c34c9600 (bug 1265342)
2018-04-24 22:31:15 +03:00
Brad Werth
f69bf8b958
Bug 1265342 Part 7: Implement shape-margin for shape-outside: shape-box. r=dholbert
...
MozReview-Commit-ID: 67vq9Gcr8qJ
2018-02-26 14:47:31 -08:00
Brad Werth
c26c445b0a
Bug 1265342 Part 6b: Implement shape-margin for shape-outside: inset, for general case of shape-margin > 0. r=dholbert
...
MozReview-Commit-ID: 4pjALPSIBhI
2018-04-17 11:39:50 -07:00
Brad Werth
611a055050
Bug 1265342 Part 6a: Implement shape-margin for shape-outside: inset, for some special cases with shape-margin > 0. r=dholbert
...
MozReview-Commit-ID: AEOksiuM0GJ
2018-04-13 11:29:14 -07:00
Brad Werth
d9819b00a3
Bug 1265342 Part 5d: Move EllipseShapeInfo class definition ahead of RoundedBoxShapeInfo so it can be referenced by rounded boxes. r=dholbert
...
MozReview-Commit-ID: G8qdPlnh8kY
2018-04-17 11:59:11 -07:00
Brad Werth
4b4cbbf6d9
Bug 1265342 Part 5c: Add some asserts to ensure ellipse distance field index values are in-bounds. r=dholbert
...
MozReview-Commit-ID: CpuWWaLh1CX
2018-04-20 13:43:36 -07:00
Brad Werth
e83cbdb4d4
Bug 1265342 Part 5b: Complete the implementation of shape-margin for ellipse (handling shape-margin: > 0). r=dholbert
...
MozReview-Commit-ID: CovCfk5ryEn
2018-04-11 15:18:32 -07:00
Brad Werth
f9764e14e4
Bug 1265342 Part 5a: Implement shape-margin for shape-outside: circle and ellipse (ellipse only for shape-margin: 0). r=dholbert
...
MozReview-Commit-ID: HeipoUTkqUE
2018-02-26 13:13:03 -08:00
Brad Werth
a508f00b3d
Bug 1265342 Part 4b: Add some logic and asserts to ensure distance field index values and image index values are in-bounds. r=dholbert
...
MozReview-Commit-ID: 1C9vB14Qhyj
2018-04-20 14:04:15 -07:00
Brad Werth
fc043ffbd8
Bug 1265342 Part 4a: Complete the implementation of shape-margin for shape-outside: image (handling shape-margin: > 0). r=dholbert
...
MozReview-Commit-ID: 4xqfqWB78Oh
2018-02-22 11:11:03 -08:00
Brad Werth
58233fa194
Bug 1265342 Part 3: Stub in shape-margin for shape-outside: image, by implementing only for shape-margin: 0. r=dholbert
...
MozReview-Commit-ID: 2gVRyQtd7Io
2018-03-12 17:04:34 -07:00
Brad Werth
bf970f6070
Bug 1265342 Part 2b: Refactor interval creation for shape-outside:image. r=dholbert
...
MozReview-Commit-ID: LnzQPsSBVqY
2018-02-28 10:43:43 -08:00
Brad Werth
31704ece62
Bug 1265342 Part 2a: Move interval binary search method into ShapeInfo. r=dholbert
...
MozReview-Commit-ID: BxJxIU0RVAo
2018-04-11 14:05:06 -07:00
Sebastian Hengst
d91e9954eb
Backed out 4 changesets (bug 525063) on request from Andi. a=backout
...
Backed out changeset 516c4fb1e4b8 (bug 525063)
Backed out changeset 6ff8aaef2866 (bug 525063)
Backed out changeset bf13e4103150 (bug 525063)
Backed out changeset d7d2f08e051c (bug 525063)
2018-04-13 16:01:28 +03:00
Tristan Bourvon
6095241db8
Bug 525063 - Initialize uninitialized class attributes in m-c. r=ehsan
2018-04-10 21:11:02 +02:00
Ting-Yu Lin
3593258ca0
Bug 1404222 Part 1: Implement shape-outside: <image>. r=dbaron,dholbert
...
When creating ImageShapeInfo, it's likely that the image is still decoding.
Part 2 will add mechanism to trigger reflow after the image is ready.
2018-01-25 14:55:18 +08:00
Ryan VanderMeulen
93ffd60378
Backed out 11 changesets (bug 1404222) for static analysis failures on a CLOSED TREE.
...
Backed out changeset a6a99136300c (bug 1404222)
Backed out changeset 7183b8104399 (bug 1404222)
Backed out changeset a1e4294c1c59 (bug 1404222)
Backed out changeset b79d6e8318db (bug 1404222)
Backed out changeset 0450620fdabd (bug 1404222)
Backed out changeset 026c74a92d04 (bug 1404222)
Backed out changeset 50ac4167f702 (bug 1404222)
Backed out changeset 59038f2db68a (bug 1404222)
Backed out changeset f6b9096da915 (bug 1404222)
Backed out changeset 4e0baffdd79b (bug 1404222)
Backed out changeset 57eeb849ab88 (bug 1404222)
2018-04-02 17:57:27 -04:00
Ting-Yu Lin
14acc00a84
Bug 1404222 Part 1: Implement shape-outside: <image>. r=dbaron,dholbert
...
When creating ImageShapeInfo, it's likely that the image is still decoding.
Part 2 will add mechanism to trigger reflow after the image is ready.
2018-01-25 14:55:18 +08:00
Ting-Yu Lin
84884a8a9f
Bug 1426065 Part 2 - Drop mozilla prefix in nsFloatManager.cpp. r=dholbert
...
The cpp file already has "using namespace mozilla;".
MozReview-Commit-ID: L2OPyBuvg9q
2017-12-19 15:22:36 +08:00
Ting-Yu Lin
770e1495a5
Bug 1426065 Part 1 - Move ShapeInfo and its dervied classes from header to cpp. r=dholbert
...
ShapeInfo and its derived classes are private to nsFloatManager, which don't
need to be in the header. Move them to cpp to make compile faster after
changing them.
MozReview-Commit-ID: MRkBGoqcPj
2017-12-19 15:06:10 +08:00
Ting-Yu Lin
48f97afc24
Bug 1418224 Part 3 - Add shape-outside: <image> support to style system. r=heycam
...
Some Gecko style system files are modified to prevent assertions and
crashing, and to keep test failures on stylo disabled builds to minimum.
MozReview-Commit-ID: GuxAeCTz0xx
2017-11-17 16:34:37 +08:00
Ting-Yu Lin
c944d7d613
Bug 1418224 Part 2 - Extract ShapeInfo::CreateBasicShape(). r=heycam
...
MozReview-Commit-ID: DZ1O0CzzsyT
2017-11-21 18:24:34 +08:00
dluca
617c4e7f6a
Backed out 4 changesets (bug 1418224) for build bustages r=backout on a CLOSED TREE
...
Backed out changeset 3ef8715cb8d7 (bug 1418224)
Backed out changeset 0d58d9fed90d (bug 1418224)
Backed out changeset faad7f275749 (bug 1418224)
Backed out changeset 1e86ff6b95ae (bug 1418224)
2017-11-27 07:42:50 +02:00
Ting-Yu Lin
0ba402e925
Bug 1418224 Part 3 - Add shape-outside: <image> support to style system. r=heycam
...
Some Gecko style system files are modified to prevent assertions and
crashing, and to keep test failures on stylo disabled builds to minimum.
MozReview-Commit-ID: GuxAeCTz0xx
2017-11-17 16:34:37 +08:00
Ting-Yu Lin
5e0f1b08ba
Bug 1418224 Part 2 - Extract ShapeInfo::CreateBasicShape(). r=heycam
...
MozReview-Commit-ID: DZ1O0CzzsyT
2017-11-21 18:24:34 +08:00
Daniel Holbert
8fea3c215f
Bug 1412346 part 5: (automated patch) Switch a bunch of C++ files in layout to use our standard mode lines. r=jfkthame
...
This patch was generated automatically by the "modeline.py" script, available
here: https://github.com/amccreight/moz-source-tools/blob/master/modeline.py
For every file that is modified in this patch, the changes are as follows:
(1) The patch changes the file to use the exact C++ mode lines from the
Mozilla coding style guide, available here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Mode_Line
(2) The patch deletes any blank lines between the mode line & the MPL
boilerplate comment.
(3) If the file previously had the mode lines and MPL boilerplate in a
single contiguous C++ comment, then the patch splits them into
separate C++ comments, to match the boilerplate in the coding style.
MozReview-Commit-ID: EuRsDue63tK
2017-10-27 10:33:53 -07:00
Ting-Yu Lin
d35b7d33db
Bug 1404243 Part 3 - Remove refcount for StyleBasicShape, and use UniquePtr to hold it. r=heycam
...
After StyleBasicShape is set to StyleShapeSource, it's life cycle never go
beyond StyleShapeSource, so I make StyleBasicShape hold by a UniquePtr in
StyleShapeSource.
Also, replace all raw pointers to StyleBasicShape by UniquePtr in all APIs.
MozReview-Commit-ID: 1MfIFjP8TsQ
2017-09-25 18:50:24 +08:00
Jonathan Kew
4dcf0fe444
Bug 1365982 - Attach frame properties to each frame instead of looking them up in a hashtable on the prescontext. r=mats
2017-05-27 12:36:00 +01:00
L. David Baron
ebf5db26b4
Bug 1367190 patch 1 - Convert the 4 objects that use nsPresArena::AllocateBySize to use AllocateByObjectID. r=mats
...
MozReview-Commit-ID: 3LaG8Daon6V
2017-05-24 09:35:26 -04:00
cku
14c0f9ceb9
Bug 1340044 - Part 2. Rename value in StyleGeometryBox. r=heycam
...
This change is to use gecko_enum_prefix in helpers.mako.rs, so that we do not
need to manually write code for nsStyleDisplay::mTransformBox.
MozReview-Commit-ID: 7UAL0iUcSIO
2017-03-16 15:18:10 +08:00
Ting-Yu Lin
17312fe511
Bug 1326409 Part 6 - Convert aBasicShape to a pointer to a const value. r=dholbert
...
To address reviewer's comments in bug 1326409 comment 13 and comment 14.
MozReview-Commit-ID: FiUXXk4O8N7
2017-03-13 12:03:40 +08:00
Ting-Yu Lin
6cf81bf416
Bug 1326409 Part 5 - Implement shape-outside: polygon(). r=dholbert
...
The <fill-rule> in the polygon() syntax is not handled because it doesn't
matter to shape-outside at all.
The reftests are numbered from 018 to avoid conflict with the w3c upstream
ones according to this list.
https://test.csswg.org/harness/results/css-shapes-1_dev/grouped/
Reftest 018 to 025 are under various writing-modes, 026 to 029 are testing
empty float area, 030 to 031 are testing polygon containing horizontal
lines.
MozReview-Commit-ID: FPUbMdZsvu6
2017-03-13 12:03:40 +08:00
Ting-Yu Lin
d88acdc8bf
Bug 1326409 Part 3 - Remove unneeded WritingMode parameter. r=dholbert
...
Remove WritingMode parameter from LineRight() and LineLeft() in both
FloatInfo and ShapeInfo.
Bug 1316549 Part 3 added the parameter to compute the border radii under
writing-modes correctly. However, bug 1326407 Part 6 later made us cache
border radii, so the WritingMode parameter is no longer needed.
MozReview-Commit-ID: DFhm5d51OXJ
2017-03-13 12:03:39 +08:00
cku
1819876e04
Bug 1336905 - Part 1. Remove StyleShapeSource's template argument. r=heycam,TYLin
...
MozReview-Commit-ID: FHTwGyXHsce
2017-02-21 23:26:17 +08:00
Ting-Yu Lin
787377e136
Bug 1326407 Part 8 - Implement shape-outside: inset(). r=dbaron
...
The reftests have passed
layout/reftests/w3c-css/submitted/check-for-references.sh.
MozReview-Commit-ID: JZk1fo8SxgV
2017-02-16 10:51:49 +08:00
Ting-Yu Lin
7ed1079d5a
Bug 1326407 Part 7 - Rename BoxShapeInfo to RoundedBoxShapeInfo. r=dbaron
...
The radii has been cached in the BoxShapeInfo in the previous part. Hence
the rename.
This class will be used to implement inset() in the next part, so the rect
stored isn't necessarily the rect of the <shape-box>. It could be the inset
rectangle. Therefore I rename mShapeBoxRect to mRect to avoid any confusion.
MozReview-Commit-ID: J0hpQDsbMyN
2017-02-16 10:51:48 +08:00
Ting-Yu Lin
12032a13e7
Bug 1326407 Part 6 - Cache the border radii in BoxShapeInfo. r=dbaron
...
The radii can be computed when creating BoxShapeInfo. No need to compute
them every time in the LineLeft() and LineRight().
MozReview-Commit-ID: GIDSLgickCT
2017-02-16 10:51:48 +08:00