Xidorn Quan
ca146f45ac
Bug 1230034 part 5 - Convert all frame properties which use DeleteValue and ReleaseValue as destructor to be typesafe. r=dbaron
...
By changing signature of those two functions, we make compiler complain about
all their existing uses, so we can find all of them and convert them.
Some of the callsites of Get() with those properties are also converted, but not
all of them. It is fine because if there is any incorrect conversion, compilers
is able to find out now. So they are completely typesafe.
2016-01-28 14:23:59 +11:00
Xidorn Quan
4dccb52f19
Bug 1230034 part 3 - Move some frame property declaration around. r=dbaron
2016-01-28 14:23:59 +11:00
Bogdan Postelnicu
0329310a32
Bug 1239251 - Initialize mCommonAncestorWithLastFrame with nullptr in constructor BuildTextRunsScanner. r=roc
2016-01-14 10:49:15 +02:00
Nicholas Nethercote
7fabd8754f
Bug 1231550 - Use DrawTarget instead of gfxContext and/or nsRenderingContext in many places in font/text code. r=jfkthame.
...
AutoTextRun now only needs a DrawTarget instead of an nsRenderingContext, and
similar nsRenderingContext/gfxContext-to-DrawTarget replacements can be
propagated a long way up the call graph. This patch replaces 93 occurrences of
nsRenderingContext and 135 occurrences of gfxContext with DrawTarget; that's
13% of them.
The patch is mostly plumbing changes. A couple of not-entirely-plumbing
changes:
- It adds a comment about the null check in
gfxGlyphExtents::GetTightGlyphExtentsAppUnits().
- A couple of functions simply had an unused gfxContext or nsRenderingContext
parameter removed, e.g. SetLineBreaks().
2015-12-15 13:56:41 -08:00
Nicholas Nethercote
be50c42d8b
Bug 1232822 (part 4) - Remove unused argument from SetPotentialLineBreaks(). r=jfkthame.
2015-12-15 13:56:40 -08:00
Jonathan Kew
d582b157a0
Bug 1224669 - Clamp width to be non-negative during intrinsic width calculation. r=dholbert
2016-01-01 10:29:27 +00:00
Xidorn Quan
16dc7cb0c0
Bug 1235489 - Remove assertion which is breakable when reflow is interrupted. r=jfkthame
2015-12-31 10:50:32 +11:00
Xidorn Quan
1a0b030355
Bug 1225018 part 2 - Move GetFontMetricsOfEmphasisMarks to nsLayoutUtils. r=jfkthame
2015-12-08 12:55:01 -05:00
Nicholas Nethercote
fe73890223
Bug 1230413 (part 4) - Remove unused nsRenderingContext argument from ForceBreak() and OptionallyBreak(). r=mattwoodrow.
2015-12-06 14:13:57 -08:00
Xidorn Quan
79d8370f97
Bug 1229739 - Use the color of shadow if available for drawing emphasis marks in shadow. r=jfkthame
2015-12-04 16:28:34 +11:00
Xidorn Quan
a0dc4027f4
Bug 1224013 part 2 - Render text-emphasis outside ruby. r=jfkthame
2015-12-04 15:16:54 +11:00
Xidorn Quan
e2a9789117
Backed out 8 changesets (bug 1225018, bug 1229278, bug 1224013) for reftest failures on CLOSED TREE
2015-12-04 13:08:17 +11:00
Xidorn Quan
cc42ace6c0
Bug 1224013 part 3 - Render text-emphasis outside ruby. r=jfkthame
2015-12-04 12:02:41 +11:00
Nicholas Nethercote
dc8d23a85d
Bug 1229202 (part 3) - Make gfxContextAutoDisableSubpixelAntialiasing take a DrawTarget instead of a gfxContext. r=mattwoodrow.
2015-12-02 15:32:16 -08:00
Robert O'Callahan
f31d503c54
Bug 1221043. Revert to including trailing whitespace for accessibility APIs. r=marcoz,mats
2015-12-01 02:21:25 +13:00
L. David Baron
ce35370e29
Bug 1228501 patch 3 - Remove nsFont::BaseEquals. r=jdaggett
...
BaseEquals and Equals were made the same by patch 2, so BaseEquals can
be removed.
(operator== is also defined as an inlined call to Equals.)
2015-11-30 14:02:25 -08:00
Carsten "Tomcat" Book
b6191f806e
Backed out changeset 6c478d7a9467 (bug 1228501)
2015-11-30 12:10:37 +01:00
L. David Baron
2b14697614
Bug 1228501 patch 3 - Remove nsFont::BaseEquals. r=jdaggett
...
BaseEquals and Equals were made the same by patch 2, so BaseEquals can
be removed.
(operator== is also defined as an inlined call to Equals.)
2015-11-29 23:15:02 -08:00
Xidorn Quan
8717c63d6e
Bug 1040668 part 14 - Add helper function nsStyleUtil::MatchesLanguagePrefix for doing simple language matching. r=dbaron
2015-11-28 11:56:33 +11:00
Xidorn Quan
713c472a8d
Bug 1040668 part 10 - Implement emphasis mark rendering. r=jfkthame
2015-11-28 11:56:33 +11:00
Xidorn Quan
e2b022c631
Bug 1040668 part 9 - Compute overflow from text-shadow after text decorations. r=dbaron
2015-11-28 11:56:33 +11:00
Xidorn Quan
f5e1cf001d
Bug 1040668 part 8 - Setup text emphasis for text run. r=jfkthame
2015-11-28 11:56:33 +11:00
Ting-Yu Lin
ec7b5746f9
Bug 1226875 - Remove nsIFrame::GetFirstChild(). r=mats
2015-11-26 17:12:39 +08:00
Xidorn Quan
95275b5ab4
Bug 1227001 part 3 - Remove no longer used mChangedBreaks from BreakSink. r=jfkthame
2015-11-24 10:23:05 +11:00
Xidorn Quan
f52ab6e53d
Bug 1227001 part 2 - Remove no longer used mExistingTextRun from BreakSink. r=jfkthame
2015-11-24 10:23:05 +11:00
Xidorn Quan
47034b5142
Bug 1227001 part 1 - Remove SetupBreakSinksFlags from BuildTextRunsScanner. r=jfkthame
2015-11-24 10:23:05 +11:00
Jonathan Kew
e418782b93
Bug 1224230 - Explicitly store the lineContainer's writing mode in InlineIntrinsicISizeData. r=dbaron
2015-11-14 08:46:11 +00:00
Nicholas Nethercote
97e025e8d2
Bug 1223215 (part 1) - Convert some gfx{Point,Size} to gfx::{Point,Size}. r=roc.
...
This lets us remove some Thebes{Point,Size}() and To{Point,Size}() calls.
2015-11-08 20:19:00 -08:00
Simon Montagu
432859415f
Bug 1216096: restore previous RTL caret behaviour by backout of bug 1164963, bug 1177505, and bug 1180417. r=jfkthame
2015-11-10 04:42:23 -08:00
Nicholas Nethercote
b038cea890
Bug 1038663 (part 6, attempt 2) - Allow percentage values for 'word-spacing'. r=heycam.
2015-11-08 16:40:37 -08:00
Nicholas Nethercote
9d739b4eb7
Bug 1038663 (part 5, attempt 2) - Change GetSpacingFlags(). r=heycam.
2015-11-08 14:49:02 -08:00
Nicholas Nethercote
751ea649bd
Bug 1038663 (part 4, attempt 2) - Inline StyleToCoord(). r=heycam.
2015-11-08 14:49:02 -08:00
Nicholas Nethercote
3a7a9ec035
Bug 1038663 (part 3, attempt 2) - Factor out space width computation. r=heycam.
2015-11-08 14:48:58 -08:00
Nicholas Nethercote
4a257d059c
Bug 1038663 (part 2, attempt 2) - Move GetFirstFontMetrics() up. r=heycam.
2015-11-08 13:52:58 -08:00
Nigel Babu
5f959e3a80
Backed out 6 changesets (bug 1038663) for Android opt R2 bustage
...
Backed out changeset 97e3492d6080 (bug 1038663)
Backed out changeset d176322f2d36 (bug 1038663)
Backed out changeset f69af9161252 (bug 1038663)
Backed out changeset 8bb77e5fad8c (bug 1038663)
Backed out changeset 954e57438f51 (bug 1038663)
Backed out changeset 16c0919101cd (bug 1038663)
2015-11-06 12:49:36 +05:30
Nicholas Nethercote
795ae6ee22
Bug 1038663 (part 6) - Allow percentage values for 'word-spacing'. r=heycam.
2015-11-05 17:25:46 -08:00
Nicholas Nethercote
d70ef0affd
Bug 1038663 (part 5) - Change GetSpacingFlags(). r=heycam.
...
Again, this doesn't make sense in isolation, but it will make it easier to
allow for percentage word-spacing in a subsequent patch.
2015-11-05 16:33:37 -08:00
Nicholas Nethercote
2e43eafaa6
Bug 1038663 (part 4) - Inline StyleToCoord(). r=heycam.
...
This doesn't make much sense by itself, but one of the call sites will be
changed in a subsequent patch.
2015-11-04 21:10:36 -08:00
Nicholas Nethercote
f780597af5
Bug 1038663 (part 3) - Factor out space width computation. r=heycam.
...
This will be reused in a subsequent patch.
2015-11-04 18:02:40 -08:00
Nicholas Nethercote
de7f6dfab1
Bug 1038663 (part 2) - Move GetFirstFontMetrics() up. r=heycam.
...
This is necessary for a subsequent patch.
2015-11-04 18:02:20 -08:00
Jim Chen
d4fa2af7fa
Bug 1219833 - Respect composition underline color; r=masayuki
...
nsTextFrame didn't use the composition underline color if the
composition didn't have a foreground color defined. This patch makes it
use the underline color if foreground color is not defined.
2015-11-03 11:53:58 -05:00
Robert O'Callahan
499603986f
Bug 264412. Optimize GetRenderedText. r=mats
...
With these changes we're slightly faster than Chrome on the non-reflowing part of
Olli's testcase.
2015-10-30 19:22:33 +13:00
Robert O'Callahan
a6cc83a9c7
Bug 264412. Refactor nsIFrame::GetRenderedText API to be more sane. r=mats,marcoz
...
The test changes here are to adjust for the fact that
nsTextFrame::GetRenderedText can now trim whitespace from the end of lines
that end in a hard line break.
2015-10-30 19:23:10 +13:00
Matt Woodrow
2dfc6a4660
Bug 1216851 - Allow flattening of opacity when it contains text. r=roc
2015-10-23 11:22:45 +13:00
Carsten "Tomcat" Book
ec720929e1
Backed out changeset 0e8e25c04938 (bug 1216851) for reftest failures
2015-10-29 13:52:29 +01:00
Matt Woodrow
a3cb76b5b7
Bug 1216851 - Allow flattening of opacity when it contains text. r=roc
2015-10-23 11:22:45 +13:00
Jonathan Kew
59607531a2
Bug 1216427 - part 2 - Ensure mouse selection does not split up a Regional Indicator flag symbol. r=emk
2015-10-26 10:47:18 +00:00
Jonathan Kew
2b6ddc91c8
Bug 1216427 - part 1 - Ensure a character+VS sequence or a ligated Regional-Indicator flag symbol is deleted as a single unit when backspacing. r=emk
2015-10-26 10:47:16 +00:00
Robert O'Callahan
0b818e072e
Revert incorrectly committed changes ab657569f554 and a396f4262479
2015-10-24 22:38:22 +13:00
Robert O'Callahan
5919848f93
Bug 264412. Refactor nsIFrame::GetRenderedText API to be more sane. r=mats,marcoz
...
The test changes here are to adjust for the fact that
nsTextFrame::GetRenderedText can now trim whitespace from the end of lines
that end in a hard line break.
2015-10-24 22:27:29 +13:00