corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
900,082 Commits 1 Branch 0 Tags
19f81b780dc2cf9fb872283e4e3003c404df6a1f
Commit Graph

575 Commits

Author SHA1 Message Date
Greg Stoll
52693f9877 Bug 1926973 - make only explicitly unloaded tabs have a grayscale dimmed favicon r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers 
This is what UX has decided makes sense, and will be much less disruptive
than dimming out all favicons on session restore. When we're ready the
default value of "browser.tabs.fadeOutExplicitlyUnloadedTabs" will be
true, and the default value of "browser.tabs.fadeOutUnloadedTabs" will
remain false.

Differential Revision: https://phabricator.services.mozilla.com/D241481
 2025-03-15 00:30:28 +00:00
DJ
fb605dda4c Bug 1950611 - fix save and restore of groups when they trigger window closing. r=sthompson,jswinarton,sessionstore-reviewers,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241490
 2025-03-14 14:18:20 +00:00
Dão Gottwald
7e0d08a5e4 Bug 1951308 - Don't show a close button for pinned tabs in the tab manager. r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241461
 2025-03-13 19:51:59 +00:00
Rolf Rando
5c04f67d7d Bug 1951525 - Implement best-effort global progress bar for all Smart Tab Grouping model files r=tabbrowser-reviewers,vazish,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D241135
 2025-03-13 18:04:32 +00:00
Vasish Baungally
ed268fb313 Bug 1952940 - Prevent Smart Tab Grouping suggestions from including New Tab page. r=rrando,dwalker,tabbrowser-reviewers 
Exclude about:home and about:newtab from Smart Tab Grouping suggestions.

Differential Revision: https://phabricator.services.mozilla.com/D240898
 2025-03-13 15:06:10 +00:00
Dão Gottwald
e3e43e49ef Bug 1953214 - When dragging multiple tabs, update multiselection to reflect that pinned and unpinned tabs cannot be mixed. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241203
 2025-03-13 01:45:39 +00:00
Rolf Rando
4d8a5b817c Bug 1952417 - Don't output Smart Tab Group topic for invalid topics r=vazish,tabbrowser-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D240922
 2025-03-12 20:15:58 +00:00
Jeremy Swinarton
c828d955e5 Bug 1938397: Record active tab group metrics r=dao,tabbrowser-reviewers,sthompson 
Differential Revision: https://phabricator.services.mozilla.com/D240196
 2025-03-12 17:46:15 +00:00
Vasish Baungally
b8ae67ceda Bug 1952381 - Add ability to test different model revisions in Inference Engine r=tarek,firefox-ai-ml-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D240953
 2025-03-12 16:05:14 +00:00
Dão Gottwald
9417710fa1 Bug 1953193 - Don't change the selected tab when collapsing a group while dragging it. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241057
 2025-03-12 13:14:29 +00:00
Dão Gottwald
de2f1dd066 Bug 1952495 - Only collapse the dragged group instead of all groups. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241006
 2025-03-12 13:14:28 +00:00
Dão Gottwald
9754a011cf Bug 1908441 - Implement drag and drop of tab group into a new or other window. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241004
 2025-03-12 11:29:36 +00:00
Alexandru Marc
e03b90be4c Backed out 4 changesets (bug 1953193, bug 1952495, bug 1953249, bug 1908441) for causing bc failures @ browser_bug495058.js CLOSED TREE 
Backed out changeset 0ccf1105aa8c (bug 1953249)
Backed out changeset 2ccc75be9d26 (bug 1953193)
Backed out changeset 02b70f25b783 (bug 1952495)
Backed out changeset 46e2f887cea6 (bug 1908441)
 2025-03-12 12:01:31 +02:00
Dão Gottwald
125ea7264f Bug 1953193 - Don't change the selected tab when collapsing a group while dragging it. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241057
 2025-03-12 08:19:41 +00:00
Dão Gottwald
ddbe423312 Bug 1952495 - Only collapse the dragged group instead of all groups. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241006
 2025-03-12 08:19:41 +00:00
Dão Gottwald
e53c0fb5e2 Bug 1908441 - Implement drag and drop of tab group into a new or other window. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241004
 2025-03-12 08:19:40 +00:00
Goloman Adrian
168ed8ab47 Backed out 4 changesets (bug 1953193, bug 1908441, bug 1952495, bug 1953249) for causing bc failures @browser_tab_manager_drag.js. CLOSED TREE 
Backed out changeset f8634c4fc742 (bug 1953249)
Backed out changeset 066cede5adcc (bug 1953193)
Backed out changeset 7afc87de4a01 (bug 1952495)
Backed out changeset 2ef344554c4c (bug 1908441)
 2025-03-12 02:44:08 +02:00
Dão Gottwald
db96c7b158 Bug 1953193 - Don't change the selected tab when collapsing a group while dragging it. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241057
 2025-03-11 21:39:06 +00:00
Dão Gottwald
8b9f7d749b Bug 1952495 - Only collapse the dragged group instead of all groups. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241006
 2025-03-11 21:39:05 +00:00
Dão Gottwald
1642f3dfa4 Bug 1908441 - Implement drag and drop of tab group into a new or other window. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241004
 2025-03-11 21:39:05 +00:00
DJ
b4c31cf534 Bug 1950973 - batch process beforeUnload handlers when removing a tab group. r=dao,tabbrowser-reviewers,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D240273
 2025-03-11 18:55:05 +00:00
Dão Gottwald
148b80000f Bug 1952962 - Be less aggressive about scrolling the selected tab into view after dragging and dropping tabs. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D240997
 2025-03-11 14:55:48 +00:00
Greg Stoll
c89735b508 Bug 1946432 - when unloading all tabs, don't switch to Firefox View if it's hidden r=tabbrowser-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D239778
 2025-03-11 12:05:41 +00:00
Dão Gottwald
6ff0c3ccca Bug 1952743 - Fix typo. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D240883
 2025-03-10 17:09:22 +00:00
Vasish Baungally
5fcf6f91a5 Bug 1950486 - Add model revision for smart tab grouping telemetry. r=rrando,tabbrowser-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D240061
 2025-03-07 18:44:29 +00:00
Goloman Adrian
7f877be10f Backed out changeset edc7847f9776 (bug 1950973) for causing bc failures @browser_prompt_close_groups.js . 2025-03-07 05:08:36 +02:00
Dão Gottwald
f2fda56c21 Bug 1908439 - Drag and drop for moving a group within the window. r=dwalker,tabbrowser-reviewers,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D239494
 2025-03-07 01:58:05 +00:00
Goloman Adrian
e5e07cd91e Backed out changeset 58ef1accf6e7 (bug 1908439) for causing mochitest failures @test_tabbrowser.xhtml. CLOSED TREE 2025-03-07 02:42:12 +02:00
Dão Gottwald
0fb65f4185 Bug 1908439 - Drag and drop for moving a group within the window. r=dwalker,tabbrowser-reviewers,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D239494
 2025-03-06 22:20:21 +00:00
DJ
3526f7e308 Bug 1950973 - batch process beforeUnload handlers when removing a tab group. r=dao,tabbrowser-reviewers,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D240273
 2025-03-06 20:59:11 +00:00
Goloman Adrian
59941c102c Backed out changeset 29aba9d75f6c (bug 1950486) for causing lint failure @SmartTabGrouping.sys.mjs. CLOSED TREE 2025-03-06 23:48:34 +02:00
Vasish Baungally
c0e8f73d16 Bug 1950486 - Add model revision for smart tab grouping telemetry. r=rrando,tabbrowser-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D240061
 2025-03-06 20:10:26 +00:00
Vasish Baungally
145851f187 Bug 1952040 - Update Smart Tab Suggest to only use title for similarity comparison. r=rrando,dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D240525
 2025-03-06 18:19:41 +00:00
Nick Grato
207d8697bf Bug 1949808 - Prevent smart tab topic output from replacing group label if user starts typing r=vazish,tabbrowser-reviewers,dao 
adding additional check before populating input

Differential Revision: https://phabricator.services.mozilla.com/D240223
 2025-03-06 15:38:51 +00:00
Tarek Ziadé
a00fc0b723 Bug 1891685 - Add telemetry in the ml component r=Mardak,credential-management-reviewers,urlbar-reviewers,dimi,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D238583
 2025-03-06 15:05:04 +00:00
Butkovits Atila
76f1949306 Backed out changeset cd8f12bed08a (bug 1950973) for causing failures at test_restore_manually_with_tab_groups.py. CLOSED TREE 2025-03-06 18:05:15 +02:00
Dão Gottwald
8bce10cd45 Bug 1951939 - Save and close tab group when middle clicking the group label. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D240479
 2025-03-06 13:18:26 +00:00
Butkovits Atila
b6264adeb4 Backed out changeset 79e3d8d9befa (bug 1949808) for causing failures at browser_tab_grouping_telemetry.js. CLOSED TREE 2025-03-06 13:53:35 +02:00
DJ
fb9b1427f2 Bug 1950973 - batch process beforeUnload handlers when removing a tab group. r=dao,tabbrowser-reviewers,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D240273
 2025-03-06 11:25:20 +00:00
Nick Grato
be9d852d84 Bug 1949808 - Prevent smart tab topic output from replacing group label if user starts typing r=vazish,tabbrowser-reviewers,dao 
adding additional check before populating input

Differential Revision: https://phabricator.services.mozilla.com/D240223
 2025-03-06 10:30:44 +00:00
Eitan Isaacson
cf6484047a Bug 1898096 - Replace color settings with "contrast control". r=emilio,fluent-reviewers,settings-reviewers,accessibility-frontend-reviewers,morgan,bolsson,masayuki,mossop,pdfjs-reviewers,calixte 
This patch changes the backing prefs by relying on the tristate offered
by browser.display.document_color_use instead of
browser.display.use_system_colors. This simplifies the color
decision tree, and offers a simplified UI.

The tristate preference offered to the user is as follows:
 1. "Use platform's contrast settings" (document_color_use=0)
 2. "Off" - never use HCM, regardless of platform setting (document_color_use=1)
 3. "On" - always use HCM, regardless of platform setting (document_color_use=2)

Option 3 also reveals a colors UI for the user to choose the palette the
browser HCM will use (bg/text/link/visited).

There are three color palettes to choose from in light of the preference
above they are:
 1. WIDGET_COLORS: The OS's configured colors used by its theme.
 2. HARDCODED_COLORS: Colors deemed as standard and are hard coded into
    Firefox (eg. white on black text, blue and purple links).
 3. PREFERENCE_COLORS: Colors that are stored in preferences and are
    configurable from the colors UI (eg. browser.visited_color and
    browser.display.background_color)

The decision over which palette to use is as follows:
 * If we are styling browser UI -> WIDGET_COLORS
 * else, if resist fingerprinting is enabled -> HARDCODED_COLORS
 * else, if document_color_use==0 AND OS HCM is on -> WIDGET_COLORS
 * else, if document_color_use==2 -> PREFERENCE_COLORS
 * else -> HARDCODED_COLORS

Differential Revision: https://phabricator.services.mozilla.com/D211115
 2025-03-05 19:18:08 +00:00
Nikki Sharpley
3757c82d4f Bug 1927258 - Add a fade effect when vertical pinned tabs overflow r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,reusable-components-reviewers,dao,tgiles,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D237645
 2025-03-05 14:35:39 +00:00
Cristina Horotan
1d64fae3b4 Backed out changeset 724df9f88bbb (bug 1891685) for causing bc failures at browser_MLSuggest_integration.js. 2025-03-05 14:40:29 +02:00
Tarek Ziadé
62fe21cd46 Bug 1891685 - Add telemetry in the ml component r=Mardak,credential-management-reviewers,urlbar-reviewers,dimi,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D238583
 2025-03-05 09:37:51 +00:00
Alexandru Marc
78ef84ae14 Backed out changeset f4d5303f5472 (bug 1898096) for causing ba failures @ browser_attributed_text.js 2025-03-05 03:27:02 +02:00
Eitan Isaacson
e55fdd6ce8 Bug 1898096 - Replace color settings with "contrast control". r=emilio,fluent-reviewers,settings-reviewers,accessibility-frontend-reviewers,morgan,bolsson,masayuki,mossop,pdfjs-reviewers,calixte 
This patch changes the backing prefs by relying on the tristate offered
by browser.display.document_color_use instead of
browser.display.use_system_colors. This simplifies the color
decision tree, and offers a simplified UI.

The tristate preference offered to the user is as follows:
 1. "Use platform's contrast settings" (document_color_use=0)
 2. "Off" - never use HCM, regardless of platform setting (document_color_use=1)
 3. "On" - always use HCM, regardless of platform setting (document_color_use=2)

Option 3 also reveals a colors UI for the user to choose the palette the
browser HCM will use (bg/text/link/visited).

There are three color palettes to choose from in light of the preference
above they are:
 1. WIDGET_COLORS: The OS's configured colors used by its theme.
 2. HARDCODED_COLORS: Colors deemed as standard and are hard coded into
    Firefox (eg. white on black text, blue and purple links).
 3. PREFERENCE_COLORS: Colors that are stored in preferences and are
    configurable from the colors UI (eg. browser.visited_color and
    browser.display.background_color)

The decision over which palette to use is as follows:
 * If we are styling browser UI -> WIDGET_COLORS
 * else, if resist fingerprinting is enabled -> HARDCODED_COLORS
 * else, if document_color_use==0 AND OS HCM is on -> WIDGET_COLORS
 * else, if document_color_use==2 -> PREFERENCE_COLORS
 * else -> HARDCODED_COLORS

Differential Revision: https://phabricator.services.mozilla.com/D211115
 2025-03-05 00:27:44 +00:00
Vasish Baungally
3ee8990937 Bug 1951552 - Lower Suggest Similar Tabs Threshold for recall. r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D240262
 2025-03-04 21:11:22 +00:00
Jeremy Swinarton
8d67992ca5 Bug 1938423: Add glean metric for tab group create r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D239921
 2025-03-04 20:05:19 +00:00
Nick Grato
43e8b7b8e6 Bug 1949590 - STG pref need to be watched to update UI not just on init r=vazish,tabbrowser-reviewers 
adding a watcher to the lazy pref getter

Differential Revision: https://phabricator.services.mozilla.com/D239187
 2025-03-04 17:49:34 +00:00
Dão Gottwald
7552ffe539 Bug 1951488 - Fix drag and drop of vertical pinned tabs with minimal movement. r=nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D240349
 2025-03-04 17:01:03 +00:00