ext-urlbar.js is unused but will be removed in a separate
patch to avoid test failures in condprof tests. Condprof tests may use
an outdated profile directory that still references ext-urlbar.js in
startupcache files, which triggers a test-only test failure in
mozilla::net::CheckForBrokenChromeURL.
Differential Revision: https://phabricator.services.mozilla.com/D199769
Since, in the bug 1875654, we have updated the `browser-toolbarKeyNav.js` to ensure the keyboard navigation handler accounts for intentionally non-focusable controls when calculating focus behavior of toolbar buttons.
We are updating the URL Bar `Go` button markup to ensure it won't be included in the keyboard focus order (since a keyboard-only user could press `Enter` to achieve the same submission of their search query), as well as associated mochitests since we do not need to separately set an environment to skip the focus check. This is because we also fine-tune the AccessibilityUtils' `isKeyboardFocusableBrowserToolbarButton()` check to ensure more through confirmation of the image button in question.
Differential Revision: https://phabricator.services.mozilla.com/D199394
In the end I wasn't able to remove underscores on a lot of these since the base
`UrlbarProvider` class defines getters and methods with the same names, but at
least `results` is no longer "private".
Depends on D199176
Differential Revision: https://phabricator.services.mozilla.com/D199594
This fixes the two `#addExposure()` calls in `UrlbarView.#updateResults()` so
that hidden exposures are properly counted. Right now we overcount them because
we record them in cases where the result would not have been shown anyway.
The new test tries to cover all possible `UrlbarView.#updateResults()` paths:
* When the view is full and a new result can't replace any of the old rows, the
new result is appended and hidden. If the query is then canceled, the new row
will never be shown
* When the vew isn't full, a new row can be appended and visible immediately
* When a new row replaces an old row, it can be visible immediately
Differential Revision: https://phabricator.services.mozilla.com/D199176
The `browser/components/urlbar/tests/browser-tips/browser_searchTips_interaction.js` and `browser/components/urlbar/tests/browser/browser_closePanelOnClick.js` tests send a click event on a non-interactive `<toolbarspring>` element to test that the URL Bar panel and a search tip would, in fact, be closed.
For users of keyboards and assistive technology another way like pressing `Esc` key is available to dismiss the dialog, thus we need to add an exception from the a11y_checks for this tests via `setEnv` and remove the `fail-if` notations from their test manifests.
Differential Revision: https://phabricator.services.mozilla.com/D198411
The current process creates the OpenSearchEngine and gets it to load its data. Once the data is loaded,
it notifies the SearchService that is ready to be added.
This changes the structure so that the SearchService loads the data, creates the engine and then adds it
straight away.
This also means that the contextual search provider can be simplified and doesn't need to tell the engine
not to add itself to the SearchService.
Differential Revision: https://phabricator.services.mozilla.com/D198814
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.
Differential Revision: https://phabricator.services.mozilla.com/D198826
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.
Differential Revision: https://phabricator.services.mozilla.com/D198825
This patch modifies PlacesUtils to cache the keywords and adds functionality to
find a keyword. The Tokenizer calls PlacesUtils to know if the first word
is a keyword and if the first word is a keyword, then the rest of the search
string will be treated as text and Tokenizer won't filter any other restrict
symbols.
Differential Revision: https://phabricator.services.mozilla.com/D198208
The heuristic fallback provider is not trimming. Regardless of that being
expected or not, the test is not right for the status quo.
Differential Revision: https://phabricator.services.mozilla.com/D198706
This improves the architecture by separating out the loading and therefore not having
the object try to load itself.
There are no functional changes nor removals here, the code is only being restructured.
Differential Revision: https://phabricator.services.mozilla.com/D198378
We intentionally turn off a11y_checks for the click updated, because it is send to send a focus on the URL Bar with the mouse, while other ways to focus it are accessible for users of assistive technology and keyboards, thus this test can be excluded from the accessibility tests.
Since this test is now expected to pass a11y_checks, we are also remiving the `fail-if` notation from the test manifest.
Differential Revision: https://phabricator.services.mozilla.com/D197433
Notification can be triggered locally via this snippet:
```js
BrowserSearch.removalOfSearchEngineNotificationBox("Google", "Foogle")
```
Depends on D189872
Differential Revision: https://phabricator.services.mozilla.com/D194312
