corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
816,233 Commits 1 Branch 0 Tags
19a6e40b11e0767c9d16d6b148d9afe8d79aecc2
Commit Graph

79 Commits

Author SHA1 Message Date
Niklas Baumgardner
9b5daf0abd Bug 1867644 - Focus last used button for screenshots UI. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D197348
 2024-01-19 22:08:30 +00:00
Stanca Serban
458c9f5419 Backed out changeset 9df2731a0530 (bug 1867644) for causing mochitests failures in browser_contentAltClick.js on OSX. CLOSED TREE 2024-01-20 03:59:49 +02:00
Niklas Baumgardner
dd6b11b910 Bug 1867644 - Focus last used button for screenshots UI. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D197348
 2024-01-19 22:08:30 +00:00
Natalia Csoregi
eb2e3cf8cb Backed out changeset c6a30d94edf2 (bug 1867644) for causing failures on browser_screenshots_drag_test.js. CLOSED TREE 2024-01-19 03:46:03 +02:00
Niklas Baumgardner
729c5b4066 Bug 1867644 - Focus last used button for screenshots UI. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D197348
 2024-01-19 00:07:46 +00:00
Iulian Moraru
e1d66150c9 Backed out changeset 2b70f662a797 (bug 1867644) for causing bc failures on browser_overlay_keyboard_test.js. CLOSED TREE 2024-01-18 22:14:11 +02:00
Niklas Baumgardner
6dd5c4f60b Bug 1867644 - Focus last used button for screenshots UI. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D197348
 2024-01-18 17:47:54 +00:00
Sam Foster
e1e878dc76 Bug 1820015 - Make the screenshots UI keyboard accessible. r=niklas 
* Move the chrome panel buttons into a `box` which is inserted into #navigator-toolbox
* Adjust what open/closed means using hidden instead
* Capture a weak ref to the focused element on open, and attempt to put focus back on exit
* Add some restore-focus tests
* Fix a bug where cancel via overlay "X" button wasn't exiting properly
* Place initial focus in the preview dialog button on the download button

Differential Revision: https://phabricator.services.mozilla.com/D181184
 2023-12-18 19:01:44 +00:00
Niklas Baumgardner
59a1e1e591 Bug 1842037 - Update screenshots telemetry. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D191679
 2023-11-14 15:57:46 +00:00
Norisz Fay
1b95461566 Backed out changeset 9ec09eb75c9f (bug 1842037) for causing bc failures on browser_screenshots_drag_test.js CLOSED TREE 2023-11-14 04:06:58 +02:00
Niklas Baumgardner
80c28a9bea Bug 1842037 - Update screenshots telemetry. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D191679
 2023-11-13 23:57:17 +00:00
Sam Foster
c20c018e69 Bug 1845796 - Rework the flow in ScreenshotsUtils to make exit an explicit outcome rather than a side-effect. r=niklas 
* Add a UIPhases / getUIPhase to figure out where we are in the flow, and get the UI into the right state
* Refactor to get rid of a bunch of implicit side-effects:
  - Separate out getting the panel from creating it
  - closePanel only closes the buttons panel
  - Add a closeOverlay so we do that and only that when needed
* When the preview dialog closes, we expect to exit unless exitOnPreviewClose was set false
* Keep some state for each browser using a weakmap so we can better handle re-entry (and later, re-focusing)

Differential Revision: https://phabricator.services.mozilla.com/D185379
 2023-09-19 00:14:27 +00:00
Niklas Baumgardner
655e4f5c79 Bug 1832667 - Add ConfirmationHint when screenshot is copied. r=sfoster,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D178674
 2023-05-25 14:27:24 +00:00
Mark Banner
b61a6a6502 Bug 1826063 - Automatic fixes for enabling Prettier on production xhtml and html files. r=mossop,webdriver-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,fxview-reviewers,sgalich,nalexander,devtools-reviewers,sclements,denschub,robwu,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177938
 2023-05-20 12:26:56 +00:00
Sam Foster
c3066d257e Bug 1832171 - Link the packaged platform-specific common stylesheets in Screenshots. r=niklas,desktop-theme-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D177569
 2023-05-10 15:55:46 +00:00
Niklas Baumgardner
9bb496859e Bug 1805984 - Update save visible and save full page screenshot buttons. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D176081
 2023-05-03 17:53:15 +00:00
Niklas Baumgardner
f0190facaa Bug 1824430 - Update screenshots buttons styling. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D173708
 2023-03-30 15:30:21 +00:00
Niklas Baumgardner
b418549f7e Bug 1812631 - Use shared icons for screenshots buttons. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D172043
 2023-03-30 15:30:21 +00:00
Iulian Moraru
7237840464 Backed out 2 changesets (bug 1824430, bug 1812631) for causing multiple mochitest failures. CLOSED TREE 
Backed out changeset 500e6e1d7092 (bug 1824430)
Backed out changeset 6d0d5de3be6e (bug 1812631)
 2023-03-30 04:44:53 +03:00
Niklas Baumgardner
5ea1b4a087 Bug 1824430 - Update screenshots buttons styling. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D173708
 2023-03-30 00:36:32 +00:00
Niklas Baumgardner
28fe1e62b1 Bug 1812631 - Use shared icons for screenshots buttons. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D172043
 2023-03-30 00:36:31 +00:00
Niklas Baumgardner
8d87e40736 Bug 1801019 - Add telemetry for screenshots component. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D164948
 2023-02-25 17:26:34 +00:00
Marian-Vasile Laza
ac8ed92c6a Backed out changeset d853ddfd853e (bug 1801019) for bc failures on browser_screenshots_telemetry_tests.js. CLOSED TREE 2023-02-23 21:11:16 +02:00
Niklas Baumgardner
4a2f7b7309 Bug 1801019 - Add telemetry for screenshots component. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D164948
 2023-02-23 17:37:01 +00:00
Butkovits Atila
0cf8d92417 Backed out changeset aaf82d1483ad (bug 1801019) for causing failures at browser_screenshots_telemetry_tests.js. CLOSED TREE 2023-02-21 23:04:05 +02:00
Niklas Baumgardner
3b1f991f19 Bug 1801019 - Add telemetry for screenshots component. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D164948
 2023-02-21 19:59:09 +00:00
Niklas Baumgardner
ad90b95338 Bug 1785293 - Downloading screenshot respects 'Always ask you where to save files'. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158678
 2022-12-06 00:06:20 +00:00
Stanca Serban
7d855ec985 Backed out changeset b080b41aecf4 (bug 1785293) for causing bc failures on browser_screenshots_test_escape.js. CLOSED TREE 2022-12-02 16:39:01 +02:00
Niklas Baumgardner
47288cb256 Bug 1785293 - Downloading screenshot respects 'Always ask you where to save files'. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158678
 2022-12-02 13:45:57 +00:00
Marian-Vasile Laza
56aa734c69 Backed out changeset 1fdf3fc76d06 (bug 1785293) for causing bc failures on browser_screenshots_drag_test.js. CLOSED TREE 2022-11-30 22:53:47 +02:00
Niklas Baumgardner
0dab83bc6a Bug 1785293 - Downloading screenshot respects 'Always ask you where to save files'. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158678
 2022-11-30 15:00:33 +00:00
Cieara Meador
a1f865ad77 Bug 1794142 - Screenshots module buttom HCM r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D162044
 2022-11-17 22:50:18 +00:00
Cristian Tuns
640cc43739 Backed out changeset 57d19e70e34c (bug 1794142) for causing mochitest failures in browser_parsable_css.js CLOSED TREE 2022-11-16 16:11:06 -05:00
Cieara Meador
baf02dc8ab Bug 1794142 - Screenshots module buttom HCM r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D162044
 2022-11-16 19:31:49 +00:00
Marian-Vasile Laza
6b363505f3 Backed out changeset 7c0eb6e89712 (bug 1785293) for causing bc failures on browser_screenshots_test_downloads.js. CLOSED TREE 2022-11-11 02:36:29 +02:00
Niklas Baumgardner
a9c238827d Bug 1785293 - Downloading screenshot respects 'Always ask you where to save files'. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158678
 2022-11-10 22:21:11 +00:00
Mark Banner
19c189e131 Bug 1798212 - Convert consumers of downloads code to ES modules. r=mak,geckoview-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich,mconley,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D161013
 2022-11-07 17:56:10 +00:00
Mark Banner
a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D158094
 2022-09-29 06:52:34 +00:00
Tooru Fujisawa
328d63ce7f Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D151214
 2022-07-12 04:21:34 +00:00
Andreea Pavel
f009ba2983 Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE 
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
 2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D151214
 2022-07-11 15:09:13 +00:00
Tooru Fujisawa
48c568867c Bug 1667455 - Part 5: Stop importing Services.jsm from chrome-priv JS code, top-level single-line cases. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,pip-reviewers,twisniewski,m_kato,jdescottes,mconley,AlexandruIonescu,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D150894
 2022-07-11 12:41:50 +00:00
Niklas Baumgardner
807796c1a3 Bug 1741740 - Add draggable selection ui for screenshots component. r=sfoster,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D138494
 2022-05-06 15:45:52 +00:00
Niklas Baumgardner
18b1b35da5 Bug 1751060 - Add fallback color and removed st2 class for screenshots SVGs. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D136417
 2022-01-20 19:52:38 +00:00
Alexandru Michis
f0b8e5859b Backed out changeset 338f8b736b41 (bug 1747429) as requested by sfoster. 2022-01-20 20:58:34 +02:00
Sam Foster
fbe65bb476 Bug 1747429 - Replace preprocessor urlbar* variables with CSS vars. r=dao 
* Define urlbarMarginInline and urlbarSearchButtonWidth as CSS rather than preprocessor variables
* Replace the urlbarViewPadding, urlbarViewFaviconWidth and urlbarViewIconMarginEnd preprocessor variables with CSS vars.
* Remove %ifdefs around the license comment in these 2 files
* Update ambiguous/out-of-date comment in the skeleton UI code

Differential Revision: https://phabricator.services.mozilla.com/D135962
 2022-01-20 00:48:42 +00:00
Niklas Baumgardner
2746a8255d Bug 1745045 - Clicking child of screenshots preview button behaves correctly. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D133276
 2021-12-15 19:54:16 +00:00
Niklas Baumgardner
a8acab196d Bug 1740029 - Add retry button for screenshots ui. r=sfoster,fluent-reviewers,Gijs,jaws 
Differential Revision: https://phabricator.services.mozilla.com/D131381
 2021-12-07 16:57:53 +00:00
Niklas Baumgardner
f6c3135c0e Bug 1741987 - screenshots.html titles to Fluent. r=Gijs,fluent-reviewers,kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D131637
 2021-11-22 14:47:14 +00:00
Sam Foster
1c5fd14c17 Bug 1736429 - Set up jswindowactors for screenshots and pass dimensions and scroll offsets from the child. r=mconley,sfoster 
* Add jswindowactors for the Screenshots component, to facilitate communication between the UI (lives in the parent) and the content document.
* Fetch content document dimensions/offsets with e.g: `ScreenshotsUtils.fetchContentBounds(gBrowser.selectedBrowser)`.

Differential Revision: https://phabricator.services.mozilla.com/D129326
 2021-11-19 15:25:19 +00:00