This removes "best match" as its own separate Firefox Suggest feature. In the
future, whether or not a suggestion is a best match (a.k.a. top pick) will be
determined by relevant product requirements. I've confirmed this with Nive.
Here's a summary of changes:
* Removes prefs and Nimbus variables related to best match
* Removes the "Top pick" checkbox in about:preferences
* Removes support for the `best_match` quick suggest config property. This
property was removed from the config in remote settings a while ago.
* Removes legacy telemetry scalars related to best match. These scalars were
added years ago for the original best match experiment and before we started
using Glean. In the case of non-sponsored suggestions, the scalars have not
been recorded at all for some time. In the case of sponsored suggestions, they
can now be recorded again due to the recent addition of sponsored priority
suggestions, but they are superseded by Glean.
Differential Revision: https://phabricator.services.mozilla.com/D190516
This patch adds a RFP warning banner shown when there is a RFP pref
enabled. Firefox has two prefs for RFP, one for normal windows and
another for private windows.
The warning banner contains a learn more linke for users to learn more
about the warning.
Differential Revision: https://phabricator.services.mozilla.com/D187451
This patch adds an event telemetry for fingerprinting protection
checkbox and fingerprinting protection prefs into the telemetry environment prefs.
Differential Revision: https://phabricator.services.mozilla.com/D186024
This patch implements a checkbox in ETP Custom usbpanel. It's for the
configuration of the fingerprinting protection. Similar to the tracking
protection checkbox, it has a dropdown list to select which window to
enable the protection, private windows or all windows.
In addition, we update the existing copy for fingerprinters to reflect
the newly added fingerprinting protectoin checkbox.
Differential Revision: https://phabricator.services.mozilla.com/D186023
Do not isolate `https-only-load-insecure` by origin attributes. This way the HTTPS-Only exceptions will behave similar to the `cookie` permission. This means that exceptions set in the system settings will also apply to private windows, but exceptions set in private windows via the identity pane will be reset after closing the browser.
Depends on D182761
Differential Revision: https://phabricator.services.mozilla.com/D183745
- Update the HTTPS-Only dropdown in the site identity pane to always set exceptions for the http version of the current origin.
- Add new parameter `forcedHTTP` to `gPermissionManager`, in order to only allow origins with a http scheme to be added in the HTTPS-Only section of the settings. This means when a https URL is added as an exeption, it will automatically be converted into a http one.
- Add a migration to convert all existing HTTPS-Only exceptions with a https scheme to a http scheme.
- Update `browser_https_only_exceptions.js` and `browser_identityPopup_HttpsOnlyMode.js` to account for this new behaviour.
Differential Revision: https://phabricator.services.mozilla.com/D182761
This should be seen as a temporary change since the UI probably needs a slightly bigger update if it should manage both HTTPS-Only and HTTPS-First.
Depends on D179424
Differential Revision: https://phabricator.services.mozilla.com/D179425
We surface the email tracking protection using the existing tracking
protection UI on the protection panel, but we don't disable email
tracking protection if tracking protection is disabled. So, users will
still see blocked trackers if tracking protection is disabled for
private windows. To provide a way to disable email tracking protection
in private windows, we also use the existing tracking protection checkbox
UI to disable the email tracking protection.
This patch implements that disabling the tracking protection via the
tracking protection checkbox also disables email tracking protection.
Differential Revision: https://phabricator.services.mozilla.com/D177520
This adapts previous test cases from the connection UI to the privacy UI.
Additional improvements:
- Set the ROLLOUT_URI_Pref to empty string to avoid DoHConfig reset setting it to undefined.
- Always set network.trr.uri even if it matches the default_provider_uri if it's a user choice.
- If the value of network.trr.uri doesn't match any of the providers, then set custom_uri so
it shows up in the input text field. This can happen when it's set by a policy.
Differential Revision: https://phabricator.services.mozilla.com/D174876