Commit Graph

384 Commits

Author SHA1 Message Date
Mike Conley
c5da337999 Bug 1877202 - Move ModalOverlay back over to browser/components/newtab. r=thecount
This originally got moved as part of bug 1868838 because it was under
browser/components/newtab/content-src/asrouter/components - however,
pdahiya points out that this component was actually only ever used
by newtab, so it makes more sense living over there.

Differential Revision: https://phabricator.services.mozilla.com/D200391
2024-02-01 23:35:23 +00:00
Nathan Barrett
148d5d76c7 Bug 1715607 - Make TopSite hover area clickable r=amy,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200049
2024-01-30 21:53:26 +00:00
scottdowne
4e942e88d8 Bug 1868232 - Fixing newtab customize menu initial transition state. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D197700
2024-01-04 20:51:44 +00:00
Mike Conley
86f73ac4f2 Bug 1866802 - Rename newtab's ASRouterAdmin to DiscoveryStreamAdmin and strip down to just Discovery Stream things. r=thecount,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D194813
2023-12-14 18:46:56 +00:00
Butkovits Atila
e9b8149367 Backed out 5 changesets (bug 1866802) for causing failures at test_TopSitesFeed.js. CLOSED TREE
Backed out changeset af9fbbc9ae50 (bug 1866802)
Backed out changeset 81d5b7de7178 (bug 1866802)
Backed out changeset e4d0863ed222 (bug 1866802)
Backed out changeset c0deb681b193 (bug 1866802)
Backed out changeset dda3e5e39f8c (bug 1866802)
2023-12-14 03:22:48 +02:00
Mike Conley
b57029eeb7 Bug 1866802 - Rename newtab's ASRouterAdmin to DiscoveryStreamAdmin and strip down to just Discovery Stream things. r=thecount,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D194813
2023-12-13 23:29:49 +00:00
Mike Conley
a3b3f76e18 Bug 1715158 - Remove snippet-related SCSS/CSS. r=thecount
Depends on D193854

Differential Revision: https://phabricator.services.mozilla.com/D193855
2023-12-06 16:15:15 +00:00
Mike Conley
b6711f55d6 Bug 1715158 - Remove ASRouterUISurface, snippet templates, and associated tests. r=pdahiya
Depends on D193853

Differential Revision: https://phabricator.services.mozilla.com/D193854
2023-12-06 16:15:15 +00:00
Shane Hughes
c0e0c0561e Bug 1830715 - ASRouter devtools for editing and resetting impressions. r=omc-reviewers,emcminn
Adds some new ASRouter methods for resetting impressions of all 3 types,
message impressions, group impressions, and screen impressions, and
exposes them through some new buttons and textboxes in a new Impressions
tab in the ASRouter devtools.

Differential Revision: https://phabricator.services.mozilla.com/D178261
2023-10-25 20:52:29 +00:00
Emilio Cobos Álvarez
db64ee1d37 Bug 1857522 - Update autogenerated files.
MANUAL PUSH: Trivial fix CLOSED TREE
2023-10-09 01:29:41 +02:00
Gijs Kruitbosch
d7ab65e6d6 Bug 1851544 - use clearer media queries in new tab styling, r=Standard8,omc-reviewers,thecount,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D188836
2023-09-27 14:45:18 +00:00
Mike Conley
e94eeb8199 Bug 1812135 - Use moz-toggle in the about:newtab personalization panel. r=thecount,amy,hjones,desktop-theme-reviewers,bolsson
This adds moz-toggle.mjs as a module to load in the main newtab document
(cached or otherwise), and then converts the existing toggles to use
moz-toggle.

This also required me to bring in tokens-brand.css to get the right
colours for the toggle to appear.

There was some markup in the original panel that had the label exist outside
of the toggle, and some CSS grid styling to make it appear alongside it.
Thankfully, moz-toggle takes care of a lot of that for us, so I was able
to get rid of the external label element and the associated styles.

Differential Revision: https://phabricator.services.mozilla.com/D187716
2023-09-25 20:32:10 +00:00
Cosmin Sabou
3c7d6c6c28 Backed out changeset 6a7f708c3d04 (bug 1812135) for causing crashtest failures on 1662259.html. CLOSED TREE 2023-09-26 01:11:46 +03:00
Mike Conley
e11dc8536f Bug 1812135 - Use moz-toggle in the about:newtab personalization panel. r=thecount,amy,hjones,desktop-theme-reviewers,bolsson
This adds moz-toggle.mjs as a module to load in the main newtab document
(cached or otherwise), and then converts the existing toggles to use
moz-toggle.

This also required me to bring in tokens-brand.css to get the right
colours for the toggle to appear.

There was some markup in the original panel that had the label exist outside
of the toggle, and some CSS grid styling to make it appear alongside it.
Thankfully, moz-toggle takes care of a lot of that for us, so I was able
to get rid of the external label element and the associated styles.

Differential Revision: https://phabricator.services.mozilla.com/D187716
2023-09-25 20:32:10 +00:00
Iulian Moraru
3f7f17e08f Backed out changeset c2341f2f6212 (bug 1812135) for causing multiple crashes. CLOSED TREE 2023-09-25 20:53:34 +03:00
Mike Conley
70f8e4fa3d Bug 1812135 - Use moz-toggle in the about:newtab personalization panel. r=thecount,amy,hjones,desktop-theme-reviewers,bolsson
This adds moz-toggle.mjs as a module to load in the main newtab document
(cached or otherwise), and then converts the existing toggles to use
moz-toggle.

This also required me to bring in design-tokens-brand.css to get the right
colours for the toggle to appear.

There was some markup in the original panel that had the label exist outside
of the toggle, and some CSS grid styling to make it appear alongside it.
Thankfully, moz-toggle takes care of a lot of that for us, so I was able
to get rid of the external label element and the associated styles.

Differential Revision: https://phabricator.services.mozilla.com/D187716
2023-09-25 16:11:33 +00:00
Emilio Cobos Álvarez
790bac2054 Bug 1853652 - Use image-set more in newtab. r=aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D188453
2023-09-18 12:32:54 +00:00
scottdowne
f53be495f8 Bug 1832789 - Pocket newtab card context menu buttons don't show if card is focused. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D178350
2023-05-17 17:42:23 +00:00
scottdowne
823afcbb67 Bug 1833125 - Pocket newtab onboarding experience dialog small fixes for high contrast modes. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D178094
2023-05-15 18:36:19 +00:00
scottdowne
4b6221125c Bug 1832178 - Pocket newtab international onboarding experience alignment issue r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D177641
2023-05-10 18:33:07 +00:00
Shane Hughes
da6cbc353b Bug 1619842 - Remove longhand rule from newtab stylelint config. r=CosminS
CLOSED TREE

Differential Revision: https://phabricator.services.mozilla.com/D177522
2023-05-09 16:39:07 +00:00
Shane Hughes
268b8b6c64 Bug 1619842 - Migrate from sass-lint to stylelint. r=omc-reviewers,thecount,emcminn
Fix a bug where VS Code's eslint integration does not work for the
newtab project because of a conflict caused by sass-lint's eslint
dependency. Switching over to stylelint eliminates that dependency and
generally modernizes our SCSS linting. stylelint doesn't have a 1 to 1
replacement for every sass-lint rule, so a few rules have been changed.

Differential Revision: https://phabricator.services.mozilla.com/D173605
2023-05-09 15:37:15 +00:00
Katherine Patenio
f2226c4d20 Bug 1828433 - restore underlines for links in new tab page. r=amy
This patch restores link underlines in the new tab page, particularly the settings page and discovery stream (top sites, pocket tiles, and recent activity). Only links that had underlines on hover were updated. `text-decoration: none` is added for cards to maintain original styling.

Differential Revision: https://phabricator.services.mozilla.com/D176819
2023-05-08 16:28:50 +00:00
scottdowne
4b486920aa Bug 1812690 - Pocket newtab enabling onboarding experience for new users seeing the Pocket section for the first time. r=gvn,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D174710
2023-04-25 16:49:25 +00:00
Amy Churchwell
2f47bbd936 Bug 1811372 - Use prefers-reduced-motion query for the new tab customization panel. r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D173575
2023-03-24 22:22:33 +00:00
Shane Hughes
dc7748825b Bug 1821497 - Add a message Share button to ASRouterAdmin. r=pdahiya,barret
Differential Revision: https://phabricator.services.mozilla.com/D172199
2023-03-20 20:31:29 +00:00
Kelly Cochrane
bf8612ed86 Bug 1781829 - Update contentTheme.js to set attributes and CSS variables on :root instead of body r=dao,extension-reviewers,robwu
Differential Revision: https://phabricator.services.mozilla.com/D167869
2023-02-06 14:25:39 +00:00
Stanca Serban
bf7714945d Backed out changeset a544e102fa0e (bug 1781829) for causing mochitests failures in browser_ext_themes_ntp_colors.js. CLOSED TREE 2023-01-26 20:24:58 +02:00
Kelly Cochrane
16ac01d97a Bug 1781829 - Update contentTheme.js to set attributes and CSS variables on :root instead of body r=dao
Differential Revision: https://phabricator.services.mozilla.com/D167869
2023-01-26 16:14:31 +00:00
scott
2aba9c12cd Bug 1799974 - Pocket newtab fixing loading of page to have less shifting. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D163621
2022-12-02 00:40:05 +00:00
Cristian Tuns
e4f818ecc2 Backed out changeset 732eca22ad6f (bug 1799974) for causing node failures CLOSED TREE 2022-12-01 14:59:56 -05:00
scott
f0ca205e0d Bug 1799974 - Pocket newtab fixing loading of page to have less shifting. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D163621
2022-12-01 19:28:48 +00:00
Kelly Cochrane
a44fcdd204 Bug 1787063 - Checked-in changes in respective activity-stream-[os] CSS files after latest updates r=dao
Differential Revision: https://phabricator.services.mozilla.com/D161204
2022-11-04 15:04:30 +00:00
Kelly Cochrane
e104d4b35c Bug 1787063 - Adjust color-mix for secondary text to better align with design spec r=dao
Differential Revision: https://phabricator.services.mozilla.com/D160687
2022-11-01 17:56:49 +00:00
Stanca Serban
4081bf7eca Backed out changeset c37b2558862b (bug 1787063) for causing new failures on _theme.scss. CLOSED TREE 2022-11-01 16:25:28 +02:00
Kelly Cochrane
c1d28465a5 Bug 1787063 - Adjust color-mix for secondary text to better align with design spec r=dao
Differential Revision: https://phabricator.services.mozilla.com/D160687
2022-11-01 13:26:20 +00:00
Gavin Suntop
f8b59c716a Bug 1790667 - Design tweaks for STP button r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D157505
2022-10-07 17:04:27 +00:00
scott
26d7902675 Bug 1793487 - Pocket newtab fixing placeholder images for recent saves r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D158531
2022-10-05 20:20:02 +00:00
Csoregi Natalia
ca10cb1d71 Backed out changeset 39dd7976006b (bug 1793487) for causing newtab failures. CLOSED TREE 2022-10-05 21:07:56 +03:00
scott
c0bd2e12f8 Bug 1793487 - Pocket newtab fixing placeholder images for recent saves r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D158531
2022-10-05 17:23:23 +00:00
Norisz Fay
ad1ab8d622 Backed out changeset b65e99ab62ad (bug 1790667) for causing node newtab failure CLOSED TREE 2022-10-04 21:34:07 +03:00
Gavin Suntop
d1027148f6 Bug 1790667 - Design tweaks for STP button r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D157505
2022-10-04 18:00:17 +00:00
Gavin Suntop
a456fc19a1 Bug 1787521 - Adjust button for newtab save to pocket action r=thecount,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D155995
2022-09-09 17:13:26 +00:00
scott
9064163ddd Bug 1782318 - Pocket newtab show placeholder thumbnail images for cards without images. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D155126
2022-08-24 15:40:12 +00:00
Gavin Suntop
c0d548aa47 Bug 1780849 - refactoring pref drawer animation r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D152793
2022-08-03 17:18:12 +00:00
Butkovits Atila
8d5010e96e Backed out changeset a12870608bdf (bug 1780849) for causing failures at browser_contentSearchUI_default.js. CLOSED TREE 2022-07-26 23:10:06 +03:00
Gavin Suntop
1d5b1fa522 Bug 1780849 - refactoring pref drawer animation r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D152793
2022-07-26 19:15:24 +00:00
Dão Gottwald
e514aabc62 Bug 1780568 - --newtab-element-hover-color needs more contrast, especially on dark backgrounds. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D152403
2022-07-22 13:36:12 +00:00
scott
0bbeca25d3 Bug 1779643 - Pocket newtab remove old border and hero css and options r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D151872
2022-07-22 04:31:45 +00:00
scott
acb6544ac6 Bug 1778351 - Removing some old Pocket newtab experiment code. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D151666
2022-07-19 17:32:56 +00:00