corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
816,233 Commits 1 Branch 0 Tags
19a6e40b11e0767c9d16d6b148d9afe8d79aecc2
Commit Graph

1401 Commits

Author SHA1 Message Date
Chris H-C
7284cf9ac7 Bug 1854245 - Add pocket recommendation id to pocket newtab events r=thecount,mmiermans 
Depends on D190858

Differential Revision: https://phabricator.services.mozilla.com/D190980
 2023-10-26 07:20:43 +00:00
Chris H-C
4fa2bba2e4 Bug 1857324 - Instrument 'dismiss' actions for newtab topsites r=nanj 
See Also DENG-1363

Depends on D190855

Differential Revision: https://phabricator.services.mozilla.com/D190856
 2023-10-26 07:20:41 +00:00
Chris H-C
ed4d986946 Bug 1857324 - Instrument the 'about our sponsors' link r=nanj 
See also: DENG-1364

Differential Revision: https://phabricator.services.mozilla.com/D190855
 2023-10-26 07:20:41 +00:00
Shane Hughes
c0e0c0561e Bug 1830715 - ASRouter devtools for editing and resetting impressions. r=omc-reviewers,emcminn 
Adds some new ASRouter methods for resetting impressions of all 3 types,
message impressions, group impressions, and screen impressions, and
exposes them through some new buttons and textboxes in a new Impressions
tab in the ASRouter devtools.

Differential Revision: https://phabricator.services.mozilla.com/D178261
 2023-10-25 20:52:29 +00:00
Sylvestre Ledru
3608dc8457 Bug 1860157 - Fix typos found by codespell 2.2.6 r=webdriver-reviewers,zeid,search-reviewers,perftest-reviewers,devtools-reviewers,releng-reviewers,gbrown,sparky,jteow 
Differential Revision: https://phabricator.services.mozilla.com/D191480
 2023-10-19 20:52:10 +00:00
negin
03bfa843f0 Bug 1858259 - [Easy Setup Feature] Fixes easy setup checkbox misalignment and spacing on responsive mode <800px r=omc-reviewers,aminomancer,emcminn 
Removes secondary section image on <800px/responsive mode for 3 checkbox easy setup.
Aligns checkboxes to the left on responsive mode.

Differential Revision: https://phabricator.services.mozilla.com/D191340
 2023-10-19 18:23:04 +00:00
Jason Prickett
f10f683d0e Bug 1857036 - create asrouter targeting for primary monitor resolution r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D190615
 2023-10-12 05:36:26 +00:00
scottdowne
9680ca1364 Bug 1858038 - Pocket newtab decouple Pocket sponsored content system pref from Discovery Stream JSON config. r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D190521
 2023-10-10 14:54:10 +00:00
Emilio Cobos Álvarez
edbe0ff9a0 Bug 1857522 - Don't ignore pseudo-classes in max-nesting-depth limit. r=Gijs 
As that allows you to get around the lint with :is() trivially.

Differential Revision: https://phabricator.services.mozilla.com/D190311
 2023-10-08 23:07:36 +00:00
Emilio Cobos Álvarez
ede2cef8c9 Bug 1857522 - Reduce max nesting depth to 3. r=Gijs 
That still doesn't trigger on the code in comment 2, so that is a bit
confusing and needs investigation.

Differential Revision: https://phabricator.services.mozilla.com/D190310
 2023-10-08 22:33:39 +00:00
scottdowne
a55282b555 Bug 1847786 - Pocket newtab remove old remote layout switching code. r=gvn,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D185688
 2023-10-03 18:53:02 +00:00
Emily McMinn
1d086f0280 Bug 1855041 - Adjust spacing and padding of survey elements r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D189291
 2023-09-27 17:51:07 +00:00
Gijs Kruitbosch
d7ab65e6d6 Bug 1851544 - use clearer media queries in new tab styling, r=Standard8,omc-reviewers,thecount,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D188836
 2023-09-27 14:45:18 +00:00
Jason Prickett
58652516e9 Bug 1847120 - Add message bar survey confirmation screen r=omc-reviewers,shopping-reviewers,aminomancer,kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D188873
 2023-09-26 23:27:15 +00:00
Shane Hughes
bd9f59f367 Bug 1854271 - Add price tag icons to Fakespot feature callouts. r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D188776
 2023-09-26 18:42:02 +00:00
Mike Conley
e94eeb8199 Bug 1812135 - Use moz-toggle in the about:newtab personalization panel. r=thecount,amy,hjones,desktop-theme-reviewers,bolsson 
This adds moz-toggle.mjs as a module to load in the main newtab document
(cached or otherwise), and then converts the existing toggles to use
moz-toggle.

This also required me to bring in tokens-brand.css to get the right
colours for the toggle to appear.

There was some markup in the original panel that had the label exist outside
of the toggle, and some CSS grid styling to make it appear alongside it.
Thankfully, moz-toggle takes care of a lot of that for us, so I was able
to get rid of the external label element and the associated styles.

Differential Revision: https://phabricator.services.mozilla.com/D187716
 2023-09-25 20:32:10 +00:00
Cosmin Sabou
3c7d6c6c28 Backed out changeset 6a7f708c3d04 (bug 1812135) for causing crashtest failures on 1662259.html. CLOSED TREE 2023-09-26 01:11:46 +03:00
Mike Conley
e11dc8536f Bug 1812135 - Use moz-toggle in the about:newtab personalization panel. r=thecount,amy,hjones,desktop-theme-reviewers,bolsson 
This adds moz-toggle.mjs as a module to load in the main newtab document
(cached or otherwise), and then converts the existing toggles to use
moz-toggle.

This also required me to bring in tokens-brand.css to get the right
colours for the toggle to appear.

There was some markup in the original panel that had the label exist outside
of the toggle, and some CSS grid styling to make it appear alongside it.
Thankfully, moz-toggle takes care of a lot of that for us, so I was able
to get rid of the external label element and the associated styles.

Differential Revision: https://phabricator.services.mozilla.com/D187716
 2023-09-25 20:32:10 +00:00
Emily McMinn
5c8bcd0c86 Bug 1854253 - Use chrome font sizes for shopping onboarding and microsurvey r=omc-reviewers,desktop-theme-reviewers,dao,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D188764
 2023-09-25 20:12:24 +00:00
Iulian Moraru
3f7f17e08f Backed out changeset c2341f2f6212 (bug 1812135) for causing multiple crashes. CLOSED TREE 2023-09-25 20:53:34 +03:00
Mike Conley
70f8e4fa3d Bug 1812135 - Use moz-toggle in the about:newtab personalization panel. r=thecount,amy,hjones,desktop-theme-reviewers,bolsson 
This adds moz-toggle.mjs as a module to load in the main newtab document
(cached or otherwise), and then converts the existing toggles to use
moz-toggle.

This also required me to bring in design-tokens-brand.css to get the right
colours for the toggle to appear.

There was some markup in the original panel that had the label exist outside
of the toggle, and some CSS grid styling to make it appear alongside it.
Thankfully, moz-toggle takes care of a lot of that for us, so I was able
to get rid of the external label element and the associated styles.

Differential Revision: https://phabricator.services.mozilla.com/D187716
 2023-09-25 16:11:33 +00:00
negin
991feaf54d Bug 1849362 - [High Contrast] The "Privacy policy" and "Terms of use" links from the Fakespot onboarding sidebar disappear when clicked r=omc-reviewers,aminomancer 
Removes the link overrides and adds the design system token link styles.

Differential Revision: https://phabricator.services.mozilla.com/D189017
 2023-09-22 20:30:28 +00:00
negin
36c71a9fa8 Bug 1854667 - [Sidebar] Update legal and learn more links to be more semantic r=omc-reviewers,emcminn,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D188997
 2023-09-22 19:24:20 +00:00
Jason Prickett
1c84e1c23c Bug 1853227 - Fix missing stepper element aria label for survey r=pdahiya,omc-reviewers,fluent-reviewers,flod,shopping-reviewers,kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D188625
 2023-09-21 17:52:51 +00:00
Jason Prickett
9e67df6459 Bug 1853210 - Add onboarding shopping container close fluent handling and string r=pdahiya,omc-reviewers,fluent-reviewers,flod,shopping-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D188397
 2023-09-19 21:33:41 +00:00
Shane Hughes
a888aea67a Bug 1852825 - Add more style configuration for Feature Callout. r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D188044
 2023-09-19 18:41:30 +00:00
Jason Prickett
a7fc6910c7 Bug 1852524 - Fix survey focus ring cutoff r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D188536
 2023-09-19 17:28:27 +00:00
negin
cc5e3a6468 Bug 1850826 - Refactor LegalParagraph as LinkParagraph & replace usage of cta_paragraph in shopping sidebar onboarding r=omc-reviewers,pdahiya,fluent-reviewers,flod,shopping-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D188376
 2023-09-19 16:02:30 +00:00
negin
7b886623a7 Bug 1849933 - [Sidebar] Update finalized images for inline image r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D188381
 2023-09-18 20:54:28 +00:00
Emilio Cobos Álvarez
790bac2054 Bug 1853652 - Use image-set more in newtab. r=aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D188453
 2023-09-18 12:32:54 +00:00
negin
e3f4786de3 Bug 1851267 - [Survey] Update Shopping Survey Styles to match final designs r=omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D188034
 2023-09-14 14:04:29 +00:00
Shane Hughes
d959e72d8f Bug 1852597 - Fix chrome panel feature callout color scheme. r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D187923
 2023-09-11 21:41:38 +00:00
Emily McMinn
efbdad2cde Bug 1852150 - Remove margin:inline from shopping sidebar buttons r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D187723
 2023-09-11 17:59:39 +00:00
negin
1cb292b852 Bug 1847284 - [Survey] Implement a way to render aboutwelcome's steps indicator above action buttons in the dom r=omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D187290
 2023-09-11 13:09:40 +00:00
negin
c563b4da07 Bug 1850801 - The onboarding Shopping sidebar is not easily discoverable with a screen reader r=omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D187294
 2023-09-07 16:18:32 +00:00
Emily McMinn
0ace8f2484 Bug 1849365 - Apply active styles to about:welcome secondary buttons r=desktop-theme-reviewers,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D187594
 2023-09-07 16:02:59 +00:00
Emily McMinn
3f50325854 Bug 1846763 - CSS pass for shopping onboarding card r=desktop-theme-reviewers,omc-reviewers,negin,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D186050
 2023-09-06 20:15:16 +00:00
hanna alemu
b726f3c745 Bug 1847641 - [Sidebar] Update template to allow showing array of image and paragraph with links r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D186499
 2023-09-06 16:39:33 +00:00
Emily McMinn
dbaeb3e36e Bug 1849958 - Revert AddonsPicker star rating r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D187229
 2023-09-01 00:57:36 +00:00
Emily McMinn
eba164ef2c Bug 1849571 - Match onboarding container height to content in shopping sidebar r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D187064
 2023-08-31 22:02:55 +00:00
Shane Hughes
3ead9a6e2e Bug 1842366 - Part 2: Allow rendering Feature Callout in panels. r=jprickett,desktop-theme-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D183074
 2023-08-31 08:14:41 +00:00
Butkovits Atila
5cbed29ced Backed out 2 changesets (bug 1842366) for causing Xpcshell failures at test_PanelTestProvider.js. CLOSED TREE 
Backed out changeset bcc147043981 (bug 1842366)
Backed out changeset c9e538ad8526 (bug 1842366)
 2023-08-31 07:43:26 +03:00
Shane Hughes
4db2cd3f28 Bug 1842366 - Part 2: Allow rendering Feature Callout in panels. r=jprickett,desktop-theme-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D183074
 2023-08-31 03:29:05 +00:00
Emily McMinn
fc2d2dea11 Bug 1849228 - Land final onboarding message strings r=omc-reviewers,fluent-reviewers,flod,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D186579
 2023-08-29 04:50:43 +00:00
Ed Lee
5e9778dfa3 Bug 1849882 - Add more useEffect dependencies to language switcher r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D186839
 2023-08-28 18:58:38 +00:00
negin
6a018aedec Bug 1846282 - [Sidebar] Create inline-image component r=omc-reviewers,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D186138
 2023-08-25 01:41:29 +00:00
Emily McMinn
ce18a59edf Bug 1845334 - Add star rating component and widget to AddonsPicker r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D184724
 2023-08-17 21:11:56 +00:00
Dan Mosedale
73932f2489 Bug 1847977 - doc basic state of current PingCentre/Glean telemetry, r=chutten 
Differential Revision: https://phabricator.services.mozilla.com/D186181
 2023-08-16 22:04:27 +00:00
Shane Hughes
4d0f7b7e73 Bug 1843461 - Set up Shopping Sidebar messaging JSActor. r=jhirsch,Gijs,omc-reviewers,Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D184956
 2023-08-12 05:06:56 +00:00
negin
39d8f344c2 Bug 1846284 - [Sidebar] Create text component with links r=omc-reviewers,fluent-reviewers,flod,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D185220
 2023-08-10 20:12:48 +00:00