corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
786,775 Commits 1 Branch 0 Tags
195bd58b5b901b1aa719a48f0559353031887109
Commit Graph

1664 Commits

Author SHA1 Message Date
Stephanie Cunnane
66b9ea3569 Bug 1816738 - Add opened_in_new_tab tracking to SERP impression event. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D177531
 2023-05-23 22:04:08 +00:00
Natalia Csoregi
1b67d0b941 Backed out 3 changesets (bug 1834222, bug 1834176) for causing RemoteProcessMonitor failures. CLOSED TREE 
Backed out changeset 346d3a1568dd (bug 1834222)
Backed out changeset ea1d8b634bfc (bug 1834176)
Backed out changeset 74d1880272d3 (bug 1834176)
 2023-05-24 04:29:45 +03:00
Mark Banner
d1fc869252 Bug 1834176 - Convert NetUtil.jsm to be an ES system module. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D178589
 2023-05-23 19:09:29 +00:00
James Teow
5246272dc4 Bug 1833245 - Enable cached page loads to be monitored in SearchSERPTelemetry - r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D178502
 2023-05-23 15:06:16 +00:00
Noemi Erli
1f146f097e Backed out 2 changesets (bug 1834176) for causing xpc failures in test_unload.js CLOSED TREE 
Backed out changeset 57876d77a652 (bug 1834176)
Backed out changeset ae2f0837b528 (bug 1834176)
 2023-05-23 12:14:37 +03:00
Mark Banner
08ff6c0ad9 Bug 1834176 - Convert NetUtil.jsm to be an ES system module. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D178589
 2023-05-23 08:13:08 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177025
 2023-05-20 12:26:49 +00:00
Mark Banner
17f6abf4e4 Bug 1834066 - Update Search Engine URL for Gule sider. r=search-reviewers,daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D178561
 2023-05-20 09:12:34 +00:00
Mark Banner
bf8f5a87d5 Bug 1834086 - Separate out the search feature in Nimbus into early startup and non-early startup sections. r=jteow 
This separates out the two sets of variables to move the ones in early startup into searchConfiguration.
This will avoid reloading the search engines on startup for most experiments, and ensure that
the experiment is handled correctly for configurations.

The default private handling is retained within the early startup section, as that has an effect on default
search engines which may be affected if engines are loaded without those flags in place.

Differential Revision: https://phabricator.services.mozilla.com/D178552
 2023-05-19 19:49:21 +00:00
James Teow
3eefbb7763 Bug 1833877 - Don't check page for components related to the impression if components don't exist - r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D178445
 2023-05-19 02:09:57 +00:00
Katherine Patenio
2e593c5af4 Bug 1830419 - Convert PanelMutiView.jsm and CustomizableUITestUtils.jsm in browser/components/customizableui to ESMs r=search-reviewers,Standard8,devtools-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D178362
 2023-05-18 18:34:51 +00:00
Iulian Moraru
9a36d620f9 Backed out changeset bbb3bbd9b6af (bug 1830679) for causing dt failures on browser_storage_cache_delete.js. CLOSED TREE 2023-05-18 22:09:25 +03:00
Itiel
801dad3de3 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D176791
 2023-05-18 17:19:45 +00:00
James Teow
887027ee03 Bug 1823683 - Update telemetry schemas - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D176178
 2023-05-17 14:36:02 +00:00
James Teow
e4efda560d Bug 1832811 - Remove unused features - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D177909
 2023-05-16 11:33:33 +00:00
Dale Harvey
a8d49a9e03 Bug 1826447 - Initial support for Rich Suggestions. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D174693
 2023-05-11 21:27:36 +00:00
Mark Banner
43c4ea36d3 Bug 1831332 - Fix test_urlTelemetry.js to not use a code for the organic:other test that is likely to be an organic:none in the future. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D177782
 2023-05-11 14:30:32 +00:00
James Teow
3f00e836a9 Bug 1831880 - Optionally use shopping tab regular expression in SearchSERPTelemetryChild - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D177451
 2023-05-10 16:11:43 +00:00
Mark Banner
0fadbc1ec4 Bug 1829618 - Enable Prettier on json files (automatic fixes). r=perftest-reviewers,webcompat-reviewers,extension-reviewers,andi,desktop-theme-reviewers,pip-reviewers,devtools-reviewers,sync-reviewers,mossop,denschub,dao,sparky,robwu,geckoview-reviewers,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D176336
 2023-05-09 16:14:51 +00:00
James Teow
f8aff411e8 Bug 1831876 - Don't attempt to record an impression / ad impression on pages that don't include a search parameter - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D177385
 2023-05-09 15:46:57 +00:00
Stephanie Cunnane
bc69c60880 Bug 1827459 - Add a Nimbus variable for browser.search.serpEventTelemetry.enabled. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D176364
 2023-05-05 14:25:12 +00:00
Stephanie Cunnane
b45b6ce291 Bug 1831395 - Make the assertAbandonmentEvent helper function synchronous rather than async. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D177192
 2023-05-05 14:00:24 +00:00
James Teow
5eda9ce4a1 Bug 1830452 - Properly check the existence of child elements from the context of the parent - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D176746
 2023-05-02 20:37:11 +00:00
James Teow
4c02a7b6f4 Bug 1829489 - Encode URLs before sending them back to the parent - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D176385
 2023-04-28 04:05:13 +00:00
James Teow
a42ff7a75c Bug 1830302 - Move default definition on the same level as the component type - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D176661
 2023-04-27 16:19:24 +00:00
James Teow
a0abe43c7f Bug 1830209 - Refactor observeActivity - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D176610
 2023-04-27 16:18:20 +00:00
James Teow
c02d22eb96 Bug 1829877 - Remove browser from browserContentSourceMap after source has been used - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D176420
 2023-04-26 13:48:22 +00:00
James Teow
ad8b73ca53 Bug 1829672 - Ensure network event is from a top level load - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D176390
 2023-04-25 11:16:59 +00:00
James Teow
c773145f2a Bug 1829578 - Allow hrefs of SERPs to be classified as non_ads_link - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D176243
 2023-04-24 14:54:29 +00:00
James Teow
35b8e78022 Bug 1816736 - Add in-content search tracking to SERP impression event - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D176242
 2023-04-24 14:54:28 +00:00
James Teow
bead9387a2 Bug 1828786 - Allow component categorization and ad_impression to occur on pages without ads - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D176159
 2023-04-24 14:54:28 +00:00
James Teow
2ef6f43e88 Bug 1824543 - Add shopping_tab_displayed and is_shopping_page to Impression Event - r=Standard8 
Since we rely on the child process to parse this information, we need to
wait until the child has reported the presence of the shopping page
before sending the Impression event.

Differential Revision: https://phabricator.services.mozilla.com/D175576
 2023-04-21 21:19:39 +00:00
James Teow
ad969973e6 Bug 1816735 - Add expanded and submitted states - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D175546
 2023-04-21 20:22:21 +00:00
James Teow
1e0f3a44da Bug 1816730 - Step 2: Allow targets in content process to register click events - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D175311
 2023-04-21 16:54:22 +00:00
James Teow
83116d3c19 Bug 1816730 - Step 1: Add target property for click events that can be detected in network processes - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D175160
 2023-04-21 16:54:21 +00:00
Marco Bonardo
5803aa315a Bug 1829192 - use PlacesTestUtils.getDatabaseValue more extensively. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D176075
 2023-04-21 08:42:26 +00:00
Mark Banner
e9e02f60d4 Bug 1827624 - Restrict search SERP telemetry actors to https only pages. r=jteow 
We only monitor telemetry from sites that are already https-only.

Depends on D175422

Differential Revision: https://phabricator.services.mozilla.com/D175423
 2023-04-14 18:04:50 +00:00
Stephanie Cunnane
023227d6ea Bug 1814776 - Implement the SERP abandonment event. r=Standard8,jteow 
Differential Revision: https://phabricator.services.mozilla.com/D171884
 2023-04-12 19:25:31 +00:00
James Teow
62e01a6622 Bug 1816729 - Implement the impression event for refinement buttons and shopping tabs - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D173691
 2023-04-03 14:01:26 +00:00
James Teow
198deba4a6 Bug 1816729 - Implement the impression event for ad_sitelink, ad_sidebar - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D172753
 2023-04-03 14:01:26 +00:00
Barret Rennie
f7a4fadf48 Bug 1788954 - Convert toolkit/components/nimbus to ES modules r=Standard8,pip-reviewers,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D172850
 2023-03-30 20:51:58 +00:00
CanadaHonk
de0de3489c Bug 1801379 - Migrate Sinon.jsm to an ES module r=extension-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,fxview-reviewers,devtools-reviewers,Standard8,nchevobbe,sclements,dimi,mconley,bytesized,robwu 
Migrated `testing/modules/Sinon.sys.mjs` to an ES module.

`testing` should now be 100% ESM 🎉

Differential Revision: https://phabricator.services.mozilla.com/D173643
 2023-03-29 07:34:10 +00:00
Dale Harvey
543ce47074 Bug 1823543 - Add telemetry to distinguish trending results. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D173093
 2023-03-28 13:28:44 +00:00
Mark Banner
e8daad195d Bug 1824173 - Enable ESLint configuration valid-jsdocs across the tree, disabling for currently failing locations. r=mossop,webcompat-reviewers,extension-reviewers,credential-management-reviewers,denschub,dimi,robwu 
Depends on D173450

Differential Revision: https://phabricator.services.mozilla.com/D173451
 2023-03-24 19:35:25 +00:00
James Teow
d37cb53974 Bug 1816728 - Add additional conditions on whether an ad is visible - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D171821
 2023-03-24 14:04:05 +00:00
James Teow
4fc0aa67ed Bug 1816728 - Add impression event for carousels - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D171820
 2023-03-24 14:04:04 +00:00
Emilio Cobos Álvarez
0ae8f17683 Bug 1823187 - Don't asynchronously size searchbar popup. r=mak 
After bug 1809084, the popup positioning code became more sound,
including reliably positioning once after opening.

This code was asynchronously reducing the size of the popup, sometimes
after popup positioning.

Which means that if the popup had to slide (due to having many one-off
buttons), and we then shrunk it, the popup would be mispositioned.

There's no reason the getBoundsWithoutFlushing call has to be async
afaict, so just size the popup up-front.

Differential Revision: https://phabricator.services.mozilla.com/D172928
 2023-03-20 14:44:18 +00:00
Dale Harvey
8fd00bf813 Bug 1822326 - Add ability to configure maximum trending suggestions. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D172766
 2023-03-17 11:41:28 +00:00
Mark Banner
d6c5ff0925 Bug 1775916 - Improve console message checking for browser_search_telemetry_sources_ads.js to avoid intermittent issues. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D172776
 2023-03-16 14:48:23 +00:00