Commit Graph

87 Commits

Author SHA1 Message Date
Erik Nordin
195bd58b5b Bug 1829691 - Add Translations settings panel to about:preferences r=gregtatum,fluent-reviewers,settings-reviewers,Gijs,flod
Adds a new button and panel for managing Translations
settings to the about:preferences panel.

Manages always-translate languages, never-translate
languages, and never-translate sites.

Depends on D178228

Differential Revision: https://phabricator.services.mozilla.com/D177854
2023-05-24 01:22:43 +00:00
Butkovits Atila
3495b22475 Backed out 11 changesets (bug 1834014, bug 1829691) for causing failures at browser_console_content_object_in_sidebar.js.
Backed out changeset bd3077e43541 (bug 1834014)
Backed out changeset 96dc91b50ecf (bug 1834014)
Backed out changeset 6099ee399488 (bug 1829691)
Backed out changeset d3488c2d7309 (bug 1829691)
Backed out changeset a89ce140c316 (bug 1829691)
Backed out changeset 40d7f94265c2 (bug 1829691)
Backed out changeset e86660a6f994 (bug 1829691)
Backed out changeset 5c63d7e15cac (bug 1829691)
Backed out changeset 2e5a01539749 (bug 1829691)
Backed out changeset 1b53cac4d88b (bug 1829691)
Backed out changeset be4a4c19e24f (bug 1829691)
2023-05-23 03:20:38 +03:00
Erik Nordin
bf3bf6e5ef Bug 1829691 - Add Translations settings panel to about:preferences r=gregtatum,fluent-reviewers,settings-reviewers,Gijs,flod
Adds a new button and panel for managing Translations
settings to the about:preferences panel.

Manages always-translate languages, never-translate
languages, and never-translate sites.

Depends on D178228

Differential Revision: https://phabricator.services.mozilla.com/D177854
2023-05-22 21:11:11 +00:00
Butkovits Atila
ca3a270f82 Backed out 10 changesets (bug 1834014, bug 1829691) for causing failures at browser_about_translations_debounce.js. CLOSED TREE
Backed out changeset 680e9579fca5 (bug 1834014)
Backed out changeset e9c17faebbe3 (bug 1834014)
Backed out changeset 6b3a514450af (bug 1829691)
Backed out changeset 58b154e4accc (bug 1829691)
Backed out changeset 749af53af3bd (bug 1829691)
Backed out changeset 252c0d70934b (bug 1829691)
Backed out changeset 6ed4a66b1e40 (bug 1829691)
Backed out changeset fb6112332b59 (bug 1829691)
Backed out changeset 70cb62814390 (bug 1829691)
Backed out changeset 7fb6e8f6251e (bug 1829691)
2023-05-22 23:30:46 +03:00
Erik Nordin
7c85b159e5 Bug 1829691 - Add Translations settings panel to about:preferences r=gregtatum,fluent-reviewers,settings-reviewers,Gijs,flod
Adds a new button and panel for managing Translations
settings to the about:preferences panel.

Manages always-translate languages, never-translate
languages, and never-translate sites.

Depends on D178228

Differential Revision: https://phabricator.services.mozilla.com/D177854
2023-05-22 17:43:10 +00:00
Greg Tatum
967c375f70 Bug 1820259 - Implement the translation language download preferences; r=nordzilla,flod,mconley
Differential Revision: https://phabricator.services.mozilla.com/D176189
2023-04-26 19:12:17 +00:00
Gijs Kruitbosch
5672958fb9 Bug 1828280 - honour enterprise policy for profile import in the prefs import section, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D175902
2023-04-21 10:23:22 +00:00
anayo
f562857268 Bug 1820654 - Replace the label link under manualUpdate with html element. r=tgiles,flod,application-update-reviewers,bytesized
Differential Revision: https://phabricator.services.mozilla.com/D175011
2023-04-18 16:01:17 +00:00
Norisz Fay
117e38b0cf Backed out 2 changesets (bug 1820654) for causing bc failures on browser_aboutPrefs_fc_check_cantApply.js
Backed out changeset 27155fbfd0e5 (bug 1820654)
Backed out changeset 753a6e3c83e1 (bug 1820654)
2023-04-17 21:12:44 +03:00
anayo
163781c8ff Bug 1820654 - Replace the label link under manualUpdate with html element. r=tgiles,flod
Differential Revision: https://phabricator.services.mozilla.com/D175011
2023-04-17 15:06:43 +00:00
Valentin Gosu
203d05ce00 Bug 1610741 - Remove old DoH UI r=Gijs,settings-reviewers,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D173940
2023-04-11 09:57:28 +00:00
Cosmin Sabou
50de03a558 Backed out 7 changesets (bug 1816948, bug 1596847, bug 1610741) for causing build bustages on TRRService.cpp. CLOSED TREE
Backed out changeset a7341379f263 (bug 1610741)
Backed out changeset 5689f1b0d016 (bug 1816948)
Backed out changeset 7746c3a39e92 (bug 1596847)
Backed out changeset 8e85f984f46c (bug 1610741)
Backed out changeset b9b738076d55 (bug 1610741)
Backed out changeset 403f22e3a0a0 (bug 1610741)
Backed out changeset 8ec3cfe29b61 (bug 1610741)
2023-04-07 00:45:15 +03:00
Valentin Gosu
5dc6bf3830 Bug 1610741 - Remove old DoH UI r=Gijs,settings-reviewers,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D173940
2023-04-06 12:57:50 +00:00
Cristian Tuns
87c1f7746b Backed out 7 changesets (bug 1610741, bug 1816948, bug 1596847) for causing xpcshell failures in test_dooh.js CLOSED TREE
Backed out changeset 8596bc4554df (bug 1610741)
Backed out changeset 1a9baaa49d3d (bug 1816948)
Backed out changeset d72b9cdfbb1e (bug 1596847)
Backed out changeset e2e564f584b3 (bug 1610741)
Backed out changeset e9e331ccc7ab (bug 1610741)
Backed out changeset 44218f91e7cf (bug 1610741)
Backed out changeset 6f296319409a (bug 1610741)
2023-04-05 15:14:36 -04:00
Valentin Gosu
aa6cc0f7c5 Bug 1610741 - Remove old DoH UI r=Gijs,settings-reviewers,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D173940
2023-04-05 17:13:52 +00:00
Emilio Cobos Álvarez
9b62e90826 Bug 1825185 - Simplify updater deck markup. r=Gijs,settings-reviewers
The spacers are unnecessary if there's a <label> or <description> that
flexes.

Since we allow labels/descriptions to shrink now they'd distribute the
space along with the spacer, which caused unnecessarily small labels.

Differential Revision: https://phabricator.services.mozilla.com/D173937
2023-03-29 18:46:22 +00:00
Siya
02d11f37da Bug 1761282 - Update sad/happy smiley faces to emoji. r=hjones,settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D172804
2023-03-21 17:04:48 +00:00
Emilio Cobos Álvarez
b9a4c412a4 Bug 1822578 - Make flex="1" on XUL set a zero flex basis like the flex shorthand does. r=Gijs,mconley,settings-reviewers,desktop-theme-reviewers,dao
In a setup with:

<hbox>
 <something flex="1"/>
 <something-else/>
</hbox>

Before bug 1822131 <something flex="1"> ended up with flex-basis: auto,
but was the only thing able to shrink, so <something-else> stayed the
same size.

After that bug however <something-else> is able to shrink too, so both
elements shrink. This wouldn't happen if flex="1" actually worked like
flex: 1 does.

However flex: 1 causes stuff like explicit main sizes to be
(effectively) ignored, so we need to fix up a few cases where now we'd
start flexing too much. For that, add a debug assert to
nsFlexContainerFrame to catch the would-be behavior changes here.

For the most part they're actually no-op since they're setting tiny
sizes, but preferences and devtools needed a couple real fixes.

The profile selection spacer is useless (zero-size).

Hopefully the last xul.css change I need to do :')

Differential Revision: https://phabricator.services.mozilla.com/D172704
2023-03-16 00:06:29 +00:00
Mike Conley
5c075e9201 Bug 1820655 - Add a new section to about:preferences to launch the migration wizard. r=jhirsch,fluent-reviewers,flod DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D172324
2023-03-15 00:35:16 +00:00
Butkovits Atila
c0d8e7c741 Backed out changeset 5c4677b1ea47 (bug 1820655) for causing failures at browser_open_migration_wizard.js. CLOSED TREE 2023-03-14 05:20:08 +02:00
Mike Conley
fdd13dfa60 Bug 1820655 - Add a new section to about:preferences to launch the migration wizard. r=jhirsch,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D172324
2023-03-14 01:59:01 +00:00
Butkovits Atila
e0499363a2 Backed out changeset 21ac89d8a165 (bug 1820655) for causing Gecko Decision failure. CLOSED TREE 2023-03-14 03:20:05 +02:00
Mike Conley
d853edb9ce Bug 1820655 - Add a new section to about:preferences to launch the migration wizard. r=jhirsch,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D172324
2023-03-14 01:06:42 +00:00
Emilio Cobos Álvarez
7ac1b96d23 Bug 1666626 - Simplify update throbbers. r=dao,Gijs,settings-reviewers
We have no XUL throbbers anymore, so remove the html difference.

We could use <img srcset="..."> instead of image-set() in css, though
that'd mean a bit of duplication in about:preferences at least.

Differential Revision: https://phabricator.services.mozilla.com/D169457
2023-02-10 16:04:57 +00:00
Emilio Cobos Álvarez
a944fa5b0e Bug 1812335 - Remove some XUL image usage from preferences. r=Gijs,settings-reviewers
Use content rather than list-style.

Differential Revision: https://phabricator.services.mozilla.com/D167811
2023-01-25 23:13:53 +00:00
Tim Giles
6b44824dc0 Bug 1801927 - refactor media control learn more link. r=settings-reviewers,mconley
Replaces the "Control media via keyboard, headset, or virtual interface"
XUL label with the moz-support-link element.

Differential Revision: https://phabricator.services.mozilla.com/D166469
2023-01-18 19:13:34 +00:00
Tim Giles
bcd9cd6b58 Bug 1801927 - refactor configure how firefox connects learn more link. r=mconley
Replaces the "Configure how Nightly connects to the internet" XUL label
with the moz-support-link element.

Differential Revision: https://phabricator.services.mozilla.com/D166468
2023-01-18 19:13:34 +00:00
Tim Giles
980f7a2fe8 Bug 1801927 - refactor cfr learn more links. r=settings-reviewers,mossop
Replaces the "Recommend extensions as you browse" and
"Recommend features as you browse" XUL labels with the moz-support-link
element.

Differential Revision: https://phabricator.services.mozilla.com/D166467
2023-01-18 19:13:32 +00:00
Tim Giles
5eb6e6c483 Bug 1801927 - refactor picture in picture learn more link. r=settings-reviewers,mossop
Replaces the "Enable picture-in-picture video controls" XUL label with
the moz-support-link element.

Differential Revision: https://phabricator.services.mozilla.com/D166466
2023-01-18 19:13:32 +00:00
Tim Giles
4d98cc5271 Bug 1801927 - refactor performance settings learn more link. r=settings-reviewers,mossop
Replaces the "Use recommended performance settings" XUL label with
the moz-support-link element.

Differential Revision: https://phabricator.services.mozilla.com/D166465
2023-01-18 19:13:31 +00:00
Tim Giles
2dfc0597c8 Bug 1801927 - refactor DRM content learn more link. r=settings-reviewers,mossop
Replaces the "Play DRM-controlled content" XUL label with the
moz-support-link element.

Differential Revision: https://phabricator.services.mozilla.com/D166464
2023-01-18 19:13:31 +00:00
Tim Giles
653373bc75 Bug 1801927 - refactor containers learn more link. r=hjones,settings-reviewers,mconley
Replaces the XUL label for the "Enable Container Tabs" with the
moz-support-link element

Differential Revision: https://phabricator.services.mozilla.com/D166463
2023-01-18 19:13:31 +00:00
Valentin Gosu
73260a3dbc Bug 1596845 - Make custom about:neterror page for TRR mode3 DNS failures r=pbz,fluent-reviewers,settings-reviewers,flod,edgul
This changes about:neterror to show a specific error page when the DNS failure
occurs for a TRR mode3 page load. This offers the user more information about
the failure, and some options.

This page will be further improved at a later stage when we add a better
DNS over HTTPS settings page.

The page is visible when the browser is using DNS over HTTPS without fallback
to native DNS. To achieve this the user sets `network.trr.mode` to `3` then
loads a page such as `http://nonexistant.test`.

If a top level load's channel returns NS_ERROR_UNKNOWN_HOST we look at
whether the page was indeed loaded with an effectiveTRRMode == TRRONLY
(some loads are excluded from using TRR).
When that is true, we present the error page allowing the user to retry,
exclude the domain from TRR, or open the settings page.

Note: This initial implementation will not work if the
`network.dns.disablePrefetch` pref is set to true. In that case nsHttpChannel
does not get an OnLookupComplete callback, so it doesn't have the
effectiveTRRMode and trrSkipReason. This will be fixed in bug 1805372.

Project plan: https://docs.google.com/document/d/12IGABt1eXI276qHduXXbVZqRFrhLN7Ad3gKEgxz81sE
Copy deck: https://docs.google.com/document/d/130UTox8bQbybjYIwvltR4qBg2hWjsGhuNUHypLwUAEQ

Depends on D164642

Differential Revision: https://phabricator.services.mozilla.com/D164347
2022-12-23 09:26:16 +00:00
Marian-Vasile Laza
6fb0160a69 Backed out 9 changesets (bug 1596845) for causing xpcshell failures on test_trr_enterprise_policy.js. CLOSED TREE
Backed out changeset 231acfc052bb (bug 1596845)
Backed out changeset 7d02dad4d720 (bug 1596845)
Backed out changeset b0449eec2671 (bug 1596845)
Backed out changeset 5cd033c9ef7c (bug 1596845)
Backed out changeset 98d583f1d19e (bug 1596845)
Backed out changeset b78bc0049605 (bug 1596845)
Backed out changeset 88919aaff89b (bug 1596845)
Backed out changeset f4adb3e7b8e1 (bug 1596845)
Backed out changeset b171f7ac0b40 (bug 1596845)
2022-12-23 09:21:39 +02:00
Valentin Gosu
e8ea595264 Bug 1596845 - Make custom about:neterror page for TRR mode3 DNS failures r=pbz,fluent-reviewers,settings-reviewers,flod,edgul
This changes about:neterror to show a specific error page when the DNS failure
occurs for a TRR mode3 page load. This offers the user more information about
the failure, and some options.

This page will be further improved at a later stage when we add a better
DNS over HTTPS settings page.

The page is visible when the browser is using DNS over HTTPS without fallback
to native DNS. To achieve this the user sets `network.trr.mode` to `3` then
loads a page such as `http://nonexistant.test`.

If a top level load's channel returns NS_ERROR_UNKNOWN_HOST we look at
whether the page was indeed loaded with an effectiveTRRMode == TRRONLY
(some loads are excluded from using TRR).
When that is true, we present the error page allowing the user to retry,
exclude the domain from TRR, or open the settings page.

Note: This initial implementation will not work if the
`network.dns.disablePrefetch` pref is set to true. In that case nsHttpChannel
does not get an OnLookupComplete callback, so it doesn't have the
effectiveTRRMode and trrSkipReason. This will be fixed in bug 1805372.

Project plan: https://docs.google.com/document/d/12IGABt1eXI276qHduXXbVZqRFrhLN7Ad3gKEgxz81sE
Copy deck: https://docs.google.com/document/d/130UTox8bQbybjYIwvltR4qBg2hWjsGhuNUHypLwUAEQ

Depends on D164642

Differential Revision: https://phabricator.services.mozilla.com/D164347
2022-12-23 01:20:02 +00:00
Sandor Molnar
a10fcf6c07 Backed out 9 changesets (bug 1596845) for causing mochitest failures in browser/base/content/test/about/browser_aboutCertError_telemetry.js
Backed out changeset eb1e34c3041f (bug 1596845)
Backed out changeset af6d41439c60 (bug 1596845)
Backed out changeset f1447dd8df04 (bug 1596845)
Backed out changeset a383f2bbcaae (bug 1596845)
Backed out changeset 950c66dd6133 (bug 1596845)
Backed out changeset ab300239fd69 (bug 1596845)
Backed out changeset 8e1fe024b680 (bug 1596845)
Backed out changeset 80e5048d1f35 (bug 1596845)
Backed out changeset b14a4910d73b (bug 1596845)
2022-12-23 00:56:35 +02:00
Valentin Gosu
d40c36f86f Bug 1596845 - Make custom about:neterror page for TRR mode3 DNS failures r=pbz,fluent-reviewers,settings-reviewers,flod
This changes about:neterror to show a specific error page when the DNS failure
occurs for a TRR mode3 page load. This offers the user more information about
the failure, and some options.

This page will be further improved at a later stage when we add a better
DNS over HTTPS settings page.

The page is visible when the browser is using DNS over HTTPS without fallback
to native DNS. To achieve this the user sets `network.trr.mode` to `3` then
loads a page such as `http://nonexistant.test`.

If a top level load's channel returns NS_ERROR_UNKNOWN_HOST we look at
whether the page was indeed loaded with an effectiveTRRMode == TRRONLY
(some loads are excluded from using TRR).
When that is true, we present the error page allowing the user to retry,
exclude the domain from TRR, or open the settings page.

Note: This initial implementation will not work if the
`network.dns.disablePrefetch` pref is set to true. In that case nsHttpChannel
does not get an OnLookupComplete callback, so it doesn't have the
effectiveTRRMode and trrSkipReason. This will be fixed in bug 1805372.

Project plan: https://docs.google.com/document/d/12IGABt1eXI276qHduXXbVZqRFrhLN7Ad3gKEgxz81sE
Copy deck: https://docs.google.com/document/d/130UTox8bQbybjYIwvltR4qBg2hWjsGhuNUHypLwUAEQ

Depends on D164642

Differential Revision: https://phabricator.services.mozilla.com/D164347
2022-12-22 21:16:06 +00:00
Max Christian Pohle
60f9ef1f3e Bug 1643309 - About dialog falsely claims App "is up to date" when offline, r=bytesized,application-update-reviewers,fluent-reviewers,settings-reviewers,bhearsum,flod
This commit is based on a patch written by Priyank Singh <preyunk>. Thank you
for your contribution, which is strongly appreciated. The original patch was
discussed here: https://phabricator.services.mozilla.com/D97972#3405294

Differential Revision: https://phabricator.services.mozilla.com/D159907
2022-12-06 22:29:11 +00:00
Norisz Fay
e02f711c8c Backed out changeset e87383813223 (bug 1643309) for causing bc failures on browser_aboutDialog_fc_check_cantApply.js CLOSED TREE 2022-11-18 21:55:40 +02:00
Max Christian Pohle
116159b915 Bug 1643309 - About dialog falsely claims App "is up to date" when offline, r=bytesized,application-update-reviewers,fluent-reviewers,settings-reviewers,bhearsum,flod
This commit is based on a patch written by Priyank Singh <preyunk>. Thank you
for your contribution, which is strongly appreciated. The original patch was
discussed here: https://phabricator.services.mozilla.com/D97972#3405294

Differential Revision: https://phabricator.services.mozilla.com/D159907
2022-11-18 17:16:55 +00:00
Emilio Cobos Álvarez
9e70efc4e9 Bug 1800379 - Fix layout of network settings description with long text. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D161969
2022-11-14 21:44:12 +00:00
Emilio Cobos Álvarez
e5685e8457 Bug 1794987 - Simplify preferences find-in-page tooltip implementation. r=mconley,Gijs,preferences-reviewers
<menulist> still uses legacy XUL layout (for reasons, I plan to fix it
but it can take a little bit).

The issue here is a poor interaction between one of the wrapping hboxes
and the xul layout. But we can simplify the code and fix the bug at the
same time, so do that.

Differential Revision: https://phabricator.services.mozilla.com/D159254
2022-10-14 10:41:35 +00:00
Emilio Cobos Álvarez
22c7dc0b6a Bug 1792730 - Keep dialogs stretching over their preferred width after bug 1665476. r=Gijs,preferences-reviewers,eemeli
width gets honored properly now. What these want is really a min-width.

Differential Revision: https://phabricator.services.mozilla.com/D158286
2022-10-02 01:40:13 +00:00
Emilio Cobos Álvarez
2e072c2520 Bug 1792337 - Make about dialog use modern flexbox emulation, and size to a smaller width. r=Gijs,bytesized,application-update-reviewers,preferences-reviewers
That was presumably the intention of the explicit width in the CSS but
that wasn't working.

While at it, use a proper deck rather than a hand-rolled one.

Differential Revision: https://phabricator.services.mozilla.com/D158223
2022-09-28 20:27:57 +00:00
Kirk Steuber
ff6db15116 Bug 1756450 - Add AppUpdater.STATUS.INTERNAL_ERROR r=bhearsum,fluent-reviewers,preferences-reviewers,desktop-theme-reviewers,flod
This patch adds a state to AppUpdater to represent when an internal error has occurred. It also adds the appropriate code to the Update UI to be able to handle this state, along with a panel in each UI and a string that can go in the panels to convey to the user that update has failed.

Ideally, it would be good if this message also directed the user to a SUMO article. See Bug 1787309 for details on this. But at the moment, I would prefer to address Bug 1756450 quickly rather than wait for that to be ready.

Differential Revision: https://phabricator.services.mozilla.com/D156998
2022-09-23 19:47:33 +00:00
Emilio Cobos Álvarez
ac7ac8f3f3 Bug 1790307 - Remove equalsize="always" usage from preferences. r=Gijs,preferences-reviewers
Emulated flexbox doesn't support this, but allows you to specify widths
in percentages instead, so do that.

Differential Revision: https://phabricator.services.mozilla.com/D157073
2022-09-19 09:39:33 +00:00
Iulian Moraru
14af5f0f9d Backed out 2 changesets (bug 1790307) as per Emilio's request. CLOSED TREE
Backed out changeset fd57a3ea2b88 (bug 1790307)
Backed out changeset 646ae1f6d62c (bug 1790307)
2022-09-18 08:57:40 +03:00
Emilio Cobos Álvarez
abe7f010cd Bug 1790307 - Remove equalsize="always" usage from preferences. r=Gijs,preferences-reviewers
Emulated flexbox doesn't support this, but allows you to specify widths
in percentages instead, so do that.

Differential Revision: https://phabricator.services.mozilla.com/D157073
2022-09-13 12:17:12 +00:00
Dão Gottwald
ee0738747b Bug 1788822 - Simplify color-scheme content override pref to only be [dark, light, auto]. r=emilio,fluent-reviewers,extension-reviewers,robwu,flod
Differential Revision: https://phabricator.services.mozilla.com/D156710
2022-09-08 17:55:07 +00:00
Andre Natal
85ff5fcb87 Bug 1776814: Incorporate data-subcategory to Firefox Translations panel on about:preferences r=preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D150446
2022-06-28 16:24:32 +00:00