corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
786,775 Commits 1 Branch 0 Tags
195bd58b5b901b1aa719a48f0559353031887109
Commit Graph

541 Commits

Author SHA1 Message Date
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177025
 2023-05-20 12:26:49 +00:00
Marco Bonardo
fe84c45462 Bug 1818461 - Remove the synchronous PlacesUtils.getChildCountForFolder().r=daisuke,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D175532
 2023-05-19 12:17:17 +00:00
Eemeli Aro
41c3009db2 Bug 1830042 - Migrate placesContext_delete_history and placesContext_createBookmark to Fluent. r=mak,fluent-reviewers,flod 
Depends on D176641

Differential Revision: https://phabricator.services.mozilla.com/D176642
 2023-05-02 18:34:41 +00:00
Marco Bonardo
28afd9f1c3 Bug 1820332 - Dragging URL from address bar results in bookmark with the URL instead of the page title. r=NeilDeakin 
Differential Revision: https://phabricator.services.mozilla.com/D173689
 2023-03-27 14:44:50 +00:00
Abhishek Tiwari
44d69b39a6 Bug 1821620 - Convert toolkit/components/forgetaboutsite to ES modules r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D172230
 2023-03-14 21:36:38 +00:00
Kelly Cochrane
0a91da08b0 Bug 1817251 - Record telemetry for History in sidebar and library when using the context menu r=sclements,mak 
Differential Revision: https://phabricator.services.mozilla.com/D171253
 2023-03-14 10:29:57 +00:00
Kelly Cochrane
e8b015d3ac Bug 1818800 - Only pass library telemetry function in controller.js if opening multiple tabs from Library r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D171024
 2023-02-26 19:51:10 +00:00
Kelly Cochrane
f5c7d36f53 Bug 1815906 - Add telemetry for History in Library window r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D169710
 2023-02-22 19:25:52 +00:00
Neil Deakin
21426e24f4 Bug 1776879, replace text/unicode for clipboard and drag and drop and use text/plain directly, r=edgar,mak,stransky,geckoview-reviewers,extension-reviewers,zombie,m_kato 
Most usage is a straight replacement but gtk needs extra changes as it transfers plain text in UTF8 natively and needs to be converted into UTF16, and Windows uses single-byte characters for RTF and CF_HTML formats so we preserve this.

Differential Revision: https://phabricator.services.mozilla.com/D158587
 2023-02-01 23:30:55 +00:00
Mark Banner
2bd093b567 Bug 1811334 - Automatically replace Cu.reportError with console.error (most of browser/components). r=settings-reviewers,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D167297
 2023-01-20 17:49:21 +00:00
Marco Bonardo
3b8f1a3fd8 Bug 1457131 - Remove itemId (aka parentId) from PlacesInsertionPoint. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D165767
 2023-01-04 13:16:08 +00:00
Marco Bonardo
5cb7cc3f7e Bug 1382992 - Remove the synchronous getFolderIdForItem() bookmarks API. r=Standard8 
Unfortunately the dragover behavior is not trivial to test, thus this relies on
manual testing. The data safety is covered by the undelrying bookmarking API
anyway, so this is just about the UI visual drag indicator.

Differential Revision: https://phabricator.services.mozilla.com/D165766
 2023-01-04 13:16:08 +00:00
Marco Bonardo
e7cd35a78d Bug 1805889 - Stop abusing the options object in the Panel View. r=Gijs 
Make Places views constructors arguments more coherent, passing the root
and view elements up to the super class explicitly.
Remove the options argument, that was not strictly necessary, the same info can
be obtained directly.
Rename the "builder" attribute to "afterplacescontent" to clarify what it is
and make panel use it, instead of passing an insertionPoint option.

Additional cleanups:
Make chevron and BMB menus use coherent popupshowing observers.
Remove useless .viewElt accessor, .associatedElement can be used instead.
Avoid an access to the private _rootElt property from the controller.

Differential Revision: https://phabricator.services.mozilla.com/D164827
 2022-12-19 10:18:22 +00:00
Sergey Galich
a94748d7f9 Bug 702925 - stop deleting saved passwords when user runs History > Forget this site command r=fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D163903
 2022-12-14 19:18:24 +00:00
Francis McKenzie
5a032067ad Bug 1795070 - Speed up deleting from history by 7,000%. r=mak 
Initial investigation revealed that when the user deletes 2,000 items from a history search, treeView.js invalidateContainer() is invoked 2,000 times (in batches of 300 at a time). However, this is not the primary cause of the poor performance.

Yes, one of the nsNavHistoryQueryResultNode observers is being refreshed for every Page_removed event, resulting in repeated calls to treeView.js invalidateContainer(). This definitely has a performance impact.

However, even worse is that another of the nsNavHistoryQueryResultNode observers is being incrementally updated for every Page_removed event. This is causing the majority of the slowdown.

This patch provides a simple solution: when handling a PlacesEvent containing 50 or more Page_removed events and no other events, just refresh all the history observers once and return.

With this change, it takes about 1 second to delete 2,000 items from a history query, representing a performance improvement of approximately 7,000%.

Differential Revision: https://phabricator.services.mozilla.com/D159286
 2022-11-04 19:30:55 +00:00
trickypr
02afbf3322 Bug 1510561 - Part 2: Apply plugin:mozilla/valid-jsdoc to browser/components/places. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D158562
 2022-10-13 10:55:28 +00:00
Shane Hughes
509e6cf163 Bug 1783207 - Add ellipsis to some menu label strings. r=flod 
The copy guidance recommends adding an ellipsis to the end of labels for
controls that require an additional step to complete the action
specified by the label. We have some menuitems and panel buttons that
open a bookmark dialog or the edit bookmark panel that don't have an
ellipsis, so add that. Also, the form "Bookmark this x" has been changed
to "Bookmark x" in menuitems. Also, there's a "Print Selection" menuitem
that needed an ellipsis. Thanks for the review!

Differential Revision: https://phabricator.services.mozilla.com/D154320
 2022-08-11 17:48:11 +00:00
Mark Banner
d026f430f6 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152005
 2022-07-20 22:34:21 +00:00
Mark Banner
b95b1937fa Bug 1779982 - Use explicit imports in controller.js rather than telling ESLint about imports from modules. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D152003
 2022-07-20 22:34:20 +00:00
smolnar
ee079d37e2 Backed out 8 changesets (bug 1779982, bug 1780017, bug 1780347) for causing doc generate failures. CLOSED TREE 
Backed out changeset 3f22c0f99cf1 (bug 1780347)
Backed out changeset 6f20b7e4b21b (bug 1780017)
Backed out changeset ae6062c69aeb (bug 1780017)
Backed out changeset e668d7778d97 (bug 1780017)
Backed out changeset e158fc41594b (bug 1780017)
Backed out changeset d4c69c956271 (bug 1779982)
Backed out changeset 145212fd826d (bug 1779982)
Backed out changeset 54079aaa1857 (bug 1779982)
 2022-07-20 22:43:53 +03:00
Mark Banner
8715b062f5 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152005
 2022-07-20 15:50:40 +00:00
Mark Banner
3db870a25d Bug 1779982 - Use explicit imports in controller.js rather than telling ESLint about imports from modules. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D152003
 2022-07-20 15:50:39 +00:00
Iulian Moraru
bc13570de5 Backed out 7 changesets (bug 1779982, bug 1780017) for causing multiple failures. CLOSED TREE 
Backed out changeset f33a58aa2f3f (bug 1780017)
Backed out changeset e21c85d61b91 (bug 1780017)
Backed out changeset 213ee5578e7c (bug 1780017)
Backed out changeset ea9b3bf42ea1 (bug 1780017)
Backed out changeset d2d8530f3c4d (bug 1779982)
Backed out changeset 088e5148c307 (bug 1779982)
Backed out changeset 267e08f3868a (bug 1779982)
 2022-07-20 15:44:53 +03:00
Mark Banner
2bd76952c1 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152005
 2022-07-20 10:36:49 +00:00
Mark Banner
c9b826a4b1 Bug 1779982 - Use explicit imports in controller.js rather than telling ESLint about imports from modules. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D152003
 2022-07-20 10:36:49 +00:00
Kagami Sascha Rosylight
4fb733cb3b Bug 1773740 - Part 4: Reapply mach -l eslint --fix with use-isInstance changes r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D148939
 2022-06-27 20:31:34 +00:00
Masatoshi Kimura
7b0749ad93 Bug 1754805 - Add "Open in New Container Tab" to places context menu. r=mak,fluent-reviewers,mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D138454
 2022-03-31 15:51:59 +00:00
Norisz Fay
e7715de615 Backed out changeset bcc49b21bd0e (bug 1754805) for causing multiple failures CLOSED TREE 2022-03-31 17:01:58 +03:00
Masatoshi Kimura
eba22b696e Bug 1754805 - Add "Open in New Container Tab" to places context menu. r=mak,fluent-reviewers,mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D138454
 2022-03-31 13:27:52 +00:00
Lebar
eab036787c Bug 1741603 - Fix Show in Folder context menu item in app menu to open in sidebar. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D139230
 2022-03-15 17:35:22 +00:00
Evgenia Kotovich
7c2a87cee4 Bug 1725487 - Don't allow dragging multiple uris if one is javascript:link. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D134395
 2022-01-28 07:46:06 +00:00
Evgenia Kotovich
c597e5d1d5 Bug 1725487 - Show the Add Bookmark Dialog when dragging javascript url to create a bookmarklet. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D133813
 2022-01-28 07:46:06 +00:00
Lebar
3d36116e67 Bug 1747200 - Added call to ensureRowIsVisible to make sure that selected node is in view after showInFolder. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D135672
 2022-01-27 14:53:43 +00:00
Mark Banner
2649c5fb78 Bug 1750974 - Extend our ESLint import-globals-from function to support absolute directories. r=Gijs,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D136368
 2022-01-20 14:15:34 +00:00
Cristian Tuns
a6563e6738 Backed out 2 changesets (bug 1725487) for causing mochitest failures on browser_toolbar_drop_bookmarklet.js CLOSED TREE 
Backed out changeset 1564124c0309 (bug 1725487)
Backed out changeset ae5ab5c447c3 (bug 1725487)
 2022-01-13 07:23:29 -05:00
Evgenia Kotovich
6ef5f7142e Bug 1725487 - Don't allow dragging multiple uris if one is javascript:link. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D134395
 2022-01-13 11:05:59 +00:00
Evgenia Kotovich
ce5749f98a Bug 1725487 - Show the Add Bookmark Dialog when dragging javascript url to create a bookmarklet. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D133813
 2022-01-13 11:05:59 +00:00
Paul Zuehlcke
4134ccfa27 Bug 1735122 - Fix esc key accepting the 'forget about this site' confirmation prompt. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D128089
 2021-10-15 15:07:06 +00:00
Lebar
86d6cd4771 Bug 469441 - Added 'Show in Folder' context menu item for bookmark library searches and bookmarks sidebar. r=Standard8,flod 
Differential Revision: https://phabricator.services.mozilla.com/D121040
 2021-10-04 21:07:09 +00:00
Mark Banner
f321dfd6b1 Bug 1729460 - Change users of defineLazyServiceGetter(s) to use Services.* where appropriate. r=mossop,webdriver-reviewers,extension-reviewers,whimboo,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D124838
 2021-09-10 12:09:49 +00:00
Noemi Erli
20dee875a7 Backed out 2 changesets (bug 1729460) for causing newtab failures CLOSED TREE 
Backed out changeset 5617839462be (bug 1729460)
Backed out changeset 6d52fde3ee0e (bug 1729460)
 2021-09-10 13:14:12 +03:00
Mark Banner
6a5ffbcc55 Bug 1729460 - Change users of defineLazyServiceGetter(s) to use Services.* where appropriate. r=mossop,webdriver-reviewers,extension-reviewers,whimboo,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D124838
 2021-09-10 09:38:42 +00:00
Stefan Zabka
a51b55b8f2 Bug 1711759 - Ask user for confirmation in Forget about this site. r=pbz,Standard8,flod 
Differential Revision: https://phabricator.services.mozilla.com/D120363
 2021-09-02 11:55:52 +00:00
Gijs Kruitbosch
e93d5b7bcc Bug 1714478 - go back to using 'edit' and 'delete' for bookmark menus, r=mak,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D124045
 2021-09-01 16:08:50 +00:00
Nicholas Fason
f0a8082876 Bug 1702708 - Hyphenate places context menu attributes r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D121583
 2021-08-03 14:03:03 +00:00
Paul Zuehlcke
8c971e0b12 Bug 1705028 - Update places forget-this-site to clear storage by base domain. r=johannh 
Differential Revision: https://phabricator.services.mozilla.com/D113495
 2021-05-26 13:49:36 +00:00
Mark Banner
f144cfcf62 Bug 1711517 - Add ESLint jsdoc validation to browser/components/places. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D115233
 2021-05-18 16:27:44 +00:00
Bernard Igiri
8f33752c03 Bug 1705105 - Update bookmarks folder context menu r=fluent-reviewers,mak,flod 
Changed the text on the edit and delete folder buttons and moved position of the Sort By Name menu item.

Differential Revision: https://phabricator.services.mozilla.com/D112110
 2021-04-16 17:27:00 +00:00
Marco Bonardo
4e88c4821b Bug 1700929 - Restore Open All in tabs in some Places context menus. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D110478
 2021-04-02 07:38:51 +00:00
Marco Bonardo
184c593112 Bug 1700929 - Restore Places context menu Delete on mixed selection. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D110477
 2021-04-02 07:38:51 +00:00