corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
882,792 Commits 1 Branch 0 Tags
176b51d0b03091ca7a49a38be970c23567ce2388
Commit Graph

1943 Commits

Author SHA1 Message Date
Moritz Beier
4983a8b7fa Bug 1916499 - Add searchForm support back to OpenSearch engines. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D225968
 2024-11-04 13:53:51 +00:00
Stephanie Cunnane
c873aefe60 Bug 1927151 - Fix Bing follow-on searches incorrectly recorded as organic:none in telemetry. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D227266
 2024-11-01 19:25:48 +00:00
Mark Banner
12b1c9c8a3 Bug 1928473 - Fix no-shadow and manifest section warnings (alphabetical) in search code. r=mbeier 
Differential Revision: https://phabricator.services.mozilla.com/D227528
 2024-11-01 14:17:03 +00:00
Butkovits Atila
edb20fc3fa Backed out changeset e3b696297414 (bug 1928473) for causing failures at browser_searchbar_results.js. CLOSED TREE 2024-11-01 13:58:18 +02:00
Mark Banner
f0da7da6f6 Bug 1928473 - Fix no-shadow and manifest section warnings (alphabetical) in search code. r=mbeier 
Differential Revision: https://phabricator.services.mozilla.com/D227528
 2024-11-01 10:59:40 +00:00
Alexandru Marc
5a5f7b93df Backed out 2 changesets (bug 1916505, bug 1916499) for causing bc failures @ browser_oneOffContextMenu.js 
Backed out changeset dbd2ce7823c2 (bug 1916505)
Backed out changeset 5082d347bbf7 (bug 1916499)
 2024-10-31 16:05:29 +02:00
Moritz Beier
36f3384408 Bug 1916499 - Add searchForm support back to OpenSearch engines. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D225968
 2024-10-31 13:01:12 +00:00
Florian Quèze
6c9d1e646e Bug 1923028 - Migrate scalars to use Glean APIs for urlbar.searchmode.*, r=chutten,search-reviewers,scunnane. 
Differential Revision: https://phabricator.services.mozilla.com/D226510
 2024-10-24 10:52:56 +00:00
Florian Quèze
8d2717cf5a Bug 1923028 - Migrate scalars to use Glean APIs for browser.search.{content,withads,adclicks}.*, r=chutten,search-reviewers,scunnane. 
Differential Revision: https://phabricator.services.mozilla.com/D226509
 2024-10-24 10:52:56 +00:00
Florian Quèze
f15527ff77 Bug 1923028 - Migrate scalars to use Glean APIs for browser.engagement.navigation.*, r=chutten,search-reviewers,scunnane. 
Differential Revision: https://phabricator.services.mozilla.com/D226372
 2024-10-24 10:52:55 +00:00
Norisz Fay
9b743ec4a9 Backed out changeset 1de300781d3f (bug 1916499) for causing multiple search related failures CLOSED TREE 2024-10-18 22:17:36 +03:00
Moritz Beier
eedeed877c Bug 1916499 - Add searchForm support back to OpenSearch engines. r=Standard8,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D225968
 2024-10-18 13:46:52 +00:00
James Teow
58e735c0ef Bug 1895134 - Remove redundant telemetry test - r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D224945
 2024-10-08 15:34:25 +00:00
James Teow
46c33defd6 Bug 1921092 - Simplify Persisted Search logic and make non-default engines consistent - r=adw,urlbar-reviewers 
The main goal is to simplify the logic in setURI, and create a more easier to understand flow of operations.

It involves making Persisted Search more contained, offload some responsibilities to UrlbarSearchTermsPersistence, and store fewer state variables than the patch that was first reviewed. I also simplified code in UrlbarSearchTermsPersistence.

**How Search Terms Persist:**

**Step 1**

When the page first appears, set state for search terms persistence. First load doesn't necessarily mean no tab switch or same page load, as a user could load a browser in the background tab. In that latter case, the first "view" may occur on a tab switch and the state won't exist because `setURI` will never have been called with that browser object being selected.

Once the state has been set, the only property that could be updated is `shouldPersist`. Otherwise, don't update the state object unless a full new page load occurs.

**Step 2**

Call `shouldPersist`. This has all the logic for when search terms should persist and gets called anytime `setURI` is called.

The conditions in which we shouldn't persist:

- There's no reason to show search terms:
  - The persist state is missing.
  - There are no search terms extracted from the URL.
- We need to temporarily hide the search terms, such as by handleRevert
  - `hideSearchTerms` is provided to setURI
- There is an user typed value and it differs from the search terms
- A single page application moved to a secondary page
- After the initial page load, there's the search mode (or lack of search mode) differs from the persist engine.

**Step 3**

Determine if we need to update `this.window.gBrowser.userTypedValue`. If we're going to persist, set `userTypedValue` to the search terms, which will keep the search mode and non-search mode state consistent. This'll also enable the ability to reuse existing logic that determines how to set `value`.

On same page loads, when switching from persist to non-persist, and search term equals the userTypedValue, then `null` the userTypedValue so that the URL shows.

**Step 4**

In the area of setURI which has logic for search mode, if we persist, ensure the search mode (or lack of search mode) is consistent with the engine. If it is, do nothing. If it isn't, either nullify the search mode or enter search mode.

Differential Revision: https://phabricator.services.mozilla.com/D224520
 2024-10-08 04:12:29 +00:00
Florian Quèze
dc117303c1 Bug 1920723 - remove search.engine legacy telemetry event that has been replaced by a Glean event, r=Standard8,settings-reviewers. 
Differential Revision: https://phabricator.services.mozilla.com/D223501
 2024-09-30 18:26:04 +00:00
Moritz Beier
75d4af01f0 Bug 1775914 - Fix Intermittent browser/components/search/test/browser/browser_426329.js. r=search-reviewers,daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D222783
 2024-09-23 07:06:36 +00:00
James Teow
43f2904306 Bug 1915856 - Enable region restrictions for SERP categorization - r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D220911
 2024-09-18 13:58:35 +00:00
Stephanie Cunnane
15a072dd91 Bug 1603760 - Remove navigation.search legacy event telemetry. r=Standard8,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D222362
 2024-09-17 22:08:07 +00:00
Norisz Fay
4487d3a4cf Backed out changeset 0a3a586fbbec (bug 1603760) for causing bc failures on browser_urlbar_telemetry_handoff.js CLOSED TREE 2024-09-18 00:37:24 +03:00
Stephanie Cunnane
771e4a43bb Bug 1603760 - Remove navigation.search legacy event telemetry. r=Standard8,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D222362
 2024-09-17 19:27:56 +00:00
James Teow
32a513aca6 Bug 1918176 - Restrict Persisted Search to App Provided Engines - r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D222165
 2024-09-14 03:21:33 +00:00
Masayuki Nakano
aa8485f065 Bug 1916087 - Make test_multiple_listeners move cursor before synthesizing a click r=jteow,search-reviewers 
They try to synthesize `mouseover` which is mapped to `eMouseEnterIntoWidget`
internal event (which is not same as DOM `mouseover`) after `click`.  However,
with any pointing devices, `mousemove` should occur before `mousedown`.
Therefore, in the real world, `mouseover` should be fired before `mousedown`,
`mouseup` and `click` in the test.  Therefore, this swaps the event order.

Note that after fixing bug 1914546, `mouseover` will be fired immediately after
`mouseup` and `click`. This makes the test waits `mouseover` after it's fired.
So, it'd permanently timeout after the fix.

Differential Revision: https://phabricator.services.mozilla.com/D220839
 2024-09-04 00:20:40 +00:00
Moritz Beier
22925f7a1e Bug 1907034 - Allow using shift-enter/shift-click to open the search engine page without a search from the search bar. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D220446
 2024-09-02 12:37:01 +00:00
Moritz Beier
ca56f68246 Bug 1775918 - Fix intermittent failure in browser/components/search/test/browser/browser_searchbar_enter.js. r=search-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D220574
 2024-09-02 09:58:06 +00:00
Stephanie Cunnane
7fb507e794 Bug 1775793 - Fix intermittent failure in browser/components/search/test/browser/browser_contentSearch.js. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D218548
 2024-08-30 14:35:14 +00:00
Stanca Serban
f02002455b Backed out changeset d53fd34c2b24 (bug 1907034) for causing mochitests failures in browser_urlbarSearchMode.js. CLOSED TREE 2024-08-29 19:59:35 +03:00
Moritz Beier
51dd58b8f1 Bug 1907034 - Allow using shift-enter/shift-click to open the search engine page without a search from the search bar. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D220446
 2024-08-29 15:51:46 +00:00
Mark Banner
28e4ba7093 Bug 1870226 - Upgrade eslint-plugin-jsdoc to version 43.2.0. r=frontend-codestyle-reviewers,credential-management-reviewers,issammani 
This switches from the deprecated/removed jsdoc/newline-after-description rule to using the replacement jsdoc/tag-lines rule.

Differential Revision: https://phabricator.services.mozilla.com/D219512
 2024-08-23 16:43:57 +00:00
Mark Banner
71dfbca3a6 Bug 1870226 - Fix missing jsdoc @returns for search code. r=search-reviewers,jteow 
Differential Revision: https://phabricator.services.mozilla.com/D219507
 2024-08-23 16:43:54 +00:00
Butkovits Atila
11a5a23896 Backed out 7 changesets (bug 1870226) for causing build bustages. CLOSED TREE 
Backed out changeset 619244623dba (bug 1870226)
Backed out changeset e85a5647cae4 (bug 1870226)
Backed out changeset 21ea9baf83ea (bug 1870226)
Backed out changeset a506c0f0ce28 (bug 1870226)
Backed out changeset 77c78201a206 (bug 1870226)
Backed out changeset 7a98dfef087f (bug 1870226)
Backed out changeset f64ad89c2406 (bug 1870226)
 2024-08-23 12:22:02 +03:00
Mark Banner
1ee70a0f13 Bug 1870226 - Upgrade eslint-plugin-jsdoc to version 43.2.0. r=frontend-codestyle-reviewers,credential-management-reviewers,issammani 
This switches from the deprecated/removed jsdoc/newline-after-description rule to using the replacement jsdoc/tag-lines rule.

Differential Revision: https://phabricator.services.mozilla.com/D219512
 2024-08-23 08:55:49 +00:00
Mark Banner
52e5a0d84f Bug 1870226 - Fix missing jsdoc @returns for search code. r=search-reviewers,jteow 
Differential Revision: https://phabricator.services.mozilla.com/D219507
 2024-08-23 08:55:47 +00:00
James Teow
eb569539c3 Bug 1909979 - Add ad_popover to components found on SERPs and add the ability to ignore sponsored links - r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D217999
 2024-08-07 18:30:19 +00:00
Stephanie Cunnane
0ecad04d44 Bug 1911117 - Only run browser_search_telemetry_categorization_experiment_info.js for non-artifact builds. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D218363
 2024-08-01 23:04:35 +00:00
Narcis Beleuzu
d6e4988bcf Backed out changeset 18511e925790 (bug 1911117) as req by scunnane 2024-08-02 00:59:26 +03:00
Stephanie Cunnane
0fcad493db Bug 1911117 - Only run browser_search_telemetry_categorization_experiment_info.js for non-artifact builds. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D218363
 2024-08-01 21:38:15 +00:00
Moritz Beier
732359d637 Bug 1881739 - Create a SearchTestUtils function to simplify creating configurations for tests. r=Standard8,mcheang,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D216807
 2024-08-01 01:29:19 +00:00
Masayuki Nakano
528d09c312 Bug 1904279 - Get rid of dom.w3c_pointer_events.dispatch_click_as_pointer_event pref r=smaug,pip-reviewers,search-reviewers,devtools-reviewers,urlbar-reviewers,nchevobbe,dao,jteow,mconley 
Keep supporting the pref makes a lot of `click`, `auxclick` and `contextmenu`
event creators complicated (and look messy).  So, let's delete it as soon as
possible.

Differential Revision: https://phabricator.services.mozilla.com/D217225
 2024-07-30 06:49:42 +00:00
Stephanie Cunnane
267a9c02e8 Bug 1900094 - Add telemetry for impressions missing due to domain-to-categories map issues. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D214868
 2024-07-25 04:49:43 +00:00
Moritz Beier
650113020b Bug 1863530 - Remove browser.search.widget.inNavBar pref. r=dao,settings-reviewers,search-reviewers,omc-reviewers,urlbar-reviewers,Gijs,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D215607
 2024-07-23 17:29:00 +00:00
Stephanie Cunnane
cbe0471b10 Bug 1879667 - Record client's experiment information in the SERP categorization ping. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D209269
 2024-07-17 16:51:12 +00:00
James Teow
419db13c99 Bug 1907097 - Add telemetry for when ads_blocked are counted - r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D216208
 2024-07-16 07:16:42 +00:00
Moritz Beier
12220c0dde Bug 1906875 - Remove the old search engine selector from the search service. r=Standard8,extension-reviewers,urlbar-reviewers,settings-reviewers,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D216047
 2024-07-15 11:15:22 +00:00
Moritz Beier
b0c1584ee2 Bug 1906665 - Intermittent TV browser/components/search/test/browser/browser_searchPanelHeader.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/browser.xhtml]. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D216206
 2024-07-11 07:33:02 +00:00
James Teow
0482ed1f22 Bug 1906945 - Switch to using checkVisibility in child process - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D216082
 2024-07-10 19:51:16 +00:00
Mark Banner
585f1f907b Bug 1822297 - Implement a SearchHistoryResult to remove dependency on satchel and fix deleting items from the search bar history. r=mak,search-reviewers,daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D214956
 2024-07-10 13:10:53 +00:00
Noemi Erli
35d7ea8a75 Backed out changeset d05089c1e269 (bug 1822297) for causing Documentation related failures CLOSED TREE 2024-07-10 13:36:53 +03:00
Mark Banner
7bda04576d Bug 1822297 - Implement a SearchHistoryResult to remove dependency on satchel and fix deleting items from the search bar history. r=mak,search-reviewers,daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D214956
 2024-07-10 09:34:20 +00:00
Cristian Tuns
4a568b94bb Backed out changeset 4d2f43c22de3 (bug 1822297) for causing frequent bc failures in browser_searchbar_default.js CLOSED TREE 2024-07-09 13:10:27 -04:00
Mark Banner
de7dcec0bf Bug 1822297 - Implement a SearchHistoryResult to remove dependency on satchel and fix deleting items from the search bar history. r=mak,search-reviewers,daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D214956
 2024-07-09 15:04:46 +00:00