Commit Graph

202 Commits

Author SHA1 Message Date
Dão Gottwald
f049ccd8d8 Bug 1925842 - Rename _numPinnedTabs to pinnedTabCount. r=tabbrowser-reviewers,jswinarton,dwalker
Also move getDuplicateTabsToClose and getAllDuplicateTabsToClose away from essentials at the top, closer to related methods.

Differential Revision: https://phabricator.services.mozilla.com/D226279
2024-10-21 14:35:06 +00:00
Dão Gottwald
ef8141753b Bug 1923367 - Go back to using the dropdown icon for all-tabs button when it's in the tabs toolbar. r=desktop-theme-reviewers,tabbrowser-reviewers,rpl
Differential Revision: https://phabricator.services.mozilla.com/D224961
2024-10-11 13:45:58 +00:00
Gregory Pappas
8c7823746a Bug 1918681 - part 2: Ensure the list-all-tabs button is visible the first time an extension hides a tab r=extension-reviewers,mconley,dao,willdurand
Depends on D224623

Differential Revision: https://phabricator.services.mozilla.com/D224624
2024-10-09 15:17:13 +00:00
William Durand
79188dd075 Bug 1920706 - Anchor "all-tabs" popup to the extensions button. r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D223318
2024-09-24 17:49:39 +00:00
Adam Vandolder
ac5cc9867a Bug 1734181 - Part 4: Add tests for the backbutton intervention behaviour. r=jjaschke,peterv,dom-core,geckoview-reviewers,extension-reviewers,robwu,owlish
Differential Revision: https://phabricator.services.mozilla.com/D216828
2024-08-24 19:43:32 +00:00
Stefan Richter
551e400b7c Bug 1409262 - Notify when openerTabId changed via tabs.update() r=robwu,dao
Differential Revision: https://phabricator.services.mozilla.com/D164982
2024-08-05 17:49:06 +00:00
William Durand
416ec07269 Bug 1784920 - Add activeTab as permission for tabs.captureVisibleTab API. r=robwu,geckoview-reviewers,amejiamarmol
Differential Revision: https://phabricator.services.mozilla.com/D206882
2024-04-10 14:15:23 +00:00
Dave Townsend
8ca92a1c30 Bug 1864896: Autofix unused function arguments (webextensions). r=extension-reviewers,zombie
Differential Revision: https://phabricator.services.mozilla.com/D202999
2024-03-05 14:21:14 +00:00
Gregory Pappas
c1ec40f95a Bug 1878401 - part 2 - Update nsIFilePicker users in browser/ to pass BrowsingContext to init r=extension-reviewers,settings-reviewers,credential-management-reviewers,Gijs,sgalich,migration-reviewers,mconley,robwu
Depends on D200546

Differential Revision: https://phabricator.services.mozilla.com/D200547
2024-02-28 21:29:37 +00:00
Sandor Molnar
c853f2f3e9 Backed out 8 changesets (bug 1878401, bug 1879041) for causing build bustages on widget/nsBaseFilePicker.cpp CLOSED TREE
Backed out changeset 2e2b8df3bdd6 (bug 1879041)
Backed out changeset 6d6952f9df2c (bug 1878401)
Backed out changeset 30b5bb590d3e (bug 1878401)
Backed out changeset 9a4b830334b9 (bug 1878401)
Backed out changeset 3c3d67f1fcb7 (bug 1878401)
Backed out changeset c83ba4026822 (bug 1878401)
Backed out changeset 6bcb670ce475 (bug 1878401)
Backed out changeset f263b196df96 (bug 1878401)
2024-02-28 17:56:48 +02:00
Gregory Pappas
0428704119 Bug 1878401 - part 2 - Update nsIFilePicker users in browser/ to pass BrowsingContext to init r=extension-reviewers,settings-reviewers,credential-management-reviewers,Gijs,sgalich,migration-reviewers,mconley,robwu
Depends on D200546

Differential Revision: https://phabricator.services.mozilla.com/D200547
2024-02-28 15:07:44 +00:00
Mark Banner
a03d040295 Bug 1864821 - Replace PromiseUtils.defer() with Promise.withResolvers() in extension code. r=extension-reviewers,geckoview-reviewers,rpl,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D197488
2024-01-05 09:22:34 +00:00
Rob Wu
db01c3ea59 Bug 1859490 - Ignore tab events when isAdoptingTab r=zombie
While a tab is being adopted, it may trigger tab events. This currently
triggers errors in the console becausetabManager.getWrapper returns null
in this situation, and the next line dereferences the return value
without null-checking.

To prevent this error from happening, exit early in this situation. This
avoids logspam whenever swapBrowsersAndCloseOther is called before
_clearTabToAdopt, at https://searchfox.org/mozilla-central/rev/76b13c585e575cf273fd05ab3b48a1532c1d1faa/browser/base/content/browser.js#1766-1772

Once `_clearTabToAdopt` is called, `isAdoptingTab()` becomes false.

Differential Revision: https://phabricator.services.mozilla.com/D193254
2023-11-14 16:39:46 +00:00
Gregory Pappas
a57c4f9405 Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol
Differential Revision: https://phabricator.services.mozilla.com/D184623
2023-08-01 23:01:02 +00:00
Gregory Pappas
7b8c07142a Bug 1809094 - Implement tab.autoDiscardable property r=robwu,geckoview-reviewers,extension-reviewers,Gijs,owlish,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D166440
2023-06-21 07:50:17 +00:00
Cosmin Sabou
811d79e739 Backed out changeset f3fe6cc42791 (bug 1809094) for bc failures on browser_ext_tabs_autoDiscardable.js. 2023-06-21 03:24:56 +03:00
Gregory Pappas
ad10790d6e Bug 1809094 - Implement tab.autoDiscardable property r=robwu,geckoview-reviewers,extension-reviewers,Gijs,owlish,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D166440
2023-06-20 23:59:08 +00:00
Sandor Molnar
1e6677e684 Backed out changeset 0ee2d1b2ec37 (bug 1809094) for causing android bustages. CLOSED TREE 2023-06-21 02:20:26 +03:00
Gregory Pappas
b89c0a7e67 Bug 1809094 - Implement tab.autoDiscardable property r=robwu,geckoview-reviewers,extension-reviewers,Gijs,owlish,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D166440
2023-06-20 23:06:37 +00:00
Katherine Patenio
ce9d8a5dad Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 18:44:48 +00:00
Cristian Tuns
f826f1b621 Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
2023-06-19 13:22:35 -04:00
Katherine Patenio
333197cd22 Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 16:46:18 +00:00
ganna
6ae89f2f46 Bug 1814414 - Replace constructed xul label with moz-support-link in ExtensionControlledPopup.jsm r=extension-reviewers,robwu
Differential Revision: https://phabricator.services.mozilla.com/D179835
2023-06-07 14:27:39 +00:00
Rob Wu
f0c7c874d6 Bug 1830814 - Migrate remaining extension jsm files to ESM r=geckoview-reviewers,Standard8,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D179890
2023-06-05 10:23:40 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Gijs Kruitbosch
bc748bee0c Bug 1810141 - switch consumers where there isn't an obvious URI object to use to fixupAndLoadURIString, r=mossop,geckoview-reviewers,extension-reviewers,settings-reviewers,mconley,owlish
This also updates layoutdebug.js, which in some ways pretends to be like a browser window but
is its own special snowflake. I kept the method naming conventions similar to the main
browser window.

Depends on D168394

Differential Revision: https://phabricator.services.mozilla.com/D168395
2023-02-13 23:50:40 +00:00
Cristina Horotan
f062495d94 Backed out 9 changesets (bug 1810141) for several test failures on a CLOSED TREE
Backed out changeset 8781a0d1254d (bug 1810141)
Backed out changeset 131037295784 (bug 1810141)
Backed out changeset 3852fbe290f4 (bug 1810141)
Backed out changeset 118f131a524a (bug 1810141)
Backed out changeset ab5d76846e10 (bug 1810141)
Backed out changeset dce3aa683445 (bug 1810141)
Backed out changeset 4dc41d90dbb3 (bug 1810141)
Backed out changeset 50b57ba1a061 (bug 1810141)
Backed out changeset 569de94781e4 (bug 1810141)
2023-02-13 16:05:30 +02:00
Gijs Kruitbosch
2e04015e9c Bug 1810141 - switch consumers where there isn't an obvious URI object to use to fixupAndLoadURIString, r=mossop,geckoview-reviewers,extension-reviewers,settings-reviewers,mconley,owlish
This also updates layoutdebug.js, which in some ways pretends to be like a browser window but
is its own special snowflake. I kept the method naming conventions similar to the main
browser window.

Depends on D168394

Differential Revision: https://phabricator.services.mozilla.com/D168395
2023-02-13 12:55:25 +00:00
Oriol Brufau
34f47a6359 Bug 1809364 - Make tabs.move on multiple tabs more reliable (2). r=robwu
Bug 1323311 tried to improve browser.tabs.move, but the logic didn't
really make sense (e.g. why use 2 different maps to track indices?),
and it broke moving multiple tabs between windows: they would appear
in the wrong order.

Differential Revision: https://phabricator.services.mozilla.com/D166405
2023-01-19 13:51:31 +00:00
Oriol Brufau
ca1a72c7a6 Bug 1808615 - Make addTab default skipLoad to createLazyBrowser. r=Gijs,extension-reviewers,nika,robwu
And make callers rely on that instead of allowInheritPrincipal when
creating lazy tabs.

Unlike allowInheritPrincipal, skipLoad sets the nodefaultsrc attribute.
This avoids a load instead of falling back to about:blank.

One consequence of that is that switching to a lazy about:blank tab will
not notify invoke listeners registered with addTabsProgressListener
(listeners registered with addProgressListener will still be invoked).

Thus test browser_open_in_lazy_tab.js needs to be updated.

Differential Revision: https://phabricator.services.mozilla.com/D166012
2023-01-07 13:51:47 +00:00
Sandor Molnar
4f5ee6f941 Backed out changeset 2b67bd0dd255 (bug 1808615) for causing bc failures in browser/components/customizableui/test/browser_open_in_lazy_tab.js CLOSED TREE 2023-01-07 03:18:23 +02:00
Oriol Brufau
60b9a931c7 Bug 1808615 - Make addTab default skipLoad to createLazyBrowser. r=Gijs,extension-reviewers,nika,robwu
And make callers rely on that instead of allowInheritPrincipal when
creating lazy tabs.

Differential Revision: https://phabricator.services.mozilla.com/D166012
2023-01-07 00:37:36 +00:00
Gregory Pappas
6c82a9320a Bug 1772166 - Implement 'ZoomSettings.defaultZoomFactor' r=mixedpuppy,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D158731
2023-01-02 13:32:42 +00:00
Gijs Kruitbosch
965c6e86fc Bug 1803158 - convert session restore consumers to reference the sys.mjs files instead, r=webdriver-reviewers,perftest-reviewers,extension-reviewers,credential-management-reviewers,Standard8,sgalich,whimboo,sparky,willdurand
Differential Revision: https://phabricator.services.mozilla.com/D163350
2022-12-06 16:02:03 +00:00
Butkovits Atila
74e26649e5 Backed out changeset 470fffc6ff9a (bug 1772166) for causing failures at browser_ext_webNavigation_onCreatedNavigationTarget.js. CLOSED TREE 2022-12-06 16:44:41 +02:00
Gregory Pappas
31354f56b1 Bug 1772166 - Implement 'ZoomSettings.defaultZoomFactor' r=mixedpuppy,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D158731
2022-12-06 13:22:09 +00:00
Sandor Molnar
adfe63bce9 Backed out changeset 26d4da528112 (bug 1772166) for causing bc failures in browser/components/extensions/test/browser/browser_ext_webNavigation_onCreatedNavigationTarget.js CLOSED TREE 2022-12-05 18:26:15 +02:00
Gregory Pappas
fdcd365e65 Bug 1772166 - Implement 'ZoomSettings.defaultZoomFactor' r=mixedpuppy,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D158731
2022-12-05 14:49:40 +00:00
Mark Banner
19c189e131 Bug 1798212 - Convert consumers of downloads code to ES modules. r=mak,geckoview-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich,mconley,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D161013
2022-11-07 17:56:10 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Mark Banner
a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D158094
2022-09-29 06:52:34 +00:00
Shane Caraveo
cd3dba3928 Bug 1711168 allow extension pages to be loaded as top level tabs by other extensions r=rpl,geckoview-reviewers,calu
Ensure extensions can manage tabs and sessions that include tabs from other extensions.  The parent
patch to this introduces cross-extension access validation.  However that breaks this specific use case
that we need to continue supporting.  This patch modifies three extension apis, tab.create/update and
windows.create to allow the creation of extension tabs which cannot be otherwise accessed.

Differential Revision: https://phabricator.services.mozilla.com/D151766
2022-08-02 17:08:58 +00:00
Butkovits Atila
b01ed36979 Backed out 3 changesets (bug 1711168, bug 1773115) for causing failures at test_ext_web_accessible_resources.html. CLOSED TREE
Backed out changeset 703c909eb009 (bug 1773115)
Backed out changeset 902385a7ce60 (bug 1711168)
Backed out changeset 3d061ce03de7 (bug 1711168)
2022-07-27 00:13:26 +03:00
Shane Caraveo
26d3eac02e Bug 1711168 allow extension pages to be loaded as top level tabs by other extensions r=rpl
Ensure extensions can manage tabs and sessions that include tabs from other extensions.  The parent
patch to this introduces cross-extension access validation.  However that breaks this specific use case
that we need to continue supporting.  This patch modifies three extension apis, tab.create/update and
windows.create to allow the creation of extension tabs which cannot be otherwise accessed.

Differential Revision: https://phabricator.services.mozilla.com/D151766
2022-07-26 19:39:14 +00:00
kernp25
0ee68a9f02 Bug 1770651 - Make sure tabs.update don't use loadURI on a discarded tab. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D149702
2022-07-04 09:10:38 +00:00
Jonathan Watt
b677f00ccc Bug 1769388 - Change nsIPrintSettingsService's 'newPrintSettings' attribute to a 'createNewPrintSettings' function. r=bobowen,webdriver-reviewers,whimboo
Having an attribute be a constructor is just...wrong.

Differential Revision: https://phabricator.services.mozilla.com/D146383
2022-05-16 11:50:34 +00:00
Shane Caraveo
594876b513 Bug 1748567 support persistent events in tabs api r=zombie
Differential Revision: https://phabricator.services.mozilla.com/D140915
2022-03-31 23:29:25 +00:00
Emilio Cobos Álvarez
202fcd0999 Bug 1760836 - Support printing to an nsIOutputStream. r=jfkthame,jrmuizel,webdriver-reviewers,geckoview-reviewers,agi
The trickiest bits are the PrintTargetCG ones, the rest is just plumbing
and cleanups and tests, but let me know if you want those to be split
out, can do.

The GTK change to nsPrintSettingsGTK::GetResolution is a no-op (we only
read resolution on windows), but I did that because we assume that it
doesn't fail and GTK returns a sane default anyways.

Differential Revision: https://phabricator.services.mozilla.com/D142199
2022-03-30 18:51:58 +00:00
Iulian Moraru
7106f0368c Backed out changeset d42d7505c9cf (bug 1760836) for causing mochitest failures on browser_print_stream.js. CLOSED TREE 2022-03-29 23:32:39 +03:00