Commit Graph

945 Commits

Author SHA1 Message Date
Tom Schuster
86f31dc0de Bug 1924466 - Remove inline popupshowing event handler from the overflow customize context menu. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D225505
2024-10-16 08:31:58 +00:00
Tom Schuster
04cd7d9f95 Bug 1924466 - Remove inline command event handlers from the overflow customize context menu. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D225481
2024-10-16 08:31:58 +00:00
Mike Conley
dd4373aecb Bug 1920799 - Add a new messaging surface to the AppMenu and PXI menus for describing the value of signing into an FxA. r=pdahiya,Gijs,desktop-theme-reviewers,omc-reviewers,home-newtab-reviewers,fluent-reviewers,hjones,skhamis,nbarrett
Developing tests in a later patch in this series.

Differential Revision: https://phabricator.services.mozilla.com/D223409
2024-10-15 16:15:09 +00:00
Florian Quèze
165920b94c Bug 1918702 - Migrate telemetry events to use Glean APIs for password manager, r=chutten,settings-reviewers,credential-management-reviewers,mossop,mtigley,dimi.
Differential Revision: https://phabricator.services.mozilla.com/D222608
2024-09-25 10:00:41 +00:00
Sandor Molnar
5095328e2d Backed out 5 changesets (bug 1918702) for causing bc failures @ browser_aaa_eventTelemetry_run_first.js CLOSED TREE
Backed out changeset f55480885aeb (bug 1918702)
Backed out changeset db1eaf09430d (bug 1918702)
Backed out changeset a9179f6e684d (bug 1918702)
Backed out changeset f9d3349e6fe3 (bug 1918702)
Backed out changeset 10d2957bbfe8 (bug 1918702)
2024-09-25 12:38:05 +03:00
Florian Quèze
3cf2dde6da Bug 1918702 - Migrate telemetry events to use Glean APIs for password manager, r=chutten,settings-reviewers,credential-management-reviewers,mossop,mtigley,dimi.
Differential Revision: https://phabricator.services.mozilla.com/D222608
2024-09-25 07:19:05 +00:00
timw-dev
84076b9d83 Bug 1896764 - onViewToolbarsPopupShowing and ToolbarContextMenu should move out of browser.js.r=scunnane,rpl
Differential Revision: https://phabricator.services.mozilla.com/D217795
2024-08-22 11:11:50 +00:00
Tom Schuster
728dc2abf5 Bug 1904029 - Correctly init View > Toolbars in the menubar. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D214543
2024-06-21 15:11:46 +00:00
Dão Gottwald
25644d743c Bug 1902314 - Consolidate toolbarpaletteitem rules. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D213590
2024-06-17 16:26:14 +00:00
Tom Schuster
a8c9401904 Bug 1893068 - Remove command inline event handlers from the menubar. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D212246
2024-06-14 21:08:03 +00:00
Gijs Kruitbosch
004090bf97 Bug 1890718 - move bookmark and library panelview event handling to not use inline event attributes, r=places-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D207881
2024-04-23 15:21:21 +00:00
Gijs Kruitbosch
efe284f711 Bug 1890718 - remove hamburger menu mainview inline command listeners, r=mossop,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D207120
2024-04-15 23:23:51 +00:00
Gijs Kruitbosch
f63cdcf1d7 Bug 1890718 - driveby: remove outdated mentions of proton, r=mossop,desktop-theme-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D207119
2024-04-15 23:23:50 +00:00
Cosmin Sabou
d17bfe39f8 Backed out 3 changesets (bug 1890718) for failing sevaral UI related bc tests. CLOSED TREE
Backed out changeset 3d91014dfcef (bug 1890718)
Backed out changeset 8c09e2028ad9 (bug 1890718)
Backed out changeset ff91ebffa8ab (bug 1890718)
2024-04-15 21:11:48 +03:00
Gijs Kruitbosch
9d2dbb58f2 Bug 1890718 - remove hamburger menu mainview inline command listeners, r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D207120
2024-04-15 14:45:51 +00:00
Gijs Kruitbosch
bee5c98c47 Bug 1890718 - driveby: remove outdated mentions of proton, r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D207119
2024-04-15 14:45:51 +00:00
Yi Xiong Wong
03a2372d77 Bug 1880914 - Move BrowserOpenAddonsMgr. r=Gijs,extension-reviewers,settings-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,robwu,thecount
Differential Revision: https://phabricator.services.mozilla.com/D207110
2024-04-15 10:22:46 +00:00
Emily McMinn
d4f51984fa Bug 1724300 - Remove What's New Panel, ToolbarPanelHub components & related tests & references r=desktop-theme-reviewers,omc-reviewers,aminomancer,pdahiya,emilio,devtools-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201867
2024-03-21 22:05:28 +00:00
Dave Townsend
a0c83bc943 Bug 1864896: Autofix unused function arguments (browser). r=webcompat-reviewers,mconley,fxview-reviewers,desktop-theme-reviewers,omc-reviewers,migration-reviewers,twisniewski,aminomancer,dao,sclements,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D203005
2024-03-19 09:36:35 +00:00
Mike Conley
4c988cb8f1 Bug 1878731 - Convert ToolbarPanelHub to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201124
2024-02-12 18:49:34 +00:00
Mike Conley
19a6e40b11 Bug 1877196 - Move ToolbarPanelHub.jsm to browser/components/asrouter. r=pdahiya,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200082
2024-02-05 22:03:13 +00:00
Itiel
cd3ef922f3 Bug 1869574 - Refactor the headerText setter to cater for more panelview needs r=twisniewski,Gijs,translations-reviewers
This introduces `mainview-with-header` attribute for panels that their
mainview should have a header (no matter where they appear); and
`has-custom-header` for panels that their panelview (not necessarily a
mainview) has a custom design for a header, one that headerText setter
can't anticipate in advance (due to UX needs that may arise).
If one of these attributes are set on the panel, this signals headerText
that the panelview's header should NOT be removed and that the markup
should be respected.

Differential Revision: https://phabricator.services.mozilla.com/D196671
2024-01-09 17:01:25 +00:00
Gijs Kruitbosch
87fba25ea4 Bug 1866503 - closing menupopups/panels inside panelviews in temporary PanelUI panels should not close those panels, r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D194632
2023-11-27 23:27:36 +00:00
Iulian Moraru
df1ac624b2 Backed out changeset 49b89e35b5f5 (bug 1866503) for causing multiple bc failures related to panelUI. CLOSED TREE 2023-11-27 15:39:13 +02:00
Gijs Kruitbosch
ae5f8336a8 Bug 1866503 - closing menupopups/panels inside panelviews in temporary PanelUI panels should not close those panels, r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D194632
2023-11-27 12:14:03 +00:00
Emilio Cobos Álvarez
f3634c1549 Bug 1863724 - Improve alignment of customization mode footer items. r=dao,desktop-theme-reviewers
On Linux it doesn't look as bad without this, but on macOS it's very
noticeable.

This ensures that items are properly centered.

The flex display / alignment of the link isn't needed (it only has text
anyways).

Differential Revision: https://phabricator.services.mozilla.com/D193784
2023-11-16 14:44:21 +00:00
Emilio Cobos Álvarez
d45fa4cc60 Bug 1855875 - Rename panel-footer-button to footer-button, and use them for customize mode footer too. r=dao,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D189630
2023-10-23 15:51:37 +00:00
Cristina Horotan
c1f4823686 Backed out changeset 6d11e2f54668 (bug 1855875) for causing bug 1856697 2023-10-04 18:46:25 +03:00
Emilio Cobos Álvarez
253a8284f6 Bug 1855875 - Rename panel-footer-button to footer-button, and use them for customize mode footer too. r=dao,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D189630
2023-10-02 16:51:52 +00:00
Itiel
213e2bd9a9 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-06-14 17:16:39 +00:00
Iulian Moraru
ff572127aa Backed out changeset 76c5afdda762 (bug 1830679) for causing xpcshell failures on test_VariablesView_filtering-without-controller.js. CLOSED TREE 2023-06-12 22:03:43 +03:00
Itiel
548aeccf66 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-06-12 17:16:35 +00:00
Shane Hughes
6da3c5e401 Bug 1831906 - Add release notes link to update modal prompts. r=bytesized,omc-reviewers,application-update-reviewers,jprickett
Differential Revision: https://phabricator.services.mozilla.com/D177410
2023-06-08 15:48:01 +00:00
William Durand
ffdc71c1cd Bug 1833438 - Add support for notifications in the extensions panel. r=Itiel,rpl,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D179345
2023-05-30 20:07:39 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Katherine Patenio
2e593c5af4 Bug 1830419 - Convert PanelMutiView.jsm and CustomizableUITestUtils.jsm in browser/components/customizableui to ESMs r=search-reviewers,Standard8,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D178362
2023-05-18 18:34:51 +00:00
Iulian Moraru
9a36d620f9 Backed out changeset bbb3bbd9b6af (bug 1830679) for causing dt failures on browser_storage_cache_delete.js. CLOSED TREE 2023-05-18 22:09:25 +03:00
Itiel
801dad3de3 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-05-18 17:19:45 +00:00
Emilio Cobos Álvarez
c5fe100d61 Bug 1821376 - Fix interactions of overflow menu with modern flexbox migration. r=Gijs
Customize mode was already using display: flex, so the migration caused
some interesting interactions.

In particular -moz-box-flex: 1 rules had no effect at all, so remove
them (same for the flex="" attribute).

Un-flex items in the overflow menu so that they don't spread too much.

Use flex: 1 in the customization-content-container to reset flex-shrink
to 1 (XUL flex didn't allow shrinking by default, so xul.css has
flex-shrink: 0).

Differential Revision: https://phabricator.services.mozilla.com/D172144
2023-03-10 13:21:23 +00:00
Emilio Cobos Álvarez
4191621d17 Bug 1821387 - Don't use vbox on panel headers. r=Gijs
While at it remove useless display declaration too.

vbox was setting -moz-box-orient: vertical, but that had no effect
because it had display: flex explicitly.

Differential Revision: https://phabricator.services.mozilla.com/D172145
2023-03-09 20:18:47 +00:00
Mark Banner
2bd093b567 Bug 1811334 - Automatically replace Cu.reportError with console.error (most of browser/components). r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D167297
2023-01-20 17:49:21 +00:00
Itiel
c5c7610894 Bug 1577257 - Share logic behind panel headers across the UI r=willdurand,Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D160972
2022-11-17 21:34:34 +00:00
Mike Conley
d4d3af9877 Bug 1782203 - Add context menu items for pinning and unpinning addon buttons to the toolbar. r=willdurand,extension-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D161200
2022-11-15 16:37:23 +00:00
Stanca Serban
7abed322ee Backed out 3 changesets (bug 1782203) for causing lint failures on browser_unified_extensions_overflowable_toolbar.js. CLOSED TREE
Backed out changeset 50e57afebed3 (bug 1782203)
Backed out changeset d17ea376ed45 (bug 1782203)
Backed out changeset e91d51f1ce90 (bug 1782203)
2022-11-15 17:42:22 +02:00
Mike Conley
55af77e9ed Bug 1782203 - Add context menu items for pinning and unpinning addon buttons to the toolbar. r=willdurand,extension-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D161200
2022-11-15 15:02:08 +00:00
Csoregi Natalia
1ce4bb73a7 Backed out 4 changesets (bug 1782203, bug 1777484) for failures on browser_unified_extensions_overflowable_toolbar.js. CLOSED TREE
Backed out changeset ae47d92443a7 (bug 1782203)
Backed out changeset 0c90b1d40e9f (bug 1782203)
Backed out changeset 4b4cae098ea0 (bug 1782203)
Backed out changeset 75eba3b7a626 (bug 1777484)
2022-11-15 03:06:21 +02:00
Mike Conley
70738f0144 Bug 1782203 - Add context menu items for pinning and unpinning addon buttons to the toolbar. r=willdurand,extension-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D161200
2022-11-14 22:41:09 +00:00
William Durand
3ff97c57e6 Bug 1799842 - Move all the lists inside the same container in the unified extensions panel. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D161668
2022-11-09 16:32:45 +00:00
Mike Conley
e04f7d728c Bug 1797836 - Part 3: Add a new AREA_ADDONS for the Unified Extensions panel. r=Gijs
This area doesn't have any special rules applied yet, nor can it have items moved to
it except programmatically. All of that will come later, including tests.

Differential Revision: https://phabricator.services.mozilla.com/D161079
2022-11-08 14:51:40 +00:00
Mike Conley
c759904dae Bug 1797836 - Part 2: Update CUI to have a general TYPE_PANEL instead of TYPE_MENU_PANEL. r=desktop-theme-reviewers,dao,sclements
Long ago, the menu panel in was a customizable area that users could drag things into.

That changed back around 2017 in bug 1354117 when the Photon redesign was built. The
menu panel become a static menu, but we also made it possible to permanently move things
to the overflow panel of the nav-bar.

It looks like we never updated the area type constant from referring to the old menu panel
though, so it's "TYPE_MENU_PANEL", and registering a node for it happens with
registerMenuPanel. This patch changes to constant to TYPE_PANEL and updates the registration
method to registerPanelNode.

I a check around the codebase as well as GitHub looking to see if there were any
system add-ons or experimental WebExtensions that rely on TYPE_MENU_PANEL / registerMenuPanel,
but I couldn't find any.

Differential Revision: https://phabricator.services.mozilla.com/D161078
2022-11-08 14:51:40 +00:00