corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
870,590 Commits 1 Branch 0 Tags
12ead799a26096ef89c00362afdcc38c5a3520b6
Commit Graph

55 Commits

Author SHA1 Message Date
Kelly Cochrane
12ead799a2 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D217504
 2024-08-02 19:27:10 +00:00
Noemi Erli
aa53f7828b Backed out changeset b825b6411765 (bug 1906140) for causing failures in browser_view_sidebar_menu.js CLOSED TREE 2024-08-02 22:17:11 +03:00
Kelly Cochrane
3f0ff02121 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D217504
 2024-08-02 18:32:38 +00:00
Sandor Molnar
62ae38bb63 Backed out changeset 3b4a3a45aa1a (bug 1906140) @ browser_sidebar_prefs.js CLOSED TREE 2024-08-01 04:21:31 +03:00
Kelly Cochrane
6f31e3a9a9 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D217504
 2024-08-01 00:34:29 +00:00
Sandor Molnar
daa46360f2 Backed out changeset 086cdcffa062 (bug 1906140) for causing bc failures @ browser_sidebar_prefs.js CLOSED TREE 2024-08-01 00:37:35 +03:00
Kelly Cochrane
466cbf628a Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D217504
 2024-07-31 21:02:05 +00:00
Jonathan Sudiaman
93a0b7bce5 Bug 1900979 - Fix empty strings assigned in Sidebar.ftl r=sidebar-reviewers,fluent-reviewers,kcochrane 
The empty strings were used as a workaround to clear out labels when switching from expanded to collapsed state. This really should have been the component's responsibility.

Differential Revision: https://phabricator.services.mozilla.com/D218087
 2024-07-31 15:18:42 +00:00
Sarah Clements
7ea40f53e4 Bug 1899336 - Position pinned tabs and new tab button for vertical tabs mode r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,kcochrane 
* Create a new container to house pinned tabs, new tab button and non-pinned tabs
* Create new pinned tabs container to apply grid layout and overflow scrolling
* Update test coverage for pinned tabs for both horizontal and vertical tabs

Differential Revision: https://phabricator.services.mozilla.com/D215482
 2024-07-29 11:30:37 +00:00
Jonathan Sudiaman
4976e075f8 Bug 1886408 - History in sidebar: Remove row limit, fix empty state, add hover button. r=sidebar-reviewers,desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,kcochrane,nsharpley 
- max-history-rows pref set to 0 for Nightly only.
- Add the X button to close a tab on hover.
- Introduce an extension to `fxview-tab-list` which handles the differences between here and FxView.
- Reuse the empty state for when history is cleared (same as firefox view).
- Update the logic of `fxview-empty-state` to allow for opening prefs link in the parent window (instead of the sidebar browser).

Differential Revision: https://phabricator.services.mozilla.com/D217111
 2024-07-25 16:03:17 +00:00
Matthew_Cash
a8fbb156bd Bug 1900282 - Apply browser.tabs.allow_transparent_browser pref to sidebar browsers. r=dao,sidebar-reviewers,sclements,sfoster 
This change allows users to remove the opaque background from the
sidebar, enabling sidebar backgrounds to be fully transparent when used
alongside a userChrome.css that provides transparency.
This is purely an aesthetic option for use with custom themes and a
continuation of Bug 28354.

Differential Revision: https://phabricator.services.mozilla.com/D212385
 2024-07-15 15:06:56 +00:00
Kelly Cochrane
b40657ff11 Bug 1897976 - Update existing tests involving sidebar-button in the nav bar for when sidebar.revamp pref is flipped on r=places-reviewers,sidebar-reviewers,urlbar-reviewers,mak,sfoster,Gijs,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D215253
 2024-07-12 15:58:29 +00:00
Luca Greco
3ae0a96b30 Bug 1905771 - switcherTarget element label set by SidebarController.registerExtension is still set when switching to a non extension sidebar. r=willdurand,sidebar-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D215945
 2024-07-10 17:52:30 +00:00
Ed Lee
e7565e634f Bug 1906122 - Selecting AI Chatbot or extensions with old sidebar panel switcher when already on that panel closes the sidebar r=sidebar-reviewers,nsharpley 
Detect menu usage as checkbox or not to toggle or show.

Differential Revision: https://phabricator.services.mozilla.com/D215797
 2024-07-04 21:06:53 +00:00
Ed Lee
1bac981cb5 Bug 1900915 - Include chat as tool for new sidebar r=sidebar-reviewers,sclements 
Update default tool ordering. Conditionally render tool if not hidden for both main and customize.

Differential Revision: https://phabricator.services.mozilla.com/D215721
 2024-07-04 14:44:11 +00:00
Gijs Kruitbosch
40e851d728 Bug 1905692 - use JS to handle activation/click of sidebar close button in non-revamped sidebar, r=sidebar-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D215379
 2024-07-01 19:40:55 +00:00
Jonathan Sudiaman
fec725412b Bug 1892430 - Add a "Hide" sidebar visibility setting r=sidebar-reviewers,sessionstore-reviewers,sclements 
The toggle was there to begin with, but this commit actually gets it working to spec.

Differential Revision: https://phabricator.services.mozilla.com/D214181
 2024-06-27 19:34:08 +00:00
Jonathan Sudiaman
52e63f2908 Bug 1892941 - Add a "Always Show" sidebar visibility setting r=sidebar-reviewers,fluent-reviewers,sessionstore-reviewers,bolsson,sclements,reusable-components-reviewers,mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D212285
 2024-06-27 19:34:08 +00:00
Nikki Sharpley
60f464ed8e Bug 1892957 - Add sidebar position settings to the Customize Sidebar menu r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,sessionstore-reviewers,kcochrane,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D213591
 2024-06-21 18:15:25 +00:00
Cristian Tuns
ecab83f214 Backed out changeset bd06757d8344 (bug 1892957) for causing mochitest failures in browser_sidebar_move.js CLOSED TREE 2024-06-21 11:40:07 -04:00
Nikki Sharpley
72b2fd0ee7 Bug 1892957 - Add sidebar position settings to the Customize Sidebar menu r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,sessionstore-reviewers,kcochrane,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D213591
 2024-06-21 14:00:00 +00:00
Sarah Clements
92d796abdd Bug 1893655 - Set up the tabstrip to work vertically r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,Gijs 
* Add ability to move tabstrip into the sidebar based on a pref

Differential Revision: https://phabricator.services.mozilla.com/D212287
 2024-06-15 10:43:19 +00:00
Ed Lee
3cefd95d0b Bug 1899827 - Stub initial conditional sidebar depending on chat pref r=tarek,fluent-reviewers,desktop-theme-reviewers,sidebar-reviewers,flod,sclements 
Add placeholder chat page that is shown in old sidebar when pref is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D212756
 2024-06-15 01:48:55 +00:00
Iulian Moraru
7af9a3a07c Backed out changeset 7c5bb1ba9d20 (bug 1893655) for causing bc failures on browser_vertical_tabs.js. 2024-06-14 18:43:35 +03:00
Sarah Clements
4758236bb0 Bug 1893655 - Set up the tabstrip to work vertically r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,Gijs 
* Add ability to move tabstrip into the sidebar based on a pref

Differential Revision: https://phabricator.services.mozilla.com/D212287
 2024-06-14 13:01:40 +00:00
Nikki Sharpley
dfc9c84b23 Bug 1891777 - Add a tools pref to the sidebar revamp r=sidebar-reviewers,kcochrane 
Rather than persisting via SessionStore, as the original bug suggests, use a pref to globally
store the disabled/enabled state of the sidebar tools.

Not entirely unrelated, I added a test for adopting the sidebar from an opener window as well.

Differential Revision: https://phabricator.services.mozilla.com/D212853
 2024-06-12 15:06:01 +00:00
Tamas Szentpeteri
795db7bf00 Backed out changeset 8c48512a48de (bug 1891777) for causing mochitest failures on browser_sidebar_prefs.js 2024-06-12 17:36:22 +03:00
Nikki Sharpley
c5c36beb8e Bug 1891777 - Add a tools pref to the sidebar revamp r=sidebar-reviewers,kcochrane 
Rather than persisting via SessionStore, as the original bug suggests, use a pref to globally
store the disabled/enabled state of the sidebar tools.

Not entirely unrelated, I added a test for adopting the sidebar from an opener window as well.

Differential Revision: https://phabricator.services.mozilla.com/D212853
 2024-06-12 13:22:13 +00:00
Kelly Cochrane
2858cd5222 Bug 406629 - Setting sidebar max-width to 75 percent of viewport width r=sidebar-reviewers,Gijs,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D211440
 2024-06-12 12:06:32 +00:00
Nikki Sharpley
0f28ad6176 Bug 1901262 - Add test for adopting the sidebar from the opener window r=sidebar-reviewers,sfoster 
It was recommended in https://phabricator.services.mozilla.com/D210218 that we have a
test for checking the sidebar is correctly adopted from the opener window when opening
an additional window.

Differential Revision: https://phabricator.services.mozilla.com/D212951
 2024-06-11 13:48:46 +00:00
Nikki Sharpley
f60a47f6c5 Bug 1895868 - Sidebar should not be visible in popup windows r=sidebar-reviewers,sessionstore-reviewers,sfoster,kcochrane 
- hides sidebar on popup window
- disabled sidebar menu options in View, hence disabling keyboard shortcuts

Differential Revision: https://phabricator.services.mozilla.com/D212597
 2024-06-10 22:44:53 +00:00
Tamas Szentpeteri
1b4d233427 Backed out changeset 4ab23ba75a11 (bug 1895868) for causing mochitest failures on browser_history_sidebar.js 2024-06-10 21:55:16 +03:00
Nikki Sharpley
878b2fc533 Bug 1895868 - Sidebar should not be visible in popup windows r=sidebar-reviewers,sessionstore-reviewers,sfoster,kcochrane 
- hides sidebar on popup window
- disabled sidebar menu options in View, hence disabling keyboard shortcuts

Differential Revision: https://phabricator.services.mozilla.com/D212597
 2024-06-10 17:37:11 +00:00
Ed Lee
93d51ae3f5 Bug 1894990 - Re-work logic for adding Megalist to sidebar to align with revamped sidebar r=mtigley,sidebar-reviewers,kcochrane 
Consolidate custom megalist sidebar logic to a helper for pref-controlled sidebars.

Differential Revision: https://phabricator.services.mozilla.com/D212240
 2024-06-05 18:59:31 +00:00
Kelly Cochrane
0f32bd57a5 Bug 1896623 - Ensure 'customize sidebar' option isn't added to menu bar View > Sidebars menu r=sidebar-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D210853
 2024-05-30 14:08:34 +00:00
Jonathan Sudiaman
6ccee8c69b Bug 1892429 - Create an expanded sidebar state r=sidebar-reviewers,fluent-reviewers,kcochrane,sclements,extension-reviewers,robwu 
Adds an `expanded` property, which, if enabled, shows labels along with their respective icons within the sidebar menu. Currently, this property is not controllable from the UI. As I understand it, the follow-up bugs are responsible for addressing that.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f269729808eed19051bea5fe4eb41550ff94ce03

Differential Revision: https://phabricator.services.mozilla.com/D210187
 2024-05-28 15:55:49 +00:00
Nikki Sharpley
f2f0a26b06 Bug 1892033 - Move sidebar style persistence from XULstore to SessionStore r=sidebar-reviewers,sessionstore-reviewers,backup-reviewers,dao,Gijs,sclements,kpatenio 
Move style persistence from XULstore to SessionStore.

Follow up bug to fix persistence of sidebar when only a new tab is open and window is closed, and its
accompanying test `browser_sidebar_persist.js`: Bug 1898613

Depends on D207048

Differential Revision: https://phabricator.services.mozilla.com/D207787
 2024-05-24 20:16:31 +00:00
Kelly Cochrane
8f3ea55cfc Bug 1894221 - Add Sidebar Extensions section to Customize Sidebar menu r=sidebar-reviewers,fluent-reviewers,bolsson,sclements,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D210381
 2024-05-21 14:00:03 +00:00
Kelly Cochrane
67d49fd057 Bug 1892012 - Add toolbar entry point for the sidebar as a default setting r=sidebar-reviewers,Gijs,mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D209978
 2024-05-17 16:37:16 +00:00
Kelly Cochrane
0b3b1956ca Bug 1896658 - Add bookmarks to sidebar customization panel r=sidebar-reviewers,fluent-reviewers,nsharpley,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D210378
 2024-05-15 19:48:00 +00:00
Nikki Sharpley
f0a31cbd25 Bug 1893505 - Add custom right-click menu to sidebar extension r=sidebar-reviewers,fluent-reviewers,Gijs,sfoster 
This patch creates a new context menu for the revamped sidebar, including existing
options for managing extensions. We should be able to build off the `onSidebarPopupShowing`
function to customize what we want to show based on what sidebar item we right click.

Differential Revision: https://phabricator.services.mozilla.com/D208951
 2024-05-15 14:30:31 +00:00
Kelly Cochrane
6fddd3893a Bug 1891775 - Create a 'Customize Sidebar' menu with default options r=desktop-theme-reviewers,sidebar-reviewers,fluent-reviewers,jsudiaman,bolsson,sclements,flod,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D208003
 2024-05-09 02:12:39 +00:00
Stanca Serban
cf6b65c339 Backed out changeset dbbb4693be30 (bug 1891775) for causing build bustages. 2024-05-09 04:45:45 +03:00
Kelly Cochrane
d64f7640d8 Bug 1891775 - Create a 'Customize Sidebar' menu with default options r=desktop-theme-reviewers,sidebar-reviewers,fluent-reviewers,jsudiaman,bolsson,sclements,flod,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D208003
 2024-05-09 01:09:03 +00:00
Narcis Beleuzu
22450b69b2 Backed out changeset 15f3e112994e (bug 1891775) for bc failure on browser_all_files_referenced.js . CLOSED TREE 2024-05-09 03:15:20 +03:00
Kelly Cochrane
f406cde6ea Bug 1891775 - Create a 'Customize Sidebar' menu with default options r=desktop-theme-reviewers,sidebar-reviewers,fluent-reviewers,jsudiaman,bolsson,sclements,flod,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D208003
 2024-05-08 21:18:04 +00:00
Jonathan Sudiaman
346e359bf1 Bug 1893672 - Extensions in revamped sidebar aren't being disabled/enabled as expected r=kcochrane,sidebar-reviewers 
A subtle regression was introduced by D207034, which allows for tools to be appended dynamically, but this caused extensions to be appended twice - once by initialization, and again by calling registerExtension(). Update to account for this potential race condition.

Differential Revision: https://phabricator.services.mozilla.com/D209579
 2024-05-07 21:47:24 +00:00
Nikki Sharpley
b43107b445 Bug 1885894 - Remove sidebar persistence from XULStore r=sessionstore-reviewers,backup-reviewers,sidebar-reviewers,Gijs,mconley,sfoster,sclements 
Since we are moving away from XUL for the revamped sidebar, remove persistence off of XULstore.
For now, this involves moving persistence of "sidebar-command" and "positionend" to SessionStore.

A follow up bug 1892033 for moving the style attribute to SessionStore has been filed. This is slightly more involved,
hence the separate patch.

Differential Revision: https://phabricator.services.mozilla.com/D207048
 2024-05-06 15:11:20 +00:00
Sarah Clements
fb5818e268 Bug 1892965 - Rename SidebarUI and SidebarLauncher r=sidebar-reviewers,places-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D208901
 2024-05-03 15:20:15 +00:00
Norisz Fay
a2156ad63a Backed out changeset 75c44ff76360 (bug 1892965) for causing multiple failures 2024-05-01 22:58:27 +03:00