Commit Graph

85 Commits

Author SHA1 Message Date
Eric Chen
12d512a370 Bug 1956096 - refactor start-up UI window handling into its own function r=mossop,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D242813
2025-04-01 20:40:20 +00:00
Mark Banner
878a5d5415 Bug 1951652 - Convert browser/components/search/ modules to use moz-src uris. r=search-reviewers,scunnane
Differential Revision: https://phabricator.services.mozilla.com/D240333
2025-03-05 09:24:37 +00:00
kernp25
cb1f1d5155 Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth
Differential Revision: https://phabricator.services.mozilla.com/D233071
2025-02-10 15:24:32 +00:00
Moritz Beier
3ef77c7282 Bug 1880913 - Part 2: Move search request handling from browser.js to SearchUIUtils. r=search-reviewers,firefox-desktop-core-reviewers ,mossop,scunnane
Differential Revision: https://phabricator.services.mozilla.com/D235596
2025-02-04 11:07:11 +00:00
Butkovits Atila
b061588f31 Backed out changeset 2c11770a86dc (bug 1939658) for causing failures at test_JsonSchemaValidator.js. CLOSED TREE 2025-02-04 13:07:29 +02:00
kernp25
cd2f76670a Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth
Differential Revision: https://phabricator.services.mozilla.com/D233071
2025-02-04 08:25:28 +00:00
Meg Viar
3bd09d7884 Bug 1941350 - Add preonboarding modal Nimbus feature r=firefox-desktop-core-reviewers ,omc-reviewers,negin
- Add `preonboarding` Nimbus feature for showing a window modal over about:welcome that cannot be dismissed via ESC
- Include the ability to suppress showing the privacy notice tab on first run using a variable under the new `preonboarding` feature
- Remove legacy `showModal` related `aboutwelcome` Nimbus feature variables (these are not in use and were for [[ https://experimenter.services.mozilla.com/nimbus/window-modal-vs-tab-modal/summary | an old experiment ]])

Differential Revision: https://phabricator.services.mozilla.com/D234039
2025-01-17 15:18:15 +00:00
Stanca Serban
b272d96a83 Backed out changeset 7ebf2aee0c7b (bug 1941350) for causing xpcshell failures in test_TelemetryReportingPolicy.js. CLOSED TREE 2025-01-16 19:51:43 +02:00
Meg Viar
9317d6a34e Bug 1941350 - Add TOU preonboarding modal Nimbus feature r=firefox-desktop-core-reviewers ,omc-reviewers,negin
- Add `preonboarding` Nimbus feature for showing a window modal over about:welcome that cannot be dismissed via ESC
- Include the ability to suppress showing the privacy notice tab on first run using a variable under the new `preonboarding` feature
- Remove legacy `showModal` related `aboutwelcome` Nimbus feature variables (these are not in use and were for [[ https://experimenter.services.mozilla.com/nimbus/window-modal-vs-tab-modal/summary | an old experiment ]])

Differential Revision: https://phabricator.services.mozilla.com/D234039
2025-01-16 16:00:13 +00:00
Meg Viar
5567720814 Bug 1933293 - Rework aboutWelcome modal behavior to still show about:welcome page and make requiring action to proceed configurable r=firefox-desktop-core-reviewers ,mossop,pdahiya
This patch updates the logic that prevents about:welcome from showing when the Nimbus `aboutWelcome` `showModal` variable is set to true. If separate screens for the modal are provided, it can now be shown on top of the default onboarding flow in about:welcome.

A `requireAction` variable that sets the modal to be a window modal requiring action (other than pressing ESC) to dismiss is also added to the `aboutWelcome` Nimbus feature

Differential Revision: https://phabricator.services.mozilla.com/D230185
2024-12-18 19:04:43 +00:00
Logan Rosen
d24c9d9ff4 Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D230598
2024-11-29 15:18:25 +00:00
Eric Chen
2daa769911 Bug 1917651 - Add a shutdown blocker to ensure update ping will be sent before Firefox exits r=bytesized,firefox-desktop-core-reviewers ,mossop
Differential Revision: https://phabricator.services.mozilla.com/D227396
2024-11-20 16:20:04 +00:00
Ray Kraesig
019b52df2e Bug 1929474 - [2/2] Document (some) other uses of Win10 tablet mode r=win-reviewers,firefox-desktop-core-reviewers ,handyman,mossop
Document remaining uses of Win10 tablet-mode detection which do not fall
under other bugs.

In particular, we leave alone:
  * `IsTabletDevice` in WinUtils.cpp. This falls under bug 1735765.
  * Uses in WinIMEHandler.{h,cpp}. These fall under bug 1929630.

No functional changes.

Differential Revision: https://phabricator.services.mozilla.com/D228206
2024-11-14 18:01:43 +00:00
Ray Kraesig
28f8d3d9cf Bug 1819421 - [1/2] create parallel check for Win11 tablet mode r=win-reviewers,Gijs,gsvelto,gstoll
Win11's tablet mode is different from Win10's tablet mode in ways both
subtle and gross. Avoid unifying them implicitly, and make it clear that
they should not be unified _explicitly_ without testing.

Unfortunately, Windows 11's API for checking whether the device is in
tablet mode is broken -- it requires one to know whether the device is a
tablet to interpret the return value, but there is no documented API
providing that information. We use a heuristic partly borrowed from
Chromium and partly based on independent investigation.

As all of the code using WindowsUIUtils effectively only checked for
Win10's tablet mode, this commit technically has no functional
changes.

Differential Revision: https://phabricator.services.mozilla.com/D224244
2024-11-04 13:56:20 +00:00
Butkovits Atila
24b71f7279 Backed out 2 changesets (bug 1819421) for causing linting failures at browser.js. CLOSED TREE
Backed out changeset b4f770bfe94c (bug 1819421)
Backed out changeset b11774655311 (bug 1819421)
2024-11-01 19:43:00 +02:00
Ray Kraesig
16f10abebe Bug 1819421 - [1/2] create parallel check for Win11 tablet mode r=win-reviewers,Gijs,gsvelto,gstoll
Win11's tablet mode is different from Win10's tablet mode in ways both
subtle and gross. Avoid unifying them implicitly, and make it clear that
they should not be unified _explicitly_ without testing.

Unfortunately, Windows 11's API for checking whether the device is in
tablet mode is broken -- it requires one to know whether the device is a
tablet to interpret the return value, but there is no documented API
providing that information. We use a heuristic partly borrowed from
Chromium and partly based on independent investigation.

As all of the code using WindowsUIUtils effectively only checked for
Win10's tablet mode, this commit technically has no functional
changes.

Differential Revision: https://phabricator.services.mozilla.com/D224244
2024-11-01 16:32:08 +00:00
Florian Quèze
67d22ade73 Bug 1923028 - Migrate scalars to use Glean APIs for os.environment.*, r=chutten,mconley.
Differential Revision: https://phabricator.services.mozilla.com/D225985
2024-10-19 07:54:51 +00:00
Norisz Fay
aee1a52659 Backed out 4 changesets (bug 1923028) for causing bc failures on browser_glean_metrics_exist.js CLOSED TREE
Backed out changeset 6f41dbd872e2 (bug 1923028)
Backed out changeset b6774d5247f5 (bug 1923028)
Backed out changeset 6db21856f4de (bug 1923028)
Backed out changeset 0de824b926d6 (bug 1923028)
2024-10-19 02:25:49 +03:00
Florian Quèze
444cfaad1b Bug 1923028 - Migrate scalars to use Glean APIs for os.environment.*, r=chutten,mconley.
Differential Revision: https://phabricator.services.mozilla.com/D225985
2024-10-18 20:24:29 +00:00
Chris H-C
724b00c304 Bug 1920562 - Remove JS uses of Services.telemetry.setEventRecordingEnabled r=florian,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,sessionstore-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,urlbar-reviewers,sfoster,nchevobbe,valentin,Gijs,dimi,lina,mconley,pdahiya,willdurand
Differential Revision: https://phabricator.services.mozilla.com/D223833
2024-10-08 20:14:42 +00:00
Sandor Molnar
92076e16a7 Backed out 5 changesets (bug 1920562) for causing xpc assertion failures. CLOSED TREE
Backed out changeset 8f085ab589a8 (bug 1920562)
Backed out changeset 4405387ae770 (bug 1920562)
Backed out changeset a68fd13a33ae (bug 1920562)
Backed out changeset cd3672fc08ed (bug 1920562)
Backed out changeset 62ab18879eea (bug 1920562)
2024-10-08 00:16:13 +03:00
Chris H-C
e944bfe7a2 Bug 1920562 - Remove JS uses of Services.telemetry.setEventRecordingEnabled r=florian,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,sessionstore-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,urlbar-reviewers,sfoster,nchevobbe,valentin,Gijs,dimi,lina,mconley,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D223833
2024-10-07 17:29:57 +00:00
Eric Chen
67045ca160 Bug 1642039 - Part 3: make updateInstalledAtStartup and lastUpdateInstalled async r=bytesized,application-update-reviewers,firefox-desktop-core-reviewers ,mossop
Differential Revision: https://phabricator.services.mozilla.com/D218248
2024-09-07 22:33:04 +00:00
Tamas Szentpeteri
10732cf3e2 Backed out 3 changesets (bug 1642039) for causing talos failures on startup_about_home_paint_realworld_webextensions. CLOSED TREE
Backed out changeset f1164ee8dd18 (bug 1642039)
Backed out changeset f9b1ba53b30e (bug 1642039)
Backed out changeset b4f5a132a3bd (bug 1642039)
2024-09-03 00:13:42 +03:00
Eric Chen
02e18b6bc9 Bug 1642039 - Part 3: make updateInstalledAtStartup and lastUpdateInstalled async r=bytesized,application-update-reviewers,firefox-desktop-core-reviewers ,mossop
Differential Revision: https://phabricator.services.mozilla.com/D218248
2024-09-02 17:51:18 +00:00
hanna alemu
defd76eb83 Bug 1898361 - Add ability to disable WNP via whatsNewPage nimbus feature r=aminomancer,omc-reviewers,firefox-desktop-core-reviewers CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D212492
2024-07-02 23:12:59 +00:00
Cristina Horotan
d76e8c435b Backed out changeset 6829ed75952b (bug 1898361) for causing build bustage at NimbusMessagingControllerTest.kt. CLOSED TREE 2024-07-03 03:58:38 +03:00
hanna alemu
e98ba5d8ad Bug 1898361 - Add ability to disable WNP via whatsNewPage nimbus feature r=aminomancer,omc-reviewers,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D212492
2024-07-02 23:12:59 +00:00
Eric Chen
35224d47a5 Bug 1901840 - restore browser.privateWindowSeparation.enabled pref r=nshukla,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D213651
2024-06-14 14:47:04 +00:00
Eric Chen
8b87eaa11c Bug 1889785 - Ensure What's New Page is displayed when the relevant update is installed by a different profile r=bytesized,application-update-reviewers,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D210854
2024-06-10 17:45:03 +00:00
Robin Steuber
f9e436ee5f Bug 1900911 - Fix reference to now non-existant updateManager.readyUpdate r=nalexander,firefox-desktop-core-reviewers ,Gijs
This patch doesn't include testing. This is in large part because I would like to land this quickly. Ideally before this bug hits Beta. And it is in small part because I believe that testing can be added fairly trivially to a test that will be added in Bug 1889785, right after the soft freeze is over.

Differential Revision: https://phabricator.services.mozilla.com/D212867
2024-06-06 22:50:36 +00:00
hanna alemu
0e85522818 Bug 1897321 - Add minVersion variable to whatsNewPage Nimbus feature r=omc-reviewers,firefox-desktop-core-reviewers ,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D211892
2024-05-29 14:43:17 +00:00
Robin Steuber
c1824547b5 Bug 1875502 - Add UpdateManager.updateInstalledAtStartup r=nalexander,application-update-reviewers,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D209127
2024-05-16 20:01:54 +00:00
Nicholas Rishel
ffb727d232 Bug 1896030 - Don't open new window on -os-autostart if the application has already started. r=nalexander,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D210253
2024-05-16 00:42:53 +00:00
Sandor Molnar
5aee31029c Backed out 23 changesets (bug 1887980, bug 1875502) for causing xpc failures @ toolkit/components/extensions/test/xpcshell/test_ext_storage_idb_data_migration.js CLOSED TREE
Backed out changeset fb53b5f266e2 (bug 1875502)
Backed out changeset 9157c611617d (bug 1875502)
Backed out changeset 924b7230a45e (bug 1875502)
Backed out changeset d83fa2a0c858 (bug 1887980)
Backed out changeset c538de825468 (bug 1875502)
Backed out changeset a6c1ee51eadb (bug 1875502)
Backed out changeset 47bc52e77563 (bug 1875502)
Backed out changeset 54d53947927a (bug 1875502)
Backed out changeset 6bc2601a69bd (bug 1875502)
Backed out changeset 917a4aed3b4b (bug 1875502)
Backed out changeset afa0353ca6a2 (bug 1875502)
Backed out changeset 42ad3c8fe41e (bug 1875502)
Backed out changeset b5f4c67a548b (bug 1875502)
Backed out changeset d47c42d117e3 (bug 1875502)
Backed out changeset a33c98ac118c (bug 1875502)
Backed out changeset b57983b426ba (bug 1875502)
Backed out changeset a013811a156b (bug 1875502)
Backed out changeset 05b53ed47055 (bug 1875502)
Backed out changeset aa0eee306544 (bug 1875502)
Backed out changeset 5736dca8c05b (bug 1875502)
Backed out changeset 6e60ddb35c98 (bug 1875502)
Backed out changeset fcb327ff8717 (bug 1875502)
Backed out changeset 1950b330d253 (bug 1875502)
2024-05-16 00:21:12 +03:00
Robin Steuber
058a179fc5 Bug 1875502 - Add UpdateManager.updateInstalledAtStartup r=nalexander,application-update-reviewers,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D209127
2024-05-15 17:06:18 +00:00
Barret Rennie
0633e0cca7 Bug 1883673 - Remove majorRelease2022 Nimbus feature r=aminomancer,omc-reviewers,win-reviewers,gstoll,pbz,firefox-desktop-core-reviewers
This feature is no longer intended for experimentation and some of the things
it controls are no longer in product.

Differential Revision: https://phabricator.services.mozilla.com/D204514
2024-04-24 20:15:19 +00:00
Iulian Moraru
b2f394db04 Backed out changeset 89b76affef99 (bug 1883673) for causing multiple bc failures. CLOSED TREE 2024-04-22 22:12:59 +03:00
Barret Rennie
b288396795 Bug 1883673 - Remove majorRelease2022 Nimbus feature r=aminomancer,omc-reviewers,win-reviewers,gstoll,pbz,firefox-desktop-core-reviewers
This feature is no longer intended for experimentation and some of the things
it controls are no longer in product.

Differential Revision: https://phabricator.services.mozilla.com/D204514
2024-04-22 17:57:31 +00:00
Nipun Shukla
9685265c6b Bug 1889232 - Removed firefox-bridge and firefox-private-bridge protocol creation r=mhughes,Gijs,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D206419
2024-04-18 15:18:04 +00:00
Iulian Moraru
ccfe6fc0fd Backed out changeset 977027e73ec0 (bug 1889232) for causing windows mass failures. 2024-04-18 01:13:29 +03:00
Nipun Shukla
fea56e6d13 Bug 1889232 - Removed firefox-bridge and firefox-private-bridge protocol creation r=mhughes,Gijs,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D206419
2024-04-17 19:13:22 +00:00
Nicholas Rishel
6cad030b59 Bug 1890066 - Pre: Allow Messaging System system notifications processing when Firefox is invoked by the Notification Server via Remote Settings. r=nalexander,mconley
Differential Revision: https://phabricator.services.mozilla.com/D207096
2024-04-11 17:13:02 +00:00
Dave Townsend
a0c83bc943 Bug 1864896: Autofix unused function arguments (browser). r=webcompat-reviewers,mconley,fxview-reviewers,desktop-theme-reviewers,omc-reviewers,migration-reviewers,twisniewski,aminomancer,dao,sclements,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D203005
2024-03-19 09:36:35 +00:00
Nicholas Rishel
43e7950cea Bug 1883476 - Part 3: Remove dead launched from WDBA telemetry. r=nalexander
Backed out changeset 5d6127a9b7ed.

Differential Revision: https://phabricator.services.mozilla.com/D203516
2024-03-08 19:27:23 +00:00
Cosmin Sabou
3ef7b06b98 Backed out 3 changesets (bug 1883476, bug 1826375) for causing windows build bustages. CLOSED TREE
Backed out changeset bc8bdcfbcd9c (bug 1883476)
Backed out changeset 7d6333da6d31 (bug 1826375)
Backed out changeset f5f32253c79c (bug 1826375)
2024-03-07 03:08:10 +02:00
Nicholas Rishel
63699f5d56 Bug 1883476 - Part 3: Remove dead launched from WDBA telemetry. r=nalexander
Backed out changeset 5d6127a9b7ed.

Differential Revision: https://phabricator.services.mozilla.com/D203516
2024-03-07 00:14:06 +00:00
hanna alemu
9dcb4145a7 Bug 1868097 - Whats New Page nimbus tooling r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D200392
2024-03-06 14:36:14 +00:00
Mike Conley
3f6bc7d41c Bug 1877545 - Add a probe for whether or not a pre-existing profile existed when initting FirstStartup. data-review=jhirsch, r=rhelmer
Differential Revision: https://phabricator.services.mozilla.com/D201286
2024-03-05 20:24:15 +00:00
Michael Hughes
a9151787eb Bug 1880368 - change firefox and firefox-private protocols to firefox-bridge and firefox-private-bridge protocols r=nshukla,mossop
Differential Revision: https://phabricator.services.mozilla.com/D201879
2024-02-29 19:03:17 +00:00