Gijs Kruitbosch
8596108aaf
Bug 1280888 - make hash links in about:reader absolute to avoid kicking people out of reader mode unnecessarily, r=jaws
...
MozReview-Commit-ID: IwrPJZZXxEW
2016-08-24 16:49:13 +01:00
Jared Wein
4518d81cb5
Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
...
MozReview-Commit-ID: EMjJ3yWt9Wt
2016-08-04 03:28:58 -04:00
Jared Wein
e8b20b6db5
Bug 1292035 - Enable the space-before-blocks rule for eslint. This patch was generated using 'eslint --fix'. r=markh
...
MozReview-Commit-ID: 2XVoU05YvES
2016-08-04 03:20:25 -04:00
Tom Tromey
1b5a2bdb96
Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
...
This removes the unnecessary setting of c-basic-offset from all
python-mode files.
This was automatically generated using
perl -pi -e 's/; *c-basic-offset: *[0-9]+//'
... on the affected files.
The bulk of these files are moz.build files but there a few others as
well.
MozReview-Commit-ID: 2pPf3DEiZqx
2016-07-14 10:16:42 -06:00
Timothy Guan-tin Chien
0170ec3615
Bug 1260276 - Replace the dead reader page in history when we are being redirected, r=gijs
...
MozReview-Commit-ID: ChSCHuBKT1l
2016-07-13 16:14:34 +08:00
Gijs Kruitbosch
252bc6e582
Bug 1281536 - remove reader mode telemetry that's out of date, extend two existing probes, r=margaret,data-r=bsmedberg
...
MozReview-Commit-ID: 2FSr4v4fPWU
2016-06-24 15:39:23 +01:00
Jared Wein
c8957f6183
Bug 1271742 - Rename currentLineHeight to currentContentWidth in AboutReader.jsm. r=gijs
...
MozReview-Commit-ID: Fn98gl3Tief
2016-05-10 15:01:06 -04:00
danhuang1202
83d0f1d213
Bug 1269521 - Add line height contral in reader mode. r=jaws
...
MozReview-Commit-ID: HLFxqXdBhrD
2016-05-09 19:17:00 +02:00
Timothy Guan-tin Chien
648c7f27c3
Bug 1153393 - Make session restore restores the scroll position of an about:reader page, r=gijs
...
MozReview-Commit-ID: 6smuca3vx5O
2016-05-07 12:31:21 +08:00
danhuang1202
72e5cc0cfb
Bug 1151200 - Add content width control in reader mode. r=shorlander, r=jaws
2016-05-02 04:50:00 +02:00
Timothy Guan-tin Chien
f9af230a34
Bug 1269996 - Remove unload event listener, enabling bfcache for about:reader pages. r=gijs, r=margaret
...
MozReview-Commit-ID: IitxeBIFrGE
2016-05-04 17:53:31 +08:00
Andrzej Hunt
e1ddbca9b4
Bug 1265004 - Try to save in-memory reader view article instead of downloading r=margaret
...
This should guarantee that any reader view page will also be successfully saved offline.
MozReview-Commit-ID: 4J8cY6hYeyU
2016-05-02 15:47:46 -07:00
Eitan Isaacson
7bae627f10
Bug 1257953 - Update narrate to use new animated icon when speaking. r=Gijs
...
MozReview-Commit-ID: 4OnlJBmzu5T
2016-04-20 10:38:20 -07:00
Timothy Guan-tin Chien
0bab46ef0a
Bug 1266372 - De-dup code to ReaderMode.leaveReaderMode, r=gijs
...
Additionally, implements ReaderMode.enterReaderMode.
MozReview-Commit-ID: 8MPvFhX4ws7
2016-04-26 12:52:50 +08:00
Gijs Kruitbosch
6bba376860
Bug 1265866 - update Readability to the latest version from github, rs=me
...
MozReview-Commit-ID: 2n8zVKjTfma
2016-04-20 21:19:07 +01:00
Andrzej Hunt
cf169ca80e
Bug 1263628 - Ignore fragments when comparing URLs during reader view caching r=gijs
...
This seems to be a common issue with medium.com articles, but affects any page which was
opened using a fragment in the URL (e.g. foo.com/bar#baz is the same page as foo.com/bar,
however our reader view caching code didn't recognise the former as being equivalent to
the latter).
MozReview-Commit-ID: BtRmHq3sD9z
2016-04-15 11:17:36 -07:00
Andrzej Hunt
eb6f798dbd
Bug 1263628 - meta-refresh can use a relative URL, ensure base URI is included r=gijs
...
E.g. articles on facebook.com provide a meta-refresh containing "0; URL=/foo/bar?....",
and we previously attempted to use just this URL component, instead of constructing it
using the current page URL.
MozReview-Commit-ID: 4vSoz5lc1e
2016-04-15 13:53:19 -07:00
Andrzej Hunt
55e235263f
Bug 1234331 - Push article into readercache when bookmarking readerview page r=margaret
...
MozReview-Commit-ID: D7Yy45xkFd8
2016-03-29 20:08:09 -07:00
Dave Townsend
769fc8f245
Bug 1257246: Update toolkit for eslint 2. r=Gijs
...
Most of this is fixing functions that in some cases return a value but then
can also run to completion without returning anything. ESLint 2 catches this
where previous versions didn't. Unless there was an obvious other choice I just
made these functions return undefined at the end which is effectively what
already happens.
MozReview-Commit-ID: KHYdAkRvhVr
2016-04-05 11:33:48 -07:00
Gijs Kruitbosch
2b8faefaba
Bug 1252855 - make reader mode use AsyncPrefs, r=margaret
...
MozReview-Commit-ID: U6ZTyQQSHG
2016-03-15 20:40:14 +00:00
Eitan Isaacson
dfb790371c
Bug 1166365 - Add tests for narrate. r=Gijs
...
MozReview-Commit-ID: 84zRbvMimLV
2016-02-24 11:56:52 -08:00
Eitan Isaacson
2ddf51e136
Bug 1166365 - Introduce Narrate feature in reader mode. r=Gijs
...
MozReview-Commit-ID: 6tJIu7C4eAv
2016-02-01 11:09:14 -08:00
Eitan Isaacson
a7db03ac85
Bug 1166365 - Pluralize dropdown logic. r=Gijs,Margaret
...
MozReview-Commit-ID: KCayCX4r8xQ
2016-01-21 11:25:48 -08:00
Shane Caraveo
07955de3a5
Bug 1252661 fix visibility state of pocket menu items, r=gijs
2016-03-04 14:38:13 -08:00
Margaret Leibovic
522e349957
Bug 1226238 - (Part 5) Update reader view toolbar styles. r=Gijs,ahunt
...
MozReview-Commit-ID: 6YjmXZgGwOu
2016-02-22 14:28:02 -08:00
Margaret Leibovic
67b8d331fa
Bug 1226238 - (Part 4) Remove reading list toggle button from reader view. r=ahunt,Gijs
...
MozReview-Commit-ID: 3pwOV5BjwC9
2016-02-22 10:35:32 -05:00
Margaret Leibovic
48d5b8852e
Bug 1226238 - (Part 3) Remove reading list button from reader view. r=Gijs
...
MozReview-Commit-ID: 4QmGlGH8ELA
2016-02-22 10:29:48 -05:00
Margaret Leibovic
35f8776807
Bug 1226238 - (Part 2) Remove reader view footer. r=Gijs
...
MozReview-Commit-ID: B474joTtVwa
2016-02-22 10:16:24 -05:00
Margaret Leibovic
36d1c35aec
Bug 1226238 - (Part 1) Remove share button from reader view. r=ahunt,Gijs
...
MozReview-Commit-ID: 3TFzz809KcM
2016-02-22 10:09:07 -05:00
Dave Townsend
141eaedde7
Bug 1245649: Enable no-nested-ternary. r=mconley
2016-02-03 21:17:16 -08:00
Dave Townsend
2e4b5d2078
Bug 1245649: Merge browser and toolkit eslint rule settings. r=felipe
2016-02-03 13:12:18 -08:00
Gijs Kruitbosch
79b21e9e90
No bug - update readability from github repo, includes fix for bug 1230050, rs=uplift-with-r+-patches-from-github
2016-01-24 23:21:58 +00:00
Gijs Kruitbosch
30046cb032
Bug 1210366 - block youtube and pinterest from reader mode, r=MattN
2016-01-12 18:57:38 +00:00
Shivin Yadav
36cff637a4
Bug 1197163 - Update reader view "Loading…" string to use ellipsis character. r=margaret"
2016-01-06 10:40:34 -05:00
Shane Caraveo
3d87f487dc
Bug 1215694 move pocket to a system addon, r=Gijs, r=glandium
...
part 1: reorganize file locations, r=Gijs
part 2: remove built-in pocket code, r=Gijs
part 3: l10n support, r=glandium
part 4: move code/functionality from part 2 into the addon, r=Gijs
part 5: remove dead code, r=Gijs
part 6: create a simple api for addons to add to reader mode, r=Gijs
part 7: various test fixes related to cui behaviour and pocket, r=me
2015-12-29 15:40:52 -08:00
Mark Finkle
96ad7d8774
Bug 1234449 - Cleanup reader telemetry r=margaret
2015-12-22 09:32:10 -05:00
Gijs Kruitbosch
f6fe0f05ef
Bug 1222792 - fix comparing escaped URIs in reader mode when detecting redirects, r=margaret
2015-12-15 15:57:03 +00:00
Dave Townsend
dd9da1fea1
Bug 1229519: Fix miscellaneous parts of toolkit to pass eslint checks. r=MattN
2015-12-03 10:02:45 -08:00
Mark Finkle
d8ff52293b
Bug 1219895 - Cleanup the 'share.1' telemetry probes by adding extra context r=margaret
2015-10-29 18:44:44 -04:00
Mark Capella
f2c065c3fb
Bug 1130646 - Find non-hacky way to make back button dismiss reader mode popup, r=bnicholson
2015-10-07 19:55:33 -04:00
Matt Howell
d4f3294cc2
Bug 1134940 - Modernize ReaderMode function declarations. r=nalexander
2015-09-23 14:09:43 -07:00
Shu-yu Guo
37989840cd
Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff)
2015-09-15 11:19:45 -07:00
Gijs Kruitbosch
0efa594cc7
Bug 1195976, r=bnicholson
2015-08-27 13:20:47 +01:00
Gijs Kruitbosch
412038a00a
Bug 1182778, r=margaret,f=bz
2015-07-17 13:30:42 +01:00
Frederik Braun
fcf3a406cc
Bug 1184056 - Non-case sensitive redirects in reader mode. r=margaret
2015-07-15 18:25:10 +02:00
Gijs Kruitbosch
4e6b339476
Bug 1172270 - don't cause extra flushes for reader mode, r=margaret,smaug
2015-06-08 16:56:34 +01:00
Gijs Kruitbosch
df94671464
Bug 1172009 - don't show reader mode button for file:///, r=margaret
2015-06-09 13:48:11 +01:00
Margaret Leibovic
69deac12ea
Bug 1166364 - Fix typo in telemetry probe. r=me
2015-05-19 10:33:00 -07:00
Gijs Kruitbosch
c5c10b1105
Bug 1164426 - build reader mode blocklist, r=margaret
2015-05-15 00:31:39 +01:00
Margaret Leibovic
96b038b8e3
Bug 1161701 - Listen for AboutReader:Ready notification instead of waiting for content to appear in testReaderView. r=mfinkle
2015-05-11 16:51:41 -07:00