Commit Graph

204 Commits

Author SHA1 Message Date
Dragana Damjanovic
31a7348925 Bug 1277895 - Remove one new line from http auth prompt message. r=dolske 2016-09-16 09:24:26 +02:00
Boris Zbarsky
d01d82f8ef Bug 1167575. Ensure that we don't exit modal state while we're still waiting on a Gecko runnable in the event-loop-spinning code in nsPrompter.js. r=dolske
If we synchronously shut down the prompt, that will exit modal state while we're
still processing our mouse or key event, which happens _before_ Gecko runnable
processing.  Exiting modal state will generally post a runnable to run timeouts,
so we can end up processing that runnable before we return from processNextEvent
and unwind to whatever code did the alert() call on the web page.  The upshot is
that the webpage will see timeouts fire before the alert() call returns.

If we exit modal state off a Gecko runnable instead, that will ensure that we
return to the nsPrompter code immediately after exiting modal state, see that
the prompt is no longer active, and return to the calling web page code _before_
processing any more runnables.
2016-09-01 21:31:22 -04:00
Matthew Noorenberghe
d46e68509f Bug 1298193 - Part 7: Make test_prompt_promptAuth work with channels in the parent. r=Dolske
MozReview-Commit-ID: 4PTYcJr83pW
2016-08-25 22:59:51 -07:00
Ryan VanderMeulen
fa3e44b133 Merge inbound to m-c. a=merge 2016-08-26 09:37:03 -04:00
Matthew Noorenberghe
6c38ee1fdf Bug 1266618 - Fix test_prompt.html for E10S by using a ChromeWindow. r=dolske
This switches getPrompt to use a ChromeWindow which matches what the shipping code does for e10s.

MozReview-Commit-ID: DcVSr6JfmdK
2016-08-25 00:06:51 -07:00
Stephen A Pohl
437594e1e5 Bug 1297707: Show icons in alert dialogs when text is null. r=felipe 2016-08-25 21:26:07 -04:00
Wes Kocher
2cd257334f Merge m-c to fx-team, a=merge
a=release for the webidl hook due to comment-only changes
2016-08-16 22:09:34 -07:00
Jared Wein
8860cdf2c1 Bug 1294547 - Enable the comma-spacing rule for eslint. r=felipe
MozReview-Commit-ID: RCSDEvvk2I
2016-08-16 15:44:15 -04:00
Wes Kocher
740463f70e Merge m-c to autoland, a=merge 2016-08-15 14:54:25 -07:00
Jared Wein
99638e1465 Bug 1294621 - Enable the no-lonely-if rule for eslint. r=gijs
MozReview-Commit-ID: 8izEqc8IyCu
2016-08-12 11:50:35 -04:00
Saad Quadri
5023fcc3b2 Bug 1274042 - Remove unnecessary edge case handling for E10S mode in prompt tests. r=Dolske
MozReview-Commit-ID: FKocwybNyib
2016-08-12 09:45:44 -07:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt
2016-08-04 03:28:58 -04:00
Jared Wein
ebf1ccbe46 Bug 1291855 - Enable the no-else-return rule for eslint. r=Felipe,kmag,mossop
MozReview-Commit-ID: DYOmE6xwMJh
2016-08-03 18:54:59 -04:00
Tom Tromey
1b5a2bdb96 Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
This removes the unnecessary setting of c-basic-offset from all
python-mode files.

This was automatically generated using

    perl -pi -e 's/; *c-basic-offset: *[0-9]+//'

... on the affected files.

The bulk of these files are moz.build files but there a few others as
well.

MozReview-Commit-ID: 2pPf3DEiZqx
2016-07-14 10:16:42 -06:00
Jared Wein
81846147fc Bug 622939 - Clicking anywhere on a tab-modal prompt should focus it. r=Gijs
MozReview-Commit-ID: JziZBlLQZiI
2016-07-14 14:24:24 -04:00
Xidorn Quan
6101508a87 Bug 1141895 part 2 - Use unprefixed unicode-bidi values in internal code. r=jfkthame
MozReview-Commit-ID: 1o2NEe8eiSX
2016-06-30 16:25:31 +10:00
Justin Dolske
babcb1da96 Bug 1265077 - Fix Linux focus issues in test_modal_prompts.html. r=MattN 2016-06-29 15:01:56 -07:00
Dragana Damjanovic
d5c6b66b8b Bug 1278418 - Add TODO for missing default button when focus is missing. r=dolske 2016-06-23 08:15:42 +02:00
Dragana Damjanovic
6e72a11bb8 Bug 1230462 - Change the authentiation dialog message. r=mayhemer,dolske,margaret,tanvi 2016-06-06 01:06:00 +02:00
Carsten "Tomcat" Book
529f945807 Backed out changeset 490d3460a197 (bug 1230462) for test failures in test_modal_prompts.html 2016-06-05 11:26:57 +02:00
Dragana Damjanovic
570b31b4cc Bug 1230462 - Change the authentiation dialog message. r=mayhemer,dolske,margaret,tanvi 2016-06-03 09:09:00 +02:00
Christoph Kerschbaumer
ff38ee8272 Bug 1271188 - Remove SEC_NORMAL from toolkit/components/prompts/test/test_modal_prompts.html (r=sicking) 2016-05-12 14:06:25 +02:00
Carsten "Tomcat" Book
37fa9ce062 Backed out changeset 0dbe09e2ce98 (bug 1269039) for timeouts in windows test_master_password.html 2016-05-03 12:30:06 +02:00
Carsten "Tomcat" Book
1577de2c1c Backed out changeset c93e30cbbed8 (bug 1269039) 2016-05-03 12:29:40 +02:00
Matthew Noorenberghe
82e73713fe Bug 1269039 - Make test_master_password.html work with e10s. r=dolske
MozReview-Commit-ID: LUVxtCxaZ8G
2016-05-02 19:54:01 -07:00
Matthew Noorenberghe
5b2ff45c1d Bug 1269039 - Use add_task in test_master_password.html. r=dolske
MozReview-Commit-ID: Bx1zVTyynN3
2016-05-02 17:33:09 -07:00
Justin Dolske
e72e79a414 Bug 1267388 - Make handlePrompt() take state/action args and actually use them. r=MattN 2016-04-29 10:09:54 -07:00
Justin Dolske
4e093a4868 Bug 1267388 - move test to mochitest/ dir, add action object. r=MattN 2016-04-29 10:09:53 -07:00
Jared Wein
430f39e4c7 Bug 1268159 - Use GreD in addition to XCurProcD for browser_misused_characters_in_strings.js to cover more string files. r=gijs
MozReview-Commit-ID: IlC170W0nlG
* * *
[mq]: temp

MozReview-Commit-ID: GF0k4zvONPD
2016-04-29 09:28:48 -04:00
Justin Dolske
935a0bf0b7 Bug 1265194 - Android test is now hanging, so disable it. Bug 1267092 to look at why it and others in this dir are problematic. 2016-04-24 14:27:50 -07:00
Justin Dolske
20b3f00e8b Bug 1265194 - Fix test bustage. 2016-04-24 11:01:01 -07:00
Justin Dolske
1e05613bbc Bug 1265194 - Refactor prompt tests to use state/action objects and new common helpers. r=adw 2016-04-24 11:01:01 -07:00
Justin Dolske
b555ebe7b3 Bug 1265194 - use the hidden attribute in commonDialog.xul for consistency with tabPrompts.xml. r=adw 2016-04-24 11:01:01 -07:00
Justin Dolske
c658473e5b Bug 1265194 - Move handlePrompt() and checkPromptState() to prompt_common.js, and rename a test. r=adw 2016-04-24 11:01:01 -07:00
Justin Dolske
ffb41fe5d1 Bug 1263784 - Fix test_modal_prompts.html and test_modal_select.html to run under E10S. r=adw
Use chromeScript and message manager to fetch state of prompt and dismiss it. Enable tests in E10S.

MozReview-Commit-ID: 5M9GYijlQPV
2016-04-15 13:43:25 -07:00
Justin Dolske
37a9d23100 Bug 1263784 - Fix test_modal_prompts.html and test_modal_select.html to run under E10S. r=adw
Move state/action objects out of handleDialog, into main runTest() body.

MozReview-Commit-ID: 1250sb8N5sT
2016-04-15 13:43:25 -07:00
Justin Dolske
d3fe06177e Bug 1263784 - Fix test_modal_prompts.html and test_modal_select.html to run under E10S. r=adw
Make expected-state object independent from ui object.

MozReview-Commit-ID: 547tN5kSyDt
2016-04-15 13:43:25 -07:00
Justin Dolske
c161975016 Bug 1263784 - Fix test_modal_prompts.html and test_modal_select.html to run under E10S. r=adw
Move all expected-ui state checks into state object.

MozReview-Commit-ID: AKV0z4G3R7d
2016-04-15 13:43:25 -07:00
Justin Dolske
22ee2a4c78 Bug 1263784 - Fix test_modal_prompts.html and test_modal_select.html to run under E10S. r=adw
Move all actions to be performed on a prompt (e.g. clicking a button, checking a checkbox) into an "action" object.

MozReview-Commit-ID: 8KSGmezOGZZ
2016-04-15 13:43:25 -07:00
Drew Willcoxon
f62c0ea024 Bug 1252723 - [e10s] Make toolkit/components/prompts/test work under e10s. r=dolske 2016-04-01 17:36:28 -07:00
Makoto Kato
b7a5f6178a Bug 1250772 - Remove softkb-change observer listener. r=mossop
MozReview-Commit-ID: 2PkpjTSVSsM
2016-02-24 12:52:38 +09:00
Dave Townsend
a215a4a95a Bug 1245649: Turn on no-extra-semi. r=markh 2016-02-03 17:27:36 -08:00
Dave Townsend
a2ba043d69 Bug 1245649: Turn on no-trailing-spaces. r=Gijs 2016-02-03 14:22:33 -08:00
Mike Hommey
d4d98b3b37 Bug 1240660 - Remove "+" prefixes in jar manifests. r=gps
Now that the faster make backend is enabled by default avoiding
cross-jar.mn file conflicts, and now that individual files can't
overlap with wildcards in the same jar.mn files, which were two
main things that the "+" prefix was used for (apart from
cargo-culting), the "+" prefixes in the tree are not necessary
anymore.
2016-01-20 07:24:40 +09:00
Dave Townsend
8dc7f59eb3 Bug 1229142: Link browser and toolkit test directory to the shared eslintrc files. r=Standard8 2015-11-30 13:05:00 -08:00
Gijs Kruitbosch
937f4d1e69 Bug 1234936 - part 2: always focus tabs when they show an onbeforeunload dialog, r=billm 2015-12-29 18:49:27 +00:00
Dave Townsend
2fb8689242 Bug 1231828: Fix JS parsing errors in toolkit and browser XBL files. r=felipe 2015-12-10 16:53:46 -05:00
Matthew Noorenberghe
49d8829ebf Bug 1216986 - Fix usage of nsIURI.host in password manager and prompt code to support IPv6. r=dolske,liuche,kanru 2015-12-02 16:13:18 -08:00
Gijs Kruitbosch
b015fb9698 Bug 332195 - part 6: make an exception for beforeunload events while tabview is open, r=mconley 2015-10-26 14:17:16 +01:00
Gijs Kruitbosch
9118a83203 Bug 332195 - part 2: allow the user to control this behaviour with a checkbox, r=mconley 2015-10-13 11:06:01 +01:00