corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
437,595 Commits 1 Branch 0 Tags
11c4b51a67d753bc22d49f7bd80adf2b10fe2c6e
Commit Graph

80 Commits

Author SHA1 Message Date
Ben Kelly
abba503aab Bug 1300658 P2 Make WorkerRunnable's destined for main thread use the MainThreadTaskQueue. r=baku 2016-09-13 20:14:02 -07:00
Wes Kocher
e70a727506 Backed out 6 changesets (bug 1300658) for frequent Windows VM Xpcshell failures a=backout 
Backed out changeset 6cf3a60640cf (bug 1300658)
Backed out changeset c74062a27462 (bug 1300658)
Backed out changeset 39fbc61739ef (bug 1300658)
Backed out changeset 0b9d70b040a2 (bug 1300658)
Backed out changeset 4e921d61f036 (bug 1300658)
Backed out changeset 56496fad6494 (bug 1300658)
 2016-09-12 16:34:08 -07:00
Ben Kelly
6988197a88 Bug 1300658 P2 Make WorkerRunnable's destined for main thread use the MainThreadTaskQueue. r=baku 2016-09-12 12:32:21 -07:00
Ben Kelly
449d185850 Backout rev 5c7368370ff9 to 980659720b86 (bug 1300118 and bug 1300658) for incorrect bug number in commit message. r=me 2016-09-12 12:29:17 -07:00
Ben Kelly
28c3944fe8 Bug 1300658 P2 Make WorkerRunnable's destined for main thread use the MainThreadTaskQueue. r=baku 2016-09-12 11:21:01 -07:00
Nicholas Nethercote
b5810a1eb4 Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm. 
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.

In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.

> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));

In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.

> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");

This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
  be true" sense used in assertions.

A common variation on the side-effect-free case is the following.

> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");
 2016-09-02 17:12:24 +10:00
Andrea Marchesini
7cef8da2ac Bug 1300655 - part 2 - WorkerProxyToMainThreadRunnable::PostDispatchOnMainThread::ReleaseRunnable should implement Cancel() correctly, r=me 2016-09-06 04:48:11 +02:00
Andrea Marchesini
d25ee7c3ca Bug 1300655 - WorkerProxyToMainThreadRunnable::PostDispatchOnMainThread::ReleaseRunnable should implement Cancel() correctly, r=bkelly 2016-09-06 04:35:49 +02:00
Nicholas Nethercote
887efe04d5 Bug 1299727 - Rename NS_WARN_IF_FALSE as NS_WARNING_ASSERTION. r=erahm. 
The new name makes the sense of the condition much clearer. E.g. compare:

  NS_WARN_IF_FALSE(!rv.Failed());

with:

  NS_WARNING_ASSERTION(!rv.Failed());

The new name also makes it clearer that it only has effect in debug builds,
because that's standard for assertions.
 2016-09-01 15:01:16 +10:00
Ben Kelly
bee31710b3 Bug 1293690 P2 Set explicit status levels to fail at when calling WorkerHolder::HoldWorker. r=baku 2016-08-18 07:11:04 -07:00
Andrea Marchesini
066cfe31e7 Bug 1286487 - WorkerProxyToMainThreadRunnable must keep alive workers using WorkerHolder, r=bkelly 2016-07-23 08:31:31 +02:00
Andrea Marchesini
fb620c74fb Bug 1288033 - Decease the busyCount when Cancel() is called in WorkerRunnable, r=khuey 2016-07-21 19:18:51 +02:00
Carsten "Tomcat" Book
933492f8f7 Backed out changeset 512f176d3de6 (bug 1288033) to fix a incomplete backout 2016-07-21 12:36:38 +02:00
Iris Hsiao
1e8ca9319d Backed out changeset 90c6741cda5d (bug 1288033) for web platform e10s failure 2016-07-21 17:52:56 +08:00
Andrea Marchesini
5fea95cd5e Bug 1288033 - part 2 - fixed a compilation error, r=me 2016-07-21 09:56:11 +02:00
Andrea Marchesini
514ee95365 Bug 1288033 - Decease the busyCount when Cancel() is called in WorkerRunnable, r=khuey 2016-07-21 09:17:41 +02:00
Andrea Marchesini
dba355cdc0 Bug 1286615 - Wrong use of ModifyBusyCountFromWorker in WorkerProxyToMainThreadRunnable, r=khuey 2016-07-18 09:17:21 +02:00
Boris Zbarsky
c3889c8b5d Bug 1279313 part 1. Simplify AutoEntryScript to not make callers pass in a JSContext. r=bholley 2016-07-07 20:08:25 -04:00
Andrea Marchesini
dc222eaba0 Bug 1282366 - Improve WorkerHolder use in Runnables, r=khuey 2016-07-04 08:19:10 +02:00
Andrea Marchesini
30d0a3f864 Bug 1269162 - part 3 - Move XHR code into dom/xhr, r=smaug 2016-06-27 19:13:40 +02:00
Andrea Marchesini
4fd580b703 Bug 1277226 - Implement MainThreadWorkerRunnable, r=sicking 2016-06-08 07:12:05 +02:00
Kyle Huey
3f438c5fd6 Bug 1272066: Slap the compiler. r=khuey 2016-05-11 11:46:36 -07:00
Wes Kocher
3f5484664a Bug 1272066 - Try to stop assertions until a better fix can land rs=khuey 2016-05-11 11:37:59 -07:00
Andrea Marchesini
bb2e171b55 Bug 1268253 - MainThreadStopSyncLoopRunnable doesn't need to be exposed, r=khuey 2016-05-11 08:05:38 +02:00
Andrea Marchesini
194c33b0e8 Bug 1268252 - XHR doesn't need to use MainThreadStopSyncLoopRunnable, r=khuey 2016-05-11 08:05:08 +02:00
Andrea Marchesini
75b2d468d5 Bug 1268231 - Get rid of StopSyncLoopRunnable, r=khuey 2016-05-03 10:21:59 +02:00
Andrea Marchesini
fddf33c51f Bug 1267904 - Add telemetry for WorkerMainThreadRunnable, r=khuey 2016-05-03 09:09:47 +02:00
Kyle Huey
a256ae1a91 Bug 1263311: Part 1 - Change the nsICancelableRunnable interface. r=froydnj 2016-04-11 11:40:06 -07:00
Wes Kocher
dd9b334d33 Backed out 3 changesets (bug 1263311) for Windows build failures in ServiceWorkerPrivate.cpp CLOSED TREE 
Backed out changeset 0434a548e1fe (bug 1263311)
Backed out changeset 60b1be29446c (bug 1263311)
Backed out changeset 18132498bc40 (bug 1263311)

MozReview-Commit-ID: LPEa05QobdQ
 2016-04-11 12:50:56 -07:00
Kyle Huey
41c353f8e9 Bug 1263311: Part 1 - Change the nsICancelableRunnable interface. r=froydnj 2016-04-11 11:40:06 -07:00
Boris Zbarsky
e470e57f99 Bug 1262630. Replace workers::GetGlobalObjectForGlobal with xpc::NativeGlobal. r=khuey 2016-04-07 21:58:21 -04:00
Boris Zbarsky
a50c6aa31a Bug 1255817 part 2. Get rid of AutoJSAPI::OwnsErrorReporting and AutoJSAPI::TakeOwnershipOfErrorReporting. r=bholley 2016-03-23 11:44:54 -04:00
Boris Zbarsky
63091385d1 Bug 1254847 part 3. Make AutoEntryScript always take ownership of error reporting. r=bholley 2016-03-09 19:02:03 -05:00
Boris Zbarsky
b4e65ce236 Bug 1072144 part 6. Switch WorkerRunnable::Run to calling TakeOwnershipOfErrorReporting on its AutoJSAPI/AutoEntryScript and remove the remaining JS_ReportPendingException callers in worker code. r=khuey 2016-03-01 16:52:27 -05:00
Boris Zbarsky
c0708da1d6 Bug 1072144 part 5. Stop fiddling with compartments on the JSContext before calling PostRun in WorkerRunnable::Run. Add some documentation explaining what's going on. r=khuey 2016-03-01 16:52:26 -05:00
Boris Zbarsky
d66e858893 Bug 1072144 part 4. Add a WorkerRunnable::PreRun so that we can move worker global creation to it and always have an AutoEntryScript by the time we're evaluating the main worker script. r=khuey 2016-03-01 16:52:26 -05:00
Boris Zbarsky
8f73921c4f Bug 1072144 part 3. Hoist the exception reporting out of WorkerRunnable::PostRun into WorkerRunnable::Run and make it unconditional. r=khuey 2016-03-01 16:52:26 -05:00
Wes Kocher
0f2b8b2305 Backed out 6 changesets (bug 1072144) for test_recursion.html failures 
Backed out changeset ac15fe0e71fd (bug 1072144)
Backed out changeset b666d48a267d (bug 1072144)
Backed out changeset 0f0464ef08ed (bug 1072144)
Backed out changeset 7ba5f3b95022 (bug 1072144)
Backed out changeset 1912f838fcaa (bug 1072144)
Backed out changeset 145c9bb59b97 (bug 1072144)

MozReview-Commit-ID: 7cl4RtpHSfl
 2016-03-01 15:41:24 -08:00
Boris Zbarsky
2f3743863b Bug 1072144 part 6. Switch WorkerRunnable::Run to calling TakeOwnershipOfErrorReporting on its AutoJSAPI/AutoEntryScript and remove the remaining JS_ReportPendingException callers in worker code. r=khuey 2016-03-01 16:52:27 -05:00
Boris Zbarsky
528f0431a3 Bug 1072144 part 5. Stop fiddling with compartments on the JSContext before calling PostRun in WorkerRunnable::Run. Add some documentation explaining what's going on. r=khuey 2016-03-01 16:52:26 -05:00
Boris Zbarsky
9924291c2e Bug 1072144 part 4. Add a WorkerRunnable::PreRun so that we can move worker global creation to it and always have an AutoEntryScript by the time we're evaluating the main worker script. r=khuey 2016-03-01 16:52:26 -05:00
Boris Zbarsky
5d643fc548 Bug 1072144 part 3. Hoist the exception reporting out of WorkerRunnable::PostRun into WorkerRunnable::Run and make it unconditional. r=khuey 2016-03-01 16:52:26 -05:00
Boris Zbarsky
5dc0351cfe Bug 1251697 part 3. Remove the JSContext argument of StopSyncLoopRunnable::MaybeSetException. r=khuey 2016-02-26 21:15:57 -05:00
Boris Zbarsky
e3eff10fb4 Bug 1251045 part 4. Remove the JSContext argument of WorkerRunnable::Dispatch. r=khuey 2016-02-26 15:23:12 -05:00
Boris Zbarsky
2b562ca809 Bug 1251045 part 3. Remove the JSContext argument of WorkerRunnable::PostDispatch and its overrides. r=khuey 2016-02-26 15:23:12 -05:00
Boris Zbarsky
2499717c67 Bug 1251045 part 2. Remove the JSContext argument of ModifyBusyCountFromWorker. r=khuey 2016-02-26 15:23:12 -05:00
Boris Zbarsky
c88bd7aba0 Bug 1250975. Stop passing a JSContext argument to WorkerRunnable::PreDispatch and its overrides. r=khuey 2016-02-25 16:05:39 -05:00
Boris Zbarsky
0b8c06c5bc Bug 1250963 part 2. Remove the unused JSContext argument of WorkerPrivate::ModifyBusyCount. r=khuey 2016-02-25 16:05:39 -05:00
Wes Kocher
5381e51b24 Backed out 2 changesets (bug 1250963) for build bustage CLOSED TREE 
Backed out changeset 257324c2ae17 (bug 1250963)
Backed out changeset 0e868ee89abc (bug 1250963)
 2016-02-25 13:41:42 -08:00
Wes Kocher
0a08f00f7c Backed out changeset bb404647f14c (bug 1250975) for build bustage CLOSED TREE 2016-02-25 13:41:09 -08:00