Arthur Edelstein
4e271d1b40
Bug 1268726 - isolate shared worker by first party domain. r=baku
...
Tor 15564: Isolate SharedWorker by first party domain
uplift/refactor by Dave Huseby <dhuseby@mozilla.com >
review tweaks
2016-09-19 21:13:00 -04:00
Ben Kelly
1d07830caa
Bug 1300658 P5 Make service worker APIs use the MainThreadTaskQueue. r=baku
2016-09-13 20:14:02 -07:00
Wes Kocher
e70a727506
Backed out 6 changesets (bug 1300658) for frequent Windows VM Xpcshell failures a=backout
...
Backed out changeset 6cf3a60640cf (bug 1300658)
Backed out changeset c74062a27462 (bug 1300658)
Backed out changeset 39fbc61739ef (bug 1300658)
Backed out changeset 0b9d70b040a2 (bug 1300658)
Backed out changeset 4e921d61f036 (bug 1300658)
Backed out changeset 56496fad6494 (bug 1300658)
2016-09-12 16:34:08 -07:00
Ben Kelly
c55871977b
Bug 1300658 P5 Make service worker APIs use the MainThreadTaskQueue. r=baku
2016-09-12 12:32:21 -07:00
Ben Kelly
449d185850
Backout rev 5c7368370ff9 to 980659720b86 (bug 1300118 and bug 1300658) for incorrect bug number in commit message. r=me
2016-09-12 12:29:17 -07:00
Ben Kelly
07e44cb284
Bug 1300658 P5 Make service worker APIs use the MainThreadTaskQueue. r=baku
2016-09-12 11:21:02 -07:00
Tom Tung
aedb197f83
Bug 1187335 - P4 - Integrate fetch and cache with SRI & add nsIConsoleReportCollector to show console report. r=bkelly.
2016-09-07 10:20:23 +08:00
Nicholas Nethercote
b5810a1eb4
Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm.
...
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.
In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.
> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.
> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");
This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
be true" sense used in assertions.
A common variation on the side-effect-free case is the following.
> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");
2016-09-02 17:12:24 +10:00
Nicholas Nethercote
887efe04d5
Bug 1299727 - Rename NS_WARN_IF_FALSE as NS_WARNING_ASSERTION. r=erahm.
...
The new name makes the sense of the condition much clearer. E.g. compare:
NS_WARN_IF_FALSE(!rv.Failed());
with:
NS_WARNING_ASSERTION(!rv.Failed());
The new name also makes it clearer that it only has effect in debug builds,
because that's standard for assertions.
2016-09-01 15:01:16 +10:00
Gabriele Svelto
71d5cdbf24
Bug 1296579 - Remove the SimplePush API r=kitcambridge,baku
2016-09-01 20:17:03 +02:00
Kan-Ru Chen
a9b19d0584
Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj
...
The patch is generated from following command:
rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,
MozReview-Commit-ID: AtLcWApZfES
2016-08-24 14:47:04 +08:00
Ben Kelly
bee31710b3
Bug 1293690 P2 Set explicit status levels to fail at when calling WorkerHolder::HoldWorker. r=baku
2016-08-18 07:11:04 -07:00
Phil Ringnalda
6ef267a68f
Backed out 10 changesets (bug 1290116, bug 1293690) for build bustage
...
CLOSED TREE
Backed out changeset bbc14d107fca (bug 1290116)
Backed out changeset a81b6ce5c25f (bug 1290116)
Backed out changeset e0b9c25b6125 (bug 1290116)
Backed out changeset 8e9a9ba04ce5 (bug 1290116)
Backed out changeset 2d5ad5e9ed20 (bug 1290116)
Backed out changeset eb7da0dbfc72 (bug 1290116)
Backed out changeset 6a4e8c92faae (bug 1290116)
Backed out changeset 0342d98afa10 (bug 1293690)
Backed out changeset d84b0768f0ce (bug 1293690)
Backed out changeset f9f62ade9508 (bug 1293690)
2016-08-17 21:16:43 -07:00
Ben Kelly
72fb8c6934
Bug 1293690 P2 Set explicit status levels to fail at when calling WorkerHolder::HoldWorker. r=baku
2016-08-17 20:01:35 -07:00
Nicholas Nethercote
1f65390cc9
Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm.
...
This patch makes most Run() declarations in subclasses of nsIRunnable have the
same form: |NS_IMETHOD Run() override|.
As a result of these changes, I had to add |override| to a couple of other
functions to satisfy clang's -Winconsistent-missing-override warning.
2016-08-08 12:18:10 +10:00
Ben Kelly
2883244a9d
Bug 1170543 P3 Expose ServiceWorker idle thread state to ServiceWorkerManager. r=asuth
2016-07-27 20:36:10 -04:00
Ben Kelly
5951700bc2
Bug 1170543 P2 Explicitly track the idle KeepAliveToken separately. r=asuth
2016-07-27 20:36:10 -04:00
Ben Kelly
eca67d0365
Bug 1170543 P1 Create separate KeepAliveTokens for service worker events and script evaluation. r=asuth
2016-07-27 20:36:10 -04:00
Ben Kelly
4464e9d2fe
Bug 1289658 Make ExtendableMessageEvent.waitUntil() hold the service worker alive. r=asuth
2016-07-27 10:32:12 -04:00
Andrew Sutherland
fe010f5717
Bug 1167553 - Timeout-related Service Worker shutdowns should be reported. r=bkelly
...
Log a message when shutting down a service worker with pending promises.
Looks like:
Terminating ServiceWorker for scope
‘http://mochi.test:8888/tests/dom/workers/test/serviceworkers/’ with
pending waitUntil/respondWith promises because of grace timeout.
2016-07-10 22:22:29 -04:00
Andrea Marchesini
611ada4ec2
Bug 1280067 - WorkerThreadModifyBusyCount should be the default value for WorkerRunnable, r=sicking
2016-06-28 19:28:13 +02:00
Andrea Marchesini
796bda032a
Bug 1269154 - Get rid of WorkerFeature: WorkerHolder, r=khuey
2016-06-23 10:53:14 +02:00
Carsten "Tomcat" Book
ef49710e52
Backed out changeset 1c5d78c7ba43 (bug 1269154) for bustage on a CLOSED TREE
2016-06-23 10:13:54 +02:00
Andrea Marchesini
274f4e927f
Bug 1269154 - Get rid of WorkerFeature: WorkerHolder, r=khuey
2016-06-22 17:24:35 +02:00
Ben Kelly
f142ff8da3
Bug 1278253 Hold service worker alive until event dispatching code is notified. r=asuth
2016-06-06 07:38:40 -07:00
Kit Cambridge
e7a2a81c8d
Bug 1265841 - Implement the notificationclose service worker event. r=wchen,baku
...
MozReview-Commit-ID: EQfCbQKqn9H
2016-04-19 22:04:09 -07:00
Ben Kelly
982d169b49
Bug 1273920 P1 Hold strong reference to service worker WaitUntil() promise until its fulfilled. r=asuth
2016-05-24 14:08:20 -07:00
Ben Kelly
a7904d6fe0
Bug 1254741 P2 Don't aggressively terminate service workers when last controlled window is closed. r=baku
2016-05-23 02:46:26 -07:00
Ben Kelly
2394fe09ed
Bug 1254741 Keep service worker alive while dispatching message event. r=baku
2016-05-12 07:30:42 -07:00
L. David Baron
238f7d5ddc
Bug 1270649 - Rename mExceptionHasBeenRisen to mExceptionWasRaised. r=smaug
...
risen is the past participle of rise; raised is the past participle of
raise, which is what is done to exceptions.
See:
https://en.wiktionary.org/wiki/rise#Verb
https://en.wiktionary.org/wiki/raise#Verb (definition 2, though not sure
if the use for exceptions is from 2.3 or 2.5)
(I wonder if mExceptionRaised would be simpler, though.)
MozReview-Commit-ID: 8Ynup8aDcLT
2016-05-08 22:16:42 -07:00
Kyle Huey
b972c94d0f
Bug 1268313: Part 7 - Move NS_NewRunnableMethod and friends to mozilla::NewRunnableMethod. r=froydnj
2016-05-05 01:45:00 -07:00
Carsten "Tomcat" Book
aadd508ffe
Backed out changeset 85ce8cb0639a (bug 1268313)
2016-04-29 14:21:16 +02:00
Kyle Huey
e62a0823c9
Bug 1268313: Part 7 - Move NS_NewRunnableMethod and friends to mozilla::NewRunnableMethod. r=froydnj
2016-04-28 14:08:25 -07:00
Ben Kelly
595800e195
Bug 1267733 P3 Trigger service worker update after failed interception. r=jdm
2016-04-27 02:24:04 -07:00
Ben Kelly
094269ad5e
Bug 1267733 P2 Pass ServiceWorkerRegistrationInfo down to CancelChannelRunnable. r=jdm
2016-04-27 02:24:04 -07:00
Kyle Huey
a9cf047227
Bug 1265927: Move nsRunnable to mozilla::Runnable, CancelableRunnable to mozilla::CancelableRunnable. r=froydnj
2016-04-25 17:23:21 -07:00
Ehsan Akhgari
6efa0b920b
Bug 1265941 - Rename the ReferrerPolicy "origin-only" enum value to "origin"; r=jdm
2016-04-20 14:21:34 -04:00
Kyle Huey
a256ae1a91
Bug 1263311: Part 1 - Change the nsICancelableRunnable interface. r=froydnj
2016-04-11 11:40:06 -07:00
Wes Kocher
dd9b334d33
Backed out 3 changesets (bug 1263311) for Windows build failures in ServiceWorkerPrivate.cpp CLOSED TREE
...
Backed out changeset 0434a548e1fe (bug 1263311)
Backed out changeset 60b1be29446c (bug 1263311)
Backed out changeset 18132498bc40 (bug 1263311)
MozReview-Commit-ID: LPEa05QobdQ
2016-04-11 12:50:56 -07:00
Kyle Huey
41c353f8e9
Bug 1263311: Part 1 - Change the nsICancelableRunnable interface. r=froydnj
2016-04-11 11:40:06 -07:00
Ben Kelly
abb6fea84b
Bug 1259338 P1 Ensure that AllowWindowInteractionHandler is released on worker thread. r=khuey
2016-04-08 13:12:52 -07:00
Kit Cambridge
c1473206f5
Bug 1246341 - Report push event errors and rejections to the Push service. r=baku
...
MozReview-Commit-ID: D6fRPqojOEh
2016-03-28 11:50:39 -07:00
Kyle Huey
20d0dc7286
Bug 1259294: Part 2 - Use MOZ_ALWAYS_SUCCEEDS. r=froydnj
2016-03-28 10:28:15 -07:00
Kyle Huey
d791fedcc4
Bug 1259290: Part 5 - Remove the cx from WorkerFeature::Notify. r=bz
2016-03-28 10:28:14 -07:00
Fabrice Desré
d8e349cc5a
Bug 1258034 - Fix ServiceWorkerPrivate.cpp build error on b2g r=khuey
2016-03-20 09:57:33 -07:00
Kyle Huey
94b9461d1d
Bug 1257042: Remove the worker descriptor for PushEvent and PushMessageData. r=bz
2016-03-16 13:44:24 -07:00
Sebastian Hengst
50d903deeb
Backed out changeset 06101225c145 (bug 1257042) for bustage. r=backout on a CLOSED TREE
2016-03-16 20:30:32 +01:00
Kyle Huey
c62ceffe62
Bug 1257042: Remove the worker descriptor for PushEvent and PushMessageData. r=bz
2016-03-16 11:51:11 -07:00
Kyle Huey
56bfa0ab15
Bug 1257032: Make files in dom/workers actually build without unification. r=baku
2016-03-16 11:51:11 -07:00
Boris Zbarsky
b3f9947be1
Bug 1255706 part 2. Remove JSContext argument from WorkerPrivate::Terminate. r=khuey
2016-03-11 16:43:30 -05:00