Commit Graph

111 Commits

Author SHA1 Message Date
Jared Wein
8860cdf2c1 Bug 1294547 - Enable the comma-spacing rule for eslint. r=felipe
MozReview-Commit-ID: RCSDEvvk2I
2016-08-16 15:44:15 -04:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt
2016-08-04 03:28:58 -04:00
Jared Wein
ebf1ccbe46 Bug 1291855 - Enable the no-else-return rule for eslint. r=Felipe,kmag,mossop
MozReview-Commit-ID: DYOmE6xwMJh
2016-08-03 18:54:59 -04:00
David Keeler
60dbae2c0f bug 803330 - fix row count assertion failure in page info dialog r=florian
When calling rowCountChanged on an nsITreeBoxObject, the implementation assumes
that the row count has actually changed. pageInfoTreeView violated this
assumption in addRows by first calling rowCountChanged and then updating its row
count. This patch fixes the issue by using the power of decomposition. That is,
there's already a perfectly fine function called 'addRow' that can be called
once for each row being added.

MozReview-Commit-ID: HP6LkP4ICLf
2016-07-14 17:21:14 -07:00
Mike Conley
e75f3db0b7 Bug 1241892 - Make Page Info work for sidebar browser. r=florian
The modifications that were made in bug 1238180 assumed that
gBrowser.selectedBrowser from the opening window context would
be defined. This is true in normal browser tabs, but not so much
in the sidebar browser. This patch makes it so that callers can
supply a browser to override the assumption.

MozReview-Commit-ID: FKSyl7WUu1V
2016-07-04 15:42:45 -04:00
Dave Huseby
ad5bcd5922 Bug 1233885 - fix up docInfo and permission manager to use default user context. r=sicking
(HEAD -> oa, refs/patches/oa/Bug_1233885)
fix up docInfo and permission manager to use default user context
2016-03-26 15:07:00 +01:00
Dave Townsend
17d8a23b3f Bug 1257246: Update browser for eslint 2. r=felipe
Most of this is fixing functions that in some cases return a value but then
can also run to completion without returning anything. ESLint 2 catches this
where previous versions didn't. Unless there was an obvious other choice I just
made these functions return undefined at the end which is effectively what
already happens.

MozReview-Commit-ID: DEskVIjiKDM
2016-04-05 11:33:33 -07:00
Mike Conley
99c9000a61 Bug 1255773 - Account for multiple media elements per node for Page Info. r=florian
MozReview-Commit-ID: GwzIYVsLgue
2016-04-05 12:39:24 -04:00
Dave Townsend
aebdf4481b Bug 1245649: Turn on no-irregular-whitespace and no-mixed-spaces-and-tabs. r=jaws 2016-02-03 18:09:49 -08:00
George Wright
9f7c9a4df8 Bug 1237025 - Stop using CPOWs for View Image Info context menu r=mconley 2016-01-19 19:21:49 -05:00
Masatoshi Kimura
0224c6ccef Bug 1211243 - Do not swallow exceptions if the URI is not an instance of a standard URL. r=florian 2016-01-22 07:29:35 +09:00
Masatoshi Kimura
7379886f4f Bug 1207168 - Fix internalSave() arguments in pageInfo.js. r=florian 2016-01-22 07:29:35 +09:00
Felipe Gomes
8ff5f8cd13 Bug 1231728 - Fixes some code to follow eslint rules. r=mak 2015-12-10 14:38:30 -05:00
Mike Conley
094b8bb46c Bug 1180991 - Send up natural dimensions of background images loaded in content for Page Info. r=florian 2015-10-05 15:22:38 -04:00
Nikhil Gupta
f0ec7a5bd7 Bug 1175877 - Removed Cu and used Components.util directly r=Mak 2015-10-08 11:30:16 +05:30
Carsten "Tomcat" Book
036e6d2fa3 Backed out 2 changesets (bug 1202902) to recking bug 1202902 to be able to reopen inbound on a CLOSED TREE
Backed out changeset 647025383676 (bug 1202902)
Backed out changeset d70c7fe532c6 (bug 1202902)
2015-10-07 14:03:21 +02:00
Carsten "Tomcat" Book
12369728f5 Backed out 1 changesets (bug 1202902) for causing merge conflicts to mozilla-central
Backed out changeset cfc1820361f5 (bug 1202902)
2015-10-07 12:13:45 +02:00
Shu-yu Guo
474f49adb7 Bug 1202902 - Scripted fix the world. 2015-10-06 14:00:31 -07:00
Jimmy Wang
c00a9ddfe2 Bug 1175794 - Use task with setTimeout and send messages to continuously update PageInfo Media tab. r=florian 2015-08-13 05:12:02 -04:00
Jimmy Wang
e2fae25424 Bug 1175794 - Rename and cleanup pageinfo code. r=florian 2015-08-13 03:37:02 -04:00
Jimmy Wang
f0e4983767 Bug 1040947 - Opening page info from a remote tab is sluggish. r=florian 2015-07-08 17:18:38 -04:00
Michael Layzell
3e45effee5 Bug 1173523 - Part 9: Update pageinfo to use the new API for nsIPermission, r=florian 2015-07-16 14:49:37 -04:00
Wes Kocher
c06754ff70 Backed out 24 changesets (bug 1173523, bug 1172080, bug 817007, bug 1165263) for android reftest bustage CLOSED TREE
Backed out changeset 84fe04b2e7d1 (bug 1172080)
Backed out changeset 0ff004760a1f (bug 1172080)
Backed out changeset af147585ad55 (bug 1165263)
Backed out changeset c3af8ebb6db0 (bug 1165263)
Backed out changeset cd3f33a888fe (bug 1165263)
Backed out changeset e5db39044a1e (bug 1165263)
Backed out changeset c01c9ed77061 (bug 1165263)
Backed out changeset fb723aaa4267 (bug 1165263)
Backed out changeset f754e52e74dc (bug 1165263)
Backed out changeset c6bda3a0afd6 (bug 817007)
Backed out changeset bfa100253349 (bug 817007)
Backed out changeset b787b3f9aadc (bug 1173523)
Backed out changeset 4a0676b73f77 (bug 1173523)
Backed out changeset 82034a4560c5 (bug 1173523)
Backed out changeset 4bdb91114c7a (bug 1173523)
Backed out changeset 72406261eccc (bug 1173523)
Backed out changeset 541b6faf7196 (bug 1173523)
Backed out changeset 1caac4569616 (bug 1173523)
Backed out changeset 0d4f9f9e1b4e (bug 1173523)
Backed out changeset 2d5661eb966c (bug 1173523)
Backed out changeset 89833c0bb0cd (bug 1173523)
Backed out changeset ea64d70eacfe (bug 1173523)
Backed out changeset a8e4f1c0c445 (bug 1173523)
Backed out changeset cf498d466b85 (bug 1173523)
2015-07-14 14:00:32 -07:00
Michael Layzell
e757d7eafd Bug 1173523 - Part 9: Update pageinfo to use the new API for nsIPermission, r=florian 2015-07-14 15:06:24 -04:00
Michael Layzell
20f33b6cf4 Bug 1170200 - Part 2: Update JavaScript consumers of nsIPermissionManager::Remove; r=ehsan 2015-07-03 17:12:27 -04:00
Ehsan Akhgari
7015e19689 Backout bug 1170200 because of test failures on a CLOSED TREE 2015-07-03 16:43:47 -04:00
Michael Layzell
b70b5a5766 Bug 1170200 - Part 2: Update JavaScript consumers of nsIPermissionManager::Remove; r=ehsan 2015-07-03 14:18:23 -04:00
Birunthan Mohanathas
fe337d7c5e Bug 1166840 - Remove unused document argument in uses of nsIClipboardHelper.copyString. r=ehsan 2015-05-21 21:49:30 +01:00
Michael Weisz
b431e9d9e5 Bug 736572 - Show arrow after sorting column in pageInfo. Provide empty string for comparison function if no according attribute was set. r=jaws 2015-03-05 20:16:18 +01:00
Anush
f832545205 Bug 418517 - Add "Select All" button to Page Info "Media" tab r=jaws 2015-03-06 14:43:59 -08:00
Michael Weisz
8d332aa7b8 Bug 782623 - Add meta tag property attribute to pageInfo view. r=jaws 2015-02-27 18:11:03 -05:00
Eric Faust
e96d905e45 Bug 1095036 - Fix broken copy context menu in Page Info. (r=MattN, a=kwierso) 2014-11-06 16:19:15 -08:00
Jon Morton
4a98f87acc Bug 979835: Port BoxObject and its subclasses to WebIDL. r=khuey sr=bz 2014-10-14 13:15:21 -07:00
Bill McCloskey
0747474266 Bug 1058543 - Make page info work again in e10s (r=mconley) 2014-09-10 17:15:41 -07:00
David Keeler
e78e0b0f80 bug 1029797 - remove redundant "Security information for this page" section of Page Info window r=dao 2014-06-24 14:31:06 -07:00
Sami Jaktholm
bde9c33a9b Bug 736574 - PageInfo: Fix an if-condition causing a failure to sort the media by count. r=Dao 2014-02-11 09:24:03 -05:00
Honza Bambas
4e726f9815 Bug 922741 - make callbacks iteration in CacheEntry smarter, r=michal 2013-11-20 23:20:17 +01:00
Honza Bambas
502d5b480e Bug 931383 - nsICacheEntryOpenCallback is not defined in pageInfo.js, test_clearHistory_shutdown.js, r=dao 2013-11-06 16:59:05 +01:00
Honza Bambas
a55f8e6460 Bug 913807 - HTTP cache v2: API+top service+integration+tests, off by default, r=michal+ehsan+mark.finkle+fabrice+mhammond+gavin 2013-09-20 11:11:25 +02:00
Robert O'Callahan
66e2e3f8dc Bug 877135. Remove HTMLMediaElement::mozLoadFrom since it's nonstandard and no longer needed (setting 'src' to another element's 'currentSrc' works just as well). r=doublec 2013-06-04 15:28:23 +12:00
Tim Taubert
492a9d488c Bug 860622 - Stop preprocessing browser/base/content/pageinfo/pageInfo.js; r=dolske 2013-04-11 10:35:07 +02:00
Ralph Giles
5d626bd8df Bug 857022 - Remove MOZ_MEDIA build-time define. r=ted
We don't test with MOZ_MEDIA=0 so that configuration no longer
works. It's better to drop the switch altogether and enable
this code unconditionally. Per-codec and -feature configure
and runtime options remain available.
2013-04-04 14:09:00 -07:00
Yosy Attias
1a61723980 Bug 845055 - Check the mime type is not null before testing the mime type itself. r=dao 2013-03-12 12:48:59 -07:00
Trevor Saunders
fdf2a869ea bug 407956 - make nsITreeView not take a nsISupportsArray* r=neil, bz sr=neil 2013-01-06 19:54:42 -05:00
Boris Zbarsky
268d0ca4ce Bug 838518 part 1. Fix treewalker callers per the API change that was made. r=smaug 2013-02-06 14:22:33 +00:00
Phil Ringnalda
24bae25b23 Back out ed72449453b4 (bug 715075) for browser-chrome orange 2012-11-15 20:40:49 -08:00
Dario Bertero
982afb5b04 Bug 715075 - Page Info reads image width and height synchronously after setting src, leads to 0px x 0px if the image isn't in your cache (e.g. after clearing cache). r=mak 2012-11-15 20:34:56 -05:00
Josh Matthews
a6d9debc97 Bug 795065 - Add privacy status to nsDownload. r=mak sr=bz 2012-10-03 13:10:20 -04:00
Yosy
3982ffb3e1 Bug 792968 - Replace some regular expression string matches with String.startsWith and replace /^https?/ URI scheme tests with /^https?$/. r=dao 2012-09-23 21:09:29 +02:00
Benjamin Peterson
d81426815e Backed out changeset 3ca1f19e4c2a (bug 792968) for mochitest-oth failures 2012-09-23 12:25:39 -04:00