Commit Graph

4476 Commits

Author SHA1 Message Date
Tom Schuster
f81d16e706 Bug 1941365 - Use a <?csp ?> processing instructions instead of a csp attribute. r=Gijs,settings-reviewers,devtools-reviewers,places-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D238474
2025-02-26 16:13:13 +00:00
Drew Willcoxon
cf70175727 Bug 1949297 - Update the Firefox Suggest settings UI. r=settings-reviewers,reusable-components-reviewers,urlbar-reviewers,fluent-reviewers,bolsson,daisuke,mstriemer
This makes the following primary changes to the Suggest settings in the search
pane:

* Remove the infobox
* Remove the learn-more link from the dismissed-suggestions description
* Add a learn-more link to the Address Bar section's description but show it
  only when Suggest is enabled
* Add `#w_what-setting-is-opt-in` fragment to the learn-more URL for the online
  toggle so it links directly to the appropriate section

It also makes these related changes:

Remove the unnecessary `vbox` containers for the toggle switches. I had to
modify some reusable-components CSS. Note that there are two copies of the
Suggest toggle, one in the search pane and one in the privacy pane.

Rename the sponsored and nonsponsored checkbox strings so they're consistent
with the other checkbox strings: `addressbar-locbar-foo-option`

Remove test tasks that click checkboxes and make sure the appropriate prefs are
updated and vice versa. Now that the infobox is gone, there's no need for
Suggest-specific tests to worry about that.

Similarly, remove test tasks that click the learn-more links and make sure the
right page is opened. No need for Suggest-specific tests to do that either.

Differential Revision: https://phabricator.services.mozilla.com/D238847
2025-02-26 15:49:16 +00:00
Sandor Molnar
bc9b3e4b97 Backed out 2 changesets (bug 1941365) for causing CSP related dt failures. CLOSED TREE
Backed out changeset b022efa3b9e7 (bug 1941365)
Backed out changeset 90c5b60c6163 (bug 1941365)
2025-02-26 17:28:48 +02:00
Tom Schuster
07c8930ba5 Bug 1941365 - Use a <?csp ?> processing instructions instead of a csp attribute. r=Gijs,settings-reviewers,devtools-reviewers,places-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D238474
2025-02-26 14:36:42 +00:00
Gregory Pappas
2300895022 Bug 1750304 - Move isChinaRepack out of AppConstants r=settings-reviewers,home-newtab-reviewers,Gijs,pdahiya,omc-reviewers,mossop,mconley
AppConstants seems like the wrong place for this method

Differential Revision: https://phabricator.services.mozilla.com/D239276
2025-02-25 20:46:37 +00:00
Rebecca King
b3a22ac978 Bug 1938253 - Implement Callout 3 for integrated version of Review Checker - r=kpatenio,shopping-reviewers,fluent-reviewers,settings-reviewers,omc-reviewers,aminomancer,bolsson,mossop
Differential Revision: https://phabricator.services.mozilla.com/D233053
2025-02-24 18:15:36 +00:00
Stanca Serban
45d787bb25 Backed out changeset 7a0277e4a8d8 (bug 1915289) for causing xpcshell failures in xpcshell/test_engine_ids.js. 2025-02-21 15:06:55 +02:00
Connor Pearson
78df501dfc Bug 1915289 - Support setting suggestion URL when adding new search engine. r=search-reviewers,fluent-reviewers,Standard8,daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D220743
2025-02-21 11:44:17 +00:00
Mika Valkealahti
7ef62798f5 Bug 1948993 - removing nightly-only ifdef so vertical tabs controls in settings ride the train with 137 r=sidebar-reviewers,settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D238900
2025-02-20 10:27:46 +00:00
Drew Willcoxon
07c0872acb Bug 1948166 - Allow Suggest online settings UI to be hidden. r=daisuke,settings-reviewers,urlbar-reviewers,mossop
This replaces `quickSuggestHideSettingsUI` with `quickSuggestSettingsUi`. Like
the old variable, we can show or hide all Suggest settings UI, and now we can
also hide UI that pertains only to Suggest online. This is necessary because as
we start to roll out Suggest to more regions, online (Merino) won't be available
for them initially.

Differential Revision: https://phabricator.services.mozilla.com/D238159
2025-02-18 20:05:11 +00:00
Sarah Clements
75a1245a9a Bug 1948969 - Update browser layout section r=sidebar-reviewers,settings-reviewers,kcochrane,mossop
* Put vertical and horizontal tabs radio buttons behind a nightly pref

Differential Revision: https://phabricator.services.mozilla.com/D238647
2025-02-18 17:09:54 +00:00
Alexandru Marc
eb7e658712 Backed out changeset dbfd15553a78 (bug 1948166) for causing bc failures @ browser_search_firefoxSuggest.js CLOSED TREE 2025-02-18 19:58:24 +02:00
Drew Willcoxon
cf1c98539b Bug 1948166 - Allow Suggest online settings UI to be hidden. r=daisuke,settings-reviewers,urlbar-reviewers,mossop
This replaces `quickSuggestHideSettingsUI` with `quickSuggestSettingsUi`. Like
the old variable, we can show or hide all Suggest settings UI, and now we can
also hide UI that pertains only to Suggest online. This is necessary because as
we start to roll out Suggest to more regions, online (Merino) won't be available
for them initially.

Differential Revision: https://phabricator.services.mozilla.com/D238159
2025-02-18 16:11:30 +00:00
Jared Hirsch
ec20ae7dd7 Bug 1921846 - Add profiles section to about:preferences. r=profiles-reviewers,settings-reviewers,fluent-reviewers,bolsson,niklas,mossop
For now, putting the profiles preferences test in the profiles
component.

Differential Revision: https://phabricator.services.mozilla.com/D237838
2025-02-14 17:10:48 +00:00
Valentin Gosu
2b6ee476f3 Bug 1900013 - Remove DoH fallback warning prefs from privacy settings UI r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D237692
2025-02-12 14:30:27 +00:00
Kai Engert
cc7d553c17 Bug 1944707 - Move pippki.js to .sys.mjs. r=keeler,fluent-reviewers,bolsson,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D131184
2025-02-12 10:54:02 +00:00
hanna.alemu
a8dfa6eec2 Bug 1945639 - Adding Solo to More from Mozilla - Add card r=settings-reviewers,desktop-theme-reviewers,omc-reviewers,Gijs,dao,pdahiya,jprickett
Differential Revision: https://phabricator.services.mozilla.com/D236377
2025-02-11 17:31:44 +00:00
Drew Willcoxon
326f3c0fe1 Bug 1946900 - Update Firefox Suggest settings UI tests so that they don't use "scenarios". r=urlbar-reviewers,daisuke
Differential Revision: https://phabricator.services.mozilla.com/D237281
2025-02-11 02:58:52 +00:00
kernp25
cb1f1d5155 Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth
Differential Revision: https://phabricator.services.mozilla.com/D233071
2025-02-10 15:24:32 +00:00
Stanca Serban
d2bc5aedda Backed out changeset aee2b68df733 (bug 1944707) for causing mochitests failures. CLOSED TREE 2025-02-07 05:25:15 +02:00
Kai Engert
5c959ca366 Bug 1944707 - Move pippki.js to .sys.mjs. r=keeler,fluent-reviewers,bolsson,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D131184
2025-02-06 23:00:46 +00:00
Tom Schuster
6817e402c2 Bug 1944329 - Use a restrictive CSP for add-engine-dialog. r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D236198
2025-02-04 13:54:17 +00:00
Tom Schuster
7d4b3ddcec Bug 1944329 - Remove inline event handler and use restrictive CSP for fxaPairDeviceDialog. r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D236197
2025-02-04 13:54:17 +00:00
Tom Schuster
11c71c2f38 Bug 1944329 - Remove inline event handler and use restrictive CSP for syncChooseOptions. r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D236196
2025-02-04 13:54:17 +00:00
Tom Schuster
16a6a010ba Bug 1944329 - Remove inline event handlers and use restrictive CSP for TranslationsDialog. r=settings-reviewers,translations-reviewers,Gijs,nordzilla
Differential Revision: https://phabricator.services.mozilla.com/D236103
2025-02-04 13:54:16 +00:00
Tom Schuster
f22daa0010 Bug 1944329 - Remove inline event handlers and use restrictive CSP for DoHExceptionsDialog. r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D235982
2025-02-04 13:54:16 +00:00
Tom Schuster
e5fba6bb18 Bug 1944329 - Remove inline event handler and use restrictive CSP for SiteDataRemoveSelectedDialog. r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D235767
2025-02-04 13:54:15 +00:00
Gijs Kruitbosch
76e33e0370 Bug 1868766 - BrowserTestUtils shouldn't default to allowInheritPrincipal set to true, r=robwu,settings-reviewers,mossop,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236337
2025-02-04 12:24:10 +00:00
Butkovits Atila
b061588f31 Backed out changeset 2c11770a86dc (bug 1939658) for causing failures at test_JsonSchemaValidator.js. CLOSED TREE 2025-02-04 13:07:29 +02:00
kernp25
cd2f76670a Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth
Differential Revision: https://phabricator.services.mozilla.com/D233071
2025-02-04 08:25:28 +00:00
Sandor Molnar
e50ad2ea12 Backed out changeset d1f7cc44e79d (bug 1868766) for causing dt failures @ browser_json_refresh.js CLOSED TREE 2025-02-04 02:21:43 +02:00
Gijs Kruitbosch
8765a056c0 Bug 1868766 - BrowserTestUtils shouldn't default to allowInheritPrincipal set to true, r=robwu,settings-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D236337
2025-02-03 20:47:24 +00:00
Alexandru Marc
232510954a Backed out changeset d6ee01dac41f (bug 1868766) for causing ba failures @ browser_alert.js CLOSED TREE 2025-02-03 13:45:50 +02:00
Gijs Kruitbosch
88fa036427 Bug 1868766 - BrowserTestUtils shouldn't default to allowInheritPrincipal set to true, r=settings-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D236337
2025-02-03 10:59:27 +00:00
Ed Lee
8b77709dbf Bug 1933524 - Flip chatbot default and remove from Labs in Nightly and Release r=ngrato,settings-reviewers,sidebar-reviewers,nsharpley,firefox-desktop-core-reviewers ,firefox-ai-ml-reviewers,jsudiaman,Gijs,sclements,desktop-theme-reviewers,hjones
Flip default pref to true and remove featuregate entry/strings/styles. Switch actor enabled to actual opt-in / provider. Update sidebar tests for chatbot as default tool.

Differential Revision: https://phabricator.services.mozilla.com/D233204
2025-01-31 16:58:55 +00:00
Nick Alexander
cd50fbecdd Bug 1944650 - Update "data collection and use" header in "Privacy & Security" section of about:preferences. r=fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D236023
2025-01-30 00:02:49 +00:00
Sam Foster
2abfcffe73 Bug 1936379 - Add new browser layout section to about:preferences, remove Labs sidebar section. r=sidebar-reviewers,fluent-reviewers,settings-reviewers,sclements,Gijs,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D235715
2025-01-29 16:48:09 +00:00
Greg Tatum
65fb960486 Bug 1942349 - Add support for model variants; r=translations-reviewers,settings-reviewers,mossop,nordzilla
This is a big patch, but it adds the support for model variants by
defining a language pair struct instead of a fromLanguage and
toLanguage. This struct can also include a source variant and target
variant. The code will resolve the pivot models as needed.

This is not going to be release user facing, but can be used in a
Nightly setting. There is nothing enforcing this, but it's the intention
of the code.

This will allow us to test multiple variants of models in Nightly and
gather feedback from users and other engineers.

Differential Revision: https://phabricator.services.mozilla.com/D235495
2025-01-28 22:12:37 +00:00
Simon Friedberger
e968ab8747 Bug 1934587: Clear up HTTPS-Only UI for HTTPS-First, r=maltejur,fluent-reviewers,settings-reviewers,bolsson,hjones,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D234074
2025-01-28 15:10:11 +00:00
Tom Schuster
2e537bbcc1 Bug 1942618 - Remove inline event handler and use restrictive CSP for BrowserLanguagesDialog. r=settings-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D235751
2025-01-28 15:04:10 +00:00
Tom Schuster
edc685ee91 Bug 1942618 - Remove inline event handler and use restrictive CSP for selectBookmarkDialog. r=settings-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D235456
2025-01-28 15:04:10 +00:00
Tom Schuster
a9b74d6911 Bug 1942618 - Remove inline event handler and use restrictive CSP for appManager. r=settings-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D235439
2025-01-27 15:54:12 +00:00
Tom Schuster
a662ebb228 Bug 1942618 - Remove inline event handler and use restrictive CSP for old ClearSiteDataDialog. r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D235156
2025-01-23 08:45:44 +00:00
Tom Schuster
7e36c664d1 Bug 1942618 - Remove inline event handler and use restrictive CSP for LanguagesDialog. r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D235122
2025-01-23 08:45:44 +00:00
Tom Schuster
c3df36aa31 Bug 1942618 - Remove inline event handler and use restrictive CSP for ConnectionsDialog. r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D234982
2025-01-23 08:45:43 +00:00
Tom Schuster
e34f2d5ce2 Bug 1942618 - Remove inline event handler and use restrictive CSP for ContainersDialog. r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D234967
2025-01-23 08:45:43 +00:00
Tom Schuster
3617397c51 Bug 1942618 - Remove inline event handler and use restrictive CSP for FontsDialog. r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D234884
2025-01-23 08:45:43 +00:00
Tom Schuster
0a15fc2f0f Bug 1942618 - Remove inline event handler and use restrictive CSP for ColorsDialog. r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D234881
2025-01-23 08:45:42 +00:00
Nick Alexander
5257fc4269 Bug 1942166 - Add descriptions with trailing detail links in Security & Privacy preferences. r=settings-reviewers,fluent-reviewers,Gijs,flod
Differential Revision: https://phabricator.services.mozilla.com/D234593
2025-01-21 17:20:52 +00:00
Erik Nordin
a645645b42 Bug 1940972 - Unify Translations Settings Observers r=settings-reviewers,translations-reviewers,Gijs,gregtatum
This patch unifies the observers that are used in the Translations
settings to listen to the same topic: `translations:pref-changed`.

Depends on D234193

Differential Revision: https://phabricator.services.mozilla.com/D234189
2025-01-16 21:48:38 +00:00