Commit Graph

112 Commits

Author SHA1 Message Date
Tim Giles
6b44824dc0 Bug 1801927 - refactor media control learn more link. r=settings-reviewers,mconley
Replaces the "Control media via keyboard, headset, or virtual interface"
XUL label with the moz-support-link element.

Differential Revision: https://phabricator.services.mozilla.com/D166469
2023-01-18 19:13:34 +00:00
Tim Giles
bcd9cd6b58 Bug 1801927 - refactor configure how firefox connects learn more link. r=mconley
Replaces the "Configure how Nightly connects to the internet" XUL label
with the moz-support-link element.

Differential Revision: https://phabricator.services.mozilla.com/D166468
2023-01-18 19:13:34 +00:00
Tim Giles
980f7a2fe8 Bug 1801927 - refactor cfr learn more links. r=settings-reviewers,mossop
Replaces the "Recommend extensions as you browse" and
"Recommend features as you browse" XUL labels with the moz-support-link
element.

Differential Revision: https://phabricator.services.mozilla.com/D166467
2023-01-18 19:13:32 +00:00
Tim Giles
5eb6e6c483 Bug 1801927 - refactor picture in picture learn more link. r=settings-reviewers,mossop
Replaces the "Enable picture-in-picture video controls" XUL label with
the moz-support-link element.

Differential Revision: https://phabricator.services.mozilla.com/D166466
2023-01-18 19:13:32 +00:00
Tim Giles
4d98cc5271 Bug 1801927 - refactor performance settings learn more link. r=settings-reviewers,mossop
Replaces the "Use recommended performance settings" XUL label with
the moz-support-link element.

Differential Revision: https://phabricator.services.mozilla.com/D166465
2023-01-18 19:13:31 +00:00
Tim Giles
2dfc0597c8 Bug 1801927 - refactor DRM content learn more link. r=settings-reviewers,mossop
Replaces the "Play DRM-controlled content" XUL label with the
moz-support-link element.

Differential Revision: https://phabricator.services.mozilla.com/D166464
2023-01-18 19:13:31 +00:00
Tim Giles
653373bc75 Bug 1801927 - refactor containers learn more link. r=hjones,settings-reviewers,mconley
Replaces the XUL label for the "Enable Container Tabs" with the
moz-support-link element

Differential Revision: https://phabricator.services.mozilla.com/D166463
2023-01-18 19:13:31 +00:00
Valentin Gosu
73260a3dbc Bug 1596845 - Make custom about:neterror page for TRR mode3 DNS failures r=pbz,fluent-reviewers,settings-reviewers,flod,edgul
This changes about:neterror to show a specific error page when the DNS failure
occurs for a TRR mode3 page load. This offers the user more information about
the failure, and some options.

This page will be further improved at a later stage when we add a better
DNS over HTTPS settings page.

The page is visible when the browser is using DNS over HTTPS without fallback
to native DNS. To achieve this the user sets `network.trr.mode` to `3` then
loads a page such as `http://nonexistant.test`.

If a top level load's channel returns NS_ERROR_UNKNOWN_HOST we look at
whether the page was indeed loaded with an effectiveTRRMode == TRRONLY
(some loads are excluded from using TRR).
When that is true, we present the error page allowing the user to retry,
exclude the domain from TRR, or open the settings page.

Note: This initial implementation will not work if the
`network.dns.disablePrefetch` pref is set to true. In that case nsHttpChannel
does not get an OnLookupComplete callback, so it doesn't have the
effectiveTRRMode and trrSkipReason. This will be fixed in bug 1805372.

Project plan: https://docs.google.com/document/d/12IGABt1eXI276qHduXXbVZqRFrhLN7Ad3gKEgxz81sE
Copy deck: https://docs.google.com/document/d/130UTox8bQbybjYIwvltR4qBg2hWjsGhuNUHypLwUAEQ

Depends on D164642

Differential Revision: https://phabricator.services.mozilla.com/D164347
2022-12-23 09:26:16 +00:00
Marian-Vasile Laza
6fb0160a69 Backed out 9 changesets (bug 1596845) for causing xpcshell failures on test_trr_enterprise_policy.js. CLOSED TREE
Backed out changeset 231acfc052bb (bug 1596845)
Backed out changeset 7d02dad4d720 (bug 1596845)
Backed out changeset b0449eec2671 (bug 1596845)
Backed out changeset 5cd033c9ef7c (bug 1596845)
Backed out changeset 98d583f1d19e (bug 1596845)
Backed out changeset b78bc0049605 (bug 1596845)
Backed out changeset 88919aaff89b (bug 1596845)
Backed out changeset f4adb3e7b8e1 (bug 1596845)
Backed out changeset b171f7ac0b40 (bug 1596845)
2022-12-23 09:21:39 +02:00
Valentin Gosu
e8ea595264 Bug 1596845 - Make custom about:neterror page for TRR mode3 DNS failures r=pbz,fluent-reviewers,settings-reviewers,flod,edgul
This changes about:neterror to show a specific error page when the DNS failure
occurs for a TRR mode3 page load. This offers the user more information about
the failure, and some options.

This page will be further improved at a later stage when we add a better
DNS over HTTPS settings page.

The page is visible when the browser is using DNS over HTTPS without fallback
to native DNS. To achieve this the user sets `network.trr.mode` to `3` then
loads a page such as `http://nonexistant.test`.

If a top level load's channel returns NS_ERROR_UNKNOWN_HOST we look at
whether the page was indeed loaded with an effectiveTRRMode == TRRONLY
(some loads are excluded from using TRR).
When that is true, we present the error page allowing the user to retry,
exclude the domain from TRR, or open the settings page.

Note: This initial implementation will not work if the
`network.dns.disablePrefetch` pref is set to true. In that case nsHttpChannel
does not get an OnLookupComplete callback, so it doesn't have the
effectiveTRRMode and trrSkipReason. This will be fixed in bug 1805372.

Project plan: https://docs.google.com/document/d/12IGABt1eXI276qHduXXbVZqRFrhLN7Ad3gKEgxz81sE
Copy deck: https://docs.google.com/document/d/130UTox8bQbybjYIwvltR4qBg2hWjsGhuNUHypLwUAEQ

Depends on D164642

Differential Revision: https://phabricator.services.mozilla.com/D164347
2022-12-23 01:20:02 +00:00
Sandor Molnar
a10fcf6c07 Backed out 9 changesets (bug 1596845) for causing mochitest failures in browser/base/content/test/about/browser_aboutCertError_telemetry.js
Backed out changeset eb1e34c3041f (bug 1596845)
Backed out changeset af6d41439c60 (bug 1596845)
Backed out changeset f1447dd8df04 (bug 1596845)
Backed out changeset a383f2bbcaae (bug 1596845)
Backed out changeset 950c66dd6133 (bug 1596845)
Backed out changeset ab300239fd69 (bug 1596845)
Backed out changeset 8e1fe024b680 (bug 1596845)
Backed out changeset 80e5048d1f35 (bug 1596845)
Backed out changeset b14a4910d73b (bug 1596845)
2022-12-23 00:56:35 +02:00
Valentin Gosu
d40c36f86f Bug 1596845 - Make custom about:neterror page for TRR mode3 DNS failures r=pbz,fluent-reviewers,settings-reviewers,flod
This changes about:neterror to show a specific error page when the DNS failure
occurs for a TRR mode3 page load. This offers the user more information about
the failure, and some options.

This page will be further improved at a later stage when we add a better
DNS over HTTPS settings page.

The page is visible when the browser is using DNS over HTTPS without fallback
to native DNS. To achieve this the user sets `network.trr.mode` to `3` then
loads a page such as `http://nonexistant.test`.

If a top level load's channel returns NS_ERROR_UNKNOWN_HOST we look at
whether the page was indeed loaded with an effectiveTRRMode == TRRONLY
(some loads are excluded from using TRR).
When that is true, we present the error page allowing the user to retry,
exclude the domain from TRR, or open the settings page.

Note: This initial implementation will not work if the
`network.dns.disablePrefetch` pref is set to true. In that case nsHttpChannel
does not get an OnLookupComplete callback, so it doesn't have the
effectiveTRRMode and trrSkipReason. This will be fixed in bug 1805372.

Project plan: https://docs.google.com/document/d/12IGABt1eXI276qHduXXbVZqRFrhLN7Ad3gKEgxz81sE
Copy deck: https://docs.google.com/document/d/130UTox8bQbybjYIwvltR4qBg2hWjsGhuNUHypLwUAEQ

Depends on D164642

Differential Revision: https://phabricator.services.mozilla.com/D164347
2022-12-22 21:16:06 +00:00
Max Christian Pohle
60f9ef1f3e Bug 1643309 - About dialog falsely claims App "is up to date" when offline, r=bytesized,application-update-reviewers,fluent-reviewers,settings-reviewers,bhearsum,flod
This commit is based on a patch written by Priyank Singh <preyunk>. Thank you
for your contribution, which is strongly appreciated. The original patch was
discussed here: https://phabricator.services.mozilla.com/D97972#3405294

Differential Revision: https://phabricator.services.mozilla.com/D159907
2022-12-06 22:29:11 +00:00
Norisz Fay
e02f711c8c Backed out changeset e87383813223 (bug 1643309) for causing bc failures on browser_aboutDialog_fc_check_cantApply.js CLOSED TREE 2022-11-18 21:55:40 +02:00
Max Christian Pohle
116159b915 Bug 1643309 - About dialog falsely claims App "is up to date" when offline, r=bytesized,application-update-reviewers,fluent-reviewers,settings-reviewers,bhearsum,flod
This commit is based on a patch written by Priyank Singh <preyunk>. Thank you
for your contribution, which is strongly appreciated. The original patch was
discussed here: https://phabricator.services.mozilla.com/D97972#3405294

Differential Revision: https://phabricator.services.mozilla.com/D159907
2022-11-18 17:16:55 +00:00
Emilio Cobos Álvarez
9e70efc4e9 Bug 1800379 - Fix layout of network settings description with long text. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D161969
2022-11-14 21:44:12 +00:00
Emilio Cobos Álvarez
e5685e8457 Bug 1794987 - Simplify preferences find-in-page tooltip implementation. r=mconley,Gijs,preferences-reviewers
<menulist> still uses legacy XUL layout (for reasons, I plan to fix it
but it can take a little bit).

The issue here is a poor interaction between one of the wrapping hboxes
and the xul layout. But we can simplify the code and fix the bug at the
same time, so do that.

Differential Revision: https://phabricator.services.mozilla.com/D159254
2022-10-14 10:41:35 +00:00
Emilio Cobos Álvarez
22c7dc0b6a Bug 1792730 - Keep dialogs stretching over their preferred width after bug 1665476. r=Gijs,preferences-reviewers,eemeli
width gets honored properly now. What these want is really a min-width.

Differential Revision: https://phabricator.services.mozilla.com/D158286
2022-10-02 01:40:13 +00:00
Emilio Cobos Álvarez
2e072c2520 Bug 1792337 - Make about dialog use modern flexbox emulation, and size to a smaller width. r=Gijs,bytesized,application-update-reviewers,preferences-reviewers
That was presumably the intention of the explicit width in the CSS but
that wasn't working.

While at it, use a proper deck rather than a hand-rolled one.

Differential Revision: https://phabricator.services.mozilla.com/D158223
2022-09-28 20:27:57 +00:00
Kirk Steuber
ff6db15116 Bug 1756450 - Add AppUpdater.STATUS.INTERNAL_ERROR r=bhearsum,fluent-reviewers,preferences-reviewers,desktop-theme-reviewers,flod
This patch adds a state to AppUpdater to represent when an internal error has occurred. It also adds the appropriate code to the Update UI to be able to handle this state, along with a panel in each UI and a string that can go in the panels to convey to the user that update has failed.

Ideally, it would be good if this message also directed the user to a SUMO article. See Bug 1787309 for details on this. But at the moment, I would prefer to address Bug 1756450 quickly rather than wait for that to be ready.

Differential Revision: https://phabricator.services.mozilla.com/D156998
2022-09-23 19:47:33 +00:00
Emilio Cobos Álvarez
ac7ac8f3f3 Bug 1790307 - Remove equalsize="always" usage from preferences. r=Gijs,preferences-reviewers
Emulated flexbox doesn't support this, but allows you to specify widths
in percentages instead, so do that.

Differential Revision: https://phabricator.services.mozilla.com/D157073
2022-09-19 09:39:33 +00:00
Iulian Moraru
14af5f0f9d Backed out 2 changesets (bug 1790307) as per Emilio's request. CLOSED TREE
Backed out changeset fd57a3ea2b88 (bug 1790307)
Backed out changeset 646ae1f6d62c (bug 1790307)
2022-09-18 08:57:40 +03:00
Emilio Cobos Álvarez
abe7f010cd Bug 1790307 - Remove equalsize="always" usage from preferences. r=Gijs,preferences-reviewers
Emulated flexbox doesn't support this, but allows you to specify widths
in percentages instead, so do that.

Differential Revision: https://phabricator.services.mozilla.com/D157073
2022-09-13 12:17:12 +00:00
Dão Gottwald
ee0738747b Bug 1788822 - Simplify color-scheme content override pref to only be [dark, light, auto]. r=emilio,fluent-reviewers,extension-reviewers,robwu,flod
Differential Revision: https://phabricator.services.mozilla.com/D156710
2022-09-08 17:55:07 +00:00
Andre Natal
85ff5fcb87 Bug 1776814: Incorporate data-subcategory to Firefox Translations panel on about:preferences r=preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D150446
2022-06-28 16:24:32 +00:00
Shane Hughes
28555896fc Bug 1767367 - Fix inverted useDownloadDir pref. r=dao,preferences-reviewers,Gijs
I forgot to add a property in bug bug 1762775.
This patch just resolves that.

Differential Revision: https://phabricator.services.mozilla.com/D145289
2022-05-03 11:57:08 +00:00
Shane Hughes
19d105fe6d Bug 1762775 - Change download folder display in prefs UI. r=Gijs,fluent-reviewers,preferences-reviewers,desktop-theme-reviewers,dao,flod
The default download folder prefs are now counterintuitively used
whether browser.download.useDownloadDir is enabled or not, since we no
longer save downloads to the "temp" folder. But the display for these
prefs in about:preferences makes it seem as though the configured path
will not be used if the "Always ask..." option is selected. This patch
removes the radiogroup and replaces it with a checkbox, so that the
download folder path can be changed irrespective of useDownloadDir's
value (unless browser.download.dir is disabled by policy).

Differential Revision: https://phabricator.services.mozilla.com/D143555
2022-04-28 19:49:17 +00:00
Shane Hughes
0604bb580c Bug 1747343 - Add pref to set default action for new mimetypes. r=Gijs,fluent-reviewers,preferences-reviewers
When downloading a file, we check for existing mime types and construct
a new one if it's unrecognized. Mime types have a flag,
alwaysAskBeforeHandling, that determines whether the unknown content
type dialog should be opened before handling the file. Before bug
1733492, the default value for that flag was simply true. Since the new
downloads flow is intended to avoid unnecessary steps, the default value
was changed to the inverted value of the new downloads panel
improvements pref. This patch adds a new pref that the mime info
constructor will read in configuring the flag's value. If the
improvements pref is not enabled, then the flag will be true, so the UCT
dialog will open. If the improvements pref is enabled, then it'll use
the value of the new pref. Also add a an interface for the pref to the
about:preferences UI, and automatically migrate a false value for
browser.download.improvements_to_download_panel to a true value for this
pref. I'm updating some tangentially related test files since they
happen to be touched slightly by this change. Strictly speaking they
would still work, but if the pref value was somehow changed from the
default they would fail.

Differential Revision: https://phabricator.services.mozilla.com/D143002
2022-04-15 18:13:11 +00:00
Butkovits Atila
0a0a5f66a3 Backed out changeset 543a78ca4fa9 (bug 1747343) for causing mochitest failures at browser_bug676619.js. CLOSED TREE 2022-04-13 03:31:53 +03:00
Shane Hughes
d59826c8a2 Bug 1747343 - Add pref to set default action for new mimetypes. r=Gijs,fluent-reviewers,preferences-reviewers
When downloading a file, we check for existing mime types and construct
a new one if it's unrecognized. Mime types have a flag,
alwaysAskBeforeHandling, that determines whether the unknown content
type dialog should be opened before handling the file. Before bug
1733492, the default value for that flag was simply true. Since the new
downloads flow is intended to avoid unnecessary steps, the default value
was changed to the inverted value of the new downloads panel
improvements pref. This patch adds a new pref that the mime info
constructor will read in configuring the flag's value. If the
improvements pref is not enabled, then the flag will be true, so the UCT
dialog will open. If the improvements pref is enabled, then it'll use
the value of the new pref. Also add a an interface for the pref to the
about:preferences UI, and automatically migrate a false value for
browser.download.improvements_to_download_panel to a true value for this
pref. I'm updating some tangentially related test files since they
happen to be touched slightly by this change. Strictly speaking they
would still work, but if the pref value was somehow changed from the
default they would fail.

Differential Revision: https://phabricator.services.mozilla.com/D143002
2022-04-12 22:32:45 +00:00
Punam Dahiya
c34f55fcf7 Bug 1751093 - Clean up Cloud Storage API and its usage in about:preferences r=preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D137248
2022-04-07 10:17:13 +00:00
Emilio Cobos Álvarez
478c168f2f Bug 1736218 - Add tooltip text to appearance chooser as aria-description. r=morgan,Gijs,fluent-reviewers,preferences-reviewers
Note that this depends on bug 1759925 to work.

Depends on D140223

Differential Revision: https://phabricator.services.mozilla.com/D141279
2022-03-18 14:26:17 +00:00
Emilio Cobos Álvarez
731cdda4e6 Bug 1736218 - Implement website appearance chooser. r=Gijs,fluent-reviewers,preferences-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D140223
2022-03-17 14:44:04 +00:00
Emilio Cobos Álvarez
5e9172396b Bug 1736218 - Split "Fonts and Colors" into two sections in about:preferences. r=Gijs,fluent-reviewers,preferences-reviewers,dao,flod
As per the UX design.

Differential Revision: https://phabricator.services.mozilla.com/D140222
2022-03-17 14:44:04 +00:00
Katherine Patenio
5e5f94c8e9 Bug 1507619 - Simplified the extension-controlled preference notice. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D111292
2022-03-10 19:06:04 +00:00
Emilio Cobos Álvarez
0f785a05ba Bug 1147847 - Allow users to enable overlay scrollbars on Linux from about:preferences. r=Gijs,fluent-reviewers,preferences-reviewers
We might want to do this on Windows 11 as well, but Windows 11 has a
system-wide preference with UI so let's not do that just yet at least,
UI-exposed preference.

Differential Revision: https://phabricator.services.mozilla.com/D138502
2022-02-14 07:43:42 +00:00
Shane Hughes
90dfc9a6b9 Bug 1749155 - Add a Nightly-only option to suppress update available notifications. r=fluent-reviewers,bytesized
The new pref app.update.suppressPrompts will allow user to suppress
update-available prompts (popupnotifications) for up to seven days.
Instead, Nightly will display an update badge and banner immediately,
and wait 7 days before showing an interactive prompt. It will also
disable update-restart prompts entirely, instead showing badge and
banner. This also adds telemetry to measure how often these update
prompts are being suppressed via user preference. All of these features
are only enabled on Nightly builds.

Differential Revision: https://phabricator.services.mozilla.com/D135449
2022-02-02 00:09:54 +00:00
Greg Tatum
79d3b1c3a1 Bug 1740067 - Rename language switching variables to be more explicit; r=mstriemer,platform-i18n-reviewers,preferences-reviewers,nordzilla
These were all areas that were confusing me when I was onboarding on to
this code, so I tried to make the terminology less ambiguous and more
precise.

The default language is now the primary language.

UI is now appended to words that are dealing with DOM elements rather
than data stores.

Differential Revision: https://phabricator.services.mozilla.com/D136019
2022-01-20 21:42:27 +00:00
Itiel
57b4f10c9d Bug 1710392 - Consolidate info boxes in about:preferences r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D115421
2021-09-21 18:14:52 +00:00
Neil Deakin
528679c058 Bug 1726736, add checkbox to the main preferences page for the confirm on pressing the quit keyboard shortcut setting, r=Gijs,fluent-reviewers,preferences-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D124223
2021-09-08 12:32:58 +00:00
Neil Deakin
a119e0db4e Bug 1724976, whether to show quit warning should not be dependent on session restore state, and remove the redundant browser.sessionstore.warnOnQuit preference, r=Gijs,fluent-reviewers,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D124221
2021-09-08 12:32:57 +00:00
Andre Natal
612e9f013e Bug 1715913 - Update Firefox Translations to 0.4.3 r=preferences-reviewers,jaws,fluent-reviewers,flod,mixedpuppy
Updating Firefox Translations to 0.4.3 https://bugzilla.mozilla.org/show_bug.cgi?id=1715913
Adding a new option to the preferences menu to handle translations exceptions https://bugzilla.mozilla.org/show_bug.cgi?id=1714031
Fixes diffoscope issues https://bugzilla.mozilla.org/show_bug.cgi?id=1713561

Differential Revision: https://phabricator.services.mozilla.com/D117512
2021-07-13 21:00:08 +00:00
Valentin Gosu
0bde9079df Bug 1713356 - Remove FTP reference from proxy config panel r=necko-reviewers,fluent-reviewers,preferences-reviewers,flod,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D116372
2021-06-01 07:43:29 +00:00
Gijs Kruitbosch
efc34c725e Bug 1706487 - honour browser.tabs.loadInBackground for 'Open Image/Video/Audio in New Tab', r=mconley,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D115545
2021-05-21 17:58:05 +00:00
Alexandru Michis
2d20f1dd01 Backed out changeset 3ef9ef49563a (bug 1706487) for causing bc failures in browser_bug734076.js
CLOSED TREE
2021-05-21 15:11:49 +03:00
Gijs Kruitbosch
8cc10fc39b Bug 1706487 - honour browser.tabs.loadInBackground for 'Open Image/Video/Audio in New Tab', r=mconley,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D115545
2021-05-21 10:13:47 +00:00
Valentin Gosu
66643c5bf0 Bug 1574475 - Remove FTP proxy code r=necko-reviewers,preferences-reviewers,mixedpuppy,mkaply,dragana
Differential Revision: https://phabricator.services.mozilla.com/D111248
2021-04-28 09:33:46 +00:00
Narcis Beleuzu
359bfccedf Backed out 8 changesets (bug 1574475, bug 1699222) for build bustages on moz.build . CLOSED TREE
Backed out changeset 6c2c039872b3 (bug 1574475)
Backed out changeset 8a2a04743c5f (bug 1699222)
Backed out changeset 9437c60798d6 (bug 1574475)
Backed out changeset 7ef1884ac11b (bug 1574475)
Backed out changeset ec8c237d5298 (bug 1574475)
Backed out changeset 4a760b3f5d53 (bug 1574475)
Backed out changeset b229b0eea1e7 (bug 1574475)
Backed out changeset 03d34a2f10a6 (bug 1574475)
2021-04-22 18:10:59 +03:00
Valentin Gosu
52e46d11c4 Bug 1574475 - Remove FTP proxy code r=necko-reviewers,preferences-reviewers,mixedpuppy,mkaply,dragana
Differential Revision: https://phabricator.services.mozilla.com/D111248
2021-04-22 13:41:34 +00:00
Bernard Igiri
186b5a93bd Bug 1692303 - Flip default value to browser.ctrlTab.recentlyUsedOrder to false r=mstriemer,mconley,preferences-reviewers
Changed default Ctrl+Tab preference to false and added UI migration to reset it for users who haven't not used the feature before.

Differential Revision: https://phabricator.services.mozilla.com/D109653
2021-03-26 21:56:41 +00:00