corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
701,513 Commits 1 Branch 0 Tags
103b1ef19e76136e48149023f6d6f200171b9c58
Commit Graph

157 Commits

Author SHA1 Message Date
Paolo Amadini
ff1ddd6adf Bug 1434883 - Part 2 - Use an asynchronous API to open PanelMultiView panels. r=Gijs 
MozReview-Commit-ID: 3VzoxJ3Ociy
 2018-02-06 09:02:27 +00:00
Cosmin Sabou
27ede269b6 Backed out 3 changesets (bug 1434883) for frequent leaks in AbstractThread, AnimationTimeline, Annotators, Array, AsyncFreeSnowWhite, ... on a CLOSED TREE 
Backed out changeset c8115e90ffa8 (bug 1434883)
Backed out changeset 22c83b1d417d (bug 1434883)
Backed out changeset 085796417462 (bug 1434883)
 2018-02-06 16:30:56 +02:00
Paolo Amadini
ea8006dd5d Bug 1434883 - Part 2 - Use an asynchronous API to open PanelMultiView panels. r=Gijs 
MozReview-Commit-ID: 3VzoxJ3Ociy
 2018-02-06 09:02:27 +00:00
Paolo Amadini
f6b0b3a5cf Bug 1432015 - Part 3 - Ensure that views passed to showSubView are added to the list of known views without having to reset the internal _panelViews variable. r=Gijs 
MozReview-Commit-ID: Hld45ghdduv
 2018-01-17 15:04:18 +00:00
Paolo Amadini
01051cc093 Bug 1432015 - Part 2 - Remove the setMainView methods. r=Gijs 
The setMainView method of PanelMultiView controls the "mainview" attribute, which is already set or removed later in the showSubView method. When called at construction time, it changes the mainViewId if there is at least one child in the "panelmultiview" element and the original mainViewId does not already reference the first child. This would be incorrect, but in practice it never happens for either ephemeral or static panels, and can be avoided for the throw-away activated page action panel.

The setMainView method of PanelUI is never called, and this makes the corresponding PanelMultiView method removable.

MozReview-Commit-ID: 5bNidHfKFTA
 2018-01-21 15:59:41 +00:00
Paolo Amadini
f8ef353e81 Bug 1432015 - Part 1 - Fix anchor handling for the action feedback panel. r=Gijs 
Commands started from an activated action panel should not be anchored to the main button, and regression tests should simulate the case where both the main action panel and the individual action button are visible and the action is invoked from the main action panel.

MozReview-Commit-ID: Eg1wP2rRe2d
 2018-01-21 17:01:59 +00:00
Paolo Amadini
a5de33f591 Bug 1417042 - Remove the "panelview" binding. r=Gijs 
MozReview-Commit-ID: 26uQb3pteQd
 2017-12-06 10:37:25 +00:00
Edouard Oger
a1ad9ef027 Bug 1417597 - Show a different feedback message in send tab when we're offline. r=jaws 
MozReview-Commit-ID: Emsx0LwFAE1
 2017-11-16 16:11:46 -05:00
Paolo Amadini
192bb221a0 Bug 1414244 - Part 6 - Fold the "photonpanelmultiview" binding into "panelmultiview". r=Gijs 
MozReview-Commit-ID: IjvSZZUHUMt
 2017-11-21 14:21:32 +00:00
Drew Willcoxon
ca57d75e25 Bug 1417272 - The "Send Tab to Device" page action can be disabled in the page action menu but enabled in the urlbar. r=Gijs 
MozReview-Commit-ID: BZ4CAqG0kkH
 2017-11-15 11:25:45 -08:00
Drew Willcoxon
058e41bcb5 Bug 1417036 - "Save to Pocket" drop down menu glitches. r=Gijs 
MozReview-Commit-ID: 1JPOmQNLn26
 2017-11-15 10:44:47 -08:00
Edouard Oger
63712d8b1c Bug 1304898 - Include why in sync ping. r=tcsc 
MozReview-Commit-ID: G9WnHhuWD7Z
 2017-11-15 17:10:45 -05:00
Drew Willcoxon
7708c2f9fb Bug 1413574 - Hide disabled page actions and offer a "Manage Extension" command for actions in extensions. r=Gijs 
MozReview-Commit-ID: HJpu9Jfi2bB
 2017-11-10 11:06:02 -05:00
Drew Willcoxon
d41c2d5435 Bug 1412170 - Integrate WebExtension page action context menus with the Photon page action context menu: Photon page action changes. r=jaws 
MozReview-Commit-ID: BOEhQEJbUNO
 2017-10-30 17:47:54 -04:00
Phil Ringnalda
c8ae0986f8 Backed out 2 changesets (bug 1412170) for eslint bustage 
Backed out changeset a9a646fe54ec (bug 1412170)
Backed out changeset 8b46ed411edf (bug 1412170)

MozReview-Commit-ID: Et3MnX3ieBe
 2017-10-30 14:21:45 -07:00
Drew Willcoxon
23a3b0cc04 Bug 1412170 - Integrate WebExtension page action context menus with the Photon page action context menu: Photon page action changes. r=jaws 
MozReview-Commit-ID: BOEhQEJbUNO
 2017-10-30 16:53:21 -04:00
Drew Willcoxon
30d6fb86b3 Bug 1395387 - Reconcile WebExtension page actions and Photon page actions: Photon page actions changes. r=Gijs 
MozReview-Commit-ID: 5NOc9N2idRE
 2017-10-27 17:39:38 -04:00
Mark Banner
e47ccbfec3 Bug 1411368 - Automatically fix no-multi-spaces issues raised when using ESLint 4. r=mossop 
MozReview-Commit-ID: H5YVp3rnzGo
 2017-10-26 11:47:01 +01:00
Jared Wein
6b69a645ce Bug 1408135 - Copy URL confirmation message should appear where user selects it. r=mikedeboer 
MozReview-Commit-ID: 99hEGe7Dtgf
 2017-10-19 11:58:53 -04:00
Henrik Adolfsson
5710371885 Bug 1392536 - Add last sync date as tooltip to send to device tab 
MozReview-Commit-ID: BsCoBJXm10B
 2017-10-10 13:50:28 -04:00
Drew Willcoxon
530f991093 Bug 1387141 - Pocket button does not stay red after URL pocketed and animation has finished. r=Gijs 
MozReview-Commit-ID: KQVOUJUOfrx
 2017-10-05 13:03:44 -07:00
Drew Willcoxon
ac48455938 Bug 1385882 - Intermittent browser/base/content/test/urlbar/browser_page_action_menu.js | Test timed out. r=Gijs 
MozReview-Commit-ID: H6BtvGNtMmQ
 2017-10-05 12:45:15 -07:00
Gijs Kruitbosch
8030db146a Bug 1389721 - fix page action menu to deal with not being passed an event, so the 'save link to pocket' context menu works, r=jaws 
This also removes the now-obsolete onBeforeCommand method from the pocket code.

MozReview-Commit-ID: EjrMoAIv3xw
 2017-10-02 20:34:01 +01:00
Gijs Kruitbosch
514cadc9cc Bug 1393843 - add telemetry for page action items and the context menu that enables/disables them, data-review=rweiss, r=adw,rweiss+418169 
MozReview-Commit-ID: E52TGDLgjCC
 2017-09-20 17:32:11 +01:00
Drew Willcoxon
e3b9b7a9a0 Bug 1402721 - Add/edit bookmark panel should open anchored on the page action (ellipsis) button instead of on the identity block (left side of the address bar) when the bookmarks star action is not pinned/visible. r=Gijs 
MozReview-Commit-ID: JMviXx5ov7F
 2017-09-25 13:30:08 -07:00
Gijs Kruitbosch
cbee9f0379 Bug 1397790 - add 'open' active state to urlbar buttons, use a more distinct background colour for it, r=abenson+572682,adw 
MozReview-Commit-ID: 7QrhAB79yNw
 2017-09-19 15:13:25 +01:00
Zibi Braniecki
424682e3b6 Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs 
MozReview-Commit-ID: Ie2Xgasg2eN
 2017-09-09 22:17:19 -07:00
Sebastian Hengst
3a807c09ee Backed out changeset 1a8147d55b02 (bug 1398390) for failing browser-chrome's browser_overflow_anchor.js at least on macOS and Windows. r=backout 2017-09-10 09:37:30 +02:00
Zibi Braniecki
8c25be70ea Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs 
MozReview-Commit-ID: Ie2Xgasg2eN
 2017-09-09 22:17:19 -07:00
Drew Willcoxon
4ee0451f04 Bug 1397501 - Page actions added to the urlbar should always come before the bookmark star. r=Gijs 
MozReview-Commit-ID: 6pVlr9d0crn
 2017-09-07 16:44:34 -07:00
Drew Willcoxon
a2aa0d2017 Bug 1396053 - Page action urlbar button ordering can get messed up for new windows. r=Gijs 
MozReview-Commit-ID: 1KwrS6tsnhO
 2017-09-04 23:58:27 -07:00
Drew Willcoxon
cffe92c4ac Bug 1395410 - Page action notifications should be anchored on relevant urlbar button, not main button, if present. r=jaws 
MozReview-Commit-ID: iFM0cR7zFi
 2017-08-31 15:48:19 -07:00
Drew Willcoxon
e03d0b329b Bug 1395154 - If Send Page to Device pageAction is Pinned, it should dismiss when a user sends a tab. r=jaws 
MozReview-Commit-ID: HkuzOOp8PDP
 2017-08-31 15:27:22 -07:00
Drew Willcoxon
3c01e4a6ec Bug 1395398 - Send to Device notification shouldn't appear after clicking "Sign in" and other non-device menu items. r=jaws 
MozReview-Commit-ID: Gm35IfZCJPQ
 2017-08-31 09:38:37 -07:00
Drew Willcoxon
cbe1682561 Bug 1395178 - The new buttons that can be added to the toolbar don't announce themselves to screen readers as buttons. r=jaws 
MozReview-Commit-ID: AvQD9Z9ySfu
 2017-08-30 13:29:54 -07:00
Jared Wein
1dc9cbd023 Bug 1395194 - Copy URL confirmation should fade out at timeout. r=adw 
MozReview-Commit-ID: DTrzSOaft3N
 2017-08-30 16:23:05 -04:00
Jared Wein
fc159ecb24 Bug 1387042 - Add a toast notification that will be shown when the Copy Link or Send to Device page actions are used. r=adw,sfoster 
MozReview-Commit-ID: CZZnLz84T4h
 2017-08-24 16:44:11 -04:00
Drew Willcoxon
b69a7ae1a8 Bug 1388835 - Hide page action urlbar buttons on about pages (about:preferences, etc.). r=Gijs 
MozReview-Commit-ID: 9lid8VpPkJE
 2017-08-26 12:47:33 -07:00
Gijs Kruitbosch
81c80329ee Bug 1391705 - don't show context menu except on toolbarbuttons on the main view, r=adw 
MozReview-Commit-ID: GkGXAIrP15u
 2017-08-23 13:29:47 +01:00
Drew Willcoxon
1314df9dee Bug 1391759 - [Photon] Page action temp panel (e.g., the Pocket panel) should have rounded corners (not square ones) on OS X. r=Gijs 
MozReview-Commit-ID: 6EdRRjsQLga
 2017-08-18 12:48:01 -07:00
Drew Willcoxon
a8d05b5a04 Bug 1391082 - Page action panel ordering can get messed up. r=Gijs 
MozReview-Commit-ID: 3hQLTLF3RU8
 2017-08-17 16:40:35 -07:00
Gijs Kruitbosch
e5158ce8b9 Bug 1366327 - deal with about:reader, IDNA and non-exposable URIs better for copy/email link, r=adw 
MozReview-Commit-ID: AnZa3mq2zMY
 2017-08-17 13:11:06 +01:00
Drew Willcoxon
062e2f296c Bug 1385418 - Remove disabled pocket code for the toolbar button now that it's been replaced by the item in the page action panel. r=Gijs 
MozReview-Commit-ID: 1wANxaD3QaV
 2017-08-16 10:13:15 -07:00
Dão Gottwald
fcc243e9bd Bug 1389740 - Rename urlbar-icons to page-action-buttons. r=gijs 
MozReview-Commit-ID: 980Rvv8mxtU
 2017-08-14 16:45:17 +02:00
Sebastian Hengst
c191a5443c Backed out changeset c73631b194bb (bug 1389740) for failing Firefox-UI's test_windows.py and test_about_private_browsing.py. r=backout 2017-08-12 18:42:57 +02:00
Dão Gottwald
a29e4c0d87 Bug 1389740 - Consolidate URL bar history dropmarker styling. r=Gijs 
The dropmarker gets the urlbar-icon class for consistency with the other URL bar icons. On this occasion, I increased the urlbar-icon padding and removed the margin to match the photon spec. Also added a rudimentary hover effect.

#urlbar-icons is renamed to #page-action-buttons to better reflect its meaning, and because .urlbar-icon is now used outside of this container.

#urlbar-wrapper wrapper isn't needed anymore -- we can just set the switchingtabs attribute directly on #urlbar.

MozReview-Commit-ID: EiuUW71IKgU
 2017-08-12 17:49:35 +02:00
Jared Wein
a080e2809f Bug 1387077 - Reimplement Pocket animation in the Page Action area. r=adw 
MozReview-Commit-ID: 5pJ96un8W5t
 2017-08-08 11:56:49 -04:00
Wes Kocher
d497d08bc6 Backed out changeset d4cc2f1e5c48 (bug 1387077) for windows debug crashtest failures a=backout 
MozReview-Commit-ID: kEMoucDCJY
 2017-08-10 15:46:38 -07:00
Jared Wein
bb3b0a581d Bug 1387077 - Reimplement Pocket animation in the Page Action area. r=adw 
MozReview-Commit-ID: 5pJ96un8W5t
 2017-08-08 11:56:49 -04:00
Michael Kohler
f15ab23e9f Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code. r=dao 
MozReview-Commit-ID: 8w1vfF2yRui
 2017-08-08 12:09:14 +02:00