Adding additional UI elements and filling out state machine with actualy UI updates. Some functions are stubbed out while waiting on ML to have API up on central. These UI changes should have no change to current UI if pref is turned off.
Differential Revision: https://phabricator.services.mozilla.com/D237277
Adding additional UI elements and filling out state machine with actualy UI updates. Some functions are stubbed out while waiting on ML to have API up on central. These UI changes should have no change to current UI if pref is turned off.
Differential Revision: https://phabricator.services.mozilla.com/D237277
Adding additional UI elements and filling out state machine with actualy UI updates. Some functions are stubbed out while waiting on ML to have API up on central. These UI changes should have no change to current UI if pref is turned off.
Differential Revision: https://phabricator.services.mozilla.com/D237277
Landing in moz-central the utility SmartTabGrouping class that enables smart tab grouping of browser tabs.
This includes some cleanup in the toolkit/../ml /code, including adding more tests.
We are slimming test data tsv files by using 5 dimensional embeddings instead of 500 dim.
There is still some algorithm code in /tabbrowser/SmartTabGrouping because it is tied up with tabs. We could maybe move some to toolkit/../ml if required but it is a little tricky.
With this patch landed, some clustering access would be available in the console by typing: gBrowser.smartTabGrouping()
@ngrato will have a separate patch to enable the UI.
Differential Revision: https://phabricator.services.mozilla.com/D237112
We just need to make sure all the throbber animations share a start
time, and we can use an arbitrary time (i.e., zero) rather than going
through all the tabs.
Differential Revision: https://phabricator.services.mozilla.com/D235300
Saved groups, open groups in other windows, and open groups in the current window all have `command` handlers defined in the tab overflow menu (TOM) to perform an action when clicked. However, the tab groups spec shows additional actions that should be available when right-clicking on those tab groups in the TOM. This patch adds those context menus and wires up their functionality:
- opening in current window
- opening in, or moving to, a new window
- deleting an open group
- forgetting a saved group
Differential Revision: https://phabricator.services.mozilla.com/D233129
Saved groups, open groups in other windows, and open groups in the current window all have `command` handlers defined in the tab overflow menu (TOM) to perform an action when clicked. However, the tab groups spec shows additional actions that should be available when right-clicking on those tab groups in the TOM. This patch adds those context menus and wires up their functionality:
- opening in current window
- opening in, or moving to, a new window
- deleting an open group
- forgetting a saved group
Differential Revision: https://phabricator.services.mozilla.com/D233129
Currently, when the tab strip is in focus, pressing the arrow keys currently switches the active tab only. With this change, pressing the arrow keys will continue to switch the active tab when the adjacent item in the tab strip is a tab, but tab group labels will also receive keyboard focus if they happen to the adjacent items in the tab strip. Now, pressing left/right allows the user to "select" each tab or tab group label in the tab strip.
Differential Revision: https://phabricator.services.mozilla.com/D233016
1. should be available in the context menu even if there are collapsed tab groups to the left/right
2. should close collapsed tab groups when they are to the left/right
3. tab groups should be saved when they are going to be closed when using "close tabs to the left/right"
Differential Revision: https://phabricator.services.mozilla.com/D232432
