Commit Graph

54 Commits

Author SHA1 Message Date
kernp25
cb1f1d5155 Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth
Differential Revision: https://phabricator.services.mozilla.com/D233071
2025-02-10 15:24:32 +00:00
Gijs Kruitbosch
747d34d801 Bug 1916424 - allow idle dispatch from BrowserUtils' category manager-based invocations, r=mossop,search-reviewers,urlbar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D220896
2025-02-07 16:54:50 +00:00
Moritz Beier
152f732f88 Bug 1880913 - Part 3: Move open search handling from BrowserSearch to dedicated module. r=Standard8,urlbar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D235597
2025-02-04 11:07:12 +00:00
Moritz Beier
6c0a5096a8 Bug 1880913 - Part 1: Move urlbar placeholder handling from BrowserSearch to UrlbarInput. r=urlbar-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D235595
2025-02-04 11:07:11 +00:00
Butkovits Atila
b061588f31 Backed out changeset 2c11770a86dc (bug 1939658) for causing failures at test_JsonSchemaValidator.js. CLOSED TREE 2025-02-04 13:07:29 +02:00
kernp25
cd2f76670a Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth
Differential Revision: https://phabricator.services.mozilla.com/D233071
2025-02-04 08:25:28 +00:00
Tom Schuster
e26598fb5f Bug 1938883 - Remove inline event handlers from managed bookmarks. r=firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D232828
2024-12-28 11:14:00 +00:00
Fred Chasen
2a40aed615 Bug 1916547 - Part 1: Render Review Checker in the new sidebar. r=shopping-reviewers,firefox-desktop-core-reviewers ,sidebar-reviewers,sclements,mossop,kpatenio
- Adds a remote content browser to contain `about:shoppingsidebar` in `review-checker.xhtml` and update the Review Checker sidebar to use that wrapper document.
- Adds ReviewChecker actors for the sidebar Review Checker panel.
- ReviewCheckerParent is a simplified version of the ShoppingSidebarParent as it does not need to handle the state of the sidebar opening or closing.
- ReviewCheckerChild is just extends ShoppingSidebarChild for now, though it will need to be separate in the future.
- Adds a browser.shopping.experience2023.shoppingSidebar boolean pref to disable ShoppingSidebar actors when they are not needed.
- Fixes `AbortError` error handling when the outer sidebar browser is removed.

Note that any auto-opening or closing behavior will need to be added afterwards, as these actors are not around to check product urls when the sidebar is closed.

Differential Revision: https://phabricator.services.mozilla.com/D222840
2024-12-12 01:24:20 +00:00
Emilio Cobos Álvarez
768894a512 Bug 1932600 - Use customtitlebar rather than tabsintitlebar in front-end code. r=dao,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley
This is probably also a better reflection of reality now that we can
have vertical tabs which would by definition not be in the titlebar.

Differential Revision: https://phabricator.services.mozilla.com/D229767
2024-11-28 12:12:51 +00:00
Emilio Cobos Álvarez
feebe3d11d Bug 1930292 - Turn chromemargin into a boolean attribute. r=win-reviewers,desktop-theme-reviewers,pip-reviewers,firefox-desktop-core-reviewers ,dao,mconley,rkraesig
There are probably other simplifications that can be done after this on the
windows side of things, but I tried to keep this minimal.

Differential Revision: https://phabricator.services.mozilla.com/D229765
2024-11-28 12:12:50 +00:00
Cristina Horotan
bb08cc9f1d Backed out 5 changesets (bug 1930292, bug 1932600) for causing chrome failures at test_maximized_persist.xhtml on a CLOSED TREE
Backed out changeset 2418bfee53f1 (bug 1932600)
Backed out changeset 3297e990715a (bug 1932600)
Backed out changeset 24a670dea977 (bug 1930292)
Backed out changeset 7dd9f48216dd (bug 1930292)
Backed out changeset 15a85ec739dd (bug 1930292)
2024-11-28 06:57:35 +02:00
Emilio Cobos Álvarez
26de824592 Bug 1932600 - Use customtitlebar rather than tabsintitlebar in front-end code. r=dao,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley
This is probably also a better reflection of reality now that we can
have vertical tabs which would by definition not be in the titlebar.

Differential Revision: https://phabricator.services.mozilla.com/D229767
2024-11-28 03:26:50 +00:00
Emilio Cobos Álvarez
67678746e6 Bug 1930292 - Turn chromemargin into a boolean attribute. r=win-reviewers,desktop-theme-reviewers,pip-reviewers,firefox-desktop-core-reviewers ,dao,mconley,rkraesig
There are probably other simplifications that can be done after this on the
windows side of things, but I tried to keep this minimal.

Differential Revision: https://phabricator.services.mozilla.com/D229765
2024-11-28 03:26:50 +00:00
Ray Kraesig
19038c4983 Bug 1929474 - [1/2] Fix Win10 tablet-mode hiding of close-button r=desktop-theme-reviewers,dao
The simplification of browser.css in bug 1844242 caused the close-button
to be hidden in tablet mode alongside the window-resizing buttons.
Revert that change's effect, and add documentation.

Differential Revision: https://phabricator.services.mozilla.com/D228205
2024-11-14 18:01:42 +00:00
Dão Gottwald
f8d89fd012 Bug 1930654 - Convert _gBrowser to a modern JS class. r=tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D228667
2024-11-14 16:33:19 +00:00
Alexandru Marc
898e7469f6 Backed out changeset 365a4dc7fe2d (bug 1930654) for causing bc failures @ browser_standalone_application_chooser_window_fallback.js . CLOSED TREE 2024-11-14 17:37:47 +02:00
Dão Gottwald
af03c5baa7 Bug 1930654 - Convert _gBrowser to a modern JS class. r=tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D228667
2024-11-14 14:02:57 +00:00
Simon Friedberger
4fcd691190 Bug 1919544 - Do not HTTPS-First upgrade URLs with http:// scheme r=mak,necko-reviewers,urlbar-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228588
2024-11-13 17:15:57 +00:00
Sandor Molnar
9e0c14a80e Backed out changeset c4dfee1f9194 (bug 1919544) for causing bc failures @ browser_UrlbarInput_formatValue.js CLOSED TREE 2024-11-13 15:20:39 +02:00
Simon Friedberger
8eafd874fe Bug 1919544 - Do not HTTPS-First upgrade URLs with http:// scheme r=mak,necko-reviewers,urlbar-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228588
2024-11-13 11:44:43 +00:00
Sandor Molnar
882c106d21 Backed out 2 changesets (bug 1926145, bug 1924850) for causing bc failures @ browser_menubar_profiles CLOSED TREE
Backed out changeset ce1ce2a8cacd (bug 1924850)
Backed out changeset 387976dca835 (bug 1926145)
2024-11-06 01:15:56 +02:00
Jared Hirsch
a6726bdfef Bug 1926145 - Add profiles menu to menubar. r=niklas,fluent-reviewers,desktop-theme-reviewers,dao,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226412
2024-11-05 21:02:14 +00:00
Dave Townsend
6928b89ed0 Bug 1893692: Notify concurrent profiles via remoting service. r=jhirsch,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D227026
2024-11-01 10:11:24 +00:00
Kelly Cochrane
fc97d3f90a Bug 1925451 - Fix for vertical tabs not always being visible in new windows r=sidebar-reviewers,Gijs,sclements
Differential Revision: https://phabricator.services.mozilla.com/D227089
2024-10-29 14:34:39 +00:00
Jared Hirsch
971718cd11 Bug 1883162 - Update profiles app menu to latest design using selectable profiles. r=niklas,fluent-reviewers,desktop-theme-reviewers,bolsson,dao
Differential Revision: https://phabricator.services.mozilla.com/D223238
2024-10-18 23:57:55 +00:00
Sandor Molnar
5eb3d8fc2b Backed out changeset e7719ffbcf2e (bug 1883162) for causing bc failures @ browser_sentence_case_strings.js CLOSED TREE 2024-10-18 04:22:37 +03:00
Jared Hirsch
d6887069ea Bug 1883162 - Update profiles app menu to latest design using selectable profiles. r=niklas,fluent-reviewers,desktop-theme-reviewers,bolsson,dao
Differential Revision: https://phabricator.services.mozilla.com/D223238
2024-10-17 23:55:53 +00:00
Gregory Pappas
ab4cbe853e Bug 1918681 - part 1: Allow moving the list-all-tabs button again r=dao
In bug 878551, the ability to move the list-all-tabs button was	removed
for a few reasons:

> Moving this widget to the navbar gives it a tiny scaled version of Toolbar.png (like a horizontal line).

> Moving it back to the tab strip make it misbehave. It disappears, but sometimes flickers into view when opening/closing a tab.

These issues are no longer present, so we should be able to allow moving
the list-all-tabs button once again.

Differential Revision: https://phabricator.services.mozilla.com/D224623
2024-10-09 02:35:42 +00:00
Chris H-C
724b00c304 Bug 1920562 - Remove JS uses of Services.telemetry.setEventRecordingEnabled r=florian,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,sessionstore-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,urlbar-reviewers,sfoster,nchevobbe,valentin,Gijs,dimi,lina,mconley,pdahiya,willdurand
Differential Revision: https://phabricator.services.mozilla.com/D223833
2024-10-08 20:14:42 +00:00
Sandor Molnar
92076e16a7 Backed out 5 changesets (bug 1920562) for causing xpc assertion failures. CLOSED TREE
Backed out changeset 8f085ab589a8 (bug 1920562)
Backed out changeset 4405387ae770 (bug 1920562)
Backed out changeset a68fd13a33ae (bug 1920562)
Backed out changeset cd3672fc08ed (bug 1920562)
Backed out changeset 62ab18879eea (bug 1920562)
2024-10-08 00:16:13 +03:00
Chris H-C
e944bfe7a2 Bug 1920562 - Remove JS uses of Services.telemetry.setEventRecordingEnabled r=florian,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,sessionstore-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,urlbar-reviewers,sfoster,nchevobbe,valentin,Gijs,dimi,lina,mconley,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D223833
2024-10-07 17:29:57 +00:00
Sam Foster
58c1f20705 Bug 1899598 - Hide the horizontal tab strip when vertical tabs are enabled. r=mconley,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,emilio,willdurand,sclements
* Remove the #titlebar element, and ensure toolbars that comprise the titlebar get a .browser-titlebar class
* Ensure we call TabBarVisibility.update when initializing with verticalTab=true
* Adjust TabBarVisibility logic so we allow for the vertical tabs case
* Give #navigator-toolbar z-index: var(--browser-area-z-index-toolbox) to ensure the urlbar view doesnt get clipped behind the lower elements

Differential Revision: https://phabricator.services.mozilla.com/D222059
2024-10-02 22:14:13 +00:00
Iulian Moraru
4a9432209c Backed out changeset 98b6ddc6deed (bug 1899598) for causing marionette failures on test_initialize_vertical_tabs.py. CLOSED TREE 2024-10-02 07:49:47 +03:00
Sam Foster
15a36fe751 Bug 1899598 - Hide the horizontal tab strip when vertical tabs are enabled. r=mconley,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,emilio,willdurand,sclements
* Remove the #titlebar element, and ensure toolbars that comprise the titlebar get a .browser-titlebar class
* Ensure we call TabBarVisibility.update when initializing with verticalTab=true
* Adjust TabBarVisibility logic so we allow for the vertical tabs case
* Give #navigator-toolbar z-index: var(--browser-area-z-index-toolbox) to ensure the urlbar view doesnt get clipped behind the lower elements

Differential Revision: https://phabricator.services.mozilla.com/D222059
2024-10-01 23:37:37 +00:00
Stanca Serban
24647acde4 Backed out changeset 0b970f2cd8fd (bug 1899598) for causing devtools failures in browser_aboutdebugging_devtoolstoolbox_tooltip_markupview.js. CLOSED TREE 2024-10-01 01:54:25 +03:00
Sam Foster
ef30ebaf5c Bug 1899598 - Hide the horizontal tab strip when vertical tabs are enabled. r=mconley,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,emilio,willdurand,sclements
* Remove the #titlebar element, and ensure toolbars that comprise the titlebar get a .browser-titlebar class
* Ensure we call TabBarVisibility.update when initializing with verticalTab=true
* Adjust TabBarVisibility logic so we allow for the vertical tabs case
* Give #navigator-toolbar z-index: var(--browser-area-z-index-toolbox) to ensure the urlbar view doesnt get clipped behind the lower elements

Differential Revision: https://phabricator.services.mozilla.com/D222059
2024-09-30 18:10:42 +00:00
Gregory Pappas
49494b7cae Bug 71895 - Create the hidden window on macOS only r=firefox-desktop-core-reviewers ,mossop
Differential Revision: https://phabricator.services.mozilla.com/D219834
2024-09-24 23:45:09 +00:00
Jared Hirsch
3ef6cee5fc Bug 1916506 - Init gProfiles before the end of the startup idle init block. r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D223236
2024-09-24 16:20:40 +00:00
Butkovits Atila
e9a321c37b Backed out changeset 76c285a906b6 (bug 71895) as requested by dev. CLOSED TREE 2024-09-24 12:28:38 +03:00
Gregory Pappas
7bb2622a0a Bug 71895 - Create the hidden window on macOS only r=firefox-desktop-core-reviewers ,mossop
Differential Revision: https://phabricator.services.mozilla.com/D219834
2024-09-20 00:54:07 +00:00
Niklas Baumgardner
6339cb8b09 Bug 1915300 - Create prefs.js and times.json when creating a selectable profile. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D220424
2024-09-12 15:58:05 +00:00
Sam Foster
adb5a03beb Bug 1899346 - Move CUI widgets out of the horizontal tabstrip when in vertical tabs mode. r=sidebar-reviewers,mconley,sclements,webdriver-reviewers,whimboo,tabbrowser-reviewers
* Ensure tabstrip widgets are temporarily removeable at browser init so the CUI placements are correctly applied
* Shuffle placements during initialization to build the correct toolbars for the verticalTabs pref value
* Notify on the 'tabstrip-orientation-change' topic when the verticalTabs pref changes and CUI placements have been updated
* Add tests for switching tabstrip orientation, and for initializing in verticalTabs mode

Differential Revision: https://phabricator.services.mozilla.com/D217161
2024-09-11 16:27:08 +00:00
Cristina Horotan
211657609a Backed out changeset 0c7c121f1fa3 (bug 1899346) for causing Mn failures at test_quit_restart.py CLOSED TREE 2024-09-04 05:34:33 +03:00
Sam Foster
5ebd63c578 Bug 1899346 - Move CUI widgets out of the horizontal tabstrip when in vertical tabs mode. r=sidebar-reviewers,mconley,sclements,webdriver-reviewers,whimboo
* Ensure tabstrip widgets are temporarily removeable at browser init so the CUI placements are correctly applied
* Shuffle placements during initialization to build the correct toolbars for the verticalTabs pref value
* Notify on the 'tabstrip-orientation-change' topic when the verticalTabs pref changes and CUI placements have been updated
* Add tests for switching tabstrip orientation, and for initializing in verticalTabs mode

Differential Revision: https://phabricator.services.mozilla.com/D217161
2024-09-04 00:12:07 +00:00
Niklas Baumgardner
2d9dacd550 Bug 1893710 - Update default profile on window focus. r=jhirsch,mossop
Differential Revision: https://phabricator.services.mozilla.com/D217825
2024-08-21 11:47:32 +00:00
Florian Quèze
fa2a31be59 Bug 1913624 - Remove expired telemetry histogram FX_TABLETMODE_PAGE_LOAD, r=TravisLong.
Depends on D219484

Differential Revision: https://phabricator.services.mozilla.com/D219485
2024-08-21 09:14:32 +00:00
Gijs Kruitbosch
3c20608c88 Bug 1913762 - move callModulesFromCategory from XPCOMUtils to BrowserUtils to avoid bloating out content JS, r=firefox-desktop-core-reviewers ,dao
Differential Revision: https://phabricator.services.mozilla.com/D219573
2024-08-20 09:20:58 +00:00
Gijs Kruitbosch
a6f6ff1c9a Bug 1896783 - start using the category manager for browser delayed startup, r=mossop,webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D210433
2024-08-14 13:10:41 +00:00
spdev
56088e7d26 Bug 1882776 - gPopupBlockerObserver shouldn't live in browser.js. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D210964
2024-07-22 21:45:33 +00:00
Dale Harvey
0c3d03e94d Bug 1905510 - Ensure SearchModeSwitcher popup opens in correct window. r=urlbar-reviewers,mak
Differential Revision: https://phabricator.services.mozilla.com/D215311
2024-07-19 21:43:39 +00:00