Commit Graph

429 Commits

Author SHA1 Message Date
Dão Gottwald
0fb65f4185 Bug 1908439 - Drag and drop for moving a group within the window. r=dwalker,tabbrowser-reviewers,sessionstore-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239494
2025-03-06 22:20:21 +00:00
DJ
3526f7e308 Bug 1950973 - batch process beforeUnload handlers when removing a tab group. r=dao,tabbrowser-reviewers,sessionstore-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D240273
2025-03-06 20:59:11 +00:00
Nick Grato
207d8697bf Bug 1949808 - Prevent smart tab topic output from replacing group label if user starts typing r=vazish,tabbrowser-reviewers,dao
adding additional check before populating input

Differential Revision: https://phabricator.services.mozilla.com/D240223
2025-03-06 15:38:51 +00:00
Butkovits Atila
76f1949306 Backed out changeset cd8f12bed08a (bug 1950973) for causing failures at test_restore_manually_with_tab_groups.py. CLOSED TREE 2025-03-06 18:05:15 +02:00
Dão Gottwald
8bce10cd45 Bug 1951939 - Save and close tab group when middle clicking the group label. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D240479
2025-03-06 13:18:26 +00:00
Butkovits Atila
b6264adeb4 Backed out changeset 79e3d8d9befa (bug 1949808) for causing failures at browser_tab_grouping_telemetry.js. CLOSED TREE 2025-03-06 13:53:35 +02:00
DJ
fb9b1427f2 Bug 1950973 - batch process beforeUnload handlers when removing a tab group. r=dao,tabbrowser-reviewers,sessionstore-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D240273
2025-03-06 11:25:20 +00:00
Nick Grato
be9d852d84 Bug 1949808 - Prevent smart tab topic output from replacing group label if user starts typing r=vazish,tabbrowser-reviewers,dao
adding additional check before populating input

Differential Revision: https://phabricator.services.mozilla.com/D240223
2025-03-06 10:30:44 +00:00
Eitan Isaacson
cf6484047a Bug 1898096 - Replace color settings with "contrast control". r=emilio,fluent-reviewers,settings-reviewers,accessibility-frontend-reviewers,morgan,bolsson,masayuki,mossop,pdfjs-reviewers,calixte
This patch changes the backing prefs by relying on the tristate offered
by browser.display.document_color_use instead of
browser.display.use_system_colors. This simplifies the color
decision tree, and offers a simplified UI.

The tristate preference offered to the user is as follows:
 1. "Use platform's contrast settings" (document_color_use=0)
 2. "Off" - never use HCM, regardless of platform setting (document_color_use=1)
 3. "On" - always use HCM, regardless of platform setting (document_color_use=2)

Option 3 also reveals a colors UI for the user to choose the palette the
browser HCM will use (bg/text/link/visited).

There are three color palettes to choose from in light of the preference
above they are:
 1. WIDGET_COLORS: The OS's configured colors used by its theme.
 2. HARDCODED_COLORS: Colors deemed as standard and are hard coded into
    Firefox (eg. white on black text, blue and purple links).
 3. PREFERENCE_COLORS: Colors that are stored in preferences and are
    configurable from the colors UI (eg. browser.visited_color and
    browser.display.background_color)

The decision over which palette to use is as follows:
 * If we are styling browser UI -> WIDGET_COLORS
 * else, if resist fingerprinting is enabled -> HARDCODED_COLORS
 * else, if document_color_use==0 AND OS HCM is on -> WIDGET_COLORS
 * else, if document_color_use==2 -> PREFERENCE_COLORS
 * else -> HARDCODED_COLORS

Differential Revision: https://phabricator.services.mozilla.com/D211115
2025-03-05 19:18:08 +00:00
Nikki Sharpley
3757c82d4f Bug 1927258 - Add a fade effect when vertical pinned tabs overflow r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,reusable-components-reviewers,dao,tgiles,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D237645
2025-03-05 14:35:39 +00:00
Alexandru Marc
78ef84ae14 Backed out changeset f4d5303f5472 (bug 1898096) for causing ba failures @ browser_attributed_text.js 2025-03-05 03:27:02 +02:00
Eitan Isaacson
e55fdd6ce8 Bug 1898096 - Replace color settings with "contrast control". r=emilio,fluent-reviewers,settings-reviewers,accessibility-frontend-reviewers,morgan,bolsson,masayuki,mossop,pdfjs-reviewers,calixte
This patch changes the backing prefs by relying on the tristate offered
by browser.display.document_color_use instead of
browser.display.use_system_colors. This simplifies the color
decision tree, and offers a simplified UI.

The tristate preference offered to the user is as follows:
 1. "Use platform's contrast settings" (document_color_use=0)
 2. "Off" - never use HCM, regardless of platform setting (document_color_use=1)
 3. "On" - always use HCM, regardless of platform setting (document_color_use=2)

Option 3 also reveals a colors UI for the user to choose the palette the
browser HCM will use (bg/text/link/visited).

There are three color palettes to choose from in light of the preference
above they are:
 1. WIDGET_COLORS: The OS's configured colors used by its theme.
 2. HARDCODED_COLORS: Colors deemed as standard and are hard coded into
    Firefox (eg. white on black text, blue and purple links).
 3. PREFERENCE_COLORS: Colors that are stored in preferences and are
    configurable from the colors UI (eg. browser.visited_color and
    browser.display.background_color)

The decision over which palette to use is as follows:
 * If we are styling browser UI -> WIDGET_COLORS
 * else, if resist fingerprinting is enabled -> HARDCODED_COLORS
 * else, if document_color_use==0 AND OS HCM is on -> WIDGET_COLORS
 * else, if document_color_use==2 -> PREFERENCE_COLORS
 * else -> HARDCODED_COLORS

Differential Revision: https://phabricator.services.mozilla.com/D211115
2025-03-05 00:27:44 +00:00
Jeremy Swinarton
8d67992ca5 Bug 1938423: Add glean metric for tab group create r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239921
2025-03-04 20:05:19 +00:00
Nick Grato
43e8b7b8e6 Bug 1949590 - STG pref need to be watched to update UI not just on init r=vazish,tabbrowser-reviewers
adding a watcher to the lazy pref getter

Differential Revision: https://phabricator.services.mozilla.com/D239187
2025-03-04 17:49:34 +00:00
Dão Gottwald
7552ffe539 Bug 1951488 - Fix drag and drop of vertical pinned tabs with minimal movement. r=nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D240349
2025-03-04 17:01:03 +00:00
Dão Gottwald
d24f3155d1 Bug 1951080 - Add Tabs to Group should show all Groups for the selection of tabs that also has at least one free tab selected. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D240302
2025-03-04 16:18:50 +00:00
Goloman Adrian
1fdec4b2d1 Backed out changeset dfdd36582a66 (bug 1938423) as requested by Aryx for missing data review. CLOSED TREE 2025-03-04 18:42:28 +02:00
Jeremy Swinarton
290d8c4e22 Bug 1938423: Add glean metric for tab group create r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239921
2025-03-04 14:29:14 +00:00
Nicholas Rishel
31e00acb5f Bug 1915739 - Part 1: Hide tab strip for taskbar tab windows. r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D234537
2025-03-03 16:40:06 +00:00
Eric Chen
2ef6890748 Bug 1915739 - Pre: Clarify logic for drawing to the title bar. r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D238710
2025-03-03 16:40:05 +00:00
Gijs Kruitbosch
dcb8be8cff Bug 1950871 - switch browser/components/tabbrowser to use moz-src, r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239926
2025-03-03 12:47:49 +00:00
Goloman Adrian
251308a40f Backed out changeset 9fc3318eca2c (bug 1927258) for causing bc failures @browser_multiselect_tabs_copy_through_drag_and_drop.js. CLOSED TREE 2025-02-27 18:00:00 +02:00
Nikki Sharpley
59098cf49c Bug 1927258 - Add a fade effect when vertical pinned tabs overflow r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,reusable-components-reviewers,dao,tgiles,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D237645
2025-02-27 14:25:03 +00:00
Butkovits Atila
c12223cfbb Backed out changeset 7cebb9e8b38c (bug 1927258) for causing failures at browser_tabReorder_vertical.js. CLOSED TREE 2025-02-27 04:26:39 +02:00
Nikki Sharpley
89eef374ea Bug 1927258 - Add a fade effect when vertical pinned tabs overflow r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,reusable-components-reviewers,dao,tgiles,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D237645
2025-02-26 19:56:35 +00:00
Butkovits Atila
59710fad67 Backed out changeset 77636df030aa (bug 1946432) for causing failures at browser_multiselect_tabs_using_keyboard.js. 2025-02-27 01:29:14 +02:00
Greg Stoll
b25e168174 Bug 1946432 - when unloading all tabs, don't switch to Firefox View if it's hidden r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D239778
2025-02-26 17:34:49 +00:00
Dão Gottwald
84d373b75c Bug 1950622 - Correctly decide whether or not multiple selected tabs need to be moved together. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239738
2025-02-26 14:06:55 +00:00
Dão Gottwald
4dd29317da Bug 1950298 - Mark group as seen when adding tabs. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239517
2025-02-26 09:05:52 +00:00
Cristina Horotan
4dd2dad95f Backed out changeset 85d499c8e0bf (bug 1927258) for causing multiple failures tabbrowser related. CLOSED TREE 2025-02-26 06:42:56 +02:00
Cristina Horotan
60fe94bdb8 Backed out changeset 5b4f48aac534 (bug 1950298) for causing bc failures at browser_tab_manager_groups.js 2025-02-26 04:20:46 +02:00
Nikki Sharpley
525619dde7 Bug 1927258 - Add a fade effect when vertical pinned tabs overflow r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,reusable-components-reviewers,dao,tgiles,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D237645
2025-02-25 22:01:56 +00:00
Dão Gottwald
09883fda4a Bug 1950298 - Mark group as seen when adding tabs. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239517
2025-02-25 16:05:21 +00:00
Dão Gottwald
ebf19a0299 Bug 1950113 - Remove null checks before isTabGroupLabel calls. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239346
2025-02-24 22:10:49 +00:00
Dão Gottwald
5bb0ca5467 Bug 1950104 - Make #moveTabNextTo handle the vertical pinned tabs container. r=nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D239354
2025-02-24 17:19:59 +00:00
Dão Gottwald
e8d536a337 Bug 1946339 - Fix stability of group creation indicator. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239331
2025-02-24 16:21:40 +00:00
Butkovits Atila
d22beded8a Backed out changeset 130ec750949d (bug 1949590) for causing Lint failures. CLOSED TREE 2025-02-22 01:51:44 +02:00
Nick Grato
3553e3994e Bug 1949590 - STG pref need to be watched to update UI not just on init r=vazish,tabbrowser-reviewers
adding a watcher to the lazy pref getter

Differential Revision: https://phabricator.services.mozilla.com/D239187
2025-02-21 23:03:55 +00:00
Vasish Baungally
7f96278c2f Bug 1949010 - Add Glean Metrics for Smart Tab Grouping. r=rrando,ngrato,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D238803
2025-02-21 21:29:47 +00:00
Dão Gottwald
84ac654618 Bug 1949419 - Sort groups in "Add Tab to Group" sub menu in recently used order. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239177
2025-02-21 21:24:28 +00:00
Dão Gottwald
705201f88e Bug 1949866 - Make _handleTabMove private. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239214
2025-02-21 21:23:27 +00:00
Dão Gottwald
bbf8ed375a Bug 1949840 - Rename dropTab and dropTabs methods now that we use them not just for dropping. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239189
2025-02-21 21:23:27 +00:00
Dão Gottwald
d968cb60db Bug 1948943 - Fix moving together multiselected tabs across tab groups. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239119
2025-02-21 15:27:42 +00:00
Dão Gottwald
e7bf01836d Bug 1949488 - Rename "Tab groups" section in the tab overflow menu's main view to "Recent tab groups". r=dwalker,fluent-reviewers,tabbrowser-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D238963
2025-02-21 04:04:16 +00:00
Dão Gottwald
e0bb662eef Bug 1933280 - Fix dragging into and out of tab groups. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239000
2025-02-20 22:44:21 +00:00
Dão Gottwald
b2246100d5 Bug 1948883 - Unlock tab sizing when collapsing a group. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D238798
2025-02-20 05:21:52 +00:00
Vasish Baungally
45db6f6e22 Bug 1949274 - Fix default tab group actions for Smart Tab Groups r=tabbrowser-reviewers,dwalker
Differential Revision: https://phabricator.services.mozilla.com/D238818
2025-02-19 22:04:14 +00:00
Dão Gottwald
a5d59a8e99 Bug 1945788 - Fix dragging multiple tabs in RTL. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D238486
2025-02-18 23:07:08 +00:00
Nick Grato
37d617a207 Bug 1946523 - STG - Step 1 UI migration r=fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,bolsson
Adding additional UI elements and filling out state machine with actualy UI updates. Some functions are stubbed out while waiting on ML to have API up on central. These UI changes should have no change to current UI if pref is turned off.

Differential Revision: https://phabricator.services.mozilla.com/D237277
2025-02-18 18:45:45 +00:00
Stanca Serban
24a38fdf6a Backed out changeset 7dac3dae07a0 (bug 1946523) for causing mochitests failures in browser_startup_images.js. 2025-02-15 23:17:28 +02:00