corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
899,013 Commits 1 Branch 0 Tags
0fb65f418564f5545d8c8e3aabb2fc50e0fb37dc
Commit Graph

189 Commits

Author SHA1 Message Date
Dão Gottwald
0fb65f4185 Bug 1908439 - Drag and drop for moving a group within the window. r=dwalker,tabbrowser-reviewers,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D239494
 2025-03-06 22:20:21 +00:00
DJ
3526f7e308 Bug 1950973 - batch process beforeUnload handlers when removing a tab group. r=dao,tabbrowser-reviewers,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D240273
 2025-03-06 20:59:11 +00:00
Butkovits Atila
76f1949306 Backed out changeset cd8f12bed08a (bug 1950973) for causing failures at test_restore_manually_with_tab_groups.py. CLOSED TREE 2025-03-06 18:05:15 +02:00
DJ
fb9b1427f2 Bug 1950973 - batch process beforeUnload handlers when removing a tab group. r=dao,tabbrowser-reviewers,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D240273
 2025-03-06 11:25:20 +00:00
Eric Chen
11dbf7050d Bug 1915739 - Part 5: Prevent window features from being restored for taskbar tab windows r=sessionstore-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D234542
 2025-03-03 16:40:08 +00:00
Jeremy Swinarton
8ab002aa2c Bug 1950123: Allow forgetting history for closed tabs from closed groups r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D239739
 2025-02-26 16:40:38 +00:00
DJ
5b2c34c50b Bug 1948078 - When restore is deferred, convert last session's open groups to saved groups. r=jswinarton,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D239451
 2025-02-25 15:55:51 +00:00
Florian Quèze
3f36c09d17 Bug 1944631 - Migrate histograms to use Glean APIs for FX_SESSION_RESTORE_* histograms, r=chutten,sessionstore-reviewers,nsharpley. 
Differential Revision: https://phabricator.services.mozilla.com/D238095
 2025-02-19 19:52:06 +00:00
Jeremy Swinarton
782cb8d757 Bug 1936284: Open recently closed grouped tabs from Firefox View. r=dao,fxview-reviewers,sessionstore-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D238122
 2025-02-19 16:27:49 +00:00
DJ
a0b1928d27 Bug 1945169 - prevent a closing window from saving a group that is being adopted. r=dao,sessionstore-reviewers,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237988
 2025-02-13 19:39:28 +00:00
Jeremy Swinarton
97dd33ecbd Bug 1947503: Closed tab groups code supports session store files created before Firefox 135 r=dao,dwalker,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237904
 2025-02-13 15:10:03 +00:00
Jeremy Swinarton
566b514ef6 Bug 1946761: Prevent saving tab groups in private windows r=dao,sessionstore-reviewers,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237588
 2025-02-11 13:43:27 +00:00
Jeremy Swinarton
016c599fa5 Bug 1944416: Restore individual tabs from closed groups in closed windows r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237110
 2025-02-07 21:35:32 +00:00
Sam Foster
c32900b41c Bug 1942314 - Avoid showing sidebars and responding to sidebar events in popup windows. r=sidebar-reviewers,sessionstore-reviewers,jsudiaman,sclements 
- Guard the main entry-points in SidebarController to handle the window being a popup
- Amend the test to also try the shortcut to show a sidebar in a popup window

Differential Revision: https://phabricator.services.mozilla.com/D236292
 2025-02-04 07:43:21 +00:00
Jeremy Swinarton
3414d7d519 Bug 1915174: Restore closed tabs to their original tab group r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D236347
 2025-02-03 14:22:39 +00:00
Jeremy Swinarton
4c0ff4a071 Bug 1940752: 'Reopen Closed Tab' tab context menu, and other paths calling undoCloseTab, support tab groups r=dao,sessionstore-reviewers,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D234680
 2025-01-21 23:07:02 +00:00
Dão Gottwald
78725d1a6b Bug 1942809 - Consolidate tabs.length check by moving it into _recordSavedTabGroupState. r=dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D234956
 2025-01-21 15:23:48 +00:00
Jeremy Swinarton
f9b9eb75c1 Bug 1932941: Add session support for closed tab groups in closed windows r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D234176
 2025-01-21 14:58:01 +00:00
DJ
857429c48c Bug 1937856 - prevent saving tab groups with only discarded tabs. r=dao,jswinarton,sessionstore-reviewers,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D234505
 2025-01-17 14:46:24 +00:00
Stanca Serban
54f9cf7d9a Backed out changeset 49fc474d91a0 (bug 1932941) for causing mochitests failures in browser_tab_groups_closed_groups_in_closed_windows.js. 2025-01-16 19:44:56 +02:00
Jeremy Swinarton
feb3d5e3db Bug 1932941: Add session support for closed tab groups in closed windows r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D234176
 2025-01-16 15:43:57 +00:00
Kelly Cochrane
f9046ef713 Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements,sidebar-reviewers,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D231182
 2025-01-16 01:40:47 +00:00
Alexandru Marc
402a01520a Backed out changeset 2821188eb89d (bug 1921060) for causing multiple failures 2025-01-16 02:25:14 +02:00
Kelly Cochrane
a876cd0373 Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements,sidebar-reviewers,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D231182
 2025-01-15 23:07:45 +00:00
Jeremy Swinarton
e409401215 Bug 1939719: Resolve talos sessionstore perf issue r=dao,sessionstore-reviewers 
The root cause of this turned out to be that the talos
sessionstore.js file did not have groups, but the call to load groups
during the deferred restore routine was expecting them to exist,
throwing an error. This change fixes the issue.

PerfCompare run: https://perf.compare/compare-results?baseRev=6ccc0ebc69e907e55033ea729a5ca40d0fcb22fe&newRev=5d112ab0e86f98dbb7a9c6f8d40de01564ebec7b&baseRepo=try&newRepo=try&framework=1

Differential Revision: https://phabricator.services.mozilla.com/D234347
 2025-01-15 16:52:30 +00:00
Stanca Serban
9e9507fcbb Backed out changeset d448ac7b0d9e (bug 1921060) for causing mochitests failures in browser_audioTabIcon.js. 2025-01-13 21:35:03 +02:00
Kelly Cochrane
50f355f8ec Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements,sidebar-reviewers,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D231182
 2025-01-13 17:55:32 +00:00
Dão Gottwald
2dcb43e95d Bug 1940231 - When restoring a session, prevent original startup tabs from moving into a restored tab group. r=tabbrowser-reviewers,jswinarton 
Differential Revision: https://phabricator.services.mozilla.com/D234022
 2025-01-13 15:59:48 +00:00
Dão Gottwald
f60b181b60 Bug 1940791 - When restoring a group, select it. r=jswinarton 
Differential Revision: https://phabricator.services.mozilla.com/D233863
 2025-01-10 16:14:38 +00:00
Jonathan Sudiaman
9372222c8c Bug 1935482 - Replace legacy properties with SidebarState properties r=sidebar-reviewers,sessionstore-reviewers,nsharpley,sfoster 
- Move resize observer (setting max width) logic over to SidebarState.
- Add `command` property to SidebarState.
- Handle receiving legacy session restore data.
- Add unit tests along with mocking structures to get a better idea of state/controller coupling (which we should ultimately reduce).

Differential Revision: https://phabricator.services.mozilla.com/D232730
 2025-01-08 23:06:42 +00:00
Jeremy Swinarton
cf0ea617df Bug 1939599: Tab groups can be restored by Ctrl+Shift+T r=dao,sthompson,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D233102
 2025-01-08 22:33:13 +00:00
Dão Gottwald
899b3c4127 Bug 1939413 - Ensure _savedGroups isn't undefined. r=jswinarton,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D233163
 2025-01-03 16:51:08 +00:00
Jeremy Swinarton
4ded93c800 Bug 1927767: Closed tab groups from the last session appear correctly in history menus r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D232879
 2024-12-30 14:56:50 +00:00
Luca Greco
775328ed67 Bug 1786601 - Tweak browser_ext_tabs_events.js to expect SessionStore onMoveToNewWindow uncaught rejection. r=dao,sessionstore-reviewers,robwu 
This patch modifies SessionStoreInternal.onMoveToNewWindow to raise a more specific error message when
no TabState is found for the tab being moved, and then allows that more specific error message
as an uncaught rejection in browser_ext_tabs_events.js through PromiseTestUtils.allowMatchingRejectionsGlobally.

These changes don't address the underlying issue hit by SessionStoreInternal, but in the short term
it will allow to prevent the high frequency intermittent failure currently hit by the
browser_ext_tabs_events.js (and to keep the existing test coverage which would be lost if we
would instead skip the entire test file to workaround the intermittency).

An inline comment added right above the call to PromiseTestUtils.allowMatchingRejectionsGlobally
includes a mention to Bug 1938594 (a new bug filed under the "Firefox :: Session Restore" bugzilla
component to track additional investigations on the SessionStore/TabStateFlusher side) as a reminder
of the underlying issue (and to remove the workaround when it may not be necessary anymore).

Differential Revision: https://phabricator.services.mozilla.com/D230528
 2024-12-22 18:06:56 +00:00
DJ
c5ab0e12ee Bug 1938589 - init savedGroups from session file. r=sthompson,dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D232747
 2024-12-21 03:30:15 +00:00
Jeremy Swinarton
9561dbc00e Bug 1927768: Purging domain data handles tabs in closed groups r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D232228
 2024-12-19 17:01:04 +00:00
Stephen Thompson
f8fd5db3b5 Bug 1933813 - "close other tabs" changes for tab groups r=dao,jswinarton,sessionstore-reviewers,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D232430
 2024-12-19 08:54:25 +00:00
Stanca Serban
30c8718405 Backed out changeset a2a3d6bf518f (bug 1921060) as requested for causing multiple regressions. 2024-12-18 20:51:04 +02:00
Stephen Thompson
d217c2630b Bug 1921802 - save open tab groups on window close r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D231892
 2024-12-18 15:54:21 +00:00
Dão Gottwald
2ed2e383f6 Bug 1936831 - Allow searching for closed and saved tab groups in the address bar and display matching tab groups as actions. r=daleharvey,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D232336
 2024-12-18 09:27:40 +00:00
Alexandru Marc
7078799556 Backed out changeset 2817415422a2 (bug 1921802) for causing bc failures @ browser_1933485_tab_groups_history.js CLOSED TREE 2024-12-18 11:34:39 +02:00
Stephen Thompson
387f34697e Bug 1921802 - save open tab groups on window close r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D231892
 2024-12-18 07:58:00 +00:00
Stanca Serban
f41de5d39a Backed out changeset 415580659e75 (bug 1927768) for causing mochitests failures in browser_394759_purge.js. CLOSED TREE 2024-12-17 14:02:52 +02:00
Jeremy Swinarton
b77759e87b Bug 1927768: Purging domain data handles tabs in closed groups r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D232228
 2024-12-17 10:03:49 +00:00
Jeremy Swinarton
cf23be9260 Bug 1933485: Ensure tab groups always appear in history menus r=dao,sthompson,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D230985
 2024-12-12 14:36:08 +00:00
Kelly Cochrane
93e44d9499 Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D231182
 2024-12-12 12:57:41 +00:00
Stephen Thompson
4b0b5070a8 Bug 1933574 - saved tab groups session schema change r=dao,sessionstore-reviewers,tabbrowser-reviewers 
This patch makes saved tab groups use the "closed tabs" schema for storing tab data. This makes saved tab groups consistent with closed tabs and closed tab groups. The tab/tab group restoration code is built to work with the "closed tabs" schema, so this schema change allows saved tab groups to be restored correctly.

Bug 1933114 will add and improve the tests for restoring tab groups.

Differential Revision: https://phabricator.services.mozilla.com/D231818
 2024-12-11 16:47:41 +00:00
Alexandru Marc
b15c866809 Backed out changeset 5b573c874645 (bug 1921060) for causing mda failures @ browser_mute_webAudio.js CLOSED TREE 2024-12-11 17:40:44 +02:00
Kelly Cochrane
bb2110744e Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D231182
 2024-12-11 14:37:38 +00:00
Sandor Molnar
b34a0a7264 Backed out changeset e5ecd3645987 (bug 1933114) for causing bc failures @ browser_tab_groups_restore_closed_in_closed_window.js CLOSED TREE 2024-12-11 03:45:56 +02:00