Commit Graph

50 Commits

Author SHA1 Message Date
Ricky Stewart
31b8ca9716 Bug 1654103: Standardize on Black for Python code in mozilla-central.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
Bogdan Tara
612312a64c Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
Ricky Stewart
065d2eb893 Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
Dorel Luca
95b44c982f Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE 2020-10-22 03:51:06 +03:00
Ricky Stewart
43baed3c18 Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
Nick Thomas
3925773260 Bug 1630809 - check_if_partners_enabled() is only needed on the top kind for each partner branch r=aki
If the partner repack task are already removed then there can be no downstreams to disable.

Differential Revision: https://phabricator.services.mozilla.com/D87726
2020-08-27 22:19:43 +00:00
Butkovits Atila
797523cdf6 Backed out 9 changesets (bug 1630809, bug 1653476) for Gecko Decision failures. CLOSED TREE
Backed out changeset 02a27bfc76dd (bug 1653476)
Backed out changeset afb5df61943a (bug 1630809)
Backed out changeset 04628c1f98e9 (bug 1630809)
Backed out changeset 4b4d50e0b1bf (bug 1630809)
Backed out changeset 2fa2deb5c993 (bug 1630809)
Backed out changeset d6652114cac3 (bug 1630809)
Backed out changeset ad5e4caa3291 (bug 1630809)
Backed out changeset d3d841cd14f3 (bug 1630809)
Backed out changeset b3746502e227 (bug 1630809)
2020-08-28 01:15:03 +03:00
Nick Thomas
ea54d140aa Bug 1630809 - check_if_partners_enabled() is only needed on the top kind for each partner branch r=aki
If the partner repack task are already removed then there can be no downstreams to disable.

Differential Revision: https://phabricator.services.mozilla.com/D87726
2020-08-27 05:28:09 +00:00
Tom Prince
ecb4c2b2fa Bug 1649356: [taskgraph] We do not honour voluptuous default values, so don't specify them; r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D81655
2020-06-30 14:10:36 +00:00
Tom Prince
6e4a2c666d Bug 1649356: [taskgraph] Don't have unused depname key in release transforms; r=Callek
We don't ever set `depname` in any of the kinds that use these transforms.
Since we don't apply default values in schemas, `Required(..., default=...)`
behaves equivalently to `Optional(...)`, so we can just remove these options.

Differential Revision: https://phabricator.services.mozilla.com/D81654
2020-06-30 14:08:27 +00:00
Mike Hommey
7032f7624b Bug 1634204 - Upgrade Linux build docker images to Debian 8. r=froydnj
This gets rid for the need of a number of local packages (mostly related
to Gtk+3). One exception is that we now need a 32-bits version of the
xz-utils package, some -dev package depends on it, and that dependency
can't be fulfilled in the 32-bits image because we already have the
64-bits backport installed, which conflicts with it (we need both
32-bits and 64-bits package to be at the same version when installed).

The system binutils fails to link clang-7 for some reason, so we now use
our toolchain binutils instead, like we already do for newer versions of
clang.

The debian-packages docker image now needs an explicit installation of
git, because it's not pulled in via the recommends of some other
package.

For some reason, snapshot.debian.org doesn't contain the jessie-backports
archive at the same location as others, and only has a few snapshots of
the archive.

Differential Revision: https://phabricator.services.mozilla.com/D73784
2020-05-06 14:16:03 +00:00
Narcis Beleuzu
126f6a6ce0 Backed out changeset 0a1edd15b210 (bug 1634204) for valgrind bustages. CLOSED TREE 2020-05-06 17:10:37 +03:00
Mike Hommey
e7473388ab Bug 1634204 - Upgrade Linux build docker images to Debian 8. r=froydnj
This gets rid for the need of a number of local packages (mostly related
to Gtk+3). One exception is that we now need a 32-bits version of the
xz-utils package, some -dev package depends on it, and that dependency
can't be fulfilled in the 32-bits image because we already have the
64-bits backport installed, which conflicts with it (we need both
32-bits and 64-bits package to be at the same version when installed).

The system binutils fails to link clang-7 for some reason, so we now use
our toolchain binutils instead, like we already do for newer versions of
clang.

The debian-packages docker image now needs an explicit installation of
git, because it's not pulled in via the recommends of some other
package.

For some reason, snapshot.debian.org doesn't contain the jessie-backports
archive at the same location as others, and only has a few snapshots of
the archive.

Differential Revision: https://phabricator.services.mozilla.com/D73784
2020-05-06 07:35:52 +00:00
Narcis Beleuzu
b4aa6e5b84 Backed out changeset b4d73278792e (bug 1634204) as per glandium req. 2020-05-06 10:33:08 +03:00
Mike Hommey
ddbf237e8e Bug 1634204 - Upgrade Linux build docker images to Debian 8. r=froydnj
This gets rid for the need of a number of local packages (mostly related
to Gtk+3). One exception is that we now need a 32-bits version of the
xz-utils package, some -dev package depends on it, and that dependency
can't be fulfilled in the 32-bits image because we already have the
64-bits backport installed, which conflicts with it (we need both
32-bits and 64-bits package to be at the same version when installed).

The system binutils fails to link clang-7 for some reason, so we now use
our toolchain binutils instead, like we already do for newer versions of
clang.

The debian-packages docker image now needs an explicit installation of
git, because it's not pulled in via the recommends of some other
package.

For some reason, snapshot.debian.org doesn't contain the jessie-backports
archive at the same location as others, and only has a few snapshots of
the archive.

Differential Revision: https://phabricator.services.mozilla.com/D73784
2020-05-06 04:56:14 +00:00
Csoregi Natalia
4fb355c528 Backed out changeset 2bf3343d2994 (bug 1634204) as per request. CLOSED TREE 2020-05-06 07:24:07 +03:00
Mike Hommey
6232ba7ecb Bug 1634204 - Upgrade Linux build docker images to Debian 8. r=froydnj
This gets rid for the need of a number of local packages (mostly related
to Gtk+3). One exception is that we now need a 32-bits version of the
xz-utils package, some -dev package depends on it, and that dependency
can't be fulfilled in the 32-bits image because we already have the
64-bits backport installed, which conflicts with it (we need both
32-bits and 64-bits package to be at the same version when installed).

The system binutils fails to link clang-7 for some reason, so we now use
our toolchain binutils instead, like we already do for newer versions of
clang.

The debian-packages docker image now needs an explicit installation of
git, because it's not pulled in via the recommends of some other
package.

For some reason, snapshot.debian.org doesn't contain the jessie-backports
archive at the same location as others, and only has a few snapshots of
the archive.

Differential Revision: https://phabricator.services.mozilla.com/D73784
2020-05-05 12:13:27 +00:00
Julien Cristau
01ff117a35 Bug 1624910 - fix partner repacks after bug 1527313. r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D68245
2020-03-25 21:13:07 +00:00
Tom Prince
950ea78d33 Bug 1527313: [taskgraph] Remove workspace-key from mozharness tasks; r=glandium
Since mozharness tasks are no longer caching the workspace directory, we don't
need a key for different tasks.

Differential Revision: https://phabricator.services.mozilla.com/D62483
2020-03-05 23:22:10 +00:00
Ricky Stewart
02945d3f8a Bug 1524639: [taskgraph] Enforce unicode strings in schemas r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D18376
2020-01-21 17:12:08 +00:00
Razvan Maries
1b1233c4a4 Backed out changeset a57aed49dc58 (bug 1524639) for beetmover bustages. a=backout 2020-01-16 14:04:31 +02:00
Ricky Stewart
16061a0a81 Bug 1524639: [taskgraph] Enforce unicode strings in schemas r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D18376
2020-01-15 20:33:20 +00:00
Nick Thomas
a8ebe69f8d Bug 1572102 - deprioritize partner-repack tasks as they don't block QE, r=aki
Lower the priority of partner-repack jobs and downstreams to medium, so that tasks which do block QE work are not impeded.

Differential Revision: https://phabricator.services.mozilla.com/D43399
2019-08-27 03:06:47 +00:00
Mike Hommey
3a6c8405e5 Bug 1573435 - Use toolchain fetches for all remaining toolchain uses, part 2. r=nalexander
This part removes the use_toolchains transform, and adjusts all task
definitions accordingly.

Differential Revision: https://phabricator.services.mozilla.com/D41891

MANUAL PUSH: avoid closing autoland while docker images and toolchains
are rebuilt.
2019-08-15 11:22:23 +09:00
Tom Prince
01bff4656d Bug 1458385: Repackage windows builds on linux. r=glandium,Callek
This only uses cross-platform tools, so switch to running these on linux, which
cuts the runtime down from ~20m to ~3m.

Differential Revision: https://phabricator.services.mozilla.com/D1080
2019-07-11 16:40:25 +00:00
Nick Thomas
bacfea2cdc Bug 1538995 - adjust repackage jobs to create partner stub installers, r=aki
On win32, where repack_stub_installer is enabled, extend the inputs to the partner repackage task so that it
donwloads the upstream artifacts and creates the stub installer.

Differential Revision: https://phabricator.services.mozilla.com/D34946
2019-06-20 22:17:55 +00:00
Tom Prince
08ece47786 Bug 1532783: [taskgraph] Switch to using worker aliases for docker-worker and generic-worker; r=dustin
Differential Revision: https://phabricator.services.mozilla.com/D24238
2019-04-30 22:58:06 +00:00
Daniel Varga
6c9efb5ae9 Backed out 4 changesets (bug 1458385) for nightly updates fail. a=backout
Backed out changeset 09338587b68e (bug 1458385)
Backed out changeset f7791b680d46 (bug 1458385)
Backed out changeset cc06a7beb3d1 (bug 1458385)
Backed out changeset 3b10487587c3 (bug 1458385)
2019-04-10 21:09:46 +03:00
Tom Prince
da87344627 Bug 1458385: Repackage windows builds on linux. r=glandium,Callek
This only uses cross-platform tools, so switch to running these on linux, which
cuts the runtime down from ~20m to ~3m.

Differential Revision: https://phabricator.services.mozilla.com/D1080
2019-04-06 05:49:55 +00:00
Oana Pop Rus
8b6a9d0b8f Backed out 3 changesets (bug 1458385) for windows partial bustages. a=backout
Backed out changeset 8036c03c3b51 (bug 1458385)
Backed out changeset 99fa5539c2bd (bug 1458385)
Backed out changeset 9a5f255979c2 (bug 1458385)
2019-03-28 15:13:13 +02:00
Tom Prince
42d0358f45 Bug 1458385: Repackage windows builds on linux. r=glandium,Callek
This only uses cross-platform tools, so switch to running these on linux, which
cuts the runtime down from ~20m to ~3m.

Differential Revision: https://phabricator.services.mozilla.com/D1080
2019-03-27 22:30:54 +00:00
Tom Prince
03059bf676 Bug 1532783: Implement worker aliases; r=aki,glandium,jmaher,dustin
There are a number of ways we want to vary workers over time and jobs, including

 - we are working on migrating to gce
 - pgo builds have a dedicated worker-type for running the instrumented build
   at level 3 but not level 1

Rather than have all tasks know about how the machines are provisioned, this
moves to using short-names for the worker types, and then has a config mapping
those to the actual worker types.

This adds support for aliases, and an initial set of them. Follow up work will
switch the existing uses of these worker types to using the aliases.

Differential Revision: https://phabricator.services.mozilla.com/D22549
2019-03-19 19:13:56 +00:00
Tom Prince
ad636eac4d Bug 1524639: [taskgraph] Add a helper to Schema to allow referencing downstream schema entries; r=dustin
Differential Revision: https://phabricator.services.mozilla.com/D18377
2019-02-04 22:42:00 +00:00
Dustin J. Mitchell
b8a734353a Bug 1492664 - add {artifact-reference: ..}; r=tomprince
This provides an easy way to encode an artifact URL in static data such as
taskcluster/ci/nightly-l10n/kind.yml, without knowing in advance the format of
the URL.
2018-09-25 20:26:55 +00:00
Sebastian Hengst
e6609388b4 Backed out 21 changesets (bug 1492664) for breaking cron task for nightlies. a=backout
Backed out changeset a7d50dbb2c8e (bug 1492664)
Backed out changeset 2d876c4ece8b (bug 1492664)
Backed out changeset c82285d253de (bug 1492664)
Backed out changeset bf6d089640eb (bug 1492664)
Backed out changeset d9a7f2ce49c3 (bug 1492664)
Backed out changeset 06c466ab4323 (bug 1492664)
Backed out changeset c1ea4a10cc8d (bug 1492664)
Backed out changeset 4c63a04fdd47 (bug 1492664)
Backed out changeset 742b038bb1dd (bug 1492664)
Backed out changeset 911b4b0fb683 (bug 1492664)
Backed out changeset 870c8cec99e5 (bug 1492664)
Backed out changeset 77699b51336b (bug 1492664)
Backed out changeset 29f33f22fd8b (bug 1492664)
Backed out changeset e7f305408708 (bug 1492664)
Backed out changeset 335a92b1f424 (bug 1492664)
Backed out changeset c566f1c8dcdf (bug 1492664)
Backed out changeset c77ae59aba41 (bug 1492664)
Backed out changeset 9c35dd209c6b (bug 1492664)
Backed out changeset a972d6b4434e (bug 1492664)
Backed out changeset 5ea6f03f845e (bug 1492664)
Backed out changeset 0699d3873e44 (bug 1492664)
2018-12-20 12:43:22 +02:00
Dustin J. Mitchell
bd391cec23 Bug 1492664 - add {artifact-reference: ..}; r=tomprince
This provides an easy way to encode an artifact URL in static data such as
taskcluster/ci/nightly-l10n/kind.yml, without knowing in advance the format of
the URL.
2018-09-25 20:26:55 +00:00
Margareta Eliza Balazs
c18ee639c6 Backed out 16 changesets (bug 1492664) for breaking developer artifact builds, requested by standard8 a=backout
Backed out changeset 31e500489665 (bug 1492664)
Backed out changeset f4945658d45f (bug 1492664)
Backed out changeset 6d17291b8b92 (bug 1492664)
Backed out changeset 90f3faa36137 (bug 1492664)
Backed out changeset 0b229b00818a (bug 1492664)
Backed out changeset 5eb2c77d70a9 (bug 1492664)
Backed out changeset e1ebad5d89c5 (bug 1492664)
Backed out changeset 3017e5890739 (bug 1492664)
Backed out changeset c8b7e620eabf (bug 1492664)
Backed out changeset d3dfbd848236 (bug 1492664)
Backed out changeset 5c92bb5ac895 (bug 1492664)
Backed out changeset fb7cfca6ebc3 (bug 1492664)
Backed out changeset 0c4101230d4d (bug 1492664)
Backed out changeset b93a0fcc86f3 (bug 1492664)
Backed out changeset 6dc9522ee0bf (bug 1492664)
Backed out changeset 85d7f8b330eb (bug 1492664)
2018-12-19 11:45:29 +02:00
Dustin J. Mitchell
cbf07b0cc0 Bug 1492664 - add {artifact-reference: ..} r=tomprince
This provides an easy way to encode an artifact URL in static data such as
taskcluster/ci/nightly-l10n/kind.yml.  This could be used in
mozharness_test.py, for example, as well -- but other code (such as to support
backfilling) expects `task-reference` there.  To avoid breaking such subtle
bits, those can continue using `task-reference` with URLs generated based on
TASKCLUSTER_ROOT_URL.

Differential Revision: https://phabricator.services.mozilla.com/D14197
2018-12-18 17:22:40 +00:00
Tom Prince
1b5387cfd8 Bug 1507898: [taskgraph] Factor out schema validation in transformations; r=dustin
Most jobs include at least one transform that verifies the input of all the
tasks against a schema. This code is duplicated in each transform. Refactor it,
so that we only need one copy of the logic.

Differential Revision: https://phabricator.services.mozilla.com/D12165
2018-11-20 23:44:12 +00:00
Narcis Beleuzu
87aec3eb00 Backed out changeset e947694d0ed7 (bug 1507898) for Linting failure. CLOSED TREE 2018-11-21 00:29:17 +02:00
Tom Prince
e6b2bfdab7 Bug 1507898: [taskgraph] Factor out schema validation in transformations; r=dustin
Most jobs include at least one transform that verifies the input of all the
tasks against a schema. This code is duplicated in each transform. Refactor it,
so that we only need one copy of the logic.

Differential Revision: https://phabricator.services.mozilla.com/D12165
2018-11-20 22:09:34 +00:00
Tom Prince
c7cde5a4ee Bug 1501776: [taskgraph] Make single_dep use primary-dependency to match multi_dep; r=aki
To make switching between `single_dep` and `multi_dep` easier, change
the `dependent-task` to `primary-dependency`.

Differential Revision: https://phabricator.services.mozilla.com/D9722
2018-10-24 22:41:38 +00:00
Nick Thomas
6213cc7d2c Bug 1493056 - check for mar existence before chmoding it, and remove deprecated action, r=aki
Differential Revision: https://phabricator.services.mozilla.com/D6460
2018-09-21 03:59:45 +00:00
Tom Prince
0e91233199 Bug 1484264: [taskgraph] Populate repackage artifacts from repackaged formats; r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D3623
2018-08-17 10:27:50 -06:00
Tom Prince
5a0d936eb1 Bug 1484264: [mozharness] Move repacakge config from mozharness to taskcluster; r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D3624
2018-08-17 09:40:57 -06:00
Tom Prince
baed2d7d35 Bug 1484012: [mozharness] Use fetch-content to download inputs in repackage tasks; r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D3559
2018-08-15 15:12:33 -06:00
Tom Prince
5feb3d6b58 Bug 1484012: [mozharness] Hard-code repackage input/output directories, since they don't vary meaningfully; r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D3558
2018-08-07 11:53:00 -06:00
Nick Thomas
e60a559af8 Bug 1483409 - provide node toolchain in mac partner repackage r=tomprince
Followup to bug 1478995 to ensure node is available for mac repackage tasks for partner and eme-free repacks.

Differential Revision: https://phabricator.services.mozilla.com/D3383
2018-08-15 23:47:42 +00:00
Gregory Szorc
0c59260047 Bug 1466689 - Move repackage tasks to gecko-{L}-b-linux worker types; r=dustin
For the same reasons that we moved build tasks to this worker type.

MozReview-Commit-ID: LZuzDtHSKL6
2018-06-04 14:14:01 -07:00
Tom Prince
2c01c6c1fb Bug 1442545: [partner-repack] Repackage signed partner builds; r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D982
2018-04-18 12:06:17 -06:00