Commit Graph

113 Commits

Author SHA1 Message Date
Ricky Stewart
31b8ca9716 Bug 1654103: Standardize on Black for Python code in mozilla-central.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
Bogdan Tara
612312a64c Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
Ricky Stewart
065d2eb893 Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
Dorel Luca
95b44c982f Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE 2020-10-22 03:51:06 +03:00
Ricky Stewart
43baed3c18 Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
Andrew Halberstadt
467bcf8afc Bug 1659187 - [ci] Use 'if-dependencies' for build-signing and repackage tasks r=bhearsum
Differential Revision: https://phabricator.services.mozilla.com/D87775
2020-08-27 20:45:00 +00:00
Tom Prince
ecb4c2b2fa Bug 1649356: [taskgraph] We do not honour voluptuous default values, so don't specify them; r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D81655
2020-06-30 14:10:36 +00:00
Tom Prince
6e4a2c666d Bug 1649356: [taskgraph] Don't have unused depname key in release transforms; r=Callek
We don't ever set `depname` in any of the kinds that use these transforms.
Since we don't apply default values in schemas, `Required(..., default=...)`
behaves equivalently to `Optional(...)`, so we can just remove these options.

Differential Revision: https://phabricator.services.mozilla.com/D81654
2020-06-30 14:08:27 +00:00
Andrew Halberstadt
00bd03fea7 Bug 1641131 - [taskgraph] Make 'repackage' and 'repackage-signing' tasks copy their dependency's optimization, r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D77346
2020-05-29 14:43:29 +00:00
Justin Wood
6c62472264 Bug 1617481 - Remove most of nightly attribute from taskcluster/taskgraph. r=aki
We leave the nightly index in place for now in order to support Geckodriver until Bug 1577110 sticks.

Differential Revision: https://phabricator.services.mozilla.com/D74510
2020-05-21 16:31:04 +00:00
Narcis Beleuzu
9b7a9aa284 Backed out 13 changesets (bug 1636637, bug 1623355, bug 1636635, bug 1617481) buid signing failures. CLOSED TREE
Backed out changeset 1b340fa71d16 (bug 1617481)
Backed out changeset 607d65d6e48a (bug 1617481)
Backed out changeset d3b4ed0caa09 (bug 1636637)
Backed out changeset bff6ecc8bb12 (bug 1636637)
Backed out changeset 12774c2e7cfc (bug 1636635)
Backed out changeset f94e3f8179a5 (bug 1623355)
Backed out changeset 001eb6623a75 (bug 1623355)
Backed out changeset 87331010321a (bug 1623355)
Backed out changeset fd76f6bc0797 (bug 1623355)
Backed out changeset b4ffd5ccbfc7 (bug 1623355)
Backed out changeset 888df247ba6e (bug 1623355)
Backed out changeset dc3076515342 (bug 1623355)
Backed out changeset de5f01ae37fa (bug 1623355)
2020-05-18 21:37:31 +03:00
Justin Wood
945d8dbbd8 Bug 1617481 - Remove most of nightly attribute from taskcluster/taskgraph. r=aki
We leave the nightly index in place for now in order to support Geckodriver until Bug 1577110 sticks.

Differential Revision: https://phabricator.services.mozilla.com/D74510
2020-05-18 14:41:58 +00:00
Tom Prince
950ea78d33 Bug 1527313: [taskgraph] Remove workspace-key from mozharness tasks; r=glandium
Since mozharness tasks are no longer caching the workspace directory, we don't
need a key for different tasks.

Differential Revision: https://phabricator.services.mozilla.com/D62483
2020-03-05 23:22:10 +00:00
Tom Prince
b4e5b5b16c Bug 1527313: Move objdir out of source directory for all mozharness builds; r=glandium,Callek
This moves the object directory and source directories around in all mozharness
jobs, to allow enabling caching on windows builders.

This makes a number of changes that all need to land at once:
- Move the source checkout for the workspace cache mount, to the checkouts
  cache mount.
- Makes the object directoy from underneath the source directory, to directly
  in the work directory (which is still under `workspace`).
- Sets the object directory to `obj-build` instead of `obj-firefox`.
- Stops caching the workspace directory (it is still a volume in docker workers,
  so writes perform well; a followup revision add some checks around this).
- Removes one level of directory in the mozharness workdir (things were under
  `workspace/build`, but are now just under `workspace/`.
- Adjust paths in environment variables and artifact specifications to match
  the above changes.

Differential Revision: https://phabricator.services.mozilla.com/D62482
2020-03-06 08:51:21 +00:00
Aki Sasaki
e007a30630 Bug 1562412 - remove unneeded repackage check. r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D57733
2020-02-25 15:36:21 +00:00
Dorel Luca
6fd8e69dd7 Backed out 17 changesets (bug 1562412) for for build-notarization failures.
Backed out changeset 9c3d85e9b9fe (bug 1562412)
Backed out changeset e39e5d6a77a8 (bug 1562412)
Backed out changeset aa62038d5d76 (bug 1562412)
Backed out changeset 2143a26de372 (bug 1562412)
Backed out changeset 5b7ca7cf6649 (bug 1562412)
Backed out changeset 7870fa417606 (bug 1562412)
Backed out changeset bf7896916b91 (bug 1562412)
Backed out changeset cd6f0176af52 (bug 1562412)
Backed out changeset af8ccde58367 (bug 1562412)
Backed out changeset 9be172fa19e1 (bug 1562412)
Backed out changeset 9ccdef3b8c9d (bug 1562412)
Backed out changeset 0fc1845ea46c (bug 1562412)
Backed out changeset 861e4a4a13aa (bug 1562412)
Backed out changeset 32f31a6daaa8 (bug 1562412)
Backed out changeset b51ce1cea46d (bug 1562412)
Backed out changeset b8ddcf8368c5 (bug 1562412)
Backed out changeset 19ac1668f0db (bug 1562412)
2020-02-25 02:54:24 +02:00
Aki Sasaki
64330390cc Bug 1562412 - remove unneeded repackage check. r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D57733
2020-02-20 23:47:55 +00:00
Ricky Stewart
02945d3f8a Bug 1524639: [taskgraph] Enforce unicode strings in schemas r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D18376
2020-01-21 17:12:08 +00:00
Razvan Maries
1b1233c4a4 Backed out changeset a57aed49dc58 (bug 1524639) for beetmover bustages. a=backout 2020-01-16 14:04:31 +02:00
Ricky Stewart
16061a0a81 Bug 1524639: [taskgraph] Enforce unicode strings in schemas r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D18376
2020-01-15 20:33:20 +00:00
Aki Sasaki
3a610a8825 Bug 1599223 - remove target.bz2.complete.mar r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D54613
2019-11-25 21:49:47 +00:00
Mike Hommey
3a6c8405e5 Bug 1573435 - Use toolchain fetches for all remaining toolchain uses, part 2. r=nalexander
This part removes the use_toolchains transform, and adjusts all task
definitions accordingly.

Differential Revision: https://phabricator.services.mozilla.com/D41891

MANUAL PUSH: avoid closing autoland while docker images and toolchains
are rebuilt.
2019-08-15 11:22:23 +09:00
Tom Prince
01bff4656d Bug 1458385: Repackage windows builds on linux. r=glandium,Callek
This only uses cross-platform tools, so switch to running these on linux, which
cuts the runtime down from ~20m to ~3m.

Differential Revision: https://phabricator.services.mozilla.com/D1080
2019-07-11 16:40:25 +00:00
Tom Prince
0145de8580 Bug 1458385: Package mar and mbsdiff as a toolchain; r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D24229
2019-07-11 16:40:13 +00:00
Tom Prince
b48289cc34 Bug 1458385: Generate MARs with the appropriate channel-id explicitly; r=nthomas
Rather than relying on the mar-channel-id set in the `mar` binary, set the channel
explicitly from taskcluster. This allows us to re-use the `mar` binary between
builds/channels.

Differential Revision: https://phabricator.services.mozilla.com/D37481
2019-07-11 16:40:13 +00:00
Tom Prince
08ece47786 Bug 1532783: [taskgraph] Switch to using worker aliases for docker-worker and generic-worker; r=dustin
Differential Revision: https://phabricator.services.mozilla.com/D24238
2019-04-30 22:58:06 +00:00
Daniel Varga
6c9efb5ae9 Backed out 4 changesets (bug 1458385) for nightly updates fail. a=backout
Backed out changeset 09338587b68e (bug 1458385)
Backed out changeset f7791b680d46 (bug 1458385)
Backed out changeset cc06a7beb3d1 (bug 1458385)
Backed out changeset 3b10487587c3 (bug 1458385)
2019-04-10 21:09:46 +03:00
Tom Prince
da87344627 Bug 1458385: Repackage windows builds on linux. r=glandium,Callek
This only uses cross-platform tools, so switch to running these on linux, which
cuts the runtime down from ~20m to ~3m.

Differential Revision: https://phabricator.services.mozilla.com/D1080
2019-04-06 05:49:55 +00:00
Tom Prince
8c75b6bbe4 Bug 1458385: Package mar and mbsdiff as a toolchain; r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D24229
2019-04-06 05:49:31 +00:00
Oana Pop Rus
8b6a9d0b8f Backed out 3 changesets (bug 1458385) for windows partial bustages. a=backout
Backed out changeset 8036c03c3b51 (bug 1458385)
Backed out changeset 99fa5539c2bd (bug 1458385)
Backed out changeset 9a5f255979c2 (bug 1458385)
2019-03-28 15:13:13 +02:00
Tom Prince
42d0358f45 Bug 1458385: Repackage windows builds on linux. r=glandium,Callek
This only uses cross-platform tools, so switch to running these on linux, which
cuts the runtime down from ~20m to ~3m.

Differential Revision: https://phabricator.services.mozilla.com/D1080
2019-03-27 22:30:54 +00:00
Tom Prince
a88e0e6e88 Bug 1458385: Package mar and mbsdiff as a toolchain; r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D24229
2019-03-27 22:30:44 +00:00
Tom Prince
03059bf676 Bug 1532783: Implement worker aliases; r=aki,glandium,jmaher,dustin
There are a number of ways we want to vary workers over time and jobs, including

 - we are working on migrating to gce
 - pgo builds have a dedicated worker-type for running the instrumented build
   at level 3 but not level 1

Rather than have all tasks know about how the machines are provisioned, this
moves to using short-names for the worker types, and then has a config mapping
those to the actual worker types.

This adds support for aliases, and an initial set of them. Follow up work will
switch the existing uses of these worker types to using the aliases.

Differential Revision: https://phabricator.services.mozilla.com/D22549
2019-03-19 19:13:56 +00:00
Dorel Luca
b07684a777 Merge mozilla-central to autoland 2019-03-02 01:23:22 +02:00
Tom Prince
d3f5e14002 Bug 1519472: Disable caches on windows repackage builds; r=aki a=tomprince
They appear to be causing tasks to take several hours to complete.

Differential Revision: https://phabricator.services.mozilla.com/D21775
2019-03-01 13:15:37 -07:00
Tom Prince
ff6cd0fba5 Bug 1531592: [taskgraph] Ensure that treeherder platform has the correct format; r=dustin
A recent change caused the treeherder platform for several jobs to have an extra `/` in it.
This add a check to ensure that the platform is formatted correctly, and fixes the tasks
with the incorrect format.

Differential Revision: https://phabricator.services.mozilla.com/D21650
2019-03-01 19:44:29 +00:00
Justin Wood
18a0ea16fe Bug 1522111 - Make l10n kind depend on -pgo where available instead of opt. r=tomprince
This avoids opt being pulled in even when l10n is optimized out

Differential Revision: https://phabricator.services.mozilla.com/D19840
2019-02-18 17:55:38 +00:00
Noemi Erli
0c2ebaaa23 Backed out 5 changesets (bug 1522111) for breaking windows opt wpts
Backed out changeset aa6103c8ef0f (bug 1522111)
Backed out changeset 14e9ed41b8be (bug 1522111)
Backed out changeset c10783ea070b (bug 1522111)
Backed out changeset cc97d772a8db (bug 1522111)
Backed out changeset 6fbfc8bc2388 (bug 1522111)
2019-02-16 00:06:17 +02:00
Justin Wood
7455b48904 Bug 1522111 - Make l10n kind depend on -pgo where available instead of opt. r=tomprince
This avoids opt being pulled in even when l10n is optimized out

Differential Revision: https://phabricator.services.mozilla.com/D19840
2019-02-15 15:36:50 +00:00
Tom Prince
ad636eac4d Bug 1524639: [taskgraph] Add a helper to Schema to allow referencing downstream schema entries; r=dustin
Differential Revision: https://phabricator.services.mozilla.com/D18377
2019-02-04 22:42:00 +00:00
Matt Howell
1b0b52aa8b Bug 1514806 Part 6 - Disable running UPX in the installer package for targets it doesn't support. r=firefox-build-system-reviewers,mshal#firefox-build-system-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D15984
2019-01-22 21:58:55 +00:00
Dustin J. Mitchell
b8a734353a Bug 1492664 - add {artifact-reference: ..}; r=tomprince
This provides an easy way to encode an artifact URL in static data such as
taskcluster/ci/nightly-l10n/kind.yml, without knowing in advance the format of
the URL.
2018-09-25 20:26:55 +00:00
Tom Prince
a54d070301 Bug 1515652: Pass arch to repackage bz2 mars as well; r=Callek
The argument is required, so this causes builds to fail when bz2 mars are created.

Differential Revision: https://phabricator.services.mozilla.com/D15117
2018-12-20 17:05:12 +00:00
Tom Prince
f4c3775995 Bug 1515652: [release] Only build bz2 mars based on esr60 release-type (rather than specific branches);
Differential Revision: https://phabricator.services.mozilla.com/D15116
2018-12-20 17:04:04 +00:00
Sebastian Hengst
e6609388b4 Backed out 21 changesets (bug 1492664) for breaking cron task for nightlies. a=backout
Backed out changeset a7d50dbb2c8e (bug 1492664)
Backed out changeset 2d876c4ece8b (bug 1492664)
Backed out changeset c82285d253de (bug 1492664)
Backed out changeset bf6d089640eb (bug 1492664)
Backed out changeset d9a7f2ce49c3 (bug 1492664)
Backed out changeset 06c466ab4323 (bug 1492664)
Backed out changeset c1ea4a10cc8d (bug 1492664)
Backed out changeset 4c63a04fdd47 (bug 1492664)
Backed out changeset 742b038bb1dd (bug 1492664)
Backed out changeset 911b4b0fb683 (bug 1492664)
Backed out changeset 870c8cec99e5 (bug 1492664)
Backed out changeset 77699b51336b (bug 1492664)
Backed out changeset 29f33f22fd8b (bug 1492664)
Backed out changeset e7f305408708 (bug 1492664)
Backed out changeset 335a92b1f424 (bug 1492664)
Backed out changeset c566f1c8dcdf (bug 1492664)
Backed out changeset c77ae59aba41 (bug 1492664)
Backed out changeset 9c35dd209c6b (bug 1492664)
Backed out changeset a972d6b4434e (bug 1492664)
Backed out changeset 5ea6f03f845e (bug 1492664)
Backed out changeset 0699d3873e44 (bug 1492664)
2018-12-20 12:43:22 +02:00
Razvan Maries
521c2bbb44 Merge mozilla-inbound to mozilla-central a=merge 2018-12-20 07:04:06 +02:00
Tom Prince
9b0f7c3319 Bug 1514124: [win64-aarch64] Pass the architecture to mar generation, so that it can pass the appropriate arch flag to xz; r=aki,Callek
XZ supports rewritting addresses in executable code, which is architechture
specific. The updater is compiled with support for the target architecture
only, so we can't always compress updates passing `--x86` to XZ. This threads
the architecture through to the repackage steps, so we can pass the appropraite
flags to the update packaging scripts.

Differential Revision: https://phabricator.services.mozilla.com/D14601
2018-12-17 21:45:09 +00:00
Margareta Eliza Balazs
c18ee639c6 Backed out 16 changesets (bug 1492664) for breaking developer artifact builds, requested by standard8 a=backout
Backed out changeset 31e500489665 (bug 1492664)
Backed out changeset f4945658d45f (bug 1492664)
Backed out changeset 6d17291b8b92 (bug 1492664)
Backed out changeset 90f3faa36137 (bug 1492664)
Backed out changeset 0b229b00818a (bug 1492664)
Backed out changeset 5eb2c77d70a9 (bug 1492664)
Backed out changeset e1ebad5d89c5 (bug 1492664)
Backed out changeset 3017e5890739 (bug 1492664)
Backed out changeset c8b7e620eabf (bug 1492664)
Backed out changeset d3dfbd848236 (bug 1492664)
Backed out changeset 5c92bb5ac895 (bug 1492664)
Backed out changeset fb7cfca6ebc3 (bug 1492664)
Backed out changeset 0c4101230d4d (bug 1492664)
Backed out changeset b93a0fcc86f3 (bug 1492664)
Backed out changeset 6dc9522ee0bf (bug 1492664)
Backed out changeset 85d7f8b330eb (bug 1492664)
2018-12-19 11:45:29 +02:00
Dustin J. Mitchell
cbf07b0cc0 Bug 1492664 - add {artifact-reference: ..} r=tomprince
This provides an easy way to encode an artifact URL in static data such as
taskcluster/ci/nightly-l10n/kind.yml.  This could be used in
mozharness_test.py, for example, as well -- but other code (such as to support
backfilling) expects `task-reference` there.  To avoid breaking such subtle
bits, those can continue using `task-reference` with URLs generated based on
TASKCLUSTER_ROOT_URL.

Differential Revision: https://phabricator.services.mozilla.com/D14197
2018-12-18 17:22:40 +00:00
Tom Prince
1b5387cfd8 Bug 1507898: [taskgraph] Factor out schema validation in transformations; r=dustin
Most jobs include at least one transform that verifies the input of all the
tasks against a schema. This code is duplicated in each transform. Refactor it,
so that we only need one copy of the logic.

Differential Revision: https://phabricator.services.mozilla.com/D12165
2018-11-20 23:44:12 +00:00