corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
688,051 Commits 1 Branch 0 Tags
0f921b51a93c8111b46568616090396cc21948eb
Commit Graph

162 Commits

Author SHA1 Message Date
Alexis Beingessner
d4ff1589b5 Bug 1633239 - make the bitfields on CacheStorageService atomic. r=valentin,necko-reviewers 
this is only a hypothetical fix to the underlying issue since we don't have a clean trace.

Differential Revision: https://phabricator.services.mozilla.com/D103057
 2021-01-28 11:05:02 +00:00
David Major
9829f29105 Bug 1688292 - Fix non-unified build errors in netwerk/cache2/ r=necko-reviewers,valentin 
This is a drive-by fix while I was looking into something else.

Differential Revision: https://phabricator.services.mozilla.com/D102795
 2021-01-25 12:23:13 +00:00
Alexis Beingessner
839a64934a Bug 1681546 - rename MOZ_ATOMIC_BITFIELDS methods to Load/Store. r=valentin,necko-reviewers 
I was running into issues where these names would conflict with the type's own Get/Set methods
and these names have the added benefit of indicating a bit more that atomic stuff is going on.

Differential Revision: https://phabricator.services.mozilla.com/D99268
 2020-12-09 18:14:55 +00:00
Alexis Beingessner
5f2921328a Bug 1670982 - Make the bitflags in CacheStorageService actually atomic. r=decoder,necko-reviewers,dragana,valentin 
TSan found races on these flags that are ostensibly benign but this way there's no UB.

This code is a bit weird. These bitfields are seemingly pointless as
they're squeezed between a uint64_t and an Atomic<bool>. There's plenty
of space for 2 more bools there.

Also the Atomic<bool> could theoretically be merged into the flags. For
now, here's the version of this patch that preserves the semantics of
this code as closely as possible, for review by the code owners.

Differential Revision: https://phabricator.services.mozilla.com/D93416
 2020-12-08 16:56:23 +00:00
Bogdan Tara
dc705240d6 Backed out 2 changesets (bug 1670982) for tsan xpc shell failures CLOSED TREE 
Backed out changeset 3ce1e8c65cbc (bug 1670982)
Backed out changeset e7211a44d968 (bug 1670982)
 2020-12-08 01:59:32 +02:00
Alexis Beingessner
b6f9e670b0 Bug 1670982 - Make the bitflags in CacheStorageService actually atomic. r=decoder,necko-reviewers,dragana,valentin 
TSan found races on these flags that are ostensibly benign but this way there's no UB.

This code is a bit weird. These bitfields are seemingly pointless as
they're squeezed between a uint64_t and an Atomic<bool>. There's plenty
of space for 2 more bools there.

Also the Atomic<bool> could theoretically be merged into the flags. For
now, here's the version of this patch that preserves the semantics of
this code as closely as possible, for review by the code owners.

Differential Revision: https://phabricator.services.mozilla.com/D93416
 2020-12-07 18:32:51 +00:00
Simon Giesecke
ab6f0a7137 Bug 1650145 - Replace all value uses of Empty[C]String by 0-length _ns literals. r=froydnj,geckoview-reviewers,agi 
Differential Revision: https://phabricator.services.mozilla.com/D82325
 2020-09-23 15:17:15 +00:00
Honza Bambas
f1469ed649 Bug 1642602 - Make about:cache show all entries, remove the no longer usable context switch UI, r=michal,necko-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D81885
 2020-07-03 11:41:53 +00:00
Simon Giesecke
a69d79b6db Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D80860
 2020-07-01 08:29:29 +00:00
Honza Bambas
02f5c3787f Bug 1487101 - Do not interrupt purging of HTTP cache entries from memory by frecency until the pool containts at most 2000 entries, r=michal,necko-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D80180
 2020-06-19 05:43:42 +00:00
Honza Bambas
9664943756 Bug 1626809 - Sanitize HTTP disk cache storage context key to prevent leak of private data like URLs, r=njn 
Differential Revision: https://phabricator.services.mozilla.com/D69625
 2020-04-09 12:38:09 +00:00
Simon Giesecke
9e7322117c Bug 1617628 - Hide nsBaseHashtable Put overloads in nsRefPtrHashtable subclass. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D63899
 2020-02-25 17:03:36 +00:00
Michal Novotny
a6d8c3a70e Bug 1614637 - ThreadSanitizer: data race [@ assign_assuming_AddRef] vs. [@ operator bool] in CacheStorageService r=mayhemer 
Differential Revision: https://phabricator.services.mozilla.com/D62550
 2020-02-17 18:44:21 +00:00
Mihai Alexandru Michis
0006d61c8a Backed out changeset 4758bb49e763 (bug 1614637) for causing multiple failures. 
CLOSED TREE
 2020-02-12 17:04:50 +02:00
Michal Novotny
c18d705eca Bug 1614637 - ThreadSanitizer: data race [@ assign_assuming_AddRef] vs. [@ operator bool] in CacheStorageService r=mayhemer 
Differential Revision: https://phabricator.services.mozilla.com/D62550
 2020-02-12 13:55:15 +00:00
Eric Rahm
daeb56f35b Bug 1606187 - Part 2b: Update users of nsClassHashtable to handle UniquePtr differences r=KrisWright,froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D59042
 2020-01-13 19:18:56 +00:00
Chris Peterson
0a9155f83b Bug 1570499 - Part 1: Replace MOZ_FALLTHROUGH macro with C++17's [[fallthrough]] attribute. r=froydnj 
This changeset is a simple find and replace of `MOZ_FALLTHROUGH` and `[[fallthrough]]`.

Unfortunately, the MOZ_FALLTHROUGH_ASSERT macro (to assert on case fallthrough in debug builds) is still necessary after switching from [[clang::fallthrough]] to [[fallthrough]] because:

* MOZ_ASSERT(false) followed by [[fallthrough]] triggers a -Wunreachable-code warning in DEBUG builds
* but MOZ_ASSERT(false) without [[fallthrough]] triggers a -Wimplicit-fallthrough warning in NDEBUG builds.

Differential Revision: https://phabricator.services.mozilla.com/D56440
 2019-12-20 07:16:43 +00:00
Tom Tung
7c1b52bb1f Bug 1474608 - P2 - Clear origin attributes data directly on cache2; r=asuth,michal,baku 
Differential Revision: https://phabricator.services.mozilla.com/D34324
 2019-12-02 19:47:05 +00:00
Andrea Marchesini
d61ff6823d Bug 1320404 - Remove appId from origin attributes - part 4 - necko, r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D29356
 2019-05-03 17:14:23 +00:00
Bogdan Tara
3fc33e1227 Backed out 4 changesets (bug 1320404) for test_permmanager_load_invalid_entries.js failures 
Backed out changeset 7c2f4e64d38e (bug 1320404)
Backed out changeset a7e7c0251179 (bug 1320404)
Backed out changeset dd741b25a244 (bug 1320404)
Backed out changeset de9073c57d20 (bug 1320404)
 2019-05-03 06:12:25 +03:00
Andrea Marchesini
d216cafc1f Bug 1320404 - Remove appId from origin attributes - part 4 - necko, r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D29356
 2019-05-02 17:25:05 +00:00
Cosmin Sabou
57e65f8648 Backed out 4 changesets (bug 1320404) for xperf failures on permissions.sqlite-journal. 
Backed out changeset fbacf18b6532 (bug 1320404)
Backed out changeset fed7c475d75c (bug 1320404)
Backed out changeset 557b586f774a (bug 1320404)
Backed out changeset 5a20b5f43280 (bug 1320404)
 2019-05-02 04:51:18 +03:00
Andrea Marchesini
3f66433d2e Bug 1320404 - Remove appId from origin attributes - part 4 - necko, r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D29356
 2019-05-01 23:21:19 +00:00
Sylvestre Ledru
d42e742a3e Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D24168
 2019-03-31 15:12:55 +00:00
Honza Bambas
f74208b387 Bug 1536387 - Append a regular HTTP cache key tag of value 0x7f to distinguish memory-only entries, r=michal 
Differential Revision: https://phabricator.services.mozilla.com/D24170
 2019-03-20 13:54:57 +00:00
Michal Novotny
44506e93f2 Bug 1479357 - Specific values for browser.cache.disk.capacity do break the cache, r=mayhemer 
This patch changes all size limits in CacheObserver to kilobytes. The same unit is used at most places when checking these limits. This avoids uint32_t overflow when converting to bytes and back.
 2019-01-08 16:28:00 +02:00
Sylvestre Ledru
e5a134f73a Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 
# ignore-this-changeset
 2018-11-30 11:46:48 +01:00
Gabriele Svelto
6036698e99 Bug 1503207 - Remove nsWeakPtr.h and cleanup all files including weak reference-related headers r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D10251
 2018-10-31 20:39:03 +00:00
Andrea Marchesini
6657222764 Bug 1468501 - Implement a way to delete network cache by nsIPrincipal, r=mayhemer, r=michal 2018-07-20 13:57:18 +02:00
Andi-Bogdan Postelnicu
cb91211b37 Bug 1453795 - Necko - Initialize member fields in classes/ structures. r=michal 2018-06-14 11:19:07 +03:00
Andi-Bogdan Postelnicu
99cba2dd23 Bug 1457411 - Update netwerk module to make use of newer methods introduced with c++11 and c++14. r=valentin 
MozReview-Commit-ID: 666LNaHyiuQ
 2018-04-30 19:46:04 +03:00
Sebastian Hengst
d91e9954eb Backed out 4 changesets (bug 525063) on request from Andi. a=backout 
Backed out changeset 516c4fb1e4b8 (bug 525063)
Backed out changeset 6ff8aaef2866 (bug 525063)
Backed out changeset bf13e4103150 (bug 525063)
Backed out changeset d7d2f08e051c (bug 525063)
 2018-04-13 16:01:28 +03:00
Tristan Bourvon
6095241db8 Bug 525063 - Initialize uninitialized class attributes in m-c. r=ehsan 2018-04-10 21:11:02 +02:00
Honza Bambas
21ab04a38b Bug 1441726 - Include CacheStorageService::mPurgeTimeStamps hashtable in the memory reporter. r=michal 2018-03-27 10:21:00 +03:00
Valentin Gosu
c77052af03 Bug 1408552 - Make sure we only instantiate CacheStorageService in the main process r=mayhemer 
* A memory leak occurs when this happens in the content process
* I added an assertion that we only create it in the parent process

MozReview-Commit-ID: 1UTyusRg0qx
 2017-10-18 21:10:22 +02:00
Sebastian Hengst
1cb4317132 Backed out changeset dfb238189002 (bug 1408552) for asserting in xpcshell's netwerk/test/unit_ipc/test_cache-entry-id_wrap.js. r=backout on a CLOSED TREE 2017-10-18 15:56:09 +02:00
Valentin Gosu
e2e475d67f Bug 1408552 - Make sure we only instantiate CacheStorageService in the main process r=mayhemer 
* A memory leak occurs when this happens in the content process
* I added an assertion that we only create it in the parent process

MozReview-Commit-ID: 1UTyusRg0qx
 2017-10-18 14:35:33 +02:00
Kris Maglione
7a77177f22 Bug 1404198: Part 2c - Switch to NS_NewTimer* in necko. r=njn 
MozReview-Commit-ID: 3YyyaBAEjHc
 2017-10-15 23:12:02 -07:00
Valentin Gosu
8afa70dcbe Bug 1395938 - Prevent crash when we are missing an IOThread during shutdown r=michal 
MozReview-Commit-ID: 4iuMoHMTzia
 2017-09-07 15:15:25 +02:00
Michal Novotny
31c97d265e Bug 1382688 - Do not allow to enable old disk cache backend, r=honzab 2017-08-24 10:25:38 +02:00
Carsten "Tomcat" Book
3fe83e45ea merge mozilla-inbound to mozilla-central a=merge 2017-07-27 10:57:25 +02:00
Bevis Tseng
59627df038 Bug 1382172 - Name nsITimerCallback instances in native implementation. r=billm 2017-07-27 02:18:20 +08:00
Kartikaya Gupta
14424677af Bug 1384233 - Remove SizePrintfMacros.h. r=froydnj 
We have a minimum requirement of VS 2015 for Windows builds, which supports
the z length modifier for format specifiers. So we don't need SizePrintfMacros.h
any more, and can just use %zu and friends directly everywhere.

MozReview-Commit-ID: 6s78RvPFMzv
 2017-07-26 16:03:57 -04:00
Mats Palmgren
64658a0f83 Bug 1376498 part 4 - Make all nsClassHashtable::RemoveAndForget() consumers use Remove() instead. r=froydnj 
MozReview-Commit-ID: G64YQLlgm6r
 2017-07-05 02:01:45 +02:00
Bill McCloskey
ce42826bdf Bug 1372405 - Provide names for all runnables in the tree (r=froydnj) 
MozReview-Commit-ID: DKR6ROiHRS7
 2017-06-26 14:19:58 -07:00
Nicholas Nethercote
4ce1e9c11f Bug 1374580 (part 3) - Remove ns{,C}Substring typedefs. r=froydnj. 
All the instances are converted as follows.

- nsSubstring  --> nsAString
- nsCSubstring --> nsACString
 2017-06-20 19:19:52 +10:00
Carsten "Tomcat" Book
238bf154d5 Backed out changeset 4f6302a98ae4 (bug 1372405) 2017-06-21 13:59:26 +02:00
Bill McCloskey
67e8af4720 Bug 1372405 - Provide names for all runnables in the tree (r=froydnj) 
MozReview-Commit-ID: DKR6ROiHRS7
 2017-06-20 21:44:11 -07:00
Carsten "Tomcat" Book
bbe9441993 Backed out changeset 9846de3bd954 (bug 1372405) 2017-06-20 08:27:02 +02:00
Bill McCloskey
f69608368b Bug 1372405 - Provide names for all runnables in the tree (r=froydnj) 
MozReview-Commit-ID: DKR6ROiHRS7
 2017-06-19 22:25:47 -07:00