Commit Graph

1329 Commits

Author SHA1 Message Date
Cosmin Sabou
0b29d94c62 Backed out changeset 9f5e51b38c2c (bug 1678323) for causing frequent failures in Bug 1691389 and Bug 1652531. 2021-02-08 19:08:13 +02:00
Marco Bonardo
e5f581b091 Bug 1678323 - Ctrl+L, Tab stopped working with browser.toolbars.keyboard_navigation=false. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D104212
2021-02-08 11:07:57 +00:00
Mark Banner
f321687f39 Bug 1412519 - Re-enable browser_contextSearchTabPosition.js for test-verify on Windows debug as it now passes. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D104235
2021-02-05 16:43:14 +00:00
harry
a767458341 Bug 1686330 - Add telemetry for tab-to-search result impressions, per-engine. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D103074
2021-02-04 19:53:37 +00:00
Narcis Beleuzu
731564fc32 Backed out 2 changesets (bug 1686330, bug 1685734) for bc failures on browser_urlbar_telemetry_tabtosearch.js
Backed out changeset 50a8c2a5f4e8 (bug 1685734)
Backed out changeset b129d712e3bc (bug 1686330)
2021-02-01 17:52:34 +02:00
harry
9cc4dd2296 Bug 1686330 - Add telemetry for tab-to-search result impressions, per-engine. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D103074
2021-01-27 17:23:35 +00:00
Mark Banner
8a9fc4165b Bug 1687235 - Enable ESLint rule no-setter-return for browser/. r=mossop,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D102152
2021-01-26 13:42:38 +00:00
Brindusan Cristian
201069fdac Backed out 5 changesets (bug 1687235) for mochitest failures at test_menulist_null_value.xhtml. CLOSED TREE
Backed out changeset 638c802ca1d1 (bug 1687235)
Backed out changeset ec830b771bce (bug 1687235)
Backed out changeset a7c933ddecfd (bug 1687235)
Backed out changeset c36493fb0599 (bug 1687235)
Backed out changeset 6eb33ad5d460 (bug 1687235)
2021-01-26 10:58:43 +02:00
Mark Banner
36cf48f89d Bug 1687235 - Enable ESLint rule no-setter-return for browser/. r=mossop,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D102152
2021-01-25 22:27:19 +00:00
Magnus Melin
0f56a88072 Bug 1524836 - Move new HTML about:config page from browser to toolkit. r=fluent-reviewers,preferences-reviewers,geckoview-reviewers,Gijs,agi
Unbitrot and change strategy for geckoview: now map about:config directly in nsAboutRecirector.cpp

Differential Revision: https://phabricator.services.mozilla.com/D25938
2021-01-26 00:27:56 +00:00
Mark Banner
b3e05a4f51 Bug 1664847 - Log the search access point for searches with ads and ad clicks. r=daleharvey
Depends on D102441

Differential Revision: https://phabricator.services.mozilla.com/D102443
2021-01-22 10:45:26 +00:00
Mark Banner
f9056ab5ef Bug 1664847 - Use a map for the search source translation in BrowserSearchTelemetry to make the code simpler. r=daleharvey
Depends on D102440

Differential Revision: https://phabricator.services.mozilla.com/D102441
2021-01-21 23:19:06 +00:00
Mark Banner
79fc6ebc12 Bug 1664847 - Change BrowserSearchTelemetry.recordSearch to take a browser rather than tabbrowser as that is more accurate. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D102440
2021-01-21 23:08:09 +00:00
Mark Banner
832a5841ff Bug 1513680 - Restrict ContentSearch messages to the privilegedabout process. r=daleharvey
Depends on D102227

Differential Revision: https://phabricator.services.mozilla.com/D102228
2021-01-22 08:31:03 +00:00
harry
e4a3bcc261 Bug 1687313 - Add international Amazon search suggestions URLs. r=Standard8,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D102210
2021-01-21 21:57:41 +00:00
Dale Harvey
e47e8fea6e Bug 1683991 - Update ebay urls to new search endpoint. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D100609
2021-01-15 22:27:14 +00:00
Noemi Erli
6cafc3acfd Backed out changeset d7b14690ec5f (bug 1683991) for causing failures in browser_searchEngine_behaviors.js CLOSED TREE 2021-01-16 00:01:16 +02:00
Dale Harvey
9db8ecc949 Bug 1683991 - Update ebay urls to new search endpoint. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D100609
2021-01-15 14:35:04 +00:00
Micah Tigley
8f370a3e55 Bug 1680637 - Update tests using the old dialog UI to only use the old UI. r=jaws,Gijs,marionette-reviewers,whimboo,remote-protocol-reviewers
Depends on D100172

Differential Revision: https://phabricator.services.mozilla.com/D101388
2021-01-14 21:45:14 +00:00
Butkovits Atila
24473dc461 Backed out 4 changesets (bug 1680637, bug 1682395) for causing Marionette failures. CLOSED TREE
Backed out changeset 073e0be7db95 (bug 1680637)
Backed out changeset 552b91b31b0f (bug 1682395)
Backed out changeset c80de6c72779 (bug 1680637)
Backed out changeset d513e228b0ad (bug 1680637)
2021-01-13 02:13:06 +02:00
Micah Tigley
c6396a0136 Bug 1680637 - Update tests using the old dialog UI to only use the old UI. r=jaws,Gijs
Depends on D100172

Differential Revision: https://phabricator.services.mozilla.com/D101388
2021-01-12 22:32:24 +00:00
Mark Banner
701c0fa0e5 Bug 1685310 - Update Top Sites icons for new version of Baidu logo. r=dao
Use a non-transparent version for the search engine favicon.

Differential Revision: https://phabricator.services.mozilla.com/D100937
2021-01-08 13:39:20 +00:00
Mark Banner
5038960166 Bug 1680906 - Update Baidu search engine logo. r=mkaply
Differential Revision: https://phabricator.services.mozilla.com/D100398
2020-12-23 19:23:04 +00:00
Dale Harvey
7b984399c0 Bug 1683654 - Fix the URL for bol.com searches r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D100282
2020-12-22 16:03:16 +00:00
Marco Bonardo
d845b18979 Bug 1682434 - Don't store long strings in search history. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D99954
2020-12-21 21:02:54 +00:00
Mark Banner
6f32af3733 Bug 1662553 - Simplify recording search telemetry. r=mak
This simplifies recording of the search telemetry by dropping the seperate logging of one-off button clicks, and combining the flows in recordSearch into one.

With the previous simplifications the calls in search bar and url bar, the remaining parts were two flows through recordSearch for the one-off buttons, and one for everything else. The two flows for one-off buttons each stopped at various times or skipped parts to continue to the rest.

This means we can combine those into one, have the flow governed by `details.isOneOff`, and change `maybeRecordTelemetry` into a function that simply determines if a one-off button was selected.

Differential Revision: https://phabricator.services.mozilla.com/D100053
2020-12-21 15:38:12 +00:00
Mark Banner
421eb13a89 Bug 1662553 - Reorder BrowserSearchTelemetry so the functions are in a slightly better order. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D100052
2020-12-18 16:19:25 +00:00
Mark Banner
be49c11ad5 Bug 1662553 - Remove unnecessary call to recordSearch in searchbar.js as nothing gets recorded in telemetry. r=mak
'header' and 'paste' sources are unknown, so they don't get logged for search counts, and they just get skipped.
Additionally, the target check for 'paste' is wrong so that would not have been recorded in recent releases anyway.

Differential Revision: https://phabricator.services.mozilla.com/D100051
2020-12-18 14:16:03 +00:00
Mark Banner
014cfd0139 Bug 1662553 - Remove unused detail.type property for BrowserSearchTelemetry.recordSearch calls. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D100050
2020-12-18 13:07:51 +00:00
Dorel Luca
e24a50422b Backed out 2 changesets (bug 1682434) for Browser-chrome in browser/components/search/test/browser/browser_contentSearchUI.js. CLOSED TREE
Backed out changeset 4fb5a850c536 (bug 1682434)
Backed out changeset 8ffb755b259c (bug 1682434)
2020-12-18 19:53:59 +02:00
Marco Bonardo
74cad2af6d Bug 1682434 - Don't store long strings in search history. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D99954
2020-12-18 14:27:18 +00:00
Marco Bonardo
4830941a5f Bug 1665049 - Remove browser.urlbar.update2. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D99487
2020-12-18 10:01:24 +00:00
Marco Bonardo
2cce82871d Bug 1665049 - Remove browser.urlbar.update2.oneOffsRefresh. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D99793
2020-12-18 09:58:17 +00:00
Marco Bonardo
8fa21d7c7f Bug 1665049 - Remove browser.urlbar.update2.disableOneOffsHorizontalKeyNavigation. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D99485
2020-12-18 09:55:28 +00:00
smolnar
7b08899f40 Backed out 4 changesets (bug 1665049) for causing bustages in browser.ini CLOSED TREE
Backed out changeset fd06f6552ad0 (bug 1665049)
Backed out changeset 156a323cd31a (bug 1665049)
Backed out changeset 011f54945acb (bug 1665049)
Backed out changeset 028644c366d5 (bug 1665049)
2020-12-18 11:45:30 +02:00
Marco Bonardo
59fc3065cf Bug 1665049 - Remove browser.urlbar.update2. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D99487
2020-12-18 09:26:35 +00:00
Marco Bonardo
4ae1ce08db Bug 1665049 - Remove browser.urlbar.update2.oneOffsRefresh. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D99793
2020-12-18 09:26:35 +00:00
Marco Bonardo
6f29eaf6f9 Bug 1665049 - Remove browser.urlbar.update2.disableOneOffsHorizontalKeyNavigation. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D99485
2020-12-15 22:28:09 +00:00
Mark Banner
51533badb0 Bug 1682264 - Simplify the search bar selected index telemetry reporting. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D99669
2020-12-17 18:14:07 +00:00
Mark Banner
387e7702c4 Bug 1682264 - Simplify search's autocomplete-popup, now that it is only used for the searchbar. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D99668
2020-12-17 18:13:47 +00:00
kanishk509
19928ad345 Bug 1654217 - Make getEngineByAlias async. r=Standard8,preferences-reviewers,nanj
Differential Revision: https://phabricator.services.mozilla.com/D96729
2020-12-11 21:41:17 +00:00
Mark Banner
fa234e703d Bug 1681382 - Drop BrowserSearch.record*SearchInTelemetry and call BrowserSearchTelemetry direct. r=daleharvey
Depends on D99206

Differential Revision: https://phabricator.services.mozilla.com/D99207
2020-12-10 23:40:58 +00:00
Mark Banner
fe4922a73f Bug 1681382 - Merge BrowserSearchTelemetry.record{Search|Urlbar}SelectedResultMethod functions into one. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D99206
2020-12-10 23:37:59 +00:00
Mark Banner
c5956a7c14 Bug 1680735 - Rename SearchTelemetry to SearchSERPTelemetry. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D98791
2020-12-08 20:42:15 +00:00
Mark Banner
b07a8fcb86 Bug 1680735 - Move search specific telemetry out of BrowserUsageTelemetry.jsm into a new module. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D98753
2020-12-08 20:42:03 +00:00
Akihiko Odaki
585a8066c5 Bug 1605305 - Origin header field is not set to HTTP request in cases where it is required, r=ckerschb,necko-reviewers,JuniorHsu,valentin
***

***

Differential Revision: https://phabricator.services.mozilla.com/D80905
2020-12-03 00:56:22 +00:00
Mark Banner
1b1d1b1d88 Bug 1669297 - Update Bing's logo for the search engine. r=mkaply.
Differential Revision: https://phabricator.services.mozilla.com/D97779
2020-11-30 21:59:50 +00:00
Mark Banner
4309bd5e99 Bug 1664849 - Extend ad impression/click telemetry to organic SERPS. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D97493
2020-11-20 13:40:09 +00:00
Butkovits Atila
567861d45c Backed out changeset aaee4ba7af2e (bug 1664849) for failures on test_urlTelemetry.js. CLOSED TREE 2020-11-20 14:32:42 +02:00
Mark Banner
c51fadb819 Bug 1664849 - Extend ad impression/click telemetry to organic SERPS. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D97493
2020-11-20 10:25:48 +00:00