Commit Graph

3284 Commits

Author SHA1 Message Date
leli
1309c53fb0 Bug 1690276 - Remove unused pref browser.preferences.exposeHTTPSOnly r=ckerschb,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D103806
2021-02-04 16:48:42 +00:00
Tim Nguyen
bc25fa0cb4 Bug 1523453 - Remove unused workaround for gAppUpdater in preferences. r=preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D103604
2021-02-01 13:47:17 +00:00
Tim Nguyen
a557545e39 Bug 1689742 - Stop using XUL <deck> for #setDefaultPane. r=preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D103522
2021-01-30 16:31:53 +00:00
Tim Nguyen
c73c17d40f Bug 1689727 - Stop using XUL <deck> for #updateDeck. r=preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D103519
2021-01-30 15:02:35 +00:00
Drew Willcoxon
2dd0131936 Bug 1688786 - Add a browser.urlbar.showSearchSuggestionsFirst pref. r=mak,preferences-reviewers
Introduce a new `browser.urlbar.showSearchSuggestionsFirst` boolean pref that
determines whether search suggestions are shown before general results.

This keeps the `matchBuckets` pref. I could have removed it since the only thing
we're using it for right now is to tell whether suggestions are shown first. The
reason I didn't remove it is because ultimately we do want a `matchBuckets` or
`resultBuckets` pref so we can experiment with different results compositions
using simple pref-flip studies. Hopefully bug 1676469 will land soon and we'll
replace `matchBuckets` with `resultBuckets`, but in the meantime I think we
should keep `matchBuckets` around.

This also removes some `browser.urlbar.matchBuckets` assignments in tests that
don't actually depend on it. For tests that do depend on it, I changed them so
they set `showSearchSuggestionsFirst` now.

Differential Revision: https://phabricator.services.mozilla.com/D103137
2021-01-28 23:23:16 +00:00
Mark Banner
8a9fc4165b Bug 1687235 - Enable ESLint rule no-setter-return for browser/. r=mossop,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D102152
2021-01-26 13:42:38 +00:00
Brindusan Cristian
201069fdac Backed out 5 changesets (bug 1687235) for mochitest failures at test_menulist_null_value.xhtml. CLOSED TREE
Backed out changeset 638c802ca1d1 (bug 1687235)
Backed out changeset ec830b771bce (bug 1687235)
Backed out changeset a7c933ddecfd (bug 1687235)
Backed out changeset c36493fb0599 (bug 1687235)
Backed out changeset 6eb33ad5d460 (bug 1687235)
2021-01-26 10:58:43 +02:00
Mark Banner
36cf48f89d Bug 1687235 - Enable ESLint rule no-setter-return for browser/. r=mossop,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D102152
2021-01-25 22:27:19 +00:00
Kirk Steuber
e11fcb7187 Bug 1685594 - Add capability for turning off automatic application update checks r=agashlin,preferences-reviewers
Note that this does not add the policy necessary to enable this feature. That policy will be added in Bug 1653430

Differential Revision: https://phabricator.services.mozilla.com/D101251
2021-01-21 23:47:19 +00:00
Masatoshi Kimura
20ad13c492 Bug 1684241 - Update a message to align with the actual proxy bypass range. r=Gijs,fluent-reviewers,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D101743
2021-01-14 16:58:16 +00:00
Alexis Beingessner
7b0d5a09cc Bug 1683730 - disabled tests failing with tsan full shutdown. r=decoder
Seems like all timeouts at various levels.

Differential Revision: https://phabricator.services.mozilla.com/D100269
2021-01-08 20:08:29 +00:00
Erica Wright
4b15bc0bb2 Bug 1685133 - String changes due to newtab updates r=preferences-reviewers,prathiksha,fluent-reviewers,flod,ntim
Differential Revision: https://phabricator.services.mozilla.com/D100819
2021-01-08 18:55:24 +00:00
Csoregi Natalia
d56135a020 Backed out changeset c98a54c184d0 (bug 1685133) for newtab failures. CLOSED TREE 2021-01-08 19:23:33 +02:00
Erica Wright
7ab3893483 Bug 1685133 - String changes due to newtab updates r=preferences-reviewers,prathiksha,fluent-reviewers,flod,ntim
Differential Revision: https://phabricator.services.mozilla.com/D100819
2021-01-08 07:34:44 +00:00
Drew Willcoxon
ed31385248 Bug 1681818 - In the search preferences UI, fix tree view problems that arise when engines are removed and restored due to the local shortcuts being present. r=mak
The problem is that a few sites assume that `lastIndex` is the index of the last
engine in the tree, but since bug 1657790 landed, `lastIndex` is now the index
of the last local shortcut.

Differential Revision: https://phabricator.services.mozilla.com/D100299
2020-12-23 00:58:51 +00:00
Gijs Kruitbosch
845b782213 Bug 1581678 - remove dead plugin code from about:preferences r=preferences-reviewers,ntim
Because 'navigator.mimeTypes' is always the empty string in the parent process, the loop at
_loadPluginHandlers never does anything, and there's no point keeping this now Flash is going
the way of the dodo anyway.

Differential Revision: https://phabricator.services.mozilla.com/D100216
2020-12-22 11:05:00 +00:00
Marco Bonardo
4830941a5f Bug 1665049 - Remove browser.urlbar.update2. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D99487
2020-12-18 10:01:24 +00:00
smolnar
7b08899f40 Backed out 4 changesets (bug 1665049) for causing bustages in browser.ini CLOSED TREE
Backed out changeset fd06f6552ad0 (bug 1665049)
Backed out changeset 156a323cd31a (bug 1665049)
Backed out changeset 011f54945acb (bug 1665049)
Backed out changeset 028644c366d5 (bug 1665049)
2020-12-18 11:45:30 +02:00
Marco Bonardo
59fc3065cf Bug 1665049 - Remove browser.urlbar.update2. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D99487
2020-12-18 09:26:35 +00:00
amy churchwell
66bcb60518 Bug 1646128 - Renamed SearchService.getDefaultEngines to SearchService.getAppProvidedEngines. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D99941
2020-12-17 20:54:57 +00:00
Butkovits Atila
03caf2a9e7 Backed out changeset d5111a57ad25 (bug 1646128) for failure on browser_engines.js. 2020-12-17 19:04:40 +02:00
amy churchwell
ebcc696d8e Bug 1646128 - Renamed SearchService.getDefaultEngines to SearchService.getAppProvidedEngines. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D99941
2020-12-17 14:40:05 +00:00
Shane Caraveo
105124d24b Bug 1678829 fix permafail due to pref change during render of about:preferences r=preferences-reviewers,ntim
Differential Revision: https://phabricator.services.mozilla.com/D99948
2020-12-16 22:37:03 +00:00
kanishk509
19928ad345 Bug 1654217 - Make getEngineByAlias async. r=Standard8,preferences-reviewers,nanj
Differential Revision: https://phabricator.services.mozilla.com/D96729
2020-12-11 21:41:17 +00:00
Tim Nguyen
3a65f02a34 Bug 1681948 - Fix min height of siteDataRemoveSelected.xhtml dialog. r=preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D99452
2020-12-11 17:27:43 +00:00
Marco Bonardo
c60c5083ed Bug 1678138 - Add a Preferences toggle for tab-to-search results. r=harry,fluent-reviewers,preferences-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D99393
2020-12-11 11:05:43 +00:00
Tim Huang
dab0b4b8ba Bug 1680459 - Part 2: Modify the tests for the new added content blocking category flag. r=johannh
Depends on D98740

Differential Revision: https://phabricator.services.mozilla.com/D98741
2020-12-09 13:31:44 +00:00
jurijuri
4dd5580016 Bug 1674806 - Remove windowtype attribute where it is obsolete r=ntim,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D99195
2020-12-09 08:20:55 +00:00
Barret Rennie
de446f2658 Bug 1677000 - Rename IOUtils.writeAtomic{,UTF8} to IOUtils.write{,UTF8} r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D99001
2020-12-09 05:48:46 +00:00
Razvan Maries
f4e9a01af4 Backed out 7 changesets (bug 1677000) for perma failures on test_ioutils_read_write.html. CLOSED TREE
Backed out changeset 3521334cfc38 (bug 1677000)
Backed out changeset 737f380c2cf2 (bug 1677000)
Backed out changeset 9dba15fdfe1f (bug 1677000)
Backed out changeset b2fa1a061b15 (bug 1677000)
Backed out changeset a5d7845d3c0c (bug 1677000)
Backed out changeset 8e6081b0c07d (bug 1677000)
Backed out changeset 6592577cf0fa (bug 1677000)
2020-12-09 07:34:21 +02:00
Barret Rennie
6ccd63bacf Bug 1677000 - Rename IOUtils.writeAtomic{,UTF8} to IOUtils.write{,UTF8} r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D99001
2020-12-09 04:31:40 +00:00
Dana Keeler
1b874313d3 Bug 1678490 - remove the "When a server requests your personal certificate" section from about:preferences r=preferences-reviewers,fluent-reviewers,jaws
In bug 634697, Firefox was changed to remember client authentication decisions
across sessions, so the option of having Firefox "Ask every time" was
misleading. Offering to "Select one automatically" is a privacy disaster and it
should not have been exposed in the UI.

Differential Revision: https://phabricator.services.mozilla.com/D98675
2020-12-04 20:45:22 +00:00
Christian Holler
d2b020d497 Bug 1677049 - Skip problematic mochitest-bc tests in TSan. r=Gankro,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D98365
2020-12-01 20:21:20 +00:00
Dão Gottwald
f1cf8c85f6 Bug 1679463 - Replace :not(foo):not(bar) with :not(foo,bar) in browser/. r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D98028
2020-11-26 21:54:32 +00:00
Drew Willcoxon
dbb9361da2 Bug 1678770 - Have the local search shortcut rows in the preferences UI show their restriction characters as keywords. r=mak
Depends on D97376

Differential Revision: https://phabricator.services.mozilla.com/D97830
2020-11-21 10:55:28 +00:00
Drew Willcoxon
8868f343fc Bug 1657790 - Allow local search mode buttons to be toggled separately from engines. r=mak,ntim
* Add prefs for each local search shortcut
* Remove the `update2.localOneOffs` pref since it's not necessary with the three
  new prefs
* Modify preferences UI by adding a new row in the engines tree for each local
  shortcut
* Add `UrlbarUtils.LOCAL_SEARCH_MODES` so we have a single place where local
  search modes and their properties are defined
* Add a new test file for the preferences UI
* Modify browser_oneOffs.js to test the three new preferences

Differential Revision: https://phabricator.services.mozilla.com/D97376
2020-11-20 22:35:08 +00:00
Erica Wright
702fb9a86f Bug 1595858 - Allow users to select or deselect addons for homepage and newtab without disabling the addons. r=preferences-reviewers,Gijs,mixedpuppy,ahal
Differential Revision: https://phabricator.services.mozilla.com/D93584
2020-11-20 21:40:14 +00:00
Bogdan Tara
ff248efb24 sBacked out changeset 26f7d3a8b1b6 (bug 1595858) for overrides related mochitest failures CLOSED TREE 2020-11-18 01:42:59 +02:00
Erica Wright
e6b0316387 Bug 1595858 - Allow users to select or deselect addons for homepage and newtab without disabling the addons. r=preferences-reviewers,Gijs,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D93584
2020-11-17 19:49:36 +00:00
Csoregi Natalia
62ee4a2c9f Backed out changeset ac3e7350aeed (bug 1673962) for failures on browser_experimental_features_restart_required_cancel.js. CLOSED TREE 2020-11-17 00:28:44 +02:00
Jared Wein
c4d1c18cde Bug 1673962 - Test to cover the code path of canceling the Restart Required prompt when enabling a restart-required=true experimental feature. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D95058
2020-11-16 19:19:35 +00:00
Noemi Erli
b1d3e523c4 Backed out changeset ac717cd03a6b (bug 1673962) for causing failures in browser_experimental_features_restart_required_cancel.js 2020-11-16 20:28:53 +02:00
Jared Wein
0a925d364e Bug 1673962 - Test to cover the code path of canceling the Restart Required prompt when enabling a restart-required=true experimental feature. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D95058
2020-11-16 16:05:51 +00:00
Nika Layzell
ed9e85fc9a Bug 1671983 - Part 4: Stop awaiting BrowserTestUtils.loadURI, r=annyG,remote-protocol-reviewers,extension-reviewers,preferences-reviewers,whimboo,zombie
This method only is async in order to allow callers to wait for a process switch
triggered by the call to `loadURI` to be finished before resolving. With
DocumentChannel, we should never trigger a process switch eagerly like this
again, so we don't need any of the async behaviour here anymore.

This part is largely mechanical changes to tests, removing the `await` calls on
`loadURI`, and a follow-up part will remove the actual async logic from
`BrowserTestUtils.loadURI`.

Differential Revision: https://phabricator.services.mozilla.com/D94641
2020-11-12 18:01:03 +00:00
Sonia Singla
65512524be Bug 1674803 - Removed references to screenX/screenY in browser/components/preferences/dialogs. r=preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D97093
2020-11-16 12:09:24 +00:00
Bogdan Tara
07d282afc6 Backed out changeset d86e4d6c2be4 (bug 1595858) for browser_ext_chrome_settings_overrides_home.js failures CLOSED TREE 2020-11-13 06:11:35 +02:00
Erica Wright
5855481ca4 Bug 1595858 - Allow users to select or deselect addons for homepage and newtab without disabling the addons. r=preferences-reviewers,Gijs,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D93584
2020-11-13 02:02:47 +00:00
Michael Goossens
bc9df21bf8 Bug 1649603 - Replace OS.File imports on ExtensionSettingsStore.jsm r=robwu,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D96776
2020-11-12 22:07:04 +00:00
Nihanth Subramanya
e415d1b8c7 Bug 1637344 - Clean up browser_statePartitioning_strings.js. r=Gijs,preferences-reviewers,ntim
Differential Revision: https://phabricator.services.mozilla.com/D96372
2020-11-12 11:19:59 +00:00
Nihanth Subramanya
cd88aa75ea Bug 1637344 - Show message in privacy preferences to indicate FPI is incompatible with dFPI. r=fluent-reviewers,johannh,preferences-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D96371
2020-11-12 11:18:23 +00:00