corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
688,051 Commits 1 Branch 0 Tags
0f921b51a93c8111b46568616090396cc21948eb
Commit Graph

209 Commits

Author SHA1 Message Date
Micah Tigley
a5ff856247 Bug 1674840 - Add Other Bookmarks folder to toolbar dynamically. r=Gijs,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D99701
 2020-12-17 16:52:35 +00:00
Marco Bonardo
c6cc66825a Bug 1464322 - Intermittent failure in browser_toolbar_overflow.js. r=adw 
Fix a race condition in _updateNodesVisibilityTimerCallback and skip nodes that
are not effective bookmarks, like the chevron or the other bookmarks button.

Differential Revision: https://phabricator.services.mozilla.com/D99900
 2020-12-16 18:06:21 +00:00
Kagami Sascha Rosylight
442b9d5680 Bug 1681592 - Promisify requestAnimationFrame in _rebuild r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D99282
 2020-12-11 18:17:52 +00:00
Micah Tigley
04928862eb Bug 1680732 - Call updateNodesVisibility() from 'Show Other Bookmarks' pref observer. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D98777
 2020-12-10 20:42:40 +00:00
Gijs Kruitbosch
f12bbd2265 Bug 1680762 - ensure both link clicks and drag/drop into the bookmarks toolbar works, r=jaws,mak 
Differential Revision: https://phabricator.services.mozilla.com/D98995
 2020-12-09 19:39:16 +00:00
Csoregi Natalia
3f90c93269 Backed out changeset 82046518530a (bug 1680762) for failures on browser_drag_bookmarks_on_toolbar.js. CLOSED TREE 2020-12-09 18:18:34 +02:00
Gijs Kruitbosch
837ba87d6d Bug 1680762 - ensure both link clicks and drag/drop into the bookmarks toolbar works, r=jaws,mak 
Differential Revision: https://phabricator.services.mozilla.com/D98995
 2020-12-09 15:08:58 +00:00
Marco Bonardo
4afae3b310 Bug 1677408 - Part 7 - Allow the view to opt-out of history details updates. r=Standard8 
In most cases bookmarks views don't need to be notified of history changes.
The only cases where they need that, is when history columns are visible in a
tree view, or the result is sorted by visits or frecency.
Thus, the menu and toolbar views can often save some work by not listening.

Differential Revision: https://phabricator.services.mozilla.com/D97280
 2020-11-23 16:29:54 +00:00
Butkovits Atila
c08d529090 Backed out 7 changesets (bug 1677408) for bustages on nsNavHistory.cpp. CLOSED TREE 
Backed out changeset 1e0dc9aaa979 (bug 1677408)
Backed out changeset 4198bc35198c (bug 1677408)
Backed out changeset ff93f264138b (bug 1677408)
Backed out changeset 0f2d72d2ed5a (bug 1677408)
Backed out changeset 996cbd111957 (bug 1677408)
Backed out changeset b0c23854e117 (bug 1677408)
Backed out changeset f7d6cc5e4457 (bug 1677408)
 2020-11-23 16:49:31 +02:00
Marco Bonardo
86303d66c6 Bug 1677408 - Part 7 - Allow the view to opt-out of history details updates. r=Standard8 
In most cases bookmarks views don't need to be notified of history changes.
The only cases where they need that, is when history columns are visible in a
tree view, or the result is sorted by visits or frecency.
Thus, the menu and toolbar views can often save some work by not listening.

Differential Revision: https://phabricator.services.mozilla.com/D97280
 2020-11-23 12:59:17 +00:00
Micah Tigley
2218b31ae9 Bug 1674539 - Add option to hide Other Bookmarks button from bookmarks toolbar. r=jaws,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D97211
 2020-11-19 21:49:26 +00:00
Narcis Beleuzu
016b07dbf6 Backed out 2 changesets (bug 1674539) for bc failures on browser_toolbar_other_bookmarks.js . CLOSED TREE 
Backed out changeset 63032f8390ea (bug 1674539)
Backed out changeset 36ab7b9324d9 (bug 1674539)
 2020-11-19 23:46:02 +02:00
Micah Tigley
afe05f330b Bug 1674539 - Add option to hide Other Bookmarks button from bookmarks toolbar. r=jaws,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D97211
 2020-11-19 20:40:04 +00:00
Jared Wein
84ba59a4bb Bug 1003364 - Add Bookmarks Toolbar view options to the context menu of the Bookmarks Toolbar. r=mak,Gijs 
This patch doesn't show the view options when right-clicking on folders or bookmarks within the toolbar, and also doesn't include an item to enter Customize mode to keep the menu from growing too large.

Differential Revision: https://phabricator.services.mozilla.com/D95798
 2020-11-05 23:00:47 +00:00
Narcis Beleuzu
479647874f Backed out 2 changesets (bug 1674160, bug 1003364) for bc failures on browser_bookmarks_toolbar_context_menu_view_options.js 
Backed out changeset b4ffebacc1b8 (bug 1674160)
Backed out changeset bfe8bc960f45 (bug 1003364)
 2020-11-05 22:55:59 +02:00
Jared Wein
76c6dfa789 Bug 1003364 - Add Bookmarks Toolbar view options to the context menu of the Bookmarks Toolbar. r=mak,Gijs 
This patch doesn't show the view options when right-clicking on folders or bookmarks within the toolbar, and also doesn't include an item to enter Customize mode to keep the menu from growing too large.

Differential Revision: https://phabricator.services.mozilla.com/D95798
 2020-11-05 19:09:18 +00:00
Micah Tigley
17aa816f05 Bug 1674756 - Use PlacesMenu helper for building the Other Bookmarks menupop. r=jaws,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D95781
 2020-11-05 03:03:07 +00:00
Dorel Luca
c86aeda4ee Backed out 2 changesets (bug 1674801, bug 1674756) for Browse-chrome failures in places/tests/browser/browser_toolbar_other_bookmarks.js. CLOSED TREE 
Backed out changeset d2697818f40d (bug 1674801)
Backed out changeset cbb47b6c9dc3 (bug 1674756)
 2020-11-05 00:09:47 +02:00
Micah Tigley
ba6a0e2b52 Bug 1674756 - Use PlacesMenu helper for building the Other Bookmarks menupop. r=jaws,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D95781
 2020-11-04 20:46:15 +00:00
Micah Tigley
a9a0aa5aea Bug 1664053 - Show 'Other Bookmarks' folder in bookmarks toolbar. r=jaws 
Differential Revision: https://phabricator.services.mozilla.com/D93698
 2020-10-28 22:37:51 +00:00
Dorel Luca
b959dcf2b1 Backed out 2 changesets (bug 1664053) for Browser-chrome failures. CLOSED TREE 
Backed out changeset 7ead316c420d (bug 1664053)
Backed out changeset 7ae93e1c8b86 (bug 1664053)
 2020-10-26 20:08:38 +02:00
Micah Tigley
2171053b5c Bug 1664053 - Show 'Other Bookmarks' folder in bookmarks toolbar. r=jaws 
Differential Revision: https://phabricator.services.mozilla.com/D93698
 2020-10-22 02:04:24 +00:00
Jared Wein
b881c15686 Bug 1597084 - Set the image attribute on the bookmark-items in the toolbar when creating them to prevent flickering of the default favicon. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D93301
 2020-10-19 16:52:32 +00:00
Sonia Singla
30a78c48fc Bug 1655400 - Enable ESLint rule no-setter-return for all of places. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D85021
 2020-07-29 11:19:09 +00:00
Masatoshi Kimura
20ab3af5ff Bug 1601235 - Remove the second arg of nsIXULBrowserWindow::SetOverLink. r=bzbarsky 
Differential Revision: https://phabricator.services.mozilla.com/D55946
 2019-12-05 14:23:01 +00:00
monikamaheshwari
edb30ffaec Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D45629
 2019-09-14 09:39:26 +00:00
Brian Grinstead
f9b8523642 Bug 1578569 - Restore padding-bottom on certain menupopups inside BMB_bookmarksPopup r=mak 
This was removed in Bug 1573158, where the following line change forced it to 0px:
https://hg.mozilla.org/integration/autoland/rev/3f54e52c52eb#l2.12

This uses shadow parts instead of Shadow DOM + XBL selectors into the arrowscrollbox,
which unblocks arrowscrollbox Custom Element conversion and appears to have the same
visual effect as far as I can tell.

Differential Revision: https://phabricator.services.mozilla.com/D44556
 2019-09-04 18:37:04 +00:00
Jared Wein
a559a71435 Bug 1571567 - Fix no-fallthrough errors in /browser. r=MattN,k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D40745
 2019-08-08 15:18:49 +00:00
Bogdan Tara
b60cea4f7a Backed out 10 changesets (bug 1571567) complementary backout after es lint failure on the patch CLOSED TREE 
Backed out changeset ce83fa75ae32 (bug 1571567)
Backed out changeset 7aa97ba7cce9 (bug 1571567)
Backed out changeset 777d79076e99 (bug 1571567)
Backed out changeset fbdf6b75a484 (bug 1571567)
Backed out changeset e2ed4620f232 (bug 1571567)
Backed out changeset 2c67015f12c6 (bug 1571567)
Backed out changeset 7ec086bb5bd5 (bug 1571567)
Backed out changeset 42df735c8556 (bug 1571567)
Backed out changeset 7d5fc57b2809 (bug 1571567)
Backed out changeset 606bafb8211c (bug 1571567)
 2019-08-08 18:13:54 +03:00
Alexander Surkov
b2f6a8c01e Bug 1539651 - Convert places-popup-base and places-popup-arrow bindings to Custom Elements r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D33821
 2019-08-08 14:28:36 +00:00
Jared Wein
8bcdbe62ed Bug 1571567 - Fix no-fallthrough errors in /browser. r=MattN,k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D40745
 2019-08-08 01:38:50 +00:00
Victor Porof
8eb72fd3fc Bug 1561435 - Format browser/components/, a=automatic-formatting 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042
 2019-07-05 09:53:32 +02:00
Marco Bonardo
231f6645fe Bug 1502119 - Remove obsolete nodeAnnotationChanged. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D34998
 2019-06-16 13:46:14 +00:00
Andrew Swan
701b88bcd2 Bug 1555496 Fix bookmark toolbar drag handlers r=bgrins 
Code here explicitly references lastElementChild inside a toolbarbutton
but it doesn't have any tests so it wasn't caught when bug 1519577 landed :(

Differential Revision: https://phabricator.services.mozilla.com/D33104
 2019-05-30 03:29:19 +00:00
Andrew Swan
1ab513d145 Bug 1519577 Convert toolbarbutton to a custom element r=surkov 
Differential Revision: https://phabricator.services.mozilla.com/D31941
 2019-05-20 10:01:02 -07:00
Ian Moody
cac3a5f1e2 Bug 1536653 - browser/ automated ESLint no-throw-literal fixes. r=Gijs 
Result of running:
$ mach eslint -funix browser/ | sed -Ee 's/:.+//' - | xargs sed -E \
    -e 's/throw ((["`])[^"]+\2);/throw new Error(\1);/g' \
    -e 's/throw ((["`])[^"]+\2 \+ [^ ";]+);/throw new Error(\1);/g' \
    -e 's/throw \(/throw new Error(/g' -i

Differential Revision: https://phabricator.services.mozilla.com/D24110
 2019-03-20 10:17:42 +00:00
Marco Bonardo
a040dd21a3 Bug 1528751 - Add a custom eslint rule to check "consistent" if bracing. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D20753
 2019-02-28 08:39:33 +00:00
Jonas Allmann
7f8cbbfa55 Bug 1523813, Remove new Function from utilityOverlay.js, r=Gijs 
Replaced new Function() by CustomEvent carrying original click event as sourceEvent.
Adapted all oncommand listeners to use event.sourceEvent instead of event.

Differential Revision: https://phabricator.services.mozilla.com/D18847
 2019-02-19 16:20:02 +00:00
Toby Ward
207badbc32 Bug 1435562 - browser.tabs.warnOnOpen is now respected when opening multiple items from the library. r=Standard8 
- Unified openContainerNodeInTabs and openURINodesInTabs in PlacesUIUtils into openMultipleLinksInTabs
- Users are now warned when the amount of links to be opened is equal to or exceeds browser.tabs.maxOpenBeforeWarn

Differential Revision: https://phabricator.services.mozilla.com/D12983
 2018-12-10 17:04:18 +00:00
James Abbatiello
26b562fade Bug 430577 - Don't open dropdown on bookmarks toolbar folder when opening new tabs, r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D13666
 2018-12-04 19:41:17 +00:00
Mark Banner
8cd25e0609 Bug 1501811 - Remove livemarks support from browserPlacesViews/treeView. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D9701
 2018-10-26 07:40:15 +00:00
Gijs Kruitbosch
2c95aeb137 Bug 1501592 - remove remaining expired feed telemetry, r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D9665
 2018-10-25 10:52:59 +00:00
Brendan Dahl
532fe1f6b0 Bug 1485426 - Use createXULElement instead of createElement in XUL docs. r=bgrins 
Preparing for transitioning to XHTML.

MozReview-Commit-ID: JLlmUxsvhIB

Differential Revision: https://phabricator.services.mozilla.com/D4265
 2018-08-25 00:16:27 +00:00
Mark Banner
7e98ad6bc5 Bug 1476228 - Enable comma-dangle ESLint rule for Places directories. r=mikedeboer 
MozReview-Commit-ID: K8HcZfyF4Sz

Differential Revision: https://phabricator.services.mozilla.com/D3796
 2018-08-22 15:44:43 +00:00
Brian Grinstead
1c86f46ecd Bug 1479125 - Migrate calls that expect an element to be returned to use element variation firstChild etc to firstElementChild etc;r=Paolo 
This allows the JS to work in HTML documents, where whitespace is preserved. In XUL
documents, whitespace is ignored when parsing so text nodes are generally not returned.

The following changes were made, with manual cleanups as necessary (i.e. when firstChild actually
refers to a text node, or when firstChild is used in a loop to empty out an element):

  firstChild->firstElementChild
  lastChild->lastElementChild
  nextSibling->nextElementSibling
  previousSibling->previousElementSibling
  childNodes->children

MozReview-Commit-ID: 95NQ8syBhYw
 2018-08-08 15:22:53 -07:00
Boris Zbarsky
e98236cf07 Bug 1476145 part 3. Stop using getInterface(nsIDOMWindowUtils) in browser/. r=gijs 2018-07-24 19:47:41 -04:00
Marco Bonardo
3c437dd9d9 Bug 1461685 - The bookmarks toolbar is empty if the first bookmark is a separator. r=standard8 
MozReview-Commit-ID: JcDokxD2wXh
 2018-05-16 15:24:23 +02:00
Gijs Kruitbosch
16ff687c65 Bug 1447619 - avoid reflowing when returning items to the toolbar from the overflow menu, r=florian 
MozReview-Commit-ID: BFGRssWb9F
 2018-04-20 15:09:44 +01:00
Andreea Pavel
8aa53073af Backed out changeset 1ce48405e58a (bug 1447619) for creating bug 1457257 and bug 1457289 on a CLOSED TREE 2018-04-28 20:46:51 +03:00
Kris Maglione
582a21b473 Bug 1456035: Part 5 - Convert manual QueryInterface to ChromeUtils.generateQI. r=mccr8 
Manually-implemented QueryInterface functions don't benefit from the
MozQueryInterface optimizaions, and a lot of them are in hot code, and
implement a large number of interfaces.

MozReview-Commit-ID: 8OzglraowZt
 2018-04-23 12:58:34 -07:00