Emma Malysz
5a03aeace8
Bug 1689405: remove components of library panel r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D103532
2021-01-30 17:12:51 +00:00
Mark Banner
8a9fc4165b
Bug 1687235 - Enable ESLint rule no-setter-return for browser/. r=mossop,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D102152
2021-01-26 13:42:38 +00:00
Brindusan Cristian
201069fdac
Backed out 5 changesets (bug 1687235) for mochitest failures at test_menulist_null_value.xhtml. CLOSED TREE
...
Backed out changeset 638c802ca1d1 (bug 1687235 )
Backed out changeset ec830b771bce (bug 1687235 )
Backed out changeset a7c933ddecfd (bug 1687235 )
Backed out changeset c36493fb0599 (bug 1687235 )
Backed out changeset 6eb33ad5d460 (bug 1687235 )
2021-01-26 10:58:43 +02:00
Mark Banner
36cf48f89d
Bug 1687235 - Enable ESLint rule no-setter-return for browser/. r=mossop,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D102152
2021-01-25 22:27:19 +00:00
tanner drake
4edddefa63
Bug 1673129: Prevent all downloads view from scrolling when toggling download resume pause state. r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D101766
2021-01-15 15:08:58 +00:00
Marco Bonardo
ab463ebaa5
Bug 1684524 - Selecting all downloads after a search should not select excluded downloads. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D101447
2021-01-13 10:57:35 +00:00
Gijs Kruitbosch
00857d5f82
Bug 1685753 - stop using level=top for the downloads panel, r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D101195
2021-01-08 23:35:49 +00:00
Sebastian Streich
ef9e395b00
Bug 1676221 - Add UX nits to unblock UI r=ckerschb,Gijs
...
Show save dialogue
***
Automaticly show Panel On Block
***
Keep Open/Save Dialogue with open panel
***
Keep User choise in downloadsView
***
Add Unblock option to Unblock panel
***
lint
***
add test
Differential Revision: https://phabricator.services.mozilla.com/D96448
2020-12-18 15:30:33 +00:00
Butkovits Atila
8480457d60
Backed out changeset 234ae5cb0ff8 (bug 1676221) for causing leaks. CLOSED TREE
2020-12-17 10:54:31 +02:00
Sebastian Streich
0515cda67b
Bug 1676221 - Add UX nits to unblock UI r=ckerschb,Gijs
...
Show save dialogue
***
Automaticly show Panel On Block
***
Keep Open/Save Dialogue with open panel
***
Keep User choise in downloadsView
***
Add Unblock option to Unblock panel
***
lint
***
add test
Differential Revision: https://phabricator.services.mozilla.com/D96448
2020-12-16 22:55:12 +00:00
Tim Huang
b77a2550da
Bug 1679325 - Part 1: Making contentAreaUtils.saveURL to accept cookieJarSettings. r=smaug
...
This patch makes the contentAreaUtils.saveURL to be aware of the
cookieJarSettings, and updates all callers.
This also updates the documentation of the persistArgs
'cookieJarSettings' for internalPersist().
Differential Revision: https://phabricator.services.mozilla.com/D98455
2020-12-03 20:10:36 +00:00
Tim Nguyen
9921aa2950
Bug 1677247 - Followup: reformat downloads.css a bit. DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D97945
2020-11-25 07:43:24 +00:00
Kartik Gautam
b2cd2a8893
Bug 1677247 - Replace :not(:is(X)) with :not(X) in the codebase. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D97943
2020-11-25 04:23:25 +00:00
Itiel
3a57098651
Bug 1631202 - Convert all uses of :-moz-any to :is in browser/ r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D90690
2020-09-21 19:35:35 +00:00
Adam Gashlin
349bf16d98
Bug 1639067 part 3 - Extend "Open In System Viewer" from PDF to all viewable internally. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D86652
2020-08-17 21:24:45 +00:00
Dorel Luca
431b3e2a3a
Backed out 4 changesets (bug 1639067) for XPCshell failures in tests/unit/test_getMIMEInfo_pdf.js. CLOSED TREE
...
Backed out changeset 1e400fafd80b (bug 1639067)
Backed out changeset 7bb3c2ec5c7a (bug 1639067)
Backed out changeset 755fd5771648 (bug 1639067)
Backed out changeset 951e10b7354f (bug 1639067)
2020-08-18 00:18:32 +03:00
Adam Gashlin
fcc30dab7f
Bug 1639067 part 3 - Extend "Open In System Viewer" from PDF to all viewable internally. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D86652
2020-08-17 19:14:00 +00:00
Sam Foster
7a6bf11a8c
Bug 1649421 - Handle null mimeInfo from a download when populating the context menu. r=jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D81767
2020-07-01 22:27:51 +00:00
Sam Foster
19f6f1121e
Bug 1639069 - Add download context menu items to 'Use' and 'Always use' the system viewer to open the download. r=jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D79396
2020-06-25 22:19:37 +00:00
Emma Malysz
fb826b9e34
Bug 1627676: add telemetry probes for downloads panel r=jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D78709
2020-06-12 17:18:07 +00:00
Sam Foster
dbcd872d8e
Bug 1638156 - Allow key modifiers to determine how/'where' PDFs are opened when possible. r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D75870
2020-05-29 07:16:54 +00:00
Razvan Maries
030be31f02
Backed out 2 changesets (bug 1638156) for perma failures on browser_pdfjs_preview.js. CLOSED TREE
...
Backed out changeset c5c3da72080f (bug 1638156)
Backed out changeset da0e27f7f17a (bug 1638156)
2020-05-28 05:01:13 +03:00
Sam Foster
0becf30a8f
Bug 1638156 - Allow key modifiers to determine how/'where' PDFs are opened when possible. r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D75870
2020-05-28 01:13:19 +00:00
Sam Foster
83842cd59d
Bug 1191591 - Delegate to the parent class' code when opening downloads from the download panel. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D73773
2020-05-18 17:30:08 +00:00
Sam Foster
0af6b6c35b
Bug 1191591 - Consolidate download opening to use download.launch() via a DownloadsCommon.openDownload helper. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D75435
2020-05-18 17:30:00 +00:00
Noemi Erli
80613259fb
Backed out 3 changesets (bug 1191591) for causing newtab failures
...
Backed out changeset bd59c10af492 (bug 1191591)
Backed out changeset 3ff8cc8dd4b7 (bug 1191591)
Backed out changeset c6b3783367f6 (bug 1191591)
2020-05-16 01:57:34 +03:00
Sam Foster
8108b677c1
Bug 1191591 - Delegate to the parent class' code when opening downloads from the download panel. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D73773
2020-05-15 20:43:46 +00:00
Sam Foster
48546bf4cf
Bug 1191591 - Consolidate download opening to use download.launch() via a DownloadsCommon.openDownload helper. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D75435
2020-05-15 20:42:03 +00:00
Gijs Kruitbosch
9fcf318d83
Bug 1628255 - do not add a label/accesskey attribute to the button in the about:downloads and library downloads views, r=mconley,flod,fluent-reviewers
...
As noted by Jamie, accessible labels for richlistitem elements come from the
label elements that have value attributes within them.
In bug 1608202, we accidentally reused the same fluent message for the buttons
in about:downloads and the library download view (DownloadsViewUI.jsm) and
the context menuitems that do the same thing. This meant that
those menuitems gained a tooltip they shouldn't have, and the buttons gained
a label and accesskey they shouldn't have. The latter caused the
accessibility regression described in the bug.
This patch separates out the two usecases for the same string. I also checked
the other l10nIds used in DownloadsViewUI.jsm, and as far as I can tell this
is the only one that is reused in this way.
Differential Revision: https://phabricator.services.mozilla.com/D70219
2020-04-08 21:39:14 +00:00
Edgar Chen
d44563232f
Bug 1615732 - Don't show download panel on Mac when ctrl key is pressed; r=Gijs
...
On Mac, ctrl-click will send a context menu event from the widget, so we don't
want to bring up the panel when ctrl key is pressed.
Differential Revision: https://phabricator.services.mozilla.com/D66414
2020-04-06 20:56:19 +00:00
Cosmin Sabou
2b8f829371
Backed out 7 changesets (bug 1615732) for bc failures on browser_ext_pageAction_click_types.js. CLOSED TREE
...
Backed out changeset 031b8abf43a8 (bug 1615732)
Backed out changeset 297d82b338dc (bug 1615732)
Backed out changeset bbcb173e6c44 (bug 1615732)
Backed out changeset d7c5824d4579 (bug 1615732)
Backed out changeset f648cf0653a7 (bug 1615732)
Backed out changeset fcd441a2a860 (bug 1615732)
Backed out changeset fa861e50f198 (bug 1615732)
2020-04-06 23:49:58 +03:00
Brian Grinstead
fc15d98aae
Bug 1623992 - Automated rewrite from chrome://global/skin/ to chrome://global/skin/global.css in markup r=marionette-reviewers,perftest-reviewers,mossop,whimboo,sparky
...
This was generated with
```
cp .gitignore .rgignore
rg -l -g '*.{html,xhtml}' 'href="chrome://global/skin/"' | xargs sed -i "" 's/href\="chrome:\/\/global\/skin\/"/href\="chrome:\/\/global\/skin\/global.css"/g'
```
Differential Revision: https://phabricator.services.mozilla.com/D67687
2020-04-03 22:23:23 +00:00
Edgar Chen
2df04d111f
Bug 1615732 - Don't show download panel on Mac when ctrl key is pressed; r=Gijs
...
On Mac, ctrl-click will send a context menu event from the widget, so we don't
want to bring up the panel when ctrl key is pressed.
Differential Revision: https://phabricator.services.mozilla.com/D66414
2020-03-17 01:03:00 +00:00
Riley Byrd
c065a62811
Bug 1608202 - downloads.dtd to Fluent r=mconley,Gijs,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D59634
2020-04-03 14:47:28 +00:00
Gijs Kruitbosch
65b2624adc
Bug 1620184 - fix drag/drop in about:downloads, r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D66075
2020-03-11 16:43:01 +00:00
Gijs Kruitbosch
419c032d4e
Bug 1617332 - activate downloads view elements immediately instead of debouncing all the time, r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D65394
2020-03-09 10:40:15 +00:00
Gijs Kruitbosch
b481feca27
Bug 1616152 - avoid race conditions in about:downloads by waiting for downloads to load, r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D63414
2020-02-21 15:02:34 +00:00
Axel Hecht
4673da4973
Bug 1609898, fix xml parsing error introduced by bug 1605467, r=Gijs
...
This is just a bustage fix, and doesn't try to address the question
of test coverage.
Differential Revision: https://phabricator.services.mozilla.com/D60234
2020-01-17 11:44:42 +00:00
Zibi Braniecki
cd25170590
Bug 1605467 - Migrate text action keys to Fluent. r=fluent-reviewers,Gijs,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D59272
2020-01-17 11:43:39 +00:00
Narcis Beleuzu
48e5f991ad
Backed out changeset a2f061d89feb (bug 1605467) for causing Bug 1609898.
2020-01-17 13:23:33 +02:00
Zibi Braniecki
7cf42623ef
Bug 1605467 - Migrate text action keys to Fluent. r=fluent-reviewers,Gijs,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D59272
2020-01-15 11:44:14 +00:00
Gijs Kruitbosch
85d6ac49c6
Bug 1605939 - allow downloads view to scroll by not enclosing it in a stack that sizes to match the view size, r=ntim
...
Differential Revision: https://phabricator.services.mozilla.com/D58220
2019-12-25 18:58:24 +00:00
Emma Malysz
ba6b2f0a9b
Bug 1601093, Rename the remaining .xul files to .xhtml in toolkit/ r=marionette-reviewers,mossop,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D55857
2019-12-11 17:44:54 +00:00
Gurzau Raul
c2d189a7a6
Backed out changeset dd809e835f2a (bug 1601093) for eslint failures at alert.xhtml and commonDialog.xhtml on a CLOSED TREE.
2019-12-11 19:27:28 +02:00
Emma Malysz
abfeb3aaa3
Bug 1601093, Rename the remaining .xul files to .xhtml in toolkit/ r=marionette-reviewers,mossop,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D55857
2019-12-11 17:02:20 +00:00
Emma Malysz
ce4da4686b
Bug 1601094, rename the remaining .xul files in browser/ to .xhtml r=marionette-reviewers,whimboo,mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D55751
2019-12-11 00:27:19 +00:00
Tim Nguyen
5afeb64516
Bug 1597120 - Replace usages of XUL mousethrough with CSS pointer-events. r=dao
...
Differential Revision: https://phabricator.services.mozilla.com/D53348
2019-11-22 13:15:00 +00:00
Brian Grinstead
628c0a5dcc
Bug 1596591 - Rename inc.xul files to inc.xhtml r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D53843
2019-11-21 09:46:01 +00:00
Christoph Kerschbaumer
414c32b5ed
Bug 1584539: Stop propagation of event. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D48027
2019-10-03 14:42:29 +00:00
Christoph Kerschbaumer
6dec8a1a75
Bug 1499354: Add object-src 'none' to the CSP of all about: pages. r=freddyb
...
Differential Revision: https://phabricator.services.mozilla.com/D46950
2019-09-26 16:22:41 +00:00