Commit Graph

271 Commits

Author SHA1 Message Date
Markus Stange
46d24f2589 Bug 1650835 - Add support for a "button-and-view" widget type. r=jaws
This widget will be used for the profiler button. The profiler button is a
two-part widget with both a command and a view. The command starts/stops the
profiler, but the starting/stopping can also be performed from inside the view.
The dropmarker button shows the view.
When this widget is located in the panel, the start/stop action is only
accessible via the view and there is no "quick-action" command.

The structure of the widget is as follows:

toolbaritem.toolbaritem-combined-buttons
 - toolbarbutton.toolbarbutton-1
 - toolbarbutton.toolbarbutton-1.toolbarbutton-combined-buttons-dropmarker

The dropmarker icon is the toolbarbutton icon of the second toolbarbutton.
The dropmarker button is only shown in the toolbar or in the customize palette.
It is hidden when the widget is located in the panel.
In the toolbar, the hover effect of the dropmarker needs to have the same height
as the hover effect of the regular button. However, due to the different image
size (12x12 instead of 16x16) it requires more vertical padding.

Differential Revision: https://phabricator.services.mozilla.com/D98216
2021-01-15 18:14:04 +00:00
Jared Wein
64176c986d Bug 727668 - Show bookmarks toolbar on the new tab page. r=Gijs,fluent-reviewers,marionette-reviewers,whimboo
This adds the ability to force the bookmarks toolbar to appear on all pages. The checkbox in the toolbar context menu will reflect if the toolbar will appear outside of the newtab page. The toolbar will always appear on the newtab page. Profiles that already had the toolbar showing will have a migration to keep their experience unchanged.

Differential Revision: https://phabricator.services.mozilla.com/D89222
2020-10-26 02:32:07 +00:00
Mihai Alexandru Michis
dc6c624799 Backed out changeset ba261cf25651 (bug 727668) for causing marionette failures in test_screenshot.py
CLOSED TREE
2020-10-22 06:13:54 +03:00
Jared Wein
8debd64190 Bug 727668 - Show bookmarks toolbar on the new tab page. r=Gijs,fluent-reviewers
This adds the ability to force the bookmarks toolbar to appear on all pages. The checkbox in the toolbar context menu will reflect if the toolbar will appear outside of the newtab page. The toolbar will always appear on the newtab page. Profiles that already had the toolbar showing will have a migration to keep their experience unchanged.

Differential Revision: https://phabricator.services.mozilla.com/D89222
2020-10-21 19:20:20 +00:00
Narcis Beleuzu
8c2c851d6a Backed out 1 changesets (bug 727668) for bc failures on browser_aboutNewTab_bookmarksToolbar.js . CLOSED TREE
Backed out changeset 5b6a14b4e16e (bug 727668)
2020-10-19 21:19:17 +03:00
Jared Wein
dae078ac27 Bug 727668 - Show bookmarks toolbar on the new tab page. r=Gijs,fluent-reviewers
This adds the ability to force the bookmarks toolbar to appear on all pages. The checkbox in the toolbar context menu will reflect if the toolbar will appear outside of the newtab page. The toolbar will always appear on the newtab page. Profiles that already had the toolbar showing will have a migration to keep their experience unchanged.

Differential Revision: https://phabricator.services.mozilla.com/D89222
2020-10-19 16:38:17 +00:00
Michael Kaply
a8789bb2df Bug 1665237 - Make managed bookmarks item dynamic. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D90628
2020-10-06 20:13:00 +00:00
Razvan Maries
363e32f089 Backed out changeset 2b2e72856dc1 (bug 1665237) for perma failures on browser_popupNode.js. CLOSED TREE 2020-09-25 06:03:12 +03:00
Michael Kaply
b7150182a5 Bug 1665237 - Make managed bookmarks item dynamic. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D90628
2020-09-22 20:08:17 +00:00
Michael Kaply
2cf31c0507 Bug 1498688 - Add ManagedBookmarks policy. r=fluent-reviewers,emalysz,Standard8,flod
Differential Revision: https://phabricator.services.mozilla.com/D76009
2020-09-08 20:09:35 +00:00
Jared Wein
d4a3809d85 Bug 1656277 - Show the bookmarks toolbar after migration if bookmarks were in the other browsers toolbar. r=MattN,Standard8
This is behind a pref so we can run a study on it.

Differential Revision: https://phabricator.services.mozilla.com/D85956
2020-08-14 15:56:36 +00:00
Mihai Alexandru Michis
4b61ccb021 Backed out changeset 8b917683232d (bug 1656277) for causing xpcshell failures in test_IE_bookmarks.js
CLOSED TREE
2020-08-14 08:36:35 +03:00
Jared Wein
41d021123f Bug 1656277 - Show the bookmarks toolbar after migration if bookmarks were in the other browsers toolbar. r=MattN,Standard8
This is behind a pref so we can run a study on it.

Differential Revision: https://phabricator.services.mozilla.com/D85956
2020-08-14 03:27:22 +00:00
Csoregi Natalia
aa0319a6dd Backed out changeset 4fc26e678c18 (bug 1656277) for failures on test_Edge_db_migration.js. CLOSED TREE 2020-08-14 04:21:35 +03:00
Jared Wein
1f16b4feae Bug 1656277 - Show the bookmarks toolbar after migration if bookmarks were in the other browsers toolbar. r=MattN,Standard8
This is controlled by a pref so we can run a study on it.

Differential Revision: https://phabricator.services.mozilla.com/D85956
2020-08-13 21:56:40 +00:00
Noemi Erli
4de7581677 Backed out changeset c2c4b8d6b915 (bug 1656277) for causing build bustages in nsDocShell.cpp CLOSED TREE 2020-08-14 01:13:41 +03:00
Jared Wein
cccc0ccf92 Bug 1656277 - Show the bookmarks toolbar after migration if bookmarks were in the other browsers toolbar. r=MattN,Standard8
This is controlled by a pref so we can run a study on it.

Differential Revision: https://phabricator.services.mozilla.com/D85956
2020-08-13 21:56:40 +00:00
Emma Malysz
5b376f1958 Bug 1650404, rely on panelUI to add "PanelUI-subView" attribute r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D82808
2020-07-09 14:30:27 +00:00
Emma Malysz
e0df299294 Bug 1648639, remove containers, help view, and developer panels from main view and place in template r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D81257
2020-06-30 22:40:15 +00:00
Butkovits Atila
34bed92925 Backed out changeset 3c400bb0cd01 (bug 1648639) for bc failures on browser_panel_keyboard_navigation.js. 2020-06-30 21:35:06 +03:00
Emma Malysz
7a023f33ea Bug 1648639, remove containers, help view, and developer panels from main view and place in template r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D81257
2020-06-30 15:11:00 +00:00
Dave Townsend
4b134e74e8 Bug 1620358: Gather telemetry on toolbar state. r=Gijs,zombie
Differential Revision: https://phabricator.services.mozilla.com/D78393
2020-06-16 21:06:15 +00:00
Andrei Oprea
e07aac01d4 Bug 1638274 - Error thrown when accessing What's New panel message r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D75495
2020-05-15 12:52:46 +00:00
Gijs Kruitbosch
8b24ac52cf Bug 1558635 - use an html:template for the customize mode palette to avoid instantiating items in the palette, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D74097
2020-05-13 23:31:05 +00:00
Itiel
9f65662371 Bug 1634247 - Fix separators in the Web Developer menu r=dao
Differential Revision: https://phabricator.services.mozilla.com/D73906
2020-05-08 15:33:18 +00:00
aarushivij
090118a252 Bug 908954 - Remove try…catch comment inside wrapWidgetEventHandler once bug 503244 is fixed r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D71268
2020-04-17 05:50:56 +00:00
Brian Grinstead
f8461d8cd0 Bug 1608281 - Automated rewrite away from reading properties on the global this in JSM files - round 1 r=mossop
This patch was generated with a script. It doesn't include all files:

- Files that use the preprocessor or fail to parse are skipped
- Files that are loaded as JSMs but don't use the .jsm extension are skipped (those will be renamed in Bug 1609269)

It was generated with the following command using d855222aa2/no-this-property-read.js:

```
hg revert --all &&
cp .gitignore .rgignore &&
rg --files-without-match -g '*.jsm' '^#endif|^#include|^#filter' | jscodeshift --stdin --transform ~/Code/jsm-rewrites/no-this-property-read.js --ignore-pattern ./mobile/android/modules/Sanitizer.jsm --ignore-pattern ./js/xpconnect/tests/unit/syntax_error.jsm &&
./mach eslint `hg st | rg '^M ' | sed 's/^M //'`
```

Differential Revision: https://phabricator.services.mozilla.com/D60187
2020-01-29 21:50:04 +00:00
Dão Gottwald
8c597b4b57 Bug 1611689 - Make OverflowableToolbar::_checkOverflow return early in DOM fullscreen mode. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D61181
2020-01-28 15:55:50 +00:00
Dão Gottwald
0a3b95e63c Bug 1607160 - Skip positioned elements when calculating whether a toolbar overflows. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D59299
2020-01-09 17:07:38 +00:00
Dão Gottwald
37548a28a9 Bug 1582797 - OverflowableToolbar should respond to resize events immediately. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D46624
2019-09-25 12:09:32 +00:00
Dão Gottwald
9dc4d11da2 Bug 1583148 - Stop subtracting border widths from clientWidth since it doesn't include borders in the first place. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D46926
2019-09-24 11:36:58 +00:00
Dão Gottwald
5460be55c4 Bug 1580538 - Make OverflowableToolbar work without overflow:hidden. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D46297
2019-09-20 13:11:23 +00:00
Gijs Kruitbosch
7e9992d99f Bug 1571236 - add logging to overflow toolbar code, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D45655
2019-09-12 17:44:53 +00:00
Gijs Kruitbosch
715b313f40 Bug 1573485 - put developer tools button back on the right/end of the toolbar in devedition, r=pbro,jaws
Differential Revision: https://phabricator.services.mozilla.com/D43599
2019-08-27 14:35:52 +00:00
Tim Nguyen
2bf8fa3909 Bug 1567420 - Fix interactive element check in CustomizableUI.jsm. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D38728
2019-07-19 20:15:33 +00:00
Victor Porof
8eb72fd3fc Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042
2019-07-05 09:53:32 +02:00
Boris Zbarsky
95de682140 Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike
Differential Revision: https://phabricator.services.mozilla.com/D34196
2019-06-11 15:51:51 +00:00
shindli
63af86e5ca Backed out changeset 92835da18445 (bug 1552565) for causing perma bc failures in browser/components/extensions/test/browser/browser_ext_browserAction_popup_preload.js CLOSED TREE 2019-05-24 23:17:33 +03:00
Greg Tatum
b36b7c80cb Bug 1552565 - Fix event listener for CustomizableUI when destroying widgets; r=Gijs
The CustomizableUI does not delete the _addedEventListeners property from
the view node when the widget is destroyed. This stops the widget from
correctly having events dispatched to it after recreating it, as the
initialization code assumes that it has already been set up.

Differential Revision: https://phabricator.services.mozilla.com/D31677
2019-05-24 15:31:39 +00:00
Andrew Swan
1ab513d145 Bug 1519577 Convert toolbarbutton to a custom element r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D31941
2019-05-20 10:01:02 -07:00
Gijs Kruitbosch
7f6584f7e4 Bug 1543129 - fix buttons disappearing in customize mode after using 'restore defaults', r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D28719
2019-04-29 13:36:04 +00:00
Kris Maglione
23a416950b Bug 1525762: Part 1b - Add databaseReady promise to replace xpi-database-loaded observer. r=aswan
All of the consumers of this observer really want it to behave like a promise.
And, for the cases where the DB may or may not already be loaded when those
callers run, getting the logic correct is difficult.

This patch replaces the observer with a promise, and also delays the
resolution of that promise until any built-in add-ons registered during
XPIProvider startup have finished installing. This latter feature is currently
unused, but will be necessary after subsequent patches for code that relies
querying the default theme immediately after provider startup.
2019-03-22 09:26:33 -07:00
Kris Maglione
1edbf94c37 Bug 1525511: Part 2d - Stop using LightweightThemeManager for in CustomizableUI. r=aswan
Differential Revision: https://phabricator.services.mozilla.com/D18785
2019-02-05 17:23:29 -08:00
Gijs Kruitbosch
d1471c88c9 Bug 1462911 - allow for new overflown items to be the first item in the overflow list, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D24944
2019-03-26 19:14:27 +00:00
Ian Moody
cac3a5f1e2 Bug 1536653 - browser/ automated ESLint no-throw-literal fixes. r=Gijs
Result of running:
$ mach eslint -funix browser/ | sed -Ee 's/:.+//' - | xargs sed -E \
    -e 's/throw ((["`])[^"]+\2);/throw new Error(\1);/g' \
    -e 's/throw ((["`])[^"]+\2 \+ [^ ";]+);/throw new Error(\1);/g' \
    -e 's/throw \(/throw new Error(/g' -i

Differential Revision: https://phabricator.services.mozilla.com/D24110
2019-03-20 10:17:42 +00:00
Vijay Budhram
ea307c8d64 Bug 1524665 - Add FxA avatar toolbar menu, r=gijs,eoger
Differential Revision: https://phabricator.services.mozilla.com//D20433
2019-02-23 17:56:19 +00:00
James Teh
09deb0f3de Bug 1515543: Support keyboard activation (space/enter) of toolbar overflow buttons when focused. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D21614
2019-03-04 06:48:43 +00:00
Myk Melez
5ecc2c1225 Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D17526
2019-01-30 17:26:25 +00:00
Cosmin Sabou
bf63534551 Merge mozilla-inbound to mozilla-central. a=merge 2019-01-29 12:01:56 +02:00
Shane Caraveo
49f496bdbc Bug 1511636: update incognito support to use pref and permissions r=rpl,aswan,kmag
This changes the policy to use the pref and permissions rather than a boolean flag.  Using permissions gets us proper settings on startup without introducing any new overhead.  Going this way flips our tests around so rather than testing an override to turn off private browsing support, we test overrides to enable private browsing support.

Differential Revision: https://phabricator.services.mozilla.com/D14482
2019-01-28 18:10:47 +00:00