Commit Graph

9575 Commits

Author SHA1 Message Date
alwu
6227830912 Bug 1676502 - part1 : move remaining sound indicator browser tests to 'browser/base/content/test/tabMediaIndicator/'. r=bryce
Differential Revision: https://phabricator.services.mozilla.com/D96629
2020-11-13 00:30:18 +00:00
Emma Malysz
8af1afb2ca Bug 1665461: reflect the correct colors for default themes in the skeleton UI. r=dthayer
This patch supports a skeleton UI for default, light, and dark themes.
It is not enabled for apenglow or any custom themes.

This also takes into account the system theme. If the user has the default
theme selected and is in dark mode, we override the theme and present the
dark theme skeleton UI.

Differential Revision: https://phabricator.services.mozilla.com/D96230
2020-11-12 23:56:44 +00:00
Cosmin Sabou
c02cd339df Backed out 3 changesets (bug 1674091) for bookmarks.jsm bc related failures.
Backed out changeset b37a366b6bca (bug 1674091)
Backed out changeset 4d49ba20a908 (bug 1674091)
Backed out changeset c2ed373e6fc3 (bug 1674091)
2020-11-13 02:37:56 +02:00
Jared Wein
09cc1da1b4 Bug 1674091 - Show and hide the empty bookmarks message if there are visible children in the toolbar. r=Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D96763
2020-11-12 21:23:52 +00:00
Mark Banner
514271239d Bug 1676692 - Move contentSearchUI and related files to browser/components/search. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D96743
2020-11-12 17:50:24 +00:00
Bogdan Tara
79696f1362 Backed out changeset 9c13c984601a (bug 1665461) for browser_preXULSkeletonUIRegistry.js failures CLOSED TREE 2020-11-12 20:49:21 +02:00
Emma Malysz
fc6f299c8f Bug 1665461: reflect the correct colors for default themes in the skeleton UI. r=dthayer
This patch supports a skeleton UI for default, light, and dark themes.
It is not enabled for apenglow or any custom themes.

This also takes into account the system theme. If the user has the default
theme selected and is in dark mode, we override the theme and present the
dark theme skeleton UI.

Differential Revision: https://phabricator.services.mozilla.com/D96230
2020-11-12 16:05:47 +00:00
Sebastian Hengst
3c8139f4fb Bug 1676634 - drop aboutGlean.ftl from list of unused files (on non-Nightly branches). r=chutten DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D96706
2020-11-12 15:49:51 +00:00
Dan Minor
e19ee18311 Bug 1673054 - Migrate uses of intl.uidirection to intl.l10n.pseudo; r=Gijs,zbraniecki
This also removes pref overrides from methods like LocaleService::IsLocaleRTL or
IntlService.getLocaleInfo, because it doesn't really make sense to override the
result of checking an arbitrary locale, the relevant use case is overriding the
result for the current app locale.

Removal of the intl.uidirection pref completely will be done in a separate bug.

Differential Revision: https://phabricator.services.mozilla.com/D96235
2020-11-09 15:33:39 +00:00
Micah Tigley
34d40ae4c8 Bug 1676414 - Fix permafail for bookmarks shortcut. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D96596
2020-11-10 17:31:00 +00:00
Emma Malysz
37d1b22ebb Bug 1670957, add placeholder rectangles for toolbarbuttons and display in skeleton UI r=dthayer,smaug,Gijs
If a searchbar is present, draw that similar to a urlbar.
This also changes how we store the urlbar, as we know will use our custom struct
to cleanly store the width and height.

Differential Revision: https://phabricator.services.mozilla.com/D95029
2020-11-10 16:48:10 +00:00
Gijs Kruitbosch
e5ae17c163 Bug 1652520 - do not overwrite extensions for all filetypes, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D96406
2020-11-10 13:59:39 +00:00
Bogdan Tara
e6037df26e Backed out changeset 58d4317c9427 (bug 1652520) for nsExternalHelperAppService bustages CLOSED TREE 2020-11-10 14:41:18 +02:00
Gijs Kruitbosch
c4814d43a9 Bug 1652520 - do not overwrite extensions for all filetypes, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D96406
2020-11-10 12:07:30 +00:00
Tim Huang
19d665923e Bug 1675420 - Cache the content principal before change the remoteness in BrowserReloadWithFlags() r=johannh
This patch makes the BrowserReloadWithFlags() to cache the content
principal before the remoteness changes. And use this cached principal
as the triggering principal for reloading.

We need to do this because the content principal in a browser will be
cleared during changing the remoteness. The browser will be destoried
and then constructed, and the content principal will be cleared. So, we
need to cache the content principal before in order to use the correct
principal.

Differential Revision: https://phabricator.services.mozilla.com/D96408
2020-11-10 11:50:40 +00:00
Jared Wein
721fa81844 Bug 1674199 - Remove the special case of showing the bookmarks toolbar on about:blank if NTP is disabled. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D95196
2020-11-10 04:18:47 +00:00
Gijs Kruitbosch
7d836dc825 Bug 1674945 - fix conditions in browser_aboutNewTab_bookmarksToolbarNewWindow.js to not throw exceptions when gNavToolbox is null, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D96473
2020-11-09 22:27:56 +00:00
Micah Tigley
28fa8f73ae Bug 1675549 - Stop using the 2h2020 pref to block new shortcut for the bookmarks toolbar. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D96471
2020-11-09 21:43:17 +00:00
Nihanth Subramanya
d760214a4b Bug 1643191 - Add a test for the 3rdPartyStorage permissions. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D95655
2020-11-09 00:19:25 +00:00
Doug Thayer
ba137a5e2e Bug 1674221 - Prefix Skeleton UI reg names with exe path r=agashlin
Differential Revision: https://phabricator.services.mozilla.com/D95541
2020-11-06 19:35:20 +00:00
Neil Deakin
efd22cee32 Bug 1649843, remove now unused legacy actor code, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D95206
2020-11-06 15:46:11 +00:00
Jared Wein
328aa2d63d Bug 1674160 - Don't show the bookmarks toolbar if there are no visible toolbarbuttons or toolbaritems. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D95539
2020-11-05 23:00:55 +00:00
Emilio Cobos Alvarez
6ed590a4f8 Bug 1675323 - Apply scrollbar-width to the content select scrollbox. r=mconley
(Instead of applying it directly to the menulist).

Since it's not inherited, we need to get the right value over to the scrollbox.
For that, export it from the arrowscrollbox, with the same name as the places
menupopup uses for the same purpose.

Differential Revision: https://phabricator.services.mozilla.com/D95887
2020-11-05 21:11:54 +00:00
Narcis Beleuzu
479647874f Backed out 2 changesets (bug 1674160, bug 1003364) for bc failures on browser_bookmarks_toolbar_context_menu_view_options.js
Backed out changeset b4ffebacc1b8 (bug 1674160)
Backed out changeset bfe8bc960f45 (bug 1003364)
2020-11-05 22:55:59 +02:00
Narcis Beleuzu
a9e39379f2 Backed out 2 changesets (bug 1674221) for SM bustages on PreXULSkeletonUI.cpp
Backed out changeset 3d9b951db0f4 (bug 1674221)
Backed out changeset 5092fde1ebe1 (bug 1674221)
2020-11-05 22:54:10 +02:00
Doug Thayer
246a65c737 Bug 1674221 - Prefix Skeleton UI reg names with exe path r=agashlin
Differential Revision: https://phabricator.services.mozilla.com/D95541
2020-11-05 20:18:16 +00:00
Jared Wein
29eb64dd87 Bug 1674160 - Don't show the bookmarks toolbar if there are no visible toolbarbuttons or toolbaritems. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D95539
2020-11-05 19:10:29 +00:00
alwu
82092c519b Bug 1674891 - change 'test_webaudioNotification.html' to browser test and move it to the dedicated folder. r=padenot
What `test_webaudioNotification.html` tests has been mostly covered already in `testWebAudioAudibilityWouldAffectTheAppearenceOfTabSoundIndicator`, the only thing we didn't test is `AudioContext.close()`.

Differential Revision: https://phabricator.services.mozilla.com/D95657
2020-11-04 16:53:31 +00:00
alwu
c1013c085d Bug 1674889 - change 'test_noWebAudioNotification.html' to browser test and move it to the dedicated folder. r=padenot
Differential Revision: https://phabricator.services.mozilla.com/D95656
2020-11-04 16:53:29 +00:00
alwu
fa7495d4d8 Bug 1674885 - change 'test_audioNotificationSilent_webAudio.html' to browser test and move it to the dedicated folder. r=padenot
Differential Revision: https://phabricator.services.mozilla.com/D95621
2020-11-04 16:13:07 +00:00
alwu
49702bdeeb Bug 1674881 - add browser test case to check tab navigation for web audio and remove its corresponding plain mochitests. r=padenot
Differential Revision: https://phabricator.services.mozilla.com/D95589
2020-11-04 16:12:49 +00:00
Jared Wein
e21dfc685f Bug 1672792 - Indicate shortcuts key to Alt > View > Toolbars > Bookmarks Toolbar menu. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D95805
2020-11-04 16:23:55 +00:00
Emilio Cobos Álvarez
719e59b40f Bug 1674135 - Don't destroy frames from hideDialog() as we rely on printing hidden frames. r=Gijs,preferences-reviewers
Using `visibility` preserves frames of the content inside the dialog,
which we rely on to print the preview `<browser>` element.

This was working before bug 1662336 mostly by chance, because we were
doing an extra clone and that happened to mostly not rely on the cloned
document being rendered.

I'd rather fix it in the front-end (by not trying to print a
`display: none` <browser>) than going back to do a separate clone,
because that can get expensive (specially with fission).

It's not super-clear to me how to best test the "print from system
dialog" case, but ideas certainly welcome.

Differential Revision: https://phabricator.services.mozilla.com/D95501
2020-11-04 11:03:48 +00:00
Kartikaya Gupta
5d15aad8f8 Bug 1673071 - Update some test expectations for macOS+WR configuration. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D95427
2020-11-04 03:14:38 +00:00
Razvan Maries
beb7584870 Backed out 7 changesets (bug 1658084, bug 1671983) for perma failures on browser_async_remove_tab.js and browser_e10s_chrome_process.js. CLOSED TREE
Backed out changeset 2e6309c1cdbd (bug 1658084)
Backed out changeset 99aafd9304ef (bug 1671983)
Backed out changeset 80280b85280a (bug 1671983)
Backed out changeset 008db2659002 (bug 1671983)
Backed out changeset 32bd45c7fe3a (bug 1671983)
Backed out changeset 56e227e6580c (bug 1671983)
Backed out changeset a404f809f79d (bug 1671983)
2020-11-04 04:23:47 +02:00
Nika Layzell
f6849f1603 Bug 1671983 - Part 4: Stop awaiting BrowserTestUtils.loadURI, r=annyG,remote-protocol-reviewers,extension-reviewers,preferences-reviewers,whimboo,zombie
This method only is async in order to allow callers to wait for a process switch
triggered by the call to `loadURI` to be finished before resolving. With
DocumentChannel, we should never trigger a process switch eagerly like this
again, so we don't need any of the async behaviour here anymore.

This part is largely mechanical changes to tests, removing the `await` calls on
`loadURI`, and a follow-up part will remove the actual async logic from
`BrowserTestUtils.loadURI`.

Differential Revision: https://phabricator.services.mozilla.com/D94641
2020-11-04 00:55:36 +00:00
Nika Layzell
2bff26479d Bug 1671983 - Part 3: E10SUtils.jsm isn't loaded in content anymore, r=annyG
Previously this component was loaded in content due to shouldLoadURI requiring
it, but it is no longer required for that, so can be removed from content
processes.

Differential Revision: https://phabricator.services.mozilla.com/D94640
2020-11-04 00:55:25 +00:00
Razvan Maries
dde7490fbf Backed out changeset b5330b68ce05 (bug 1674135) for perma failures on browser_siteData2.js and browser_pdf_printer_settings.js. CLOSED TREE 2020-11-04 02:43:34 +02:00
Emilio Cobos Álvarez
e473e3b272 Bug 1674135 - Don't destroy frames from hideDialog() as we rely on printing hidden frames. r=Gijs,preferences-reviewers
Using `visibility` preserves frames of the content inside the dialog,
which we rely on to print the preview `<browser>` element.

This was working before bug 1662336 mostly by chance, because we were
doing an extra clone and that happened to mostly not rely on the cloned
document being rendered.

I'd rather fix it in the front-end (by not trying to print a
`display: none` <browser>) than going back to do a separate clone,
because that can get expensive (specially with fission).

It's not super-clear to me how to best test the "print from system
dialog" case, but ideas certainly welcome.

Differential Revision: https://phabricator.services.mozilla.com/D95501
2020-11-03 23:36:32 +00:00
Emilio Cobos Alvarez
6eb1ea3bbe Bug 1394491 - Don't override menucaption background for content selects. r=mconley
So that they use the select background color by default. The code in
SelectParent expects this when figuring out whether to set background colors
too. This matches other browsers and MacOS, see:

  data:text/html,<select style="background: red"><optgroup label="foo"><option>Bar</option><option>Baz</option></optgroup></select>

Differential Revision: https://phabricator.services.mozilla.com/D95690
2020-11-03 17:56:23 +00:00
Razvan Maries
51a072bc8b Backed out 4 changesets (bug 1673071) for perma failures on grid-minimum-contribution-baseline-shim-vertical-lr.html. CLOSED TREE
Backed out changeset a8ad01797ee0 (bug 1673071)
Backed out changeset f2ed8ed80bf2 (bug 1673071)
Backed out changeset 34d6c0fbfeef (bug 1673071)
Backed out changeset d6857ecf3c81 (bug 1673071)
2020-11-04 00:56:16 +02:00
Kartikaya Gupta
7e91b651e8 Bug 1673071 - Update some test expectations for macOS+WR configuration. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D95427
2020-11-03 14:59:31 +00:00
alwu
7bf78de98a Bug 1674857 - part2 : add test case for volume 0 and remove corresponding plain mochitests. r=bryce
Differential Revision: https://phabricator.services.mozilla.com/D95583
2020-11-03 20:29:16 +00:00
alwu
1c6cf69fa1 Bug 1674857 - part1 : change 'test_noAudioNotificationOnMutedElement.html' to browser test and move it to the dedicated folder. r=bryce
Add a test case to cover the testing in `test_noAudioNotificationOnMutedElement.html`.

In addition, in order to shorten the running time of the test, we can wait for `timeupdate` to ensure the media has been already playing for a while before checking sound indicator status, not necessary to wait media reaching to the end.

Differential Revision: https://phabricator.services.mozilla.com/D95582
2020-11-03 20:29:08 +00:00
Dorel Luca
a273b913d8 Backed out changeset 3cc7771c487c (bug 1674135) for Browser-chrome failures in preferences/tests/siteData/browser_siteData.js. CLOSED TREE 2020-11-03 19:37:30 +02:00
Emilio Cobos Álvarez
67981a28a6 Bug 1674135 - Don't destroy frames from hideDialog() as we rely on printing hidden frames. r=Gijs,preferences-reviewers
Using `visibility` preserves frames of the content inside the dialog,
which we rely on to print the preview `<browser>` element.

This was working before bug 1662336 mostly by chance, because we were
doing an extra clone and that happened to mostly not rely on the cloned
document being rendered.

I'd rather fix it in the front-end (by not trying to print a
`display: none` <browser>) than going back to do a separate clone,
because that can get expensive (specially with fission).

It's not super-clear to me how to best test the "print from system
dialog" case, but ideas certainly welcome.

Differential Revision: https://phabricator.services.mozilla.com/D95501
2020-11-03 16:35:34 +00:00
Jared Wein
1e52359ed2 Bug 1673363 - Check the URIs to load in new windows when determining to show the bookmarks toolbar. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D95111
2020-11-02 21:55:12 +00:00
Gijs Kruitbosch
9e5e20600c Bug 1673490 - do not update bookmarks toolbar visibility for same-document navigations, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D95426
2020-11-02 15:45:19 +00:00
Tim Giles
0da5ad9ed1 Bug 1668965 - Remove mention of Lockwise mobile apps from about:logins. r=sfoster,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D93260
2020-11-02 17:09:56 +00:00
Micah Tigley
d4a4ad3d82 Bug 1664053 - Update test for dragging tabs to bookmarks toolbar. r=jaws
Depends on D94404

Differential Revision: https://phabricator.services.mozilla.com/D95209
2020-10-30 16:32:34 +00:00