gavin@gavinsharp.com
0e7705fbc2
Bug 343958: fix strict warnings in controller.js, patch by Regis Caspar <regis.caspar+bz@gmail.com>, r=annie
2006-07-10 22:48:48 +00:00
sspitzer@mozilla.org
fb3d3df0d6
fix for bug #340966 , regression, "node QI Failed When middle clicking a bookmark"
...
also address another scenario of bug #333734 , "Protect against opening too many tabs at once"
r=ben
2006-06-15 22:58:34 +00:00
sspitzer@mozilla.org
d9ac39ac46
supplimental checkin for bug #333734 , protect (warn) against opening too many tabs at once. ugh.
2006-06-09 08:04:10 +00:00
sspitzer@mozilla.org
adc09813b2
follow-up checkin for #333734 , fix coding style per ben.
2006-06-09 07:58:20 +00:00
sspitzer@mozilla.org
75cafa7bd2
fix for bug #333734 . protect (warn) against opening too many tabs at once.
...
r=ben, UI and strings r=beltzner
2006-06-09 07:53:12 +00:00
myk@mozilla.org
90319e8e33
Initial support for microsummaries via a service and integration into the bookmarks UI.
...
bug=334471
r=brettw
a=ben for the branch
2006-05-05 22:45:37 +00:00
beng@bengoodger.com
abc0a6ad91
329367 -cannot return to bookmarks after a search r=annie.sullivan@gmail.com and 334401 - assorted places organizer fixes including new debug panel r=brettw@gmail.com
2006-04-19 03:34:26 +00:00
joe@retrovirus.com
86537d8dcf
Removes the history item mode for the (Bookmark) Properties dialog, which
...
just showed disabled title and URI fields. The "Properties" context menu
item is now disabled for URI nodes which are not bookmarked.
bug=330876
r/sr=ben@mozilla.org
2006-04-18 01:49:10 +00:00
beng@bengoodger.com
48e735a443
332495 - grouping by site is not preserved when searching + various other search/sort fixes. r=annie.sullivan@gmail.com, brettw@gmail.com (history pieces)
2006-04-13 22:49:02 +00:00
joe@retrovirus.com
0309b67e0d
Resubmitting this patch, which adds a editing for livemark URIs as well
...
as fixing a few small livemark bugs, now that I've fixed a couple reference
leaks in nsLivemarkService (see bugs 333764 and 333784).
NOTE: I expect this to cause an increase in allocations on branch balsa,
since it causes nsLivemarkService to be instantiated to set up the menus.
(nsLivemarkService previously wasn't used in the balsa bloat test)
bug=330063
r=annie.sullivan@gmail.com
sr=ben@mozilla.org
2006-04-13 17:19:18 +00:00
brettw@gmail.com
5ecb856b5b
Bug 332144 r=brettw sr=beng (checkin for pamg) Subscriptions context menu should have "reload all livemarks"
2006-04-13 16:40:06 +00:00
gavin@gavinsharp.com
d2aac97f1d
Bug 332888: JS warning: variable folderId hides argument, r=ben
2006-04-12 18:23:32 +00:00
beng@bengoodger.com
b2ef5c0b5f
329733 - problems with drag & drop to bookmarks menus. ensure that we properly close up bookmarks menus after they have been opened. r=annie.sullivan@gmail.com
2006-04-10 19:26:01 +00:00
joe@retrovirus.com
17192e1480
Backing out patch from bug 330063 to see if it's responsible for the
...
branch balsa allocation increases, and if so, fix before resubmitting.
2006-04-08 17:58:16 +00:00
joe@retrovirus.com
47865495d6
* Added ability to edit Live Bookmark feed & site URIs in Bookmark Properties dialog
...
* Fixed a setFeedURI bug in the LivemarkService
* Fixed problems that broke the toolbar when a live bookmark had no site URI
* Converted some browser UI code to use LivemarkService methods rather than manipulating the annotations directly
bug=330063
r=annie.sullivan@gmail.com
sr=ben@mozilla.org
2006-04-06 23:25:36 +00:00
joe@retrovirus.com
ad5c7985c9
Implements "Bookmark All Tabs..." for Places. (Also fixes a small error
...
when undoing aggregate transactions.)
bug=330929
r=annie.sullivan@gmail.com
sr=ben@mozilla.org
2006-04-04 01:25:06 +00:00
darin@meer.net
1cf5f1bc5e
fixes bug 329634 "No apparent way to Reload Live Bookmark (or update livemarks)" patch by pamg, r=annie, sr=beng
2006-04-04 00:32:33 +00:00
beng@bengoodger.com
08c0fea00a
331755 - Use Bookmark option for setting home page is broken. add a new home page selection dialog that uses places. r=annie.sullivan@gmail.com
2006-04-04 00:13:58 +00:00
roc+@cs.cmu.edu
6831bb6020
Bug 331522. By default, do not allow keyword searches when navigating to URLs; modify browser UI code to enable keyword searches only on selected URL input mechanisms (e.g., typed into the URL bar). r+sr=darin,r=mconnor
2006-04-03 23:17:51 +00:00
beng@bengoodger.com
b44ae199cc
331905 - pasted folders/items are inserted at the wrong level in the bookmarks hierarchy. r=annie.sullivan@gmail.com
2006-03-31 22:42:21 +00:00
joe@retrovirus.com
444f9b2f4a
Convert all the DB-modifying operations in the Bookmark Properties to use
...
transactions so that they can be undone. (The "change URI" is the only one
that's not transactionized yet, because it needs deeper work, cf. bug 331655)
bug=326321
r=annie.sullivan@gmail.com
sr=ben@mozilla.org
2006-03-31 00:34:03 +00:00
beng@bengoodger.com
b029228604
328191, cannot delete history entries + a few other fixes r=annie.sullivan@gmail.com
2006-03-28 19:59:26 +00:00
beng@bengoodger.com
f11b3889f9
323812 - fix bogus copy-paste behavior and assorted other issues (insertion bugs, command updating) r=annie.sullivan@gmail.com
2006-03-28 00:53:50 +00:00
beng@bengoodger.com
2c33614c1e
324958 - folder undo delete back to previous folder id. Implement folder removal transaction in bookmarks service itself, using private methods to restore folders back to previous ids. Adjust fe to use new api. r=brettw (C++), annie.sullivan (JS)
2006-03-25 00:46:09 +00:00
annie.sullivan@gmail.com
8847fc4aec
Bug 329743: fixes dropmarker icon not showing up on places toolbar folders on mac.
...
Patch by Pam Greene <pamg.bugs@gmail.com >
r=annie.sullivan@gmail.com sr=ben@mozilla.org
2006-03-23 16:30:27 +00:00
joe@retrovirus.com
7f648bbd0f
* Moved changeBookmarkURI functionality from controller.js into
...
nsINavBookmarksService
* Added annotation and favicon handling to changeBookmarkURI
* Added brettw's copyAnnotations patch to nsIAnnotationService
* Added a GetAnnotationService() to the annotation service for faster
intra-component access
* Added a getBookmarkFoldersTArray() to nsINavBookmarksService for easier
intra-component memory management; updated getBookmarkFolders() to use it
* Added stub for tagRoot to nsINavBookmarksService; DO NOT USE until 329961
has been resolved
* Quick fix for Add Bookmarks breakage caused by 329546
bug=330192
r=brettw@gmail.com
sr=bryner@bryanryner.com
2006-03-23 06:24:54 +00:00
beng@bengoodger.com
a7a60eefa5
329269, more command handling cleanup for places views. make sure the right commands are enabled for items in the readonly area of the places list, and generally. make sure reload commands are enabled appropriately. also, some spit and polish for the organizer window r=annie.sullivan@gmail.com
2006-03-23 00:53:54 +00:00
joe@retrovirus.com
7b2a2d0d09
This submission is a roll-up of three patches developed & approved during
...
the branch freeze:
330052 add bookmark dialog should have a default folder selected
329792 remove dead code for old tag-style folder selector in bookmark properties
330023 allow for editing of folder names
r=annie.sullivan@gmail.com
sr=ben@mozilla.org
2006-03-22 03:36:41 +00:00
beng@bengoodger.com
11144b6eeb
329269 various improvements to view initialization r=annie.sullivan@gmail.com 330736 - bug in query serialization r=brettw@gmail.com
2006-03-17 02:01:06 +00:00
annie.sullivan@gmail.com
25d09daf6e
Fixes several bugs with open in tabs: makes menus set selection in command events in case DOMMenuItemActive doesn't get sent, only shows Open in Tabs menuitem if there are two or more items in the menu, and respects browser.tabs.loadFolderAndReplace and browser.tabs.loadBookmarksInBackground prefs. Also moves #include of debug.js to browser.js as this was causing JavaScript errors on the mac. r=ben@mozilla.org sr=darin@meer.net bug=330130
2006-03-15 19:59:09 +00:00
joe@retrovirus.com
b1ecd5619d
Moved Ben's JavaScript ASSERT function to be NS_ASSERT in
...
toolkit/content/debug.js
debug.js is now included by globalOverlay.js, but if that's not in your
scope you can just #include debug.js directly.
NS_ASSERT() shows a dialog box containing a stack trace when it's called
with a condition that isn't true. The dialog box will be suppressed in
final builds, but in nightlies and alphas, it's useful for encouraging
bug submissions. To disable the dialogs, set XUL_ASSERT_PROMPT=0 in
your environment.
bug=327349
r=darin@meer.net , gavin.sharp@gmail.com
2006-03-14 01:56:09 +00:00
beng@bengoodger.com
ba999eacf0
329269 - more work on places organizer. menus, accessible sorting and grouping options, etc. still a work in progress. r=annie.sullivan@gmail.com
2006-03-10 23:48:40 +00:00
joe@retrovirus.com
28e71dd1d2
Changes to bookmark properties dialog:
...
* Customized bookmark properties dialog for add vs. edit cases
* Added support for changing URI of bookmark (annotations not carried over yet)
* Add support for viewing properties of history entries
* Changed from tag-style control to folder tree for folder selection,
yielding layout and accessibility improvements
* Switched to using standard dialog buttons
bug=329272
r=annie.sullivan@gmail.com
sr=bugs@bengoodger.com
2006-03-10 17:36:41 +00:00
beng@bengoodger.com
de13bd15cc
329956 - add bookmark button on toolbar no longer works. r=joe@retrovirus.com
2006-03-09 22:02:21 +00:00
beng@bengoodger.com
268b6e977b
329586 - browser shim cleanup, tidies up some UI update notification in the browser, fixes a few menu items here and there, removes unnecessary initialization, moves places to its own window, removes all code to do with maintaining places as a tab, renames osme objects and member variables, formatting issues, creates a browser controller for updating commands. r=annie.sullivan@gmail.com
2006-03-09 02:08:45 +00:00
annie.sullivan@gmail.com
29243bdeb2
Fixes JavaScript warnings about trailing commas and redefined variables. bug=329171 r=ben@mozilla.org
2006-03-07 23:20:08 +00:00
beng@bengoodger.com
75afec6589
329587 - controllers registered after places controller cannot execute any commands due to places controller consuming all. r=fritz@google.com
2006-03-07 18:24:28 +00:00
joe@retrovirus.com
8f7b3936ca
* Allows the user to access Bookmark Properties dialog from context menus.
...
* Adds support for editing the bookmark shortcut (formerly keyword) in the Bookmark Properties dialog.
* Improves the appearance of the Bookmark Properties dialog.
* Removes dead code from PlacesBrowserShim in browser.js
NOTE: This doesn't reflect the final UI for this functionality; rather,
this change is intended to add functionality for users of the nightlies.
bug=322988
r=annie.sullivan@gmail.com
sr=bugs@bengoodger.com
2006-03-07 00:52:35 +00:00
annie.sullivan@gmail.com
edc2180ac1
Adds menuitem for Open In Tabs.
...
Reorganizes code so that command/click handlers for toolbar/menu bindings can be attached by overlays.
r=ben@mozilla.org bug=327034
2006-03-04 01:12:05 +00:00
annie.sullivan@gmail.com
edc0a47409
Fixes problems with bookmark menus and toolbarbuttons not working correctly on mac. bug=327036 r=ben@mozilla.org
2006-02-23 18:30:40 +00:00
annie.sullivan@gmail.com
5030e95c4e
Checking in patch by mossop@blueprintit.co.uk to allow middle click to open links in tabs. bug=325781 sr=beng
2006-02-17 22:58:13 +00:00
annie.sullivan@gmail.com
cc3aec4e24
Fixed drag and drop support for toolbars and menus. Added lots more visual feedback when dragging and dropping.
...
bug=318052 r=beng
2006-02-17 18:31:06 +00:00
beng@bengoodger.com
35ac93355f
326598 - tree D&D massively broken. r=annie.sullivan@gmail.com. checked in on the branch earlier, checking in now to the trunk.
2006-02-14 21:36:04 +00:00
beng@bengoodger.com
ebfbe24fa8
324948 - should not be able to do edit operations on immutable containers (delete, paste, cut). Make sure we check if a container has readonly children, or the folder itself (if it is a bookmark folder) is readonly before enabling commands for cut, copy and paste. Also assert that activeView is non-null, for safety. r=annie.sullivan@gmail.com
2006-02-09 21:32:24 +00:00
beng@bengoodger.com
7c823c9c0e
320655 - changing the history view displayed should also update the sorting r=annie.sullivan@gmail.com
2006-02-09 19:29:10 +00:00
beng@bengoodger.com
e5d391b859
326346 - javascript error when selecting text on a page. r=annie.sullivan@gmail.com
2006-02-08 01:52:41 +00:00
bryner@brianryner.com
dc2b6bdc33
Add support for bookmark separators (bug 320261). r=brettw, ben.
2006-02-08 01:10:57 +00:00
brettw@gmail.com
07495f4424
Bug 325161 r=annie.sullivan Make all nsINavHistoryResultNodes support URI attribute, remove nsINavHistoryURIResultNode.
2006-02-07 01:56:36 +00:00
annie.sullivan@gmail.com
27b6cde5bd
bug=325169 r=brettw@gmail.com keywords=fixed1.8.1 Fix Livemark icons
2006-02-01 02:13:34 +00:00
beng@bengoodger.com
f05c577626
317633 - undo/redo for Places. Make sure the various transactions work better - e.g. folder undo should save a list of its child nodes for restoration. Also ensure that bookmark edits done in the places tab aren't undone when another tab is selected and Ctrl+Z hit by implementing a transaction manager in the browser window that filters out places-tab transactions if the places tab isn't selected. Make the goDo*Command utility functions in globalOverlay.js consult the window looking for applicable controllers, not just the focused element. r=sullivan. Also 320085 - search menu keybindings for places: allow find bar to be turned off using a state variable, which prevents the opening of the strip but fires an event which other applications like places can listen to: 'find-activated'.
2006-01-31 18:00:06 +00:00
