Commit Graph

613 Commits

Author SHA1 Message Date
Stephen Thompson
78282be03c Bug 1938430 - add delete tab group event r=jswinarton,tabbrowser-reviewers,sessionstore-reviewers
Record when users delete an open group from the tab group context menu or delete an open group from a context menu in the all-tabs menu.

This will not record when users close a window or close all of the individual tabs in a tab group, even though those cases have the logical side effect of deleting a tab group.

Differential Revision: https://phabricator.services.mozilla.com/D241884
2025-03-25 21:16:37 +00:00
Dão Gottwald
8b40ef8567 Bug 1956252 - Don't let #moveTabNextTo move unpinned tabs between pinned ones. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D242935
2025-03-25 15:45:37 +00:00
Cosmin Sabou
782522ac2f Backed out changeset bfb6d89e6bb9 (bug 1953801) for causing bc failures on browser_restore_container_tabs_oa. CLOSED TREE 2025-03-25 19:36:35 +02:00
Dão Gottwald
270b9d5781 Bug 1955276 - Consolidate moveTabTo checks. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D242338
2025-03-25 14:16:54 +00:00
Dão Gottwald
f9a2272451 Bug 1955361 - Make dropping a link insert the new tab at the correct drop index. r=jswinarton,dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D242632
2025-03-25 14:05:34 +00:00
Jeremy Swinarton
39b35f9816 Bug 1953801: Update SessionStore cache immediately after creating a tab group. r=sthompson,sessionstore-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D241634
2025-03-25 13:39:45 +00:00
Rolf Rando
eb92578b06 Bug 1954867 - fixed some accuracy issues in progress bar r=tarek,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D242066
2025-03-24 19:23:59 +00:00
DJ
4467bf52f4 Bug 1955388 - prevent pinned tabs from commingling with non-pinned tabs when there are hidden tabs present. r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D242596
2025-03-24 18:22:30 +00:00
Dão Gottwald
e588889083 Bug 1954341 - Disable tabdrop-samewindow transition for dragged tab groups. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D242642
2025-03-24 15:51:54 +00:00
Dão Gottwald
9150b253ca Bug 1955112 - Finish tab moving animation when a drag session wasn't ended properly. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D242631
2025-03-24 15:00:26 +00:00
Rolf Rando
6457c1eed4 Bug 1954648 - Smart Tab Group settings in Preferences->Tabs r=ngrato,fluent-reviewers,settings-reviewers,tabbrowser-reviewers,dwalker,flod
Differential Revision: https://phabricator.services.mozilla.com/D241922
2025-03-23 04:03:31 +00:00
Dão Gottwald
e05dcb5003 Bug 1955391 - Make elementIndex throw on tabs that aren't visible. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D242544
2025-03-21 20:27:57 +00:00
Chris Shiohama
a51c127c17 Bug 1953971 - Calls to BrowserTestUtils.addTab in the Tabbed Browser component do not need to be awaited. r=scunnane
Differential Revision: https://phabricator.services.mozilla.com/D241843
2025-03-21 17:00:11 +00:00
Nick Grato
a637f54059 Bug 1951524 - Opt-in UI with Progress bar for Smart Tab groups r=rrando,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson,dwalker,hjones
adding the optin flow and progress bar

Differential Revision: https://phabricator.services.mozilla.com/D241864
2025-03-21 16:03:03 +00:00
Francesco Lodolo (:flod)
2dc7e3ee3a Bug 1955573 - Don't generate Fluent IDs at run-time for Tab Group colors, r=tabbrowser-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D242520
2025-03-21 15:33:38 +00:00
Florian Quèze
41442e60fd Bug 1950710 - Migrate histograms to use Glean APIs for FX_TAB_CLOSE_*, r=chutten,tabbrowser-reviewers,nsharpley.
Differential Revision: https://phabricator.services.mozilla.com/D242169
2025-03-21 15:32:40 +00:00
Florian Quèze
1c4eb07f93 Bug 1950710 - Migrate histograms to use Glean APIs for FX_TAB_SWITCH_*, r=chutten,tabbrowser-reviewers,mconley.
Differential Revision: https://phabricator.services.mozilla.com/D242167
2025-03-21 15:32:40 +00:00
shaneziegler
37f81a03af Bug 1954799 - Move new tab, new window, home button drag/drop handlers out of browser.js into ToolbarDropHandler.sys.mjs r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D242203
2025-03-21 14:37:32 +00:00
Dão Gottwald
ddb726f7e6 Bug 1955621 - Make the tabGroups.enabled Nimbus feature variable use setPref instead of fallbackPref. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D242546
2025-03-21 14:16:57 +00:00
Dão Gottwald
5b7b89286d Bug 1954865 - Fix closing the last unpinned tab via mouse. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D242292
2025-03-21 12:46:03 +00:00
Butkovits Atila
a1232f30d3 Backed out changeset e2836c2d1f98 (bug 1951524) for causing failures at browser_all_files_referenced.js. 2025-03-21 08:37:42 +02:00
Nick Grato
2a66d14721 Bug 1951524 - Opt-in UI with Progress bar for Smart Tab groups r=rrando,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson,dwalker,hjones
adding the optin flow and progress bar

Differential Revision: https://phabricator.services.mozilla.com/D241864
2025-03-21 03:23:11 +00:00
Stanca Serban
7df2c7072f Backed out 5 changesets (bug 1950710) for causing timeout related failures. CLOSED TREE
Backed out changeset 7a1f8fe65c63 (bug 1950710)
Backed out changeset d2514bee519f (bug 1950710)
Backed out changeset c5f6cd03c1d4 (bug 1950710)
Backed out changeset 9e57a5c12317 (bug 1950710)
Backed out changeset 482b8c741722 (bug 1950710)
2025-03-21 06:29:53 +02:00
Stanca Serban
dfcc675d76 Backed out changeset c0e6b3896ea0 (bug 1954865) for causing mochitests failures in browser_standalonePinnedTab.js. 2025-03-21 06:18:11 +02:00
Florian Quèze
4ec5f45bdb Bug 1950710 - Migrate histograms to use Glean APIs for FX_TAB_CLOSE_*, r=chutten,tabbrowser-reviewers,nsharpley.
Differential Revision: https://phabricator.services.mozilla.com/D242169
2025-03-20 20:14:04 +00:00
Florian Quèze
3a92537eb9 Bug 1950710 - Migrate histograms to use Glean APIs for FX_TAB_SWITCH_*, r=chutten,tabbrowser-reviewers,mconley.
Differential Revision: https://phabricator.services.mozilla.com/D242167
2025-03-20 20:14:03 +00:00
Dão Gottwald
ba53c891e3 Bug 1954865 - Fix closing the last unpinned tab via mouse. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D242292
2025-03-20 17:46:50 +00:00
Gijs Kruitbosch
fcab2ecd6a Bug 1953575 - move gShareUtils to its own module, r=firefox-desktop-core-reviewers ,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D241485
2025-03-20 15:54:31 +00:00
Vasish Baungally
9df0f82fe9 Bug 1955127 - Augment smart tab title suggestions with group name if present. r=rrando,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D242230
2025-03-20 14:33:01 +00:00
Dão Gottwald
dbbbda7272 Bug 1954275 - Expand group when dragging a link over collapsed group label. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D241724
2025-03-20 03:27:20 +00:00
Dão Gottwald
eea154de49 Bug 1954909 - Add Nikki to Tabbed Browser triage rotation. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D242111
2025-03-19 21:02:49 +00:00
Sandor Molnar
53925bf70d Backed out changeset 272d0dd8b6a7 (bug 1954648) for causing bc failures @ browser_experimental_features.js 2025-03-19 23:36:30 +02:00
Rolf Rando
07417b054d Bug 1954648 - Smart Tab Group settings in Preferences->Tabs r=ngrato,fluent-reviewers,settings-reviewers,tabbrowser-reviewers,dwalker,flod
Differential Revision: https://phabricator.services.mozilla.com/D241922
2025-03-19 17:14:19 +00:00
Dão Gottwald
3ba48b6655 Bug 1950904 - Use element index instead of tab index for the drop indicator. r=dwalker,jswinarton,tabbrowser-reviewers,perftest-reviewers,fbilt
Differential Revision: https://phabricator.services.mozilla.com/D239937
2025-03-19 15:07:53 +00:00
Dão Gottwald
6613f880d6 Bug 1954163 - Properly enter and exit moving tab mode when holding or releasing Ctrl key. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D241704
2025-03-19 13:48:53 +00:00
Jeremy Swinarton
4bec852b57 Bug 1954500: Fix tab group telemetry to be in line with spec r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D241830
2025-03-18 20:48:15 +00:00
Rolf Rando
ce4fa16558 Bug 1954541 - Remove word duplicates supports singular/plural r=vazish,tabbrowser-reviewers,dwalker
Differential Revision: https://phabricator.services.mozilla.com/D241847
2025-03-18 18:45:16 +00:00
Stephen Thompson
8b2bd5ebfd Bug 1953533 - do not re-render tabs list more than once per frame r=dao,sessionstore-reviewers,tabbrowser-reviewers
The tab overflow menu's tabs list started listening for tab groups' events in order to refresh the tabs list and keep it in sync with the state of the tab strip. However, for operations that affect large tab groups all at once (restoring a closed tab group, closing a tab group), the tab group fires one event per tab all at once. This causes the tabs list to re-render itself once per tab, which is a lot of work for large tab groups.

This patch prevents re-rendering more than once per frame.

Differential Revision: https://phabricator.services.mozilla.com/D241380
2025-03-18 02:41:59 +00:00
Greg Stoll
52693f9877 Bug 1926973 - make only explicitly unloaded tabs have a grayscale dimmed favicon r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers
This is what UX has decided makes sense, and will be much less disruptive
than dimming out all favicons on session restore. When we're ready the
default value of "browser.tabs.fadeOutExplicitlyUnloadedTabs" will be
true, and the default value of "browser.tabs.fadeOutUnloadedTabs" will
remain false.

Differential Revision: https://phabricator.services.mozilla.com/D241481
2025-03-15 00:30:28 +00:00
DJ
fb605dda4c Bug 1950611 - fix save and restore of groups when they trigger window closing. r=sthompson,jswinarton,sessionstore-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D241490
2025-03-14 14:18:20 +00:00
Dão Gottwald
7e0d08a5e4 Bug 1951308 - Don't show a close button for pinned tabs in the tab manager. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D241461
2025-03-13 19:51:59 +00:00
Rolf Rando
5c04f67d7d Bug 1951525 - Implement best-effort global progress bar for all Smart Tab Grouping model files r=tabbrowser-reviewers,vazish,dwalker
Differential Revision: https://phabricator.services.mozilla.com/D241135
2025-03-13 18:04:32 +00:00
Vasish Baungally
ed268fb313 Bug 1952940 - Prevent Smart Tab Grouping suggestions from including New Tab page. r=rrando,dwalker,tabbrowser-reviewers
Exclude about:home and about:newtab from Smart Tab Grouping suggestions.

Differential Revision: https://phabricator.services.mozilla.com/D240898
2025-03-13 15:06:10 +00:00
Dão Gottwald
e3e43e49ef Bug 1953214 - When dragging multiple tabs, update multiselection to reflect that pinned and unpinned tabs cannot be mixed. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D241203
2025-03-13 01:45:39 +00:00
Rolf Rando
4d8a5b817c Bug 1952417 - Don't output Smart Tab Group topic for invalid topics r=vazish,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D240922
2025-03-12 20:15:58 +00:00
Jeremy Swinarton
c828d955e5 Bug 1938397: Record active tab group metrics r=dao,tabbrowser-reviewers,sthompson
Differential Revision: https://phabricator.services.mozilla.com/D240196
2025-03-12 17:46:15 +00:00
Vasish Baungally
b8ae67ceda Bug 1952381 - Add ability to test different model revisions in Inference Engine r=tarek,firefox-ai-ml-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D240953
2025-03-12 16:05:14 +00:00
Dão Gottwald
9417710fa1 Bug 1953193 - Don't change the selected tab when collapsing a group while dragging it. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D241057
2025-03-12 13:14:29 +00:00
Dão Gottwald
de2f1dd066 Bug 1952495 - Only collapse the dragged group instead of all groups. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D241006
2025-03-12 13:14:28 +00:00
Dão Gottwald
9754a011cf Bug 1908441 - Implement drag and drop of tab group into a new or other window. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D241004
2025-03-12 11:29:36 +00:00