corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
902,045 Commits 1 Branch 0 Tags
0e492d56a9cf2837b1e316bb0fb3d4fea94e6515
Commit Graph

212 Commits

Author SHA1 Message Date
Jared Hirsch
a78e75d919 Bug 1933264 - Copy data preferences between profiles in a group. r=profiles-reviewers,fluent-reviewers,settings-reviewers,mossop,bolsson 
Also add an explanatory note to preferences.

Differential Revision: https://phabricator.services.mozilla.com/D241902
 2025-03-20 17:17:57 +00:00
Gijs Kruitbosch
afe72e45e7 Bug 1953531 - update crash reporter and technical plus interaction data links, r=settings-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D241245
 2025-03-18 13:04:10 +00:00
Drew Willcoxon
cf70175727 Bug 1949297 - Update the Firefox Suggest settings UI. r=settings-reviewers,reusable-components-reviewers,urlbar-reviewers,fluent-reviewers,bolsson,daisuke,mstriemer 
This makes the following primary changes to the Suggest settings in the search
pane:

* Remove the infobox
* Remove the learn-more link from the dismissed-suggestions description
* Add a learn-more link to the Address Bar section's description but show it
  only when Suggest is enabled
* Add `#w_what-setting-is-opt-in` fragment to the learn-more URL for the online
  toggle so it links directly to the appropriate section

It also makes these related changes:

Remove the unnecessary `vbox` containers for the toggle switches. I had to
modify some reusable-components CSS. Note that there are two copies of the
Suggest toggle, one in the search pane and one in the privacy pane.

Rename the sponsored and nonsponsored checkbox strings so they're consistent
with the other checkbox strings: `addressbar-locbar-foo-option`

Remove test tasks that click checkboxes and make sure the appropriate prefs are
updated and vice versa. Now that the infobox is gone, there's no need for
Suggest-specific tests to worry about that.

Similarly, remove test tasks that click the learn-more links and make sure the
right page is opened. No need for Suggest-specific tests to do that either.

Differential Revision: https://phabricator.services.mozilla.com/D238847
 2025-02-26 15:49:16 +00:00
Valentin Gosu
2b6ee476f3 Bug 1900013 - Remove DoH fallback warning prefs from privacy settings UI r=settings-reviewers,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D237692
 2025-02-12 14:30:27 +00:00
Nick Alexander
cd50fbecdd Bug 1944650 - Update "data collection and use" header in "Privacy & Security" section of about:preferences. r=fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D236023
 2025-01-30 00:02:49 +00:00
Simon Friedberger
e968ab8747 Bug 1934587: Clear up HTTPS-Only UI for HTTPS-First, r=maltejur,fluent-reviewers,settings-reviewers,bolsson,hjones,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D234074
 2025-01-28 15:10:11 +00:00
Nick Alexander
5257fc4269 Bug 1942166 - Add descriptions with trailing detail links in Security & Privacy preferences. r=settings-reviewers,fluent-reviewers,Gijs,flod 
Differential Revision: https://phabricator.services.mozilla.com/D234593
 2025-01-21 17:20:52 +00:00
Gijs Kruitbosch
50f4376ab8 Bug 1921218 - Part 1: Add settings checkbox for usage/DAU ping in Firefox Desktop. r=fluent-reviewers,settings-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D226354
 2025-01-15 23:13:24 +00:00
Hanna Jones
031bfa2b70 Bug 1917305 - Part 4: Update search and suggest toggles in settings r=urlbar-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D226722
 2024-12-12 18:27:15 +00:00
Butkovits Atila
cd16376f28 Backed out 6 changesets (bug 1917305) for causing failure at browser_parsable_css.js. CLOSED TREE 
Backed out changeset a11742cbdf6c (bug 1917305)
Backed out changeset f148cb47b84f (bug 1917305)
Backed out changeset 8c3b26eb05e7 (bug 1917305)
Backed out changeset 0b20c8187edc (bug 1917305)
Backed out changeset d0749e2b61fc (bug 1917305)
Backed out changeset f538e9697cb3 (bug 1917305)
 2024-12-11 19:37:27 +02:00
Hanna Jones
3c7e21815c Bug 1917305 - Part 4: Update search and suggest toggles in settings r=urlbar-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D226722
 2024-12-11 15:52:53 +00:00
Sandor Molnar
ab8c870dbe Backed out 6 changesets (bug 1917305) for causing bc failures @ browser_parsable_css.js CLOSED TREE 
Backed out changeset 54eeb575b705 (bug 1917305)
Backed out changeset ea78740bd5b1 (bug 1917305)
Backed out changeset a1fe92460a5d (bug 1917305)
Backed out changeset 5b6f08a5fd6c (bug 1917305)
Backed out changeset 488458777db0 (bug 1917305)
Backed out changeset ab9d3dcb9ac7 (bug 1917305)
 2024-12-11 01:49:50 +02:00
Hanna Jones
27bfbfc367 Bug 1917305 - Part 4: Update search and suggest toggles in settings r=urlbar-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D226722
 2024-12-10 21:01:05 +00:00
Benjamin VanderSloot
2fb04528e4 Bug 1932741 - Remove legacy DNT UI when GPC "functionality.enabled" preference is false - r=anti-tracking-reviewers,settings-reviewers,mossop,timhuang 
Instead, hide the whole thing! Long live GPC!

Differential Revision: https://phabricator.services.mozilla.com/D231148
 2024-12-06 13:25:26 +00:00
Benjamin VanderSloot
9a76de256c Bug 1928087 - Remove DNT control from about:preferences#privacy - r=pbz,fluent-reviewers,settings-reviewers,flod,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D227343
 2024-11-25 13:16:45 +00:00
Tom Ritter
4b3b40595d Bug 1666160: Direct users in the warning box to the new RFP-specific support page r=settings-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D227727
 2024-11-12 17:33:30 +00:00
Chris Peterson
28a46ac3dc Bug 1920421 - Fix Settings links to open in a new tab. r=Gijs 
1. Fix these Settings links to open in a new tab like Settings' other "Learn more" links:

* The "Learn more" link for "Suggest Firefox Relay email masks to protect your email address"

* The Privacy Notice link for "Firefox Data Collection and Use"

* The "Learn more" link for "Allow Firefox to send technical and interaction data to Mozilla"

* The "View Firefox Studies" (about:studies) link for "Allow Firefox to install and run studies"

2. Also remove a redundant `target="_blank"` in searchResults.inc.xhtml because the link's `is="moz-support-link"` attribute will cause the link to open in a new tab.

Differential Revision: https://phabricator.services.mozilla.com/D223080
 2024-09-25 03:33:31 +00:00
Gijs Kruitbosch
0f506dab3a Bug 1916813 - visibly disable the studies checkbox if telemetry upload is disabled to reflect reality, r=mossop,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D221328
 2024-09-18 12:18:43 +00:00
Norisz Fay
77d6f50252 Backed out changeset c35f4e167d98 (bug 1916813) for causing bc failures on browser_about_preferences.js 2024-09-11 19:04:46 +03:00
Gijs Kruitbosch
4d3210fc70 Bug 1916813 - visibly disable the studies checkbox if telemetry upload is disabled to reflect reality, r=mossop,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D221328
 2024-09-11 13:53:25 +00:00
Mathew Hodson
3897b0e480 Bug 1830673 - Use support-page attribute for telemetry article link r=settings-reviewers,mconley 
This prevents two tabs from being opened.

Differential Revision: https://phabricator.services.mozilla.com/D218268
 2024-08-01 21:37:44 +00:00
Mathew Hodson
c973289aa3 Bug 1792887 - Correct alignment of telemetry learn more link r=settings-reviewers,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D218269
 2024-08-01 21:33:42 +00:00
Malte Juergens
7d71bae2f3 Bug 1907517 - Update strings in HTTPS-Only settings to make users aware of HTTPS-First r=freddyb,fluent-reviewers,settings-reviewers,mossop 
In light of us being in the process of enabling HTTPS-First by default, these strings have been proposed by content design to make it more clear to the user that if they disable HTTPS-Only, upgrades may still be happening.

The description generally has been updated, but the labels for the radio buttons only get the new strings in this patch when HTTPS-First is also enabled.

Differential Revision: https://phabricator.services.mozilla.com/D216381
 2024-07-19 12:34:09 +00:00
Emilio Cobos Álvarez
4758aafdc8 Bug 1907709 - Add a search header for website advertising section. r=settings-reviewers,Gijs 
A bit weird that this doesn't work more automatically but...

Differential Revision: https://phabricator.services.mozilla.com/D216680
 2024-07-17 18:21:44 +00:00
Emilio Cobos Álvarez
9e7668fdbe Bug 1901194 - Remove useless tail-with-learn-more class on <span>s. r=settings-reviewers 
It doesn't do anything on a span so it's just confusing.

Differential Revision: https://phabricator.services.mozilla.com/D212902
 2024-06-07 12:11:23 +00:00
Francesco Lodolo (:flod)
f4c285d3a4 Bug 1901191 - Tweak use of moz-support-link in privacy-preserving setting, r=emilio,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D212900
 2024-06-07 10:35:02 +00:00
Emilio Cobos Álvarez
07889c29e7 Bug 1901068 - Setting for privacy-preserving attribution. r=mt,settings-reviewers,fluent-reviewers,mconley,bgrins 
Differential Revision: https://phabricator.services.mozilla.com/D211656
 2024-06-06 17:22:07 +00:00
Sidharth Sachdev
98e0d52b70 Bug 1403081 - Optionally protect filling of saved logins with OS authentication (including biometrics). r=sgalich,settings-reviewers,fluent-reviewers,flod 
Depends on D207219

Differential Revision: https://phabricator.services.mozilla.com/D201276
 2024-05-07 04:21:31 +00:00
Cristina Horotan
65bc72d8e5 Backed out 7 changesets (bug 1802809, bug 1890883, bug 1877720, bug 1403081, bug 1877717) for causing bc failures at browser_primaryPassword.js CLOSED TREE 
Backed out changeset 7bdafce80724 (bug 1877717)
Backed out changeset 4969f17f935c (bug 1877717)
Backed out changeset d700fbbd7541 (bug 1877717)
Backed out changeset 98e31d4cd373 (bug 1802809)
Backed out changeset c1e8c6c34fcc (bug 1877720)
Backed out changeset 0d8d5e77a93c (bug 1403081)
Backed out changeset 594b7bbecd22 (bug 1890883)
 2024-05-06 20:59:20 +03:00
Sidharth Sachdev
0176b1dcff Bug 1403081 - Optionally protect filling of saved logins with OS authentication (including biometrics). r=sgalich,settings-reviewers,fluent-reviewers,flod 
Depends on D207219

Differential Revision: https://phabricator.services.mozilla.com/D201276
 2024-05-06 15:58:23 +00:00
Stanca Serban
fdfaad305b Backed out 7 changesets (bug 1802809, bug 1877717, bug 1403081, bug 1890883, bug 1877720) for causing localization checks failures in aboutLogins.ftl. CLOSED TREE 
Backed out changeset 62eeb65b23bd (bug 1877717)
Backed out changeset 4fde845a1182 (bug 1877717)
Backed out changeset d3124d383693 (bug 1877717)
Backed out changeset 344ac200b360 (bug 1802809)
Backed out changeset 754a1bf3b55e (bug 1877720)
Backed out changeset 961a1121017e (bug 1403081)
Backed out changeset 19b2252a4ccf (bug 1890883)
 2024-05-06 18:27:03 +03:00
Sidharth Sachdev
6fd74c4252 Bug 1403081 - Optionally protect filling of saved logins with OS authentication (including biometrics). r=sgalich,settings-reviewers,fluent-reviewers,flod 
Depends on D207219

Differential Revision: https://phabricator.services.mozilla.com/D201276
 2024-05-06 14:54:16 +00:00
Cosmin Sabou
2873243069 Backed out 6 changesets (bug 1877717, bug 1802809, bug 1890883, bug 1877720, bug 1403081) for causing failures on browser_creditCard_doorhanger_action. 
Backed out changeset 8ee572259ac8 (bug 1877717)
Backed out changeset dad0f115e953 (bug 1877717)
Backed out changeset d792b9335db3 (bug 1802809)
Backed out changeset 7610115f0011 (bug 1877720)
Backed out changeset 9c53bcd6a763 (bug 1403081)
Backed out changeset aa4981999347 (bug 1890883)
 2024-05-05 20:37:16 +03:00
Sidharth Sachdev
8716cffc2b Bug 1403081 - Optionally protect filling of saved logins with OS authentication (including biometrics). r=sgalich,settings-reviewers,fluent-reviewers,flod 
Depends on D207219

Differential Revision: https://phabricator.services.mozilla.com/D201276
 2024-05-05 15:59:35 +00:00
Stanca Serban
ba7ef6bf02 Backed out 6 changesets (bug 1802809, bug 1890883, bug 1877717, bug 1403081, bug 1877720) multiple mochitests failures. CLOSED TREE 
Backed out changeset 8b238dd69206 (bug 1877717)
Backed out changeset c6e16bf303ed (bug 1877717)
Backed out changeset e4d8856edf45 (bug 1802809)
Backed out changeset 9a6a418a1e45 (bug 1877720)
Backed out changeset b587dcaf8f9f (bug 1403081)
Backed out changeset 17febe56cad6 (bug 1890883)
 2024-05-03 22:01:28 +03:00
Sidharth Sachdev
2ca5d5e1dd Bug 1403081 - Optionally protect filling of saved logins with OS authentication (including biometrics). r=sgalich,settings-reviewers,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D201276
 2024-05-03 17:23:48 +00:00
Gijs Kruitbosch
d9adc27a64 Bug 1884370 - drop confusing label from DoH settings, r=mossop,settings-reviewers,desktop-theme-reviewers,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D205345
 2024-04-02 16:07:55 +00:00
Tim Giles
4b1c3b2da6 Bug 1864606 - Fix missing label association for crash reports checkbox r=fluent-reviewers,Gijs,bolsson 
Thanks to mhowell for the STRIP_ANCHOR function in the Fluent migration.

We were using the "for" attribute on a XUL label which does not behave
like an HTML label. This prevented the programmatic association
between the checkbox and the label. By utilizing moz-label, we maintain
the accesskey behavior of the previous XUL label.

Additionally we use moz-support-link to remove the
"collection-backlogged-crash-reports-link" Fluent string.

Differential Revision: https://phabricator.services.mozilla.com/D204557
 2024-03-15 00:10:38 +00:00
Gijs Kruitbosch
b8e31c3dbe Bug 1869734 - update explainer text around deleting data and private browsing, r=pbz,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D200171
 2024-01-31 20:50:46 +00:00
Jules Simplicio
48386fea6c Bug 1872909 - Commit to deemphasized descriptive text pattern in preferences that has already been introduced under Search settings in order to improve information architecture r=settings-reviewers,desktop-theme-reviewers,dao,Gijs 
This patch makes us commit to the deemphasized color descriptive pattern throughout settings.

I also made some changes where some settings were using description and should most likely be using a label instead and vice versa.

Quick note that if the descriptive text is tied to an input such as a checkbox or toggle, as opposed to a section heading, we opt for the `.text-deemphasized` class/treatment where not only do we use the `--text-color-deemphasized` color but also shrink the font size. You'll see I opted for such treatment in the Experiments page checkbox list.

Differential Revision: https://phabricator.services.mozilla.com/D197615
 2024-01-26 04:09:59 +00:00
Stanca Serban
6bc6e24ee2 Backed out changeset 337d90568478 (bug 1872909) for causing mochitests failures in browser_experimental_features.js. CLOSED TREE 2024-01-25 04:17:13 +02:00
Jules Simplicio
10c04f95d5 Bug 1872909 - Commit to deemphasized descriptive text pattern in preferences that has already been introduced under Search settings in order to improve information architecture r=settings-reviewers,desktop-theme-reviewers,dao,Gijs 
This patch makes us commit to the deemphasized color descriptive pattern throughout settings.

I also made some changes where some settings were using description and should most likely be using a label instead and vice versa.

Quick note that if the descriptive text is tied to an input such as a checkbox or toggle, as opposed to a section heading, we opt for the `.text-deemphasized` class/treatment where not only do we use the `--text-color-deemphasized` color but also shrink the font size. You'll see I opted for such treatment in the Experiments page checkbox list.

Differential Revision: https://phabricator.services.mozilla.com/D197615
 2024-01-25 01:13:43 +00:00
Karandeep
f11961815d Bug 1852048 - Move address bar to search preferences. r=dao,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D194895
 2024-01-04 09:11:22 +00:00
John Schanck
b75accc3dc Bug 1853747 - add a link to Windows settings for passkey management. r=keeler,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,dao,bolsson,flod 
Differential Revision: https://phabricator.services.mozilla.com/D195613
 2023-12-12 20:34:39 +00:00
jneuberger
f9dc8c7ae5 Bug 1867017 - P1. Update about:preferences strings of passwords section r=credential-management-reviewers,fluent-reviewers,settings-reviewers,joschmidt,bolsson,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D195280
 2023-12-12 16:02:07 +00:00
jneuberger
5946f0e354 Bug 1867020 - Update about:preferences strings for exceptions modal r=credential-management-reviewers,fluent-reviewers,settings-reviewers,joschmidt,bolsson,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D195279
 2023-12-12 16:02:06 +00:00
Sandor Molnar
5e9ca11c9d Backed out 5 changesets (bug 1867017, bug 1867019, bug 1867018, bug 1867020) for causing bc failures at browser/components/preferences/tests/browser_search_subdialogs_within_preferences_5.js CLOSED TREE 
Backed out changeset 0c4bc9a698ba (bug 1867017)
Backed out changeset ea95d41995f0 (bug 1867017)
Backed out changeset 56289937eb65 (bug 1867020)
Backed out changeset 022c1f63a6fe (bug 1867019)
Backed out changeset fa5b89f2d1b6 (bug 1867018)
 2023-12-12 05:54:37 +02:00
Cristian Tuns
2f6520726f Backed out changeset 7351cc3d5b11 (bug 1853747) for causing failures in createcredential-abort.https.html CLOSED TREE 2023-12-11 18:17:22 -05:00
jneuberger
a3d542118c Bug 1867017 - P1. Update about:preferences strings of passwords section r=credential-management-reviewers,fluent-reviewers,settings-reviewers,joschmidt,bolsson,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D195280
 2023-12-11 21:54:34 +00:00
jneuberger
777f61f0ec Bug 1867020 - Update about:preferences strings for exceptions modal r=credential-management-reviewers,fluent-reviewers,settings-reviewers,joschmidt,bolsson,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D195279
 2023-12-11 21:54:34 +00:00