corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
982,672 Commits 1 Branch 0 Tags
0dcefccb1a088b03932873d2fb79bb519351eb0f
Commit Graph

492 Commits

Author SHA1 Message Date
Jason Prickett
2d728f9022 Bug 1974076 - Remove the finish setup message and setup checklist auto-open message a=pascalc 
Differential Revision: https://phabricator.services.mozilla.com/D255347
 2025-07-02 12:11:54 +00:00
Meg Viar
39f4cca70c Bug 1965258 - Clear active infobar when user closes the window the infobar is displayed in before interacting with it a=dmeehan DONTBUILD 
Original Revision: https://phabricator.services.mozilla.com/D250465

Differential Revision: https://phabricator.services.mozilla.com/D252856
 2025-06-06 19:46:54 +00:00
Jason Prickett
490630c460 Bug 1962493 - Land onboarding setup checklist messages for EN a=dmeehan DONTBUILD 
Original Revision: https://phabricator.services.mozilla.com/D248458

Differential Revision: https://phabricator.services.mozilla.com/D252876
 2025-06-06 18:54:07 +00:00
negin
e157e3e2ed Bug 1968335 - Add ability to configure infobar buttons to not dismiss the infobar on click a=dmeehan 
Original Revision: https://phabricator.services.mozilla.com/D251068

Differential Revision: https://phabricator.services.mozilla.com/D251187
 2025-05-27 18:48:35 +00:00
Mark Banner
4529a8e15d Bug 1881701 - Change new .eslintrc.mjs files to modules (browser/), and export as flat config. r=frontend-codestyle-reviewers,extension-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,places-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,urlbar-reviewers,aminomancer,daisuke,dimi,robwu,jteow,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D249949
 2025-05-24 17:11:02 +00:00
Mark Banner
d7c7c5369b Bug 1881701 - Rename many ESLint files to use .mjs. r=frontend-codestyle-reviewers,perftest-reviewers,Gijs,sparky,webcompat-reviewers,twisniewski 
This is separate to help preserve history of the files.

Differential Revision: https://phabricator.services.mozilla.com/D249945
 2025-05-24 17:10:51 +00:00
Mark Banner
757ba4f58e Bug 1967249 - Update globals package used in TypeScript, to avoid issues with ESLint. r=zombie,home-newtab-reviewers,omc-reviewers,aminomancer,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D250033
 2025-05-23 22:57:21 +00:00
Beth Rennie
212ee2bff7 Bug 1956080 - Use async experiment cleanup in messaging system browser tests r=omc-reviewers,emcminn 
ExperimentManager.unenroll() is now effectively async when running in a
browser test (because we are now executing SQL queries during
unenrollment) so all cleanup functions that trigger unenrollment are
async as well.

Differential Revision: https://phabricator.services.mozilla.com/D250511
 2025-05-22 21:20:39 +00:00
Rebecca King
5a894ba744 Bug 1964836 - Clean up AboutWelcomeShopping and Shopping messages - r=shopping-reviewers,omc-reviewers,emcminn,fchasen 
Differential Revision: https://phabricator.services.mozilla.com/D248957
 2025-05-22 18:04:34 +00:00
Emily McMinn
00843b127f Bug 1964817 - Update illustrations & anchors for Tab Groups onboarding callouts r=omc-reviewers,jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D249091
 2025-05-21 23:55:44 +00:00
Duncan McIntosh
78bf65ff9b Bug 1868192 - Add packageFamilyName attribute for use with ASRouterTargeting. r=nalexander,nrishel,omc-reviewers,jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D249417
 2025-05-21 21:08:34 +00:00
Dan Mosedale
925a7aee1a Bug 1967339 - Make FxMS expose messages after reach recording failures, r=omc-reviewers,emcminn 
If ASRouter._recordReachEvent throws an error, right now we don't handle it, so we don't send exposure, and we don't route the message either. This patch makes that method catch all errors that occur inside it, much like the Glean record method.

The test we include forces an exception by replacing Glean's reach message with a stub that throws, even though it doesn't seem particularly likely that this is what's happening in the field. What's happening in the field seems to happen on the FxMS messaging IDs that are configured incorrectly AND that have some other as-yet-unknown property. There are a couple of live experiments that have (have had) issues but ONLY AFTER A CERTAIN POINT (maybe related to 138 hitting release).

The fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1965869 has repaired the configuration on the recent misconfigured feature ids, which will likely fix many/most problems. This adds another bandaid, where if there's some issue inside _recordReachEvent, we'll handle that too.

More could be done to bulletproof sendTriggerMessage, where the relevant code all lives (we could consider putting the entire thing inside a try/catch block, and ideally even send telemetry if the catch block gets hit). I'm open to thoughts about that...

Differential Revision: https://phabricator.services.mozilla.com/D250302
 2025-05-21 21:05:36 +00:00
Meg Viar
4d816ed41f Bug 1967713 - Update Remote L10N tests to accomodate new FTL file r=omc-reviewers,mimi 
Differential Revision: https://phabricator.services.mozilla.com/D250444
 2025-05-21 17:31:09 +00:00
Mathieu Leplatre
6995a90947 Bug 1761473 - Get rid of deprecated downloadToDisk() attachments method r=acottner,omc-reviewers,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D234466
 2025-05-21 15:21:21 +00:00
Meg Viar
48389d49cb Bug 1967342 - Add preview update string for existing user TOU infobar r=fluent-reviewers,omc-reviewers,bolsson,pdahiya 
Add preview string for use in TOU infobar

Differential Revision: https://phabricator.services.mozilla.com/D250273
 2025-05-20 20:21:27 +00:00
Beth Rennie
90daa226bc Bug 1907633 - Use ExperimentAPI._rsLoader in browser_trigger_messagesLoaded.js r=omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D250110
 2025-05-20 19:46:50 +00:00
Emily McMinn
c75f64e314 Bug 1963213 - Allow messaging on only one profile in a multiprofile selectable group r=pdahiya,jhirsch,omc-reviewers,profiles-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D247459
 2025-05-20 18:49:49 +00:00
Beth Rennie
f80f934349 Bug 1907633 - Use ExperimentAPI._rsLoader in browser_asrouter_experimentsAPILoader.js r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D249869
 2025-05-19 19:33:56 +00:00
Beth Rennie
4893e22c74 Bug 1907633 - Add ExperimentAPI.optInToExperiment API r=nalexander,nimbus-reviewers,relud,omc-reviewers,aminomancer 
Instead of calling this function on the `RemoteSettingsExperimentLoader`
from `RemoteSettingsExperimentLoader.sys.mjs`, we instead provide the
public API on the `ExperimentAPI`, which will delegate to its current
`RemoteSettingsExperimentLoader`.

Differential Revision: https://phabricator.services.mozilla.com/D248073
 2025-05-19 19:33:52 +00:00
Shane Hughes
a1fcf2855e Bug 1892417 - Make feature callout autofocus configurable and disabled by default. r=omc-reviewers,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D247391
 2025-05-19 18:41:25 +00:00
iulian moraru
83b2199691 Revert "Bug 1907633 - Add ExperimentAPI.optInToExperiment API r=nalexander,nimbus-reviewers,relud,omc-reviewers,aminomancer" for causing bc failures on browser_about_studies.js. 
This reverts commit d50af79d99.
 2025-05-19 18:39:25 +00:00
Beth Rennie
d50af79d99 Bug 1907633 - Add ExperimentAPI.optInToExperiment API r=nalexander,nimbus-reviewers,relud,omc-reviewers,aminomancer 
Instead of calling this function on the `RemoteSettingsExperimentLoader`
from `RemoteSettingsExperimentLoader.sys.mjs`, we instead provide the
public API on the `ExperimentAPI`, which will delegate to its current
`RemoteSettingsExperimentLoader`.

Differential Revision: https://phabricator.services.mozilla.com/D248073
 2025-05-19 17:21:37 +00:00
Cristina Horotan
2da93f3a7e Revert "Bug 1907633 - Use ExperimentAPI._rsLoader in browser_asrouter_experimentsAPILoader.js r=omc-reviewers,aminomancer" for causing ESlint failure at browser_asrouter_experimentsAPILoader.js 
This reverts commit a7c081f8f6.
 2025-05-19 16:41:19 +00:00
Beth Rennie
a7c081f8f6 Bug 1907633 - Use ExperimentAPI._rsLoader in browser_asrouter_experimentsAPILoader.js r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D249869
 2025-05-19 16:00:16 +00:00
Mark Banner
b71032b413 Bug 1966764 - Add a moz-src scheme handler for webpack to allow newtab/asrouter/aboutwelcome tests to work with the new protocol. r=home-newtab-reviewers,omc-reviewers,mconley,pdahiya. 
Differential Revision: https://phabricator.services.mozilla.com/D249737
 2025-05-17 17:38:45 +00:00
Beth Rennie
af2f7883a2 Bug 1950237 - Use ExperimentAPI.manager in browser/components/asrouter r=omc-reviewers,emcminn 
As part of this bug, the global ExperimentManager will no longer be
exported from ExperimentManager.sys.mjs and will only be available as a
property on the ExperimentAPI.

Differential Revision: https://phabricator.services.mozilla.com/D249108
 2025-05-14 06:41:59 +00:00
Meg Viar
ac61100a31 Bug 1964816 - Support Localization in Universal Infobars r=omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D248136
 2025-05-13 14:15:51 +00:00
Beth Rennie
80ea752013 Bug 1959207 - Use GleanPing::TestSubmission in browser/components/asrouter r=omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D247505
 2025-05-12 22:32:26 +00:00
Beth Rennie
25f1aa8bdb Bug 1963183 - Add buildId to ASRouterTargeting and Nimbus targeting context r=omc-reviewers,nimbus-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D246994
 2025-05-06 22:08:17 +00:00
Daniel Thorn
bf9652f4ff Bug 1959483 - Port tests from ExperimentFakes and ExperimentTestUtils to NimbusTestUtils for browser/components/aboutwelcome and browser/components/asrouter r=nimbus-reviewers,omc-reviewers,beth,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D247004
 2025-05-06 03:33:22 +00:00
isaac
34664bd6e0 Bug 1959517 - [themes] Replace all instances of font-weight: 590 with the --font-weight-bold token. r=hjones,desktop-theme-reviewers,omc-reviewers,urlbar-reviewers,mimi,jteow,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D246064
 2025-05-06 00:37:08 +00:00
Meg Viar
d42d78e05a Bug 1964116 - Update infobar schema to reflect that 'text' can be an array r=jprickett,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D247646
 2025-05-05 09:43:25 +00:00
Emily McMinn
b41709a7cc Bug 1961862 - Land animated onboarding callouts for tab groups in tree r=omc-reviewers,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D246480
 2025-05-02 14:39:40 +00:00
Meg Viar
0114e29cfd Bug 1963951 - Change ToS spotlight modal's button string from 'Confirm and continue' to just 'Continue' r=fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D247570
 2025-05-02 12:56:55 +00:00
Beth Rennie
313e2dd2b1 Bug 1961629 - Use ExperimentFeature.getEnrollmentMetadata() in browser/components/asrouter (again) r=omc-reviewers,aminomancer 
Missed a few occurrences.

Differential Revision: https://phabricator.services.mozilla.com/D247473
 2025-05-02 03:21:27 +00:00
Alexandru Marc
aca9e5c747 Revert "Bug 1961629 - Use ExperimentFeature.getEnrollmentMetadata() in browser/components/asrouter (again) r=omc-reviewers,aminomancer" for causing lint failures @ browser_asrouter_experimentsAPILoader.js 
This reverts commit 061b82e9ad.
 2025-05-02 02:47:17 +00:00
Beth Rennie
061b82e9ad Bug 1961629 - Use ExperimentFeature.getEnrollmentMetadata() in browser/components/asrouter (again) r=omc-reviewers,aminomancer 
Missed a few occurrences.

Differential Revision: https://phabricator.services.mozilla.com/D247473
 2025-05-02 02:14:51 +00:00
Tim Giles
134dc6c03a Bug 1936648 - Replace searchfield-cancel with close-12 icon. r=desktop-theme-reviewers,fxview-reviewers,tabbrowser-reviewers,reusable-components-reviewers,omc-reviewers,emilio,aminomancer,hjones 
Replaces the searchfield-cancel icon with the close-12 icon so that we
can style the background-color of the icon as needed.

Since we need close-12.svg to be content accessible, I needed to move
the icon to layout/style/res and add it as a content accessible file.
This resulted in replacing the existing uses of
chrome://global/skin/icons/close-12.svg with the new resource URL,
resource://content-accessible/close-12.svg.

Differential Revision: https://phabricator.services.mozilla.com/D243564
 2025-05-01 15:24:34 +00:00
Meg Viar
9d474d2001 Bug 1959542 - Enable ToS by default in Firefox 138.x mid-cycle dot release (Windows, Mac, Linux) r=hanna_a,omc-reviewers 
- Show ToS modal by default for all new users on official builds
  - Remove code related to the on-train rollout for Mac/Linus/MSIX

Differential Revision: https://phabricator.services.mozilla.com/D247111
 2025-05-01 03:50:23 +00:00
Reem H
29b06e65ba Bug 1949001 - Add OMC for inferred p13n card. r=home-newtab-reviewers,omc-reviewers,nbarrett,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D246376
 2025-04-30 04:31:20 +00:00
smolnar
a2d552f453 Backed out changeset af872f8e8213 (bug 1949001) for causing xpc failures @ test_PanelTestProvider.js CLOSED TREE 2025-04-30 04:54:45 +03:00
Reem H
9421ec89d3 Bug 1949001 - Add OMC for inferred p13n card. r=home-newtab-reviewers,omc-reviewers,nbarrett,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D246376
 2025-04-30 00:48:33 +00:00
smolnar
bd51edbf53 Backed out changeset c62c5b5629ff (bug 1959542) for causing bc failures @ browser_browserGlue_showModal_trigger.js CLOSED TREE 2025-04-30 03:03:43 +03:00
Meg Viar
7888974e9f Bug 1959542 - Enable ToS by default in Firefox 138.x mid-cycle dot release (Windows, Mac, Linux) r=hanna_a,omc-reviewers 
- Show ToS modal by default for all new users on official builds
  - Remove code related to the on-train rollout for Mac/Linus/MSIX

Differential Revision: https://phabricator.services.mozilla.com/D247111
 2025-04-29 18:57:33 +00:00
negin
af4c9168f2 Bug 1935255 - FC Updates split dismiss button HCM styling and buttons using tokens-shared variables r=omc-reviewers,accessibility-frontend-reviewers,emcminn,ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D245474
 2025-04-29 17:51:38 +00:00
Beth Rennie
85992a9d15 Bug 1961629 - Use ExperimentFeature.getEnrollmentMetadata() in browser/components/asrouter r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D246149
 2025-04-29 13:07:23 +00:00
Butkovits Atila
d5769ff5cb Backed out changeset 5591b71c7d59 (bug 1961629) for causing failures at browser_asrouter_toast_notification.js. 2025-04-29 15:45:16 +03:00
Beth Rennie
c8b5015aca Bug 1961629 - Use ExperimentFeature.getEnrollmentMetadata() in browser/components/asrouter r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D246149
 2025-04-29 11:28:57 +00:00
Cristina Horotan
01a3787bf5 Backed out changeset b19f01c4a432 (bug 1959542) for causing bc failures at browser_browserGlue_showModal_trigger.js CLOSED TREE 2025-04-24 17:36:56 +03:00
Meg Viar
37e9896cea Bug 1959542 - Enable ToS by default in Firefox 138.x mid-cycle dot release (Windows, Mac, Linux) r=omc-reviewers,hanna_a 
-     Show ToS modal by default for all new users on official builds
  -     Remove code related to the on-train rollout for Mac/Linus/MSIX

Differential Revision: https://phabricator.services.mozilla.com/D245100
 2025-04-24 11:04:43 +00:00