corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
447,026 Commits 1 Branch 0 Tags
0dc7db800b34a5ade2295f828e2bb33ace633768
Commit Graph

327 Commits

Author SHA1 Message Date
Benjamin Smedberg
0f95227641 Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports: 
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.
 2009-01-12 14:20:59 -05:00
Benjamin Smedberg
7a084ac404 Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal. 2009-01-09 11:35:24 -05:00
Benjamin Smedberg
991a16d8bc Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports: 
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
 2008-11-05 14:25:30 -05:00
Andrew Smith
925ffa073b Implement css3 border-image property. (Bug 378217) r=vlad,dbaron,robarnold 2008-07-16 23:30:25 -07:00
L. David Baron
f51a50d4ed Backed out changeset 9b0b2391485c due to linker errors related to nsStyleStructInlines.h not being included enough. 2008-07-16 22:59:14 -07:00
Andrew Smith
97a13b7ef1 Implement css3 border-image property. (Bug 378217) r=vlad,dbaron,robarnold 2008-07-16 22:18:38 -07:00
368c29ae32 Introduce a setter for nsHTMLReflowState::mComputedHeight so that we're sure to 
update the resize flags properly.  Bug 388084, r+sr+a=dbaron
 2007-08-02 11:08:05 -07:00
98de634631 Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros. 2007-07-08 00:08:04 -07:00
cee90f607b Fix bug 387154 -- rendering of narrow buttons (for which we need to scoot the 
text over to the left) regressed.  r+sr=dbaron
 2007-07-06 17:48:29 -07:00
79eeaa32d0 Cleanup implementations of QueryInterface. b=385750 r+sr=dbaron r+sr=jst 2007-07-03 19:15:31 -07:00
cdb5b22b87 Change the FrameNeedsReflow API to pass the dirty flags to be added directly tothe method, instead of setting them before calling the method. That way we canavoid reflowing the ancestor of a reflow root which is not itself dirty but hasdirty children. This also makes it harder to set dirty bits inconsistentlywith the FrameNeedsReflow call. Bug 378784, r+sr=dbaron, pending rbs' reviewon the mathml parts. 2007-05-06 12:16:51 -07:00
e0f90db412 Rename nsIFrame::GetPresContext to nsIFrame::PresContext. Bug 376042, patch byTaras Glek <tglek@mozilla.com>, rs=roc. 2007-03-30 14:11:41 -07:00
dbaron@dbaron.org
a4cc40910e Clean up IsFrameOfType methods to call their base class IsFrameOfType methods reliably. b=341326 r+sr=roc 2007-02-24 18:33:33 +00:00
bzbarsky@mit.edu
ec0b8c50c7 Remove some no longer needed code. Bug 368273, r+sr=dbaron 2007-01-30 05:52:27 +00:00
cvshook@sicking.cc
e80f1dba4e Kill remainders of ns(XBL|HTML|XUL|Layout)Atoms. r/sr=jst b=368128 2007-01-30 00:06:41 +00:00
bzbarsky@mit.edu
b09985c9eb Make mComputedWidth private, with a getter/setter, and make the setter update 
the resize flags.  Bug 367442, r+sr=dbaron
 2007-01-26 00:05:12 +00:00
dbaron@dbaron.org
8648581bf7 Change the bulk of ascent (baseline) computation to happen on a virtual method on nsIFrame, and remove the redundant descent member from nsHTMLReflowMetrics, primarily to support having both first-line and last-line baselines. b=367332 r+sr=roc 2007-01-23 04:06:56 +00:00
timeless@mozdev.org
f4ef17d178 Bug 355300 There should be only one nsGkAtoms creature 
r=dbaron
 2006-12-26 17:47:52 +00:00
dbaron@dbaron.org
13db671d0b Better API for used padding/border/margin: remove deprecated Calc*For on nsStyleStructs and add GetUsed* to nsIFrame. b=332922 r+sr=roc 2006-12-13 23:04:57 +00:00
dbaron@dbaron.org
d21cb374bd Bug 300030: Move intrinsic width computation out of nsIFrame::Reflow and into its own methods on nsIFrame. Replace reflow reasons, types, and commands with dirty bits/notifications. Thanks to bzbarsky for almost all of the HTML form controls (mozilla/layout/forms) changes, and many others for help testing and patching. For detailed commit logs, see REFLOW_YYYYMMDD_BRANCH, where YYYYMMDD is one of 20061031, 20060830, 20060603, 20060302, 20060119, 20051011, 20050804, 20050429, 20050315, 20050111, and 20041213. 2006-12-08 05:38:33 +00:00
mats.palmgren@bredband.net
7ad743157e Remove the special painting code for a 165-twips checkbox. Move the remaining parts of nsFormControlHelper to its consumers and remove nsFormControlHelper.{cpp,h} from the tree. b=343495 r+sr=roc (r=me on roc's part) 2006-07-06 10:43:51 +00:00
bzbarsky@mit.edu
7a214013bb Give HTMLButtonControlFrames their own frame type. Bug 335419, r+sr=dbaron 2006-04-25 19:56:45 +00:00
roc+@cs.cmu.edu
24f6f0ed12 Bug 328926. Remove aPresContext parameter from nsIFrame::Destroy, nsIFrame::SetInitialChildList and nsIFrame::RemovedAsPrimaryFrame. patch by Marc Liddell, r+sr=roc 2006-04-10 00:16:29 +00:00
roc+@cs.cmu.edu
54d3415318 Bug 330934. Set a nsIFrame's stylecontext in its constructor, to ensure that there's always one available for GetPresContext() to use even if Init hasn't been called. Patch by Marc Liddell, r+sr=roc 2006-03-26 21:30:36 +00:00
pavlov@pavlov.net
93222d8d4f backing out roc's patch for bug 328926 due to crash running tests on vc8 machines. 2006-03-15 06:43:36 +00:00
roc+@cs.cmu.edu
c92e50faf4 Bug 328926. Remove aPresContext parameter from Destroy and SetInitialChildList. patch by Marc Liddell, r+sr=roc 2006-03-15 03:14:02 +00:00
roc+@cs.cmu.edu
79c7894a78 Bug 328926. Remove aPresContext from nsIFrame::Init and nsIFrame::DidSetStyleContext. r+sr=roc, patch by Marc Liddell 2006-03-09 18:55:21 +00:00
roc+@cs.cmu.edu
e0e50ea5ee Bug 326827. Don't allow mouse events to target button contents. r+sr=dbaron 2006-02-19 20:14:11 +00:00
roc+@cs.cmu.edu
a1b6a30f14 Bug 317375. Reorganize frame painting and mouse event targeting around frame display lists. Some review from dbaron, lots of testing help from Martijn, Julien and others 2006-01-26 02:29:17 +00:00
bmlk@gmx.de
5b8ee77062 Avoid reframing inside button frames and move the frame creation entirely into the frame constructor, bug 51767, r=mats sr=roc 2006-01-13 07:58:12 +00:00
cvshook@sicking.cc
aa95e1bf2f Bug 321294: Remove unused ReplaceFrame codepaths. 
r/sr=roc
 2006-01-10 22:58:37 +00:00
roc+@cs.cmu.edu
358bfc2241 Bug 254755. deCOMtaminate nsIFormControlFrame. patch by jpl24, r+sr=roc 2005-12-12 23:53:06 +00:00
bzbarsky@mit.edu
1b622da905 Treat inline and block buttons more uniformly. Bug 304004, r+sr=dbaron 2005-11-22 23:39:48 +00:00
timeless@mozdev.org
71ed8bc863 Bug 106386 Correct misspellings in source code 
patch by mats.palmgren@bredband.net r=dbaron sr=dbaron
 2005-11-20 22:05:24 +00:00
roc+@cs.cmu.edu
96e9963c67 Bug 313817. DeCOMtaminate more NS_New*Frame functions. r+sr=roc, patch by Marc Liddell 2005-11-01 20:40:54 +00:00
cvshook@sicking.cc
77710748bc Bug 311827: Make GetAttr return a bool rather then an nsresult. 
r/sr=bz
 2005-10-28 11:25:24 +00:00
roc+@cs.cmu.edu
7875a54822 Bug 313817. DeCOMtaminate a bunch of NS_New*Frame functions. patch by Marc Liddell, r+sr=roc 2005-10-26 21:46:39 +00:00
roc+@cs.cmu.edu
5d1b988569 Bug 108310. Make GetFrameForPoint take frame-relative coordinates, not bogus relative-to-some-view-or-other, and simplify the signature. r+sr=roc, patch by Eli Friedman. 2005-09-19 02:15:54 +00:00
jst@mozilla.jstenback.com
f54c1fc9b1 Fixing bug 289940. Make chrome event handlers only receive trusted events by default. r=jonas@sicking.cc, sr=peterv@propagandism.org, a=chofmann@mozilla.org 2005-04-28 23:48:28 +00:00
roc+@cs.cmu.edu
4d2971cfd7 Bug 287592. Make buttons return the correct overflow area from reflow. r+sr=dbaron 2005-03-31 02:19:48 +00:00
bzbarsky@mit.edu
9e69ad849c Remove prescontext args for some nsIFrame methods 
(Append/Insert/Remove/ReplaceFrames) and for some methods in table land.  Patch
by Vidar Braut Haarr <bugmail@q1n.org>, r+sr=bzbarsky
 2005-02-07 01:58:25 +00:00
bryner@brianryner.com
c4c10dcf35 Remove nsIHTMLContent interface (bug 276959). r+sr=jst. 2005-01-12 19:45:38 +00:00
mats.palmgren@bredband.net
3525895845 Propagate NS_FRAME_HAS_CHILD_WITH_VIEW to the area frame. b=276236 r=bzbarsky sr=dbaron 2005-01-03 07:27:11 +00:00
neil@parkwaycc.co.uk
ab8be2367d Bug 276100 GetOriginToView has unused PresContext argument p=bugmail@q1n.org r+sr=dbaron 2005-01-01 17:26:29 +00:00
aaronleventhal@moonset.net
c2cc498217 Bug 250269. Outlines not getting painted on buttons, radios, checkboxes, tables and table cells. r+sr=roc 2004-11-11 15:07:22 +00:00
bzbarsky@mit.edu
37964a1cde Make the frame constructor state and save state automatically handle inserting 
out of flows in the right place in the fixed/absolute/float containing blocks
so that it can't be screwed up by callers.  Bug 264914, r+sr=roc
 2004-10-30 21:43:49 +00:00
bmlk@gmx.de
8bed280351 frames with a percentage based width should report a 0 MEW bug 246999 r/sr=roc 2004-08-31 18:50:40 +00:00
bryner@brianryner.com
6cde4639f0 Change nsIPresContext to nsPresContext globally, follow-up to bug 253470. rs=roc 2004-07-31 23:15:21 +00:00
rbs@maths.uq.edu.au
6026676857 Cleanup font usage in form input controls, b=251637, r=jshin, sr=bzbarsky 2004-07-21 01:05:44 +00:00
tor@cs.brown.edu
4b2931240a Bug 240274 - remove unused argument of SetClip{Rect,Region}. 
r=blizzard, sr=bryner
 2004-04-23 15:21:24 +00:00