Commit Graph

62 Commits

Author SHA1 Message Date
Jeremy Swinarton
0d521d1f2b Bug 1908416: gBrowser.visibleTabs handles tab groups r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D218796
2024-08-08 16:23:24 +00:00
Sam Foster
f64b68c78d Bug 1899580 - Exclude collapsed vertical tabs from indicator-replaces-favicon behavior. r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements
- Ensure everything that sets .expanded on sidebar-main uses the toggleExpanded method

Differential Revision: https://phabricator.services.mozilla.com/D217507
2024-08-07 18:51:26 +00:00
Jeremy Swinarton
cd95d6d498 Bug 1908404: Click to expand/collapse tab group r=dao,desktop-theme-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D218434
2024-08-07 14:59:36 +00:00
Anna Yeddi
f351d96411 Bug 1884970 - Close current tab button is missing an accessible name and role. r=tabbrowser-reviewers,fluent-reviewers,dao,bolsson,flod
The [tab-close-button](https://searchfox.org/mozilla-central/rev/f9157a03835653cd3ece8d2dc713a782b7e4374e/browser/base/content/tabbrowser-tab.js#40) is not labeled and is missing an interactive role of button, while it is functioning as one.

Note: we do not want this control to be keyboard focusable, because keyboard-only user could close the tab via the context menu and we don't want to create an additional tab stop for the navigation as well, but making sure the control is marked up as a button with an accessible name would allow it to be actionable with speech-to-text software, with touch devices, with switch controls in scan mode, and for screen readers via their navigation shortcuts as well.

Differential Revision: https://phabricator.services.mozilla.com/D204413
2024-08-06 13:51:06 +00:00
Stefan Richter
551e400b7c Bug 1409262 - Notify when openerTabId changed via tabs.update() r=robwu,dao
Differential Revision: https://phabricator.services.mozilla.com/D164982
2024-08-05 17:49:06 +00:00
Dão Gottwald
5cc15d0779 Bug 1908412 - add API for adding tabs to a group. r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D218204
2024-08-05 09:25:19 +00:00
DJ
89ad94eb74 Bug 1902619 - Hold space for pending screenshots and fade in when ready. r=jswinarton,desktop-theme-reviewers,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D218101
2024-07-31 18:47:41 +00:00
DJ
a96bf7ac85 Bug 1906123 - use a fixed AR for tab preview while preserving scroll position. r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D218085
2024-07-31 18:47:40 +00:00
Sandor Molnar
2e5df25263 Backed out 2 changesets (bug 1906123, bug 1902619) for causing bc failures @ @ browser_thumbnails_bg_basic.js CLOSED TREE
Backed out changeset d64bfab9a514 (bug 1902619)
Backed out changeset 5bbb9dd95c0e (bug 1906123)
2024-07-31 21:29:58 +03:00
DJ
7ae78e601d Bug 1902619 - Hold space for pending screenshots and fade in when ready. r=jswinarton,desktop-theme-reviewers,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D218101
2024-07-31 17:30:23 +00:00
DJ
db52857c68 Bug 1906123 - use a fixed AR for tab preview while preserving scroll position. r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D218085
2024-07-31 17:30:22 +00:00
Dão Gottwald
95d5536b2f Bug 1910576 - tabbrowser.js needs to check tabContainer.verticalMode rather than tabContainer.inVerticalTabsMode. r=tabbrowser-reviewers,dwalker
Borrowed from https://phabricator.services.mozilla.com/D218052

Differential Revision: https://phabricator.services.mozilla.com/D218185
2024-07-31 15:18:09 +00:00
Dão Gottwald
0ca3183451 Bug 1910601 - Remove _verticalTabs property and use verticalMode instead. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D218063
2024-07-31 09:12:40 +00:00
Butkovits Atila
81e0c9fdb0 Backed out changeset a99be1c64226 (bug 1910601) for causing failures at browser_multiselect_tabs_reorder.jS. 2024-07-30 23:29:04 +03:00
Dão Gottwald
ccbd151e5e Bug 1910601 - Remove _verticalTabs property and use verticalMode instead. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D218063
2024-07-30 17:19:04 +00:00
Dão Gottwald
57b3a833e4 Bug 1908162 - Basic Tab Group custom element. r=dwalker,desktop-theme-reviewers,tabbrowser-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D217980
2024-07-30 14:57:41 +00:00
Jeremy Swinarton
416bd4c2b9 Bug 1879103: Update THP on tab change r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D217829
2024-07-30 14:47:24 +00:00
Stuart Colville
a6dc7c69d9 Bug 1880138 - Filter Fx View from AllTabs hidden tabs UI. r=fxview-reviewers,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D217809
2024-07-29 12:13:55 +00:00
Sarah Clements
7ea40f53e4 Bug 1899336 - Position pinned tabs and new tab button for vertical tabs mode r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,kcochrane
* Create a new container to house pinned tabs, new tab button and non-pinned tabs
* Create new pinned tabs container to apply grid layout and overflow scrolling
* Update test coverage for pinned tabs for both horizontal and vertical tabs

Differential Revision: https://phabricator.services.mozilla.com/D215482
2024-07-29 11:30:37 +00:00
Sammy Khamis
994493e803 Bug 1909783: Synced tabs list should de-dupe r=markh,fxview-reviewers,sync-reviewers,tabbrowser-reviewers,firefox-desktop-core-reviewers ,dao
Differential Revision: https://phabricator.services.mozilla.com/D217700
2024-07-26 20:31:03 +00:00
Jeremy Swinarton
088315a50d Bug 1902252: Screenshot size respects devicePixelRatio r=dwalker,desktop-theme-reviewers,tabbrowser-reviewers,cmkm
Differential Revision: https://phabricator.services.mozilla.com/D217459
2024-07-25 15:03:13 +00:00
Jeremy Swinarton
0fef333b99 Bug 1908666: Prevent THP from opening when other panel is animating r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D217168
2024-07-23 18:39:43 +00:00
timw-dev
139987ebda Bug 1804166 - favicon not reseting when changing tab to about:newtab with newtab to Blank Page.r=tgiles,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D216357
2024-07-23 17:07:39 +00:00
Jeremy Swinarton
cd42d69cab Bug 1889880: temporarily cancel tab hover UI delay when leaving tabstrip r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D209167
2024-07-18 17:01:32 +00:00
Jeremy Swinarton
5215ca95dd Bug 1903042: THP popups show immediately after closing other panels r=dwalker,mconley
Differential Revision: https://phabricator.services.mozilla.com/D215809
2024-07-17 19:00:24 +00:00
Jeremy Swinarton
93f2268504 Bug 1899556: Disable THP when app in background r=dwalker,tabbrowser-reviewers,mak
Differential Revision: https://phabricator.services.mozilla.com/D216205
2024-07-12 21:39:42 +00:00
jlvivero
1cc313284f Bug 1882655 cache startup time value by calling it in the initialize function, update remove intermediate variable and fix typo, move getting startuptime to tabs.js r=tabbrowser-reviewers,sfoster,dao
Differential Revision: https://phabricator.services.mozilla.com/D215032
2024-07-10 15:55:06 +00:00
Nikki Sharpley
db8bc399ee Bug 1893656 - Fix vertical tabs drag and drop r=sidebar-reviewers,tabbrowser-reviewers,dao,Gijs
- fix animation of drag and drop
- fix dragging to new window
- add tests for vertical tabs drag and drop

Differential Revision: https://phabricator.services.mozilla.com/D213237
2024-07-09 13:22:55 +00:00
Jeremy Swinarton
5b1962c93d Bug 1900749: THP shows correct URL in reader mode r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D215545
2024-07-03 13:52:34 +00:00
Amy Lee
0be4c4335f Bug 1902430 - Update strings for close duplicate tabs in tab overview menu. r=tabbrowser-reviewers,fluent-reviewers,dao,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D214455
2024-07-02 18:56:44 +00:00
DJ
8a72f7671e Bug 1900867 - dismiss tab preview when tab select occurs. r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D215506
2024-07-02 15:23:08 +00:00
DJ
c65aeb08e6 Bug 1899566 - only rollup tab preview on wheel if tabs overflow. r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D215260
2024-07-02 13:59:45 +00:00
Tom Schuster
b558a0cc09 Bug 1900381 - Remove (direct) mainPopupset onpopupshowing inline event handlers. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D213940
2024-07-01 08:10:00 +00:00
Cristian Tuns
49bd8e8edd Backed out changeset 6ac47dbd939c (bug 1884970) for causing bc failures in browser_tab_tooltips.js CLOSED TREE 2024-06-28 15:23:44 -04:00
Anna Yeddi
f0d91c0df0 Bug 1884970 - Close current tab button is missing an accessible name and role. r=tabbrowser-reviewers,fluent-reviewers,dao,bolsson,flod
The [tab-close-button](https://searchfox.org/mozilla-central/rev/f9157a03835653cd3ece8d2dc713a782b7e4374e/browser/base/content/tabbrowser-tab.js#40) is not labeled and is missing an interactive role of button, while it is functioning as one.

Note: we do not want this control to be keyboard focusable, because keyboard-only user could close the tab via the context menu and we don't want to create an additional tab stop for the navigation as well, but making sure the control is marked up as a button with an accessible name would allow it to be actionable with speech-to-text software, with touch devices, with switch controls in scan mode, and for screen readers via their navigation shortcuts as well.

Differential Revision: https://phabricator.services.mozilla.com/D204413
2024-06-28 18:23:45 +00:00
Cristian Tuns
29b9dc4717 Backed out changeset 87d3cf2b45b2 (bug 1884970) for causing bc failures in browser_multiselect_tabs_close.js CLOSED TREE 2024-06-28 14:15:24 -04:00
Anna Yeddi
9bcc35ccaa Bug 1884970 - Close current tab button is missing an accessible name and role. r=tabbrowser-reviewers,fluent-reviewers,dao,bolsson,flod
The [tab-close-button](https://searchfox.org/mozilla-central/rev/f9157a03835653cd3ece8d2dc713a782b7e4374e/browser/base/content/tabbrowser-tab.js#40) is not labeled and is missing an interactive role of button, while it is functioning as one.

Note: we do not want this control to be keyboard focusable, because keyboard-only user could close the tab via the context menu and we don't want to create an additional tab stop for the navigation as well, but making sure the control is marked up as a button with an accessible name would allow it to be actionable with speech-to-text software, with touch devices, with switch controls in scan mode, and for screen readers via their navigation shortcuts as well.

Differential Revision: https://phabricator.services.mozilla.com/D204413
2024-06-28 17:19:31 +00:00
Marco Bonardo
f946b2a5f2 Bug 1893568 - Tab open animation is skipped with preloaded content. r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D212679
2024-06-26 15:05:15 +00:00
Jan-Niklas Jaeschke
914d043b7d Bug 1901064, part 1 - Preserve user activation when Fission is disabled. r=edgar,dom-core,tabbrowser-reviewers,mak,geckoview-reviewers,ohall
The code path that was used for loading a document
with fission disabled did not take user activation into account.
This made almost all WPTs for Text Fragments fail,
since they depend on this flag to decide if
a text directive is allowed to be scrolled to.

This patch makes sure that the user activation is
also available for code paths that run through
`CanonicalBrowsingContext::FixupAndLoadURIString()`
to load a document.

This is done by adding a flag `hasValidUserGestureActivation`
to the `nsIOpenWindowInfo`, which carries it through
the JS stack for loading a document.

Differential Revision: https://phabricator.services.mozilla.com/D213401
2024-06-26 14:24:35 +00:00
DJ
ac5de85e40 Bug 1902639 - update tab preview if it changes while animating. r=emilio,tabbrowser-reviewers,niklas
Differential Revision: https://phabricator.services.mozilla.com/D214646
2024-06-25 16:32:47 +00:00
Mike Conley
c3abb11ec6 Bug 1903888 - Warn on closing duplicate tabs even for 1 duplicate tab. r=tabbrowser-reviewers,dwalker
Differential Revision: https://phabricator.services.mozilla.com/D214598
2024-06-24 16:44:36 +00:00
Dão Gottwald
f0cf92a1c5 Bug 1903996 - Make customizing and mousedown proper boolean attributes. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D214525
2024-06-21 15:38:54 +00:00
Sebastian Hengst
e43a62744c Backed out 2 changesets (bug 1901064) for blocking the backout of bug 1888756
Backed out changeset 0e582d262ca8 (bug 1901064)
Backed out changeset 992a876144a0 (bug 1901064)
2024-06-21 12:07:33 +02:00
DJ
9126f12555 Bug 1878038 - show entire viewport in tab preview. r=emilio,tabbrowser-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D212709
2024-06-20 15:47:57 +00:00
Jan-Niklas Jaeschke
245ec27b92 Bug 1901064, part 1 - Preserve user activation when Fission is disabled. r=edgar,dom-core,tabbrowser-reviewers,mak,geckoview-reviewers,ohall
The code path that was used for loading a document
with fission disabled did not take user activation into account.
This made almost all WPTs for Text Fragments fail,
since they depend on this flag to decide if
a text directive is allowed to be scrolled to.

This patch makes sure that the user activation is
also available for code paths that run through
`CanonicalBrowsingContext::FixupAndLoadURIString()`
to load a document.

This is done by adding a flag `hasValidUserGestureActivation`
to the `nsIOpenWindowInfo`, which carries it through
the JS stack for loading a document.

Differential Revision: https://phabricator.services.mozilla.com/D213401
2024-06-20 15:00:31 +00:00
Andreas Farre
154d4b7619 Bug 1891670 - Expose crossGroupOpener on CanonicalBrowsingContext. r=dom-core,tabbrowser-reviewers,peterv
Differential Revision: https://phabricator.services.mozilla.com/D212677
2024-06-17 14:16:23 +00:00
Sarah Clements
92d796abdd Bug 1893655 - Set up the tabstrip to work vertically r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,Gijs
* Add ability to move tabstrip into the sidebar based on a pref

Differential Revision: https://phabricator.services.mozilla.com/D212287
2024-06-15 10:43:19 +00:00
Iulian Moraru
7af9a3a07c Backed out changeset 7c5bb1ba9d20 (bug 1893655) for causing bc failures on browser_vertical_tabs.js. 2024-06-14 18:43:35 +03:00
Sarah Clements
4758236bb0 Bug 1893655 - Set up the tabstrip to work vertically r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,Gijs
* Add ability to move tabstrip into the sidebar based on a pref

Differential Revision: https://phabricator.services.mozilla.com/D212287
2024-06-14 13:01:40 +00:00
Henrik Skupin
eb9c12f3a3 Bug 1901489 - [browser] Return promptType in DOMModalDialogClosed event details. r=Gijs,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D213074
2024-06-14 09:26:44 +00:00