Commit Graph

117 Commits

Author SHA1 Message Date
Mark Striemer
4cb7946dc8 Bug 1690333 - Proton infobar styles r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D104585
2021-03-29 02:38:56 +00:00
Butkovits Atila
d44674b631 Backed out changeset 1890d2ac5a43 (bug 1690333) for causing failures on test_bug509732.xhtml. CLOSED TREE 2021-03-29 02:56:02 +03:00
Mark Striemer
ec8da555ef Bug 1690333 - Proton infobar styles r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D104585
2021-03-28 19:04:34 +00:00
Butkovits Atila
918c913984 Backed out 2 changesets (bug 1690333, bug 1699250) for causing failures on test_bug509732.xhtml. CLOSED TREE
Backed out changeset dcba2814dbc4 (bug 1690333)
Backed out changeset ae3a0e6dde00 (bug 1699250)
2021-03-28 21:16:58 +03:00
Mark Striemer
f699cfce4c Bug 1690333 - Proton infobar styles r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D104585
2021-03-28 17:02:21 +00:00
Cosmin Sabou
2027d03134 Backed out 2 changesets (bug 1690333, bug 1699250) for mochitest failures on test_notificationbox.xhtml.
Backed out changeset d6780d34ca05 (bug 1690333)
Backed out changeset 50cc5db86f1e (bug 1699250)
2021-03-27 23:58:04 +02:00
Mark Striemer
c831343532 Bug 1690333 - Proton infobar styles r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D104585
2021-03-27 21:02:51 +00:00
Mark Striemer
457cef8f92 Bug 1682676 - Part 1: Move named-deck to toolkit widgets r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D106012
2021-03-10 19:22:56 +00:00
Mark Banner
81b89568d4 Bug 1687235 - Enable ESLint rule no-setter-return for toolkit and services. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D102153
2021-01-26 13:43:58 +00:00
Brindusan Cristian
201069fdac Backed out 5 changesets (bug 1687235) for mochitest failures at test_menulist_null_value.xhtml. CLOSED TREE
Backed out changeset 638c802ca1d1 (bug 1687235)
Backed out changeset ec830b771bce (bug 1687235)
Backed out changeset a7c933ddecfd (bug 1687235)
Backed out changeset c36493fb0599 (bug 1687235)
Backed out changeset 6eb33ad5d460 (bug 1687235)
2021-01-26 10:58:43 +02:00
Mark Banner
8622ae02de Bug 1687235 - Enable ESLint rule no-setter-return for toolkit and services. r=mossop
Depends on D102152

Differential Revision: https://phabricator.services.mozilla.com/D102153
2021-01-25 22:27:01 +00:00
Sam Foster
69e18b4ee0 Bug 1654684 - Add sheet-indicator and preview navigation to the print preview. r=mstriemer,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D96737
2020-12-09 20:56:28 +00:00
Csoregi Natalia
ab71c86aaf Backed out 2 changesets (bug 1654684) for browser chrome failures with .printPreviewCurrentPageNumber. CLOSED TREE
Backed out changeset 2fdc1b5569e1 (bug 1654684)
Backed out changeset 8ae1d037aa9c (bug 1654684)
2020-12-09 16:11:42 +02:00
Sam Foster
b39650600d Bug 1654684 - Add sheet-indicator and preview navigation to the print preview. r=mstriemer,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D96737
2020-12-09 02:59:26 +00:00
Brindusan Cristian
76c9db8ae8 Backed out 2 changesets (bug 1654684) for bc failures at browser_ext_tabs_printPreview. CLOSED TREE
Backed out changeset 5a0333ca8a19 (bug 1654684)
Backed out changeset 87d06a4d6ab6 (bug 1654684)
2020-12-07 12:59:10 +02:00
Sam Foster
9528af8e33 Bug 1654684 - Add sheet-indicator and preview navigation to the print preview. r=mstriemer,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D96737
2020-12-07 08:44:14 +00:00
Emilio Cobos Álvarez
6869665d58 Bug 1627520 - Use keydown instead of keypress for autocomplete event listeners. r=mak,Gijs
This is so that we can avoid needing mozSystemGroup (to get keypress for
non-printable keys), which in turn prevents racing with the native key event
listeners, see the second patch in bug 1624657.

This turned out to be a bit tricky, because we need to guarantee the ordering of
the search one-offs handling in the searchbar with the usual autocomplete-input
handling. We could try to move this to the popup subclass but this is already a
bigger patch than what I'd like.

We can also revert the customElements.js change I did in bug 1624657, as the bug
is no longer relevant.

Differential Revision: https://phabricator.services.mozilla.com/D69743
2020-04-14 20:48:26 +00:00
Bogdan Tara
8df8611a4f Backed out changeset b92904ec121f (bug 1627520) for browser_searchbar_keyboard_navigation.js failures CLOSED TREE 2020-04-14 16:58:35 +03:00
Emilio Cobos Álvarez
773cbf50dc Bug 1627520 - Use keydown instead of keypress for autocomplete event listeners. r=mak,Gijs
This is so that we can avoid needing mozSystemGroup (to get keypress for
non-printable keys), which in turn prevents racing with the native key event
listeners, see the second patch in bug 1624657.

This turned out to be a bit tricky, because we need to guarantee the ordering of
the search one-offs handling in the searchbar with the usual autocomplete-input
handling. We could try to move this to the popup subclass but this is already a
bigger patch than what I'd like.

We can also revert the customElements.js change I did in bug 1624657, as the bug
is no longer relevant.

Differential Revision: https://phabricator.services.mozilla.com/D69743
2020-04-14 12:42:16 +00:00
Emma Malysz
e4397c159d Bug 1590573, create a unified approach for caching fragments in our Custom Elements r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D58866
2020-04-08 16:17:50 +00:00
Razvan Maries
155eb99120 Backed out changeset 6b7c81561ecc (bug 1590573) for marionette perma failures on test_refresh_firefox.py. CLOSED TREE 2020-04-08 07:43:49 +03:00
Emma Malysz
5944c8268e Bug 1590573, create a unified approach for caching fragments in our Custom Elements r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D58866
2020-04-07 23:56:45 +00:00
Emilio Cobos Álvarez
8dd7869f2e Bug 1624657 - Eagerly load autocomplete-input custom element. r=Gijs
My patch causes an interesting regression. We stop constructing custom elements
for the stuff inside the edit-bookmark-panel as expected. This means that the
autocomplete-input here:

  https://searchfox.org/mozilla-central/rev/3f9e822318e8ec18ce673a9cb983d3608a3e2ed2/browser/components/places/content/editBookmarkPanel.inc.xhtml#81

Doesn't cause autocomplete-input.js to load. That means that it'll load by the
time the searchbar-textbox autocomplete is created, which means that it'll get
upgraded asynchronously. So far so good. However there's an interesting race due
to the way keypress event listeners are setup in autocomplete-input.js. In
particular, it uses the capture phase and the system group:

  https://searchfox.org/mozilla-central/rev/3f9e822318e8ec18ce673a9cb983d3608a3e2ed2/toolkit/content/widgets/autocomplete-input.js#38

This means it'll race with the other native / system group event listeners that
get added by the editor component. This caused arrow-up / arrow-down to not work
on the searchbar because the custom element was upgraded async.

This kinda papers over the issue the same way editBookmarkPanel was papering
over it, but ideally we should figure out a way to not use the system group or
keypress there so that we don't race in this awful way. Separate bug, probably.

Differential Revision: https://phabricator.services.mozilla.com/D69730
2020-04-05 18:36:00 +00:00
Tim Nguyen
4e7d6e9096 Bug 1625982 - Rename textbox.js and textbox.css to moz-input-box.js and search-textbox.css. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D68829
2020-03-30 18:22:56 +00:00
Mark Banner
1cc76add79 Bug 1620218 - Automatic code fixes for Prettier 1.18.2 upgrade. r=mossop,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D65509
2020-03-08 21:45:16 +00:00
Brendan Dahl
ceaa1a0f8e Bug 1531455 - Don't load extra custom elements in GeckoView. r=bgrins
GeckoView only needs the browser element, skip loading the rest.

Differential Revision: https://phabricator.services.mozilla.com/D63360
2020-02-19 20:13:42 +00:00
Emma Malysz
ba6b2f0a9b Bug 1601093, Rename the remaining .xul files to .xhtml in toolkit/ r=marionette-reviewers,mossop,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D55857
2019-12-11 17:44:54 +00:00
Gurzau Raul
c2d189a7a6 Backed out changeset dd809e835f2a (bug 1601093) for eslint failures at alert.xhtml and commonDialog.xhtml on a CLOSED TREE. 2019-12-11 19:27:28 +02:00
Emma Malysz
abfeb3aaa3 Bug 1601093, Rename the remaining .xul files to .xhtml in toolkit/ r=marionette-reviewers,mossop,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D55857
2019-12-11 17:02:20 +00:00
Emma Malysz
32233a0ca1 Bug 1592141, look for xul ns root element within customElement.js r=zbraniecki
Differential Revision: https://phabricator.services.mozilla.com/D52291
2019-11-11 19:20:28 +00:00
Alexander J. Vincent
e2ffa53f7c Bug 1591761 - parseXULToFragment should throw a clearer exception for non-well-formed markup. r=bgrins
***
Bug 1591671, revert a breaking change in calling DOMParser.

Differential Revision: https://phabricator.services.mozilla.com/D50729
2019-10-29 23:04:14 +00:00
Oana Pop Rus
3383114e4b Backed out changeset 8799781bbf34 (bug 1591761) for causing mass test failures. on a CLOSED TREE 2019-10-29 01:19:11 +02:00
Alexander J. Vincent
cced0cd2d1 Bug 1591761 - parseXULToFragment should throw a clearer exception for non-well-formed markup. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D50729
2019-10-28 21:59:59 +00:00
Alexander Surkov
19eabb6750 Bug 1397876 - Replace panel and arrowpanel bindings with a custom element r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D35040
2019-10-07 21:57:04 +00:00
Brian Grinstead
1ce836b612 Bug 1514926 - Convert the arrowscrollbox binding to a Custom Element r=dao
This uses Shadow DOM slotting instead of XBL, and migrates styles from
using XBL anonymous traversal to using CSS Shadow Parts.

This also removes the basecontrol binding, since this was the last
binding to extend it.

Differential Revision: https://phabricator.services.mozilla.com/D43651
2019-10-03 04:21:15 +00:00
Dorel Luca
8ed3a683b3 Backed out changeset 5e221240fc1d (bug 1514926) for mochitest failures in browser/tools/mozscreenshots/primaryUI/browser_primaryUI.js 2019-10-03 06:08:18 +03:00
Brian Grinstead
cf8e189da8 Bug 1514926 - Convert the arrowscrollbox binding to a Custom Element r=dao
This uses Shadow DOM slotting instead of XBL, and migrates styles from
using XBL anonymous traversal to using CSS Shadow Parts.

This also removes the basecontrol binding, since this was the last
binding to extend it.

Differential Revision: https://phabricator.services.mozilla.com/D43651
2019-10-02 22:57:39 +00:00
Sean Feng
dcfd220746 Bug 1467970 - Unsupport cross docGroup adoption r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D43135
2019-09-14 00:09:44 +00:00
Tim Nguyen
2be30c16a5 Bug 1534455 - Convert autocomplete binding to a customized input element. r=dao,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D33250
2019-09-17 06:22:42 +00:00
Mihai Alexandru Michis
7aa1fc73e6 Backed out changeset e859a5aebb5b (bug 1534455) for causing failures at test_bug437844.xul 2019-09-17 07:51:36 +03:00
Tim Nguyen
7d98f6a96f Bug 1534455 - Convert autocomplete binding to a customized input element. r=dao,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D33250
2019-09-17 01:35:25 +00:00
Paul Morris
4e8536c32e Bug 1545824 - Implement a getElementForAttrInheritance function r=aswan
Differential Revision: https://phabricator.services.mozilla.com/D39210
2019-07-30 15:11:26 +00:00
Victor Porof
3ca308bcdc Bug 1561435 - Format toolkit/content/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36053
2019-07-05 11:14:49 +02:00
Alexander Surkov
1160845e4e Bug 1544916 - migrate dialog binding to Custom Element r=bgrins,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D30289
2019-06-04 17:28:16 +00:00
Andrew Swan
1ab513d145 Bug 1519577 Convert toolbarbutton to a custom element r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D31941
2019-05-20 10:01:02 -07:00
Tim Nguyen
8febf82700 Bug 1521280 - Convert search-textbox to a custom element. r=dao,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D23045
2019-05-13 18:12:37 +00:00
Coroiu Cristina
bf0ad6faca Backed out changeset c5798de806e2 (bug 1521280) for crashing when searching about:config for upcoming beta (bug 1551013) 2019-05-13 08:50:28 +03:00
Tim Nguyen
606d5c9ce4 Bug 1521280 - Convert search-textbox to a custom element. r=dao,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D23045
2019-05-10 11:46:49 +00:00
Razvan Maries
cbf14f8671 Merge mozilla-inbound to mozilla-central a=merge 2019-04-26 12:46:15 +03:00
Brian Grinstead
7d71257436 Bug 1448213 - Migrate label-control to a Custom Element r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D5686
2019-04-23 20:16:46 +00:00