corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
899,829 Commits 1 Branch 0 Tags
0c35bb4f68f396d08f8e3c04af133734e7e8948e
Commit Graph

332 Commits

Author SHA1 Message Date
Thomas Wisniewski
0c35bb4f68 Bug 1952334 - Remove the old Report Site Issue fallback and its system addon, and have Report Broken Site perform its function; r=Gijs,mossop,webcompat-reviewers,zeid,frontend-codestyle-reviewers,denschub 
Differential Revision: https://phabricator.services.mozilla.com/D240671
 2025-03-13 20:37:14 +00:00
Gijs Kruitbosch
d7fff069d3 Bug 1597228 - move reportFalseDeceptiveSite to browser-safebrowsing.js, r=firefox-desktop-core-reviewers ,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D238761
 2025-02-24 15:30:41 +00:00
Tom Schuster
b5796e10bf Bug 1936523 - Remove inline event handlers from PopupNotifications. r=Gijs,extension-reviewers,reusable-components-reviewers,mstriemer 
I ended up having to change some of the fundamentals of the popupnotification element because the code relied on being able to inherit inline event handler attributes such as buttoncommand as oncommand on the button element and so on.

The primary user of the popupnotification element seems to be `PopupNotifications`. Following a pre-existing coupling with `PopupNotifications._onCheckboxCommand`, by default all commands/actions will simply call the corresponding `PopupNotifications` handler. However, I found at least one instance in `panelUI.js` that tries to override the command handlers. I solved this by dispatching a custom cancelable event on the popupnotification element.

Differential Revision: https://phabricator.services.mozilla.com/D231927
 2024-12-18 17:38:57 +00:00
Jared Hirsch
971718cd11 Bug 1883162 - Update profiles app menu to latest design using selectable profiles. r=niklas,fluent-reviewers,desktop-theme-reviewers,bolsson,dao 
Differential Revision: https://phabricator.services.mozilla.com/D223238
 2024-10-18 23:57:55 +00:00
Sandor Molnar
5eb3d8fc2b Backed out changeset e7719ffbcf2e (bug 1883162) for causing bc failures @ browser_sentence_case_strings.js CLOSED TREE 2024-10-18 04:22:37 +03:00
Jared Hirsch
d6887069ea Bug 1883162 - Update profiles app menu to latest design using selectable profiles. r=niklas,fluent-reviewers,desktop-theme-reviewers,bolsson,dao 
Differential Revision: https://phabricator.services.mozilla.com/D223238
 2024-10-17 23:55:53 +00:00
Mike Conley
dd4373aecb Bug 1920799 - Add a new messaging surface to the AppMenu and PXI menus for describing the value of signing into an FxA. r=pdahiya,Gijs,desktop-theme-reviewers,omc-reviewers,home-newtab-reviewers,fluent-reviewers,hjones,skhamis,nbarrett 
Developing tests in a later patch in this series.

Differential Revision: https://phabricator.services.mozilla.com/D223409
 2024-10-15 16:15:09 +00:00
Florian Quèze
165920b94c Bug 1918702 - Migrate telemetry events to use Glean APIs for password manager, r=chutten,settings-reviewers,credential-management-reviewers,mossop,mtigley,dimi. 
Differential Revision: https://phabricator.services.mozilla.com/D222608
 2024-09-25 10:00:41 +00:00
Sandor Molnar
5095328e2d Backed out 5 changesets (bug 1918702) for causing bc failures @ browser_aaa_eventTelemetry_run_first.js CLOSED TREE 
Backed out changeset f55480885aeb (bug 1918702)
Backed out changeset db1eaf09430d (bug 1918702)
Backed out changeset a9179f6e684d (bug 1918702)
Backed out changeset f9d3349e6fe3 (bug 1918702)
Backed out changeset 10d2957bbfe8 (bug 1918702)
 2024-09-25 12:38:05 +03:00
Florian Quèze
3cf2dde6da Bug 1918702 - Migrate telemetry events to use Glean APIs for password manager, r=chutten,settings-reviewers,credential-management-reviewers,mossop,mtigley,dimi. 
Differential Revision: https://phabricator.services.mozilla.com/D222608
 2024-09-25 07:19:05 +00:00
Tom Schuster
a8c9401904 Bug 1893068 - Remove command inline event handlers from the menubar. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D212246
 2024-06-14 21:08:03 +00:00
Gijs Kruitbosch
004090bf97 Bug 1890718 - move bookmark and library panelview event handling to not use inline event attributes, r=places-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D207881
 2024-04-23 15:21:21 +00:00
Gijs Kruitbosch
efe284f711 Bug 1890718 - remove hamburger menu mainview inline command listeners, r=mossop,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D207120
 2024-04-15 23:23:51 +00:00
Gijs Kruitbosch
f63cdcf1d7 Bug 1890718 - driveby: remove outdated mentions of proton, r=mossop,desktop-theme-reviewers,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D207119
 2024-04-15 23:23:50 +00:00
Cosmin Sabou
d17bfe39f8 Backed out 3 changesets (bug 1890718) for failing sevaral UI related bc tests. CLOSED TREE 
Backed out changeset 3d91014dfcef (bug 1890718)
Backed out changeset 8c09e2028ad9 (bug 1890718)
Backed out changeset ff91ebffa8ab (bug 1890718)
 2024-04-15 21:11:48 +03:00
Gijs Kruitbosch
9d2dbb58f2 Bug 1890718 - remove hamburger menu mainview inline command listeners, r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D207120
 2024-04-15 14:45:51 +00:00
Gijs Kruitbosch
bee5c98c47 Bug 1890718 - driveby: remove outdated mentions of proton, r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D207119
 2024-04-15 14:45:51 +00:00
Emily McMinn
d4f51984fa Bug 1724300 - Remove What's New Panel, ToolbarPanelHub components & related tests & references r=desktop-theme-reviewers,omc-reviewers,aminomancer,pdahiya,emilio,devtools-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201867
 2024-03-21 22:05:28 +00:00
Dave Townsend
a0c83bc943 Bug 1864896: Autofix unused function arguments (browser). r=webcompat-reviewers,mconley,fxview-reviewers,desktop-theme-reviewers,omc-reviewers,migration-reviewers,twisniewski,aminomancer,dao,sclements,firefox-desktop-core-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D203005
 2024-03-19 09:36:35 +00:00
Mike Conley
4c988cb8f1 Bug 1878731 - Convert ToolbarPanelHub to an ESM. r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201124
 2024-02-12 18:49:34 +00:00
Mike Conley
19a6e40b11 Bug 1877196 - Move ToolbarPanelHub.jsm to browser/components/asrouter. r=pdahiya,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200082
 2024-02-05 22:03:13 +00:00
Gijs Kruitbosch
87fba25ea4 Bug 1866503 - closing menupopups/panels inside panelviews in temporary PanelUI panels should not close those panels, r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D194632
 2023-11-27 23:27:36 +00:00
Iulian Moraru
df1ac624b2 Backed out changeset 49b89e35b5f5 (bug 1866503) for causing multiple bc failures related to panelUI. CLOSED TREE 2023-11-27 15:39:13 +02:00
Gijs Kruitbosch
ae5f8336a8 Bug 1866503 - closing menupopups/panels inside panelviews in temporary PanelUI panels should not close those panels, r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D194632
 2023-11-27 12:14:03 +00:00
Itiel
213e2bd9a9 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D176791
 2023-06-14 17:16:39 +00:00
Iulian Moraru
ff572127aa Backed out changeset 76c5afdda762 (bug 1830679) for causing xpcshell failures on test_VariablesView_filtering-without-controller.js. CLOSED TREE 2023-06-12 22:03:43 +03:00
Itiel
548aeccf66 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D176791
 2023-06-12 17:16:35 +00:00
Shane Hughes
6da3c5e401 Bug 1831906 - Add release notes link to update modal prompts. r=bytesized,omc-reviewers,application-update-reviewers,jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D177410
 2023-06-08 15:48:01 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177025
 2023-05-20 12:26:49 +00:00
Katherine Patenio
2e593c5af4 Bug 1830419 - Convert PanelMutiView.jsm and CustomizableUITestUtils.jsm in browser/components/customizableui to ESMs r=search-reviewers,Standard8,devtools-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D178362
 2023-05-18 18:34:51 +00:00
Iulian Moraru
9a36d620f9 Backed out changeset bbb3bbd9b6af (bug 1830679) for causing dt failures on browser_storage_cache_delete.js. CLOSED TREE 2023-05-18 22:09:25 +03:00
Itiel
801dad3de3 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D176791
 2023-05-18 17:19:45 +00:00
Mark Banner
2bd093b567 Bug 1811334 - Automatically replace Cu.reportError with console.error (most of browser/components). r=settings-reviewers,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D167297
 2023-01-20 17:49:21 +00:00
Mike Conley
c759904dae Bug 1797836 - Part 2: Update CUI to have a general TYPE_PANEL instead of TYPE_MENU_PANEL. r=desktop-theme-reviewers,dao,sclements 
Long ago, the menu panel in was a customizable area that users could drag things into.

That changed back around 2017 in bug 1354117 when the Photon redesign was built. The
menu panel become a static menu, but we also made it possible to permanently move things
to the overflow panel of the nav-bar.

It looks like we never updated the area type constant from referring to the old menu panel
though, so it's "TYPE_MENU_PANEL", and registering a node for it happens with
registerMenuPanel. This patch changes to constant to TYPE_PANEL and updates the registration
method to registerPanelNode.

I a check around the codebase as well as GitHub looking to see if there were any
system add-ons or experimental WebExtensions that rely on TYPE_MENU_PANEL / registerMenuPanel,
but I couldn't find any.

Differential Revision: https://phabricator.services.mozilla.com/D161078
 2022-11-08 14:51:40 +00:00
Mark Banner
a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D158094
 2022-09-29 06:52:34 +00:00
Emilio Cobos Álvarez
abab9b2db7 Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak 
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
 2022-09-02 20:26:29 +00:00
Butkovits Atila
e4a4a23311 Backed out changeset 368a7ce1b104 (bug 1788273) for causing failures at browser_recently_closed_tabs.js. CLOSED TREE 2022-09-02 16:35:55 +03:00
Emilio Cobos Álvarez
72c00adfaa Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak 
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
 2022-09-02 11:18:54 +00:00
Shane Caraveo
c114951f8b Bug 1783972 make browser actions pop out of overflow r=zombie,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D154179
 2022-08-22 18:55:59 +00:00
Iulian Moraru
df431be6b8 Backed out 3 changesets (bug 1780074, bug 1780347) for causing multiple failures. CLOSED TREE 
Backed out changeset ee4c4d34816c (bug 1780347)
Backed out changeset a13d3939b98a (bug 1780074)
Backed out changeset 3bc739f7de43 (bug 1780074)
 2022-07-20 14:57:48 +03:00
Mark Banner
9e59e52e55 Bug 1780074 - Migrate newtab consumers to use ESM imports directly. r=daleharvey,application-update-reviewers,nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D152114
 2022-07-20 10:36:52 +00:00
Neil Deakin
c9ddb2f4b9 Bug 1682621, remove keypress listener for main toolbar buttons, and use the inputSource to distinguish keyboard events, r=Gijs 
The virtual click event is also removed. It seems this event is only used to check whether this was a key or mouse event in PanelMultiView.jsm

This also removes support for pressing the enter key to trigger these toolbarbuttons on Mac which shouldn't be happening anyway.

Differential Revision: https://phabricator.services.mozilla.com/D149285
 2022-07-03 09:44:39 +00:00
Norisz Fay
f4827a4636 Backed out 2 changesets (bug 1682621) for causing bc failures on browser_menu_touch.js CLOSED TREE 
Backed out changeset 88be5107a4a1 (bug 1682621)
Backed out changeset e32910a4948b (bug 1682621)
 2022-06-29 19:36:51 +03:00
Neil Deakin
4674aa45e8 Bug 1682621, remove keypress listener for main toolbar buttons, and use the inputSource to distinguish keyboard events, r=Gijs 
The virtual click event is also removed. It seems this event is only used to check whether this was a key or mouse event in PanelMultiView.jsm

This also removes support for pressing the enter key to trigger these toolbarbuttons on Mac which shouldn't be happening anyway.

Differential Revision: https://phabricator.services.mozilla.com/D149285
 2022-06-29 12:38:30 +00:00
Marian-Vasile Laza
3dee1242d8 Backed out 2 changesets (bug 1682621) for causing bc failures on browser_ext_browserAction_click_types.js. 
Backed out changeset 31a6b027b4e7 (bug 1682621)
Backed out changeset 782fd4871c5f (bug 1682621)
 2022-06-28 20:27:15 +03:00
Neil Deakin
27e54692b9 Bug 1682621, remove keypress listener for main toolbar buttons, and use the inputSource to distinguish keyboard events, r=Gijs 
The virtual click event is also removed. It seems this event is only used to check whether this was a key or mouse event in PanelMultiView.jsm

This also removes support for pressing the enter key to trigger these toolbarbuttons on Mac which shouldn't be happening anyway.

Differential Revision: https://phabricator.services.mozilla.com/D149285
 2022-06-28 16:02:37 +00:00
Gijs Kruitbosch
a408c9940d Bug 1749537 - remove obsolete _formatPrintButtonShortcuts(), r=jwatt 
Differential Revision: https://phabricator.services.mozilla.com/D135949
 2022-02-28 14:33:29 +00:00
Jonathan Watt
8bf216317f Bug 1745332 - Remove print.tab_modal.enabled checks from CustomizableUI code. r=mconley 
The old UI is going away.

Differential Revision: https://phabricator.services.mozilla.com/D133451
 2022-01-06 18:55:37 +00:00
Rob Wu
b6b78cf0cc Bug 1714846 - Really hide panels on hide, r=robwu,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D132574
 2021-12-07 11:50:19 +00:00
Butkovits Atila
f90ffaea22 Backed out changeset 6e298bdd0dd8 (bug 1714846) for causing assertion failures at CompositorBridgeParent.cpp. CLOSED TREE 2021-12-03 23:30:10 +02:00