corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
899,829 Commits 1 Branch 0 Tags
0c35bb4f68f396d08f8e3c04af133734e7e8948e
Commit Graph

3055 Commits

Author SHA1 Message Date
Thomas Wisniewski
0c35bb4f68 Bug 1952334 - Remove the old Report Site Issue fallback and its system addon, and have Report Broken Site perform its function; r=Gijs,mossop,webcompat-reviewers,zeid,frontend-codestyle-reviewers,denschub 
Differential Revision: https://phabricator.services.mozilla.com/D240671
 2025-03-13 20:37:14 +00:00
Mike Conley
686bc35742 Bug 1917913 - Add JSDoc documentation for CustomizeMode. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D241264
 2025-03-13 19:01:47 +00:00
Sam Foster
5e0d65a91e Bug 1921536 - Make the SidebarState the source of truth for the current sidebar command/panel and re-open previous panel when toggling the sidebar open. r=sidebar-reviewers,jsudiaman 
* We retain the behavior from legacy sidebar which re-opens the previously open sidebar panel when the sidebar is toggled open
* Rename SidebarState's '#previousLauncherVisible' to '#previousLauncherExpanded' as it actually tracks expandedness
* Don't persist the panel/command id when the panel isn't open
* Ensure all the sidebar tests reset the sidebar state when they are done

Differential Revision: https://phabricator.services.mozilla.com/D234773
 2025-03-12 16:41:47 +00:00
Gijs Kruitbosch
d7ea8b75a5 Bug 1952416 - fix downloads button context menu ordering to be correct again, r=nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D241109
 2025-03-12 13:28:17 +00:00
Goloman Adrian
6847fa7ceb Backed out changeset 4754bc9e58f3 (bug 1921536) for causing bc failures @browser_toolbarKeyNav.js 2025-03-08 09:15:01 +02:00
Sam Foster
ace31bb084 Bug 1921536 - Make the SidebarState the source of truth for the current sidebar command/panel and re-open previous panel when toggling the sidebar open. r=sidebar-reviewers,jsudiaman 
* We retain the behavior from legacy sidebar which re-opens the previously open sidebar panel when the sidebar is toggled open
* Rename SidebarState's '#previousLauncherVisible' to '#previousLauncherExpanded' as it actually tracks expandedness
* Don't persist the panel/command id when the panel isn't open
* Ensure all the sidebar tests reset the sidebar state when they are done

Differential Revision: https://phabricator.services.mozilla.com/D234773
 2025-03-08 05:17:08 +00:00
Cosmin Sabou
bc3553b84c Bug 1947098 - Mark browser_history_recently_closed as failing on a11y because it's permafailing. a=test-only 
CLOSED TREE
 2025-03-06 20:36:35 +02:00
Sandor Molnar
b51ff49434 Backed out changeset f56181344f2a (bug 1921536) for causing bc failures @ browser_bookmark_context_menu_contents.js & browser_reviewchecker_sidebar.js CLOSED TREE 2025-03-06 06:15:10 +02:00
Sam Foster
dc4f09430e Bug 1921536 - Make the SidebarState the source of truth for the current sidebar command/panel and re-open previous panel when toggling the sidebar open. r=sidebar-reviewers,jsudiaman 
* We retain the behavior from legacy sidebar which re-opens the previously open sidebar panel when the sidebar is toggled open
* Rename SidebarState's '#previousLauncherVisible' to '#previousLauncherExpanded' as it actually tracks expandedness
* Don't persist the panel/command id when the panel isn't open
* Ensure all the sidebar tests reset the sidebar state when they are done

Differential Revision: https://phabricator.services.mozilla.com/D234773
 2025-03-06 01:52:28 +00:00
Nikki Sharpley
af747cf20a Bug 1948342 - Update toolbar and tabstrip context menus to include vertical tabs and sidebar r=sidebar-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D239813
 2025-02-28 21:29:56 +00:00
Butkovits Atila
2c6df00864 Backed out changeset b1a4f0700184 (bug 1948342) for causing failures at browser_customization_context_menus.js. CLOSED TREE 2025-02-28 22:25:01 +02:00
Nikki Sharpley
743bc5201e Bug 1948342 - Update toolbar and tabstrip context menus to include vertical tabs and sidebar r=sidebar-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D239813
 2025-02-28 19:11:24 +00:00
Nikki Sharpley
3248e2b487 Bug 1949753 - Remove sidebar options from toolbar context menu unless triggered by sidebar button r=sidebar-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D239219
 2025-02-24 17:04:27 +00:00
Gijs Kruitbosch
d7fff069d3 Bug 1597228 - move reportFalseDeceptiveSite to browser-safebrowsing.js, r=firefox-desktop-core-reviewers ,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D238761
 2025-02-24 15:30:41 +00:00
Gijs Kruitbosch
c7252c05d5 Bug 1948931 - move toolbar window initialization into CustomizableUI, r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D238536
 2025-02-21 16:07:08 +00:00
Gregory Pappas
408fd9c57f Bug 1925823 - Stop disabling screenshots component in mochitest r=urlbar-reviewers,niklas 
Differential Revision: https://phabricator.services.mozilla.com/D226241
 2025-02-17 22:39:54 +00:00
Jeremy Swinarton
97dd33ecbd Bug 1947503: Closed tab groups code supports session store files created before Firefox 135 r=dao,dwalker,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237904
 2025-02-13 15:10:03 +00:00
Andrea Marchesini
05175c0b08 Bug 1944563 - Remove "extensions.ui.postInstallPrivateBrowsingCheckbox", r=rpl 
Differential Revision: https://phabricator.services.mozilla.com/D236686
 2025-02-11 08:42:52 +00:00
Goloman Adrian
60a096f80f Backed out changeset 41b7588e99ef (bug 1834559) for causing bc failures @browser_history_recently_closed_middleclick.js. 2025-02-10 05:11:17 +02:00
Goloman Adrian
2db7c2df7a Bug 1834559 - Disable browser_history_recently_closed.js on linux 1804 for frequent failures. r=intermittent-reviewers,jmaher DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D237499
 2025-02-09 19:22:55 +00:00
Jeremy Swinarton
016c599fa5 Bug 1944416: Restore individual tabs from closed groups in closed windows r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237110
 2025-02-07 21:35:32 +00:00
Jeremy Swinarton
2290ebcc4a Bug 1944328: "Reopen All Tabs" supports closed tab groups from closed windows r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D236872
 2025-02-05 21:06:43 +00:00
Moritz Beier
4ff8ed5deb Bug 1880913 - Part 4: Remove BrowserSearch.searchBar getter. r=search-reviewers,scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D235598
 2025-02-04 11:07:12 +00:00
Alexandru Marc
ff52370de6 Backed out changeset 3b0d32c48d6b (bug 1925823) for causing mochitest failures @ browser.toml 2025-02-03 18:06:06 +02:00
Gregory Pappas
bb9537bfca Bug 1925823 - Stop disabling screenshots component in mochitest r=urlbar-reviewers,niklas 
Differential Revision: https://phabricator.services.mozilla.com/D226241
 2025-02-03 14:55:59 +00:00
Jeremy Swinarton
140b7bce30 Bug 1945111: Only include tabs inside groups at deletion time in closed tab groups in history menus r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D236432
 2025-02-03 14:45:41 +00:00
Nikki Sharpley
e88f046412 Bug 1944190 - Add new options to the tab strip context menu for sidebar revamp r=sidebar-reviewers,fluent-reviewers,bolsson,jsudiaman 
Horizontal tabs mode
- Turn on Vertical Tabs

Vertical tabs mode
- Turn off Vertical Tabs
- Customize Sidebar

Differential Revision: https://phabricator.services.mozilla.com/D236013
 2025-01-31 15:31:22 +00:00
Goloman Adrian
f318ff63af Backed out changeset 93bbf90232b7 (bug 1944190) for causing bc failures @browser_fullscreen_context_menu.js. CLOSED TREE 2025-01-31 03:18:31 +02:00
Nikki Sharpley
7ecca5c680 Bug 1944190 - Add new options to the tab strip context menu for sidebar revamp r=sidebar-reviewers,fluent-reviewers,bolsson,jsudiaman 
Horizontal tabs mode
- Turn on Vertical Tabs

Vertical tabs mode
- Turn off Vertical Tabs
- Customize Sidebar

Differential Revision: https://phabricator.services.mozilla.com/D236013
 2025-01-31 00:36:53 +00:00
Goloman Adrian
2d40cae4ae Backed out changeset 55b692ccd15f (bug 1944190) for causing bc failures @browser_fullscreen_context_menu.js. CLOSED TREE 2025-01-31 00:51:02 +02:00
Nikki Sharpley
ae210aa960 Bug 1944190 - Add new options to the tab strip context menu for sidebar revamp r=sidebar-reviewers,fluent-reviewers,bolsson,jsudiaman 
Horizontal tabs mode
- Turn on Vertical Tabs

Vertical tabs mode
- Turn off Vertical Tabs
- Customize Sidebar

Differential Revision: https://phabricator.services.mozilla.com/D236013
 2025-01-30 21:00:20 +00:00
Rebecca King
16716b7b5a Bug 1931402 - Add undo button for new theme installation - r=fluent-reviewers,rpl,Gijs,willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D229410
 2025-01-28 18:55:55 +00:00
Jeremy Swinarton
a86608a71b Bug 1943850: Recently closed tabs use correct indexing r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D235813
 2025-01-28 15:14:45 +00:00
Jeremy Swinarton
7db0891300 Bug 1941799: 'Reopen All Tabs' supports tab groups r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D235317
 2025-01-23 19:55:42 +00:00
Mike Conley
f9458508d5 Bug 1917913 - Add JSDoc documentation for DragPositionManager. r=nsharpley 
We also take the opportunity to convert AreaPositionManager to an ES6
class and use proper private members, as well as using DOMRectReadOnly
instead of the bespoke rect-like frozen objects that we were using
before.

Differential Revision: https://phabricator.services.mozilla.com/D230114
 2025-01-16 21:14:23 +00:00
Mike Conley
ed93de6239 Bug 1917913 - Add JSDoc documentation for ToolbarContextMenu. r=dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D230113
 2025-01-16 21:14:23 +00:00
Mike Conley
7bcf09af5b Bug 1917913 - Add JSDoc documentation for SearchWidgetTracker. r=mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D230112
 2025-01-16 21:14:22 +00:00
Mike Conley
b6aa0cf47f Bug 1917913 - Make PanelMultiView.sys.mjs pass the valid-jsdoc ESLint rule and add missing source documentation. r=sfoster 
This also makes some members and methods private that were using the
underscore pseudoprivate technique.

Differential Revision: https://phabricator.services.mozilla.com/D225820
 2025-01-16 21:14:22 +00:00
Mike Conley
5e236d8ae5 Bug 1917913 - Make CustomizableUI.sys.mjs pass the valid-jsdoc ESLint rule and add initial source documentation. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D222679
 2025-01-16 21:14:21 +00:00
Mike Conley
b32f4d478b Bug 1917913 - Enable valid-jsdoc ESLint rule for browser/components/customizableui. r=Standard8,frontend-codestyle-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D222678
 2025-01-16 21:14:21 +00:00
Jeremy Swinarton
a80eb49e6c Bug 1939904: Closed tab groups in history menus can be restored regardless of window they were closed in. r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D234042
 2025-01-14 17:49:24 +00:00
Nikki Sharpley
3106c425e7 Bug 1930220 - Assert nothing changes in the toolbar upon browser restarts r=mconley,webdriver-reviewers,whimboo 
To help catch bugs such as Bug 1919721, assert the toolbar is unchanged and widgets are in the correct order on browser restart.

Differential Revision: https://phabricator.services.mozilla.com/D233749
 2025-01-13 16:40:34 +00:00
Alexandru Marc
6f253b451f Backed out changeset 713114c0331a (bug 1938707) by developer request CLOSED TREE 2025-01-13 18:29:52 +02:00
Nikki Sharpley
55d657620d Bug 1938707 - Assert nothing changes in the toolbar upon browser restarts r=mconley,webdriver-reviewers,whimboo 
To help catch bugs such as Bug 1919721, assert the toolbar is unchanged and widgets are in the correct order on browser restart.

Differential Revision: https://phabricator.services.mozilla.com/D233749
 2025-01-13 16:20:20 +00:00
Nikki Sharpley
2c3ff409c2 Bug 1940304 - Fix browser_sidebar_button_reset.js intermittent r=sidebar-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D233433
 2025-01-08 21:41:21 +00:00
Nikki Sharpley
96a8625c9d Bug 1919223 - Restore sidebar-button when CustomizableUI is reset if sidebar revamp enabled r=sidebar-reviewers,kcochrane,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D232847
 2025-01-07 17:32:20 +00:00
Emilio Cobos Álvarez
6752d74098 Bug 1929400 - Remove CUI special cases for BookmarksBarButton. r=mak,omc-reviewers,jprickett 
We can just tag the widget as not removable.

Differential Revision: https://phabricator.services.mozilla.com/D228103
 2024-12-19 14:32:52 +00:00
Tom Schuster
b5796e10bf Bug 1936523 - Remove inline event handlers from PopupNotifications. r=Gijs,extension-reviewers,reusable-components-reviewers,mstriemer 
I ended up having to change some of the fundamentals of the popupnotification element because the code relied on being able to inherit inline event handler attributes such as buttoncommand as oncommand on the button element and so on.

The primary user of the popupnotification element seems to be `PopupNotifications`. Following a pre-existing coupling with `PopupNotifications._onCheckboxCommand`, by default all commands/actions will simply call the corresponding `PopupNotifications` handler. However, I found at least one instance in `panelUI.js` that tries to override the command handlers. I solved this by dispatching a custom cancelable event on the popupnotification element.

Differential Revision: https://phabricator.services.mozilla.com/D231927
 2024-12-18 17:38:57 +00:00
Nikki Sharpley
2d0cfb1365 Bug 1933592 - Hide the sidebar launcher if the sidebar toolbar button is removed r=sidebar-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D231749
 2024-12-18 16:07:19 +00:00
Norisz Fay
066b9b823f Backed out changeset f76adacaf89e (bug 1933592) for causing sidebar related bc failures 2024-12-17 22:34:55 +02:00