Commit Graph

52 Commits

Author SHA1 Message Date
Jared Wein
0c024fa9ca Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6
2016-10-24 13:14:19 -04:00
Andrew Swan
8bae139a2d Bug 1298989 Don't show notification on theme install from discovery pane r=jaws
MozReview-Commit-ID: 5G8PNFKfJkc
2016-09-06 22:32:31 -07:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt
2016-08-04 03:28:58 -04:00
Dave Townsend
17d8a23b3f Bug 1257246: Update browser for eslint 2. r=felipe
Most of this is fixing functions that in some cases return a value but then
can also run to completion without returning anything. ESLint 2 catches this
where previous versions didn't. Unless there was an obvious other choice I just
made these functions return undefined at the end which is effectively what
already happens.

MozReview-Commit-ID: DEskVIjiKDM
2016-04-05 11:33:33 -07:00
Felipe Gomes
e5ea10c3ed Bug 1228627 - Remove #includes from browser.js. r=Gijs 2015-11-30 12:13:57 -02:00
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Dave Townsend
4618999b6b Bug 1042699: Block cross-origin add-on install requests. r=dveditz 2015-08-18 17:21:05 -07:00
Dave Townsend
b84450c5d4 Backing out bug 1184296 for causing regressions. 2015-08-11 07:22:11 -07:00
Dave Townsend
fd0063acc1 Bug 1184296: Cancel add-on installs if the user dismisses the install notification. r=dao 2015-08-03 10:50:07 -07:00
Riadh Chtara
f3b59b84be Bug 1175300 - Switch password manager to using displayOrigin to display the origin in the capture doorhanger. r=MattN 2015-07-15 21:26:54 -07:00
Jimmy Wang
ce3f8aaecc Bug 653065 - Make the lightweight theme web installer ready for e10s. r=mconley 2015-07-14 11:42:02 -07:00
Dave Townsend
16b826c1cd Bug 1170162: Use a support page for signing warnings intended for users. r=dao 2015-06-08 09:17:15 -07:00
Dave Townsend
dcfcd0cedf Bug 1163973: Show new install confirmation doorhangers after the previous doorhanger has been dismissed. r=dao 2015-06-03 15:31:25 -07:00
Dão Gottwald
32cda0a501 Bug 1171146 - Display a learn more link when refusing to install an unsigned add-on. r=dtownsend 2015-06-05 13:10:53 +02:00
Dave Townsend
771797d5ee Bug 1168954: Unexpected "Install" button appears on add-on install progress doorhanger. r=dao 2015-05-27 13:08:37 -07:00
Dão Gottwald
02e1efb57c Bug 1165584 - Remove host from add-on installation error messages. r=dtownsend 2015-05-20 12:56:32 +02:00
Dão Gottwald
5a3d24e93d Backed out changeset 18ede4264d90 2015-05-19 14:06:01 +02:00
Dão Gottwald
04f6c3263b Bug 1165584 - Remove host from add-on installation error messages. r=dtownsend 2015-05-19 12:30:27 +02:00
Dão Gottwald
f2a11c1dbe Bug 1165577 - Remove originatingURI check from the addon-install-blocked observer. r=dtownsend 2015-05-19 12:30:07 +02:00
Dão Gottwald
e1961d98b1 Bug 1147808 - Cancel add-on installation when the tab or window closes while waiting for the user to confirm the installation. r=dtownsend 2015-05-16 13:28:34 +02:00
Dave Townsend
839a8ba5e4 Bug 1162584: Update the icons for the add-on install flow. r=dao 2015-05-14 12:05:58 -07:00
Ryan VanderMeulen
f7a5e0089a Backed out changeset ab6600d9847b (bug 1147808) for addon manager test failures. 2015-05-15 16:14:28 -04:00
Dão Gottwald
8219b769a8 Bug 1147808 - Cancel installation when the tab or window closes while downloading the add-on or waiting for the user to confirm the installation. r=dtownsend 2015-05-15 21:21:17 +02:00
Dão Gottwald
6056332152 Bug 1162863 - part 1: rename originHost to displayOrigin. r=paolo sr=gavin 2015-05-15 14:34:50 +02:00
Dave Townsend
9953184f5a Bug 1148021: Warn users when installing unsigned add-ons. r=dão 2015-04-30 11:55:36 -07:00
Dão Gottwald
63f6e27928 Bug 1147805 - Add Learn More link to the add-on install confirmation doorhanger. r=dtownsend 2015-04-17 20:19:08 +02:00
Sushrut Girdhari
b8092378d8 Bug 989307 - Make FUEL warn deprecation to the console on first usage. r=jaws 2015-04-03 15:42:04 -04:00
Dão Gottwald
2e8b695b16 Bug 1148543 - Remove the add-on author from the install confirmation doorhanger. r=dtownsend 2015-03-27 23:02:06 +01:00
Dão Gottwald
ec26f9e5a9 Bug 1147823 - Properly show the add-on install confirmation UI when there was no prior addon-progress notification (i.e. for local installs). r=dtownsend 2015-03-26 20:32:37 +01:00
Dão Gottwald
bcb2055449 Bug 1139656 followup, addressing flod's review comments 2015-03-25 08:59:29 +01:00
Dão Gottwald
57018e1fa9 Bug 1139656 - Implement the first pieces of the all-doorhanger install flow for add-ons installed from websites. r=dtownsend 2015-03-24 22:24:49 +01:00
Ryan VanderMeulen
8a4e41e395 Backed out changeset 37bd20ca096a (bug 1139656) for test_blocklistchange.js xpcshell failures.
CLOSED TREE
2015-03-24 15:36:48 -04:00
Dão Gottwald
0332e04351 Bug 1139656 - Implement the first pieces of the all-doorhanger install flow for add-ons installed from websites. r=dtownsend 2015-03-24 18:54:59 +01:00
Blair McBride
58d17df0ab Bug 1128126 - Enforce safe schemes in isInstallAllowed. r=Mossop 2015-02-10 15:47:50 +13:00
Dave Townsend
f5d707425c Bug 1084558: Switch the web installer interfaces to use browsers instead of DOM windows. r=Unfocused 2014-11-04 19:20:52 -08:00
Till Schneidereit
8219681d97 Bug 1075059 - Part 1: Backout of Array.prototpype.contains usages. r=me 2014-10-02 17:37:48 +02:00
Ayush Mishra
fd3b4210c3 Bug 1072889 - Replace array.indexOf(...) != -1 with array.contains(...) in browser/base/ ; r=dao 2014-09-26 20:51:09 +02:00
Bobby Holley
c383ef5653 Bug 1062631 - Watch out for dead object proxies in gXPInstallObserver. r=Gijs
In browser_navigateaway2.js we end up with an XPCWrappedJS double-wrapped
DeadObjectProxy here, which triggers an exception when it's inserted into
the WeakMap.
2014-09-08 13:36:21 -07:00
Bobby Holley
d73c54d063 Bug 1062631 - Handle null originatingURI in browser-addons.js. r=Gijs 2014-09-08 13:36:21 -07:00
Blake Kaplan
d172b97f15 Bug 952201 - Make installing addons from web content work correctly in e10s. r=bmcbride@mozilla.com 2014-07-18 09:27:29 -07:00
Jim Blandy
39dc0c6097 Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00
Matthew Noorenberghe
dcc4b17b8c Bug 885139 - Notify consumers about LWT optimization and listen for it in LightweightThemeListener. r=jaws
[Australis]
2014-03-20 13:55:49 -07:00
Matthew Noorenberghe
e696b9ce27 Bug 983761 - Add support for CSSGroupingRules in LightweightThemeListener. r=Gijs 2014-03-14 16:24:57 -07:00
Trevor Saunders
c5bbaf6b46 bug 331376 - merge nsIDocShellTreeNode into nsIDocShellTreeItem r=smaug 2014-01-06 17:34:15 -05:00
Gijs Kruitbosch
d059e35def Bug 884120 - nullcheck themeData before using it in LightweightThemeListener, r=MattN 2013-07-17 12:36:32 +02:00
Gijs Kruitbosch
6d74e73948 Bug 749804 - part 0: remove the add-on bar, r=jaws 2013-05-09 12:08:07 +02:00
Matthew Noorenberghe
b5d764441f Bug 813786 - Australis tabs Windows lightweight theme support. r=mconley 2013-04-22 17:01:31 -07:00
Jonathan Kew
f0be4f09aa bug 814383 - fix javascript strict-mode warnings in browser.js. r=gavin 2012-11-26 16:18:25 +00:00
Graeme McCutcheon
28f09bf11e Bug 736358 - Remove "Open Add-Ons Manager" button for restartless addons. r=bmcbride 2012-10-08 09:33:19 +01:00
Ian Moody
3e05c975c6 Bug 737792 - Use for..of loops in browser.js. r=dao 2012-08-21 18:56:07 +02:00